Re: emulators/mame use system pugixml

2021-05-26 Thread Frederic Cambus 
On Tue, May 25, 2021 at 05:52:31AM +0200, Rafael Sadowski wrote:
> On Tue May 25, 2021 at 05:50:06AM +0200, Rafael Sadowski wrote:
> > Simple diff to enable pugixml usage in mame. OK?
> > 
> 
> of course, with REVISION bump:

Looks good to me. Brad also sent me the same diff privately, so
please mention it in the commit message as we usually do.

OK fcambus@

Re: emulators/mame use system pugixml

2021-05-24 Thread Rafael Sadowski 
On Tue May 25, 2021 at 05:50:06AM +0200, Rafael Sadowski wrote:
> Simple diff to enable pugixml usage in mame. OK?
> 

of course, with REVISION bump:

Index: Makefile
===
RCS file: /cvs/ports/emulators/mame/Makefile,v
retrieving revision 1.48
diff -u -p -r1.48 Makefile
--- Makefile1 May 2021 13:34:18 -   1.48
+++ Makefile25 May 2021 03:52:11 -
@@ -12,6 +12,7 @@ GH_ACCOUNT =  mamedev
 GH_PROJECT =   mame
 GH_TAGNAME =   mame0${V}
 DISTNAME = mame-0.${V}
+REVISION = 0
 
 CATEGORIES =   emulators
 
@@ -21,8 +22,8 @@ HOMEPAGE =https://mamedev.org/
 PERMIT_PACKAGE =   Yes
 
 WANTLIB += ${COMPILER_LIBCXX} FLAC GL SDL2 SDL2_ttf X11 Xext Xi
-WANTLIB += Xinerama c expat fontconfig freetype jpeg lua5.3 m
-WANTLIB += sqlite3 util z
+WANTLIB += Xinerama c expat fontconfig freetype jpeg lua${MODLUA_VERSION} m
+WANTLIB += pugixml sqlite3 util z
 
 COMPILER = base-clang ports-gcc base-gcc
 
@@ -38,7 +39,8 @@ LIB_DEPENDS = audio/flac \
databases/sqlite3 \
devel/sdl2 \
devel/sdl2-ttf \
-   graphics/jpeg
+   graphics/jpeg \
+   textproc/pugixml
 
 CFLAGS +=  -I${PREFIX}/include -I${X11BASE}/include -I${MODLUA_INCL_DIR}
 CFLAGS +=  -Wno-unknown-warning-option -Wno-ignored-qualifiers 
-fno-ret-protector
@@ -53,6 +55,7 @@ MAKE_ENV =NOWERROR=1 TOOLS=1 verbose=1 
USE_SYSTEM_LIB_FLAC=1 \
USE_SYSTEM_LIB_LUA=1 \
USE_SYSTEM_LIB_SQLITE3=1 \
+   USE_SYSTEM_LIB_PUGIXML=1 \
USE_QTDEBUG=0 # avoid depending on Qt
 
 .if ${MACHINE_ARCH} == "amd64"

emulators/mame use system pugixml

2021-05-24 Thread Rafael Sadowski 
Simple diff to enable pugixml usage in mame. OK?

Index: Makefile
===
RCS file: /cvs/ports/emulators/mame/Makefile,v
retrieving revision 1.48
diff -u -p -r1.48 Makefile
--- Makefile1 May 2021 13:34:18 -   1.48
+++ Makefile25 May 2021 03:48:01 -
@@ -21,8 +21,8 @@ HOMEPAGE =https://mamedev.org/
 PERMIT_PACKAGE =   Yes
 
 WANTLIB += ${COMPILER_LIBCXX} FLAC GL SDL2 SDL2_ttf X11 Xext Xi
-WANTLIB += Xinerama c expat fontconfig freetype jpeg lua5.3 m
-WANTLIB += sqlite3 util z
+WANTLIB += Xinerama c expat fontconfig freetype jpeg lua${MODLUA_VERSION} m
+WANTLIB += pugixml sqlite3 util z
 
 COMPILER = base-clang ports-gcc base-gcc
 
@@ -38,7 +38,8 @@ LIB_DEPENDS = audio/flac \
databases/sqlite3 \
devel/sdl2 \
devel/sdl2-ttf \
-   graphics/jpeg
+   graphics/jpeg \
+   textproc/pugixml
 
 CFLAGS +=  -I${PREFIX}/include -I${X11BASE}/include -I${MODLUA_INCL_DIR}
 CFLAGS +=  -Wno-unknown-warning-option -Wno-ignored-qualifiers 
-fno-ret-protector
@@ -53,6 +54,7 @@ MAKE_ENV =NOWERROR=1 TOOLS=1 verbose=1 
USE_SYSTEM_LIB_FLAC=1 \
USE_SYSTEM_LIB_LUA=1 \
USE_SYSTEM_LIB_SQLITE3=1 \
+   USE_SYSTEM_LIB_PUGIXML=1 \
USE_QTDEBUG=0 # avoid depending on Qt
 
 .if ${MACHINE_ARCH} == "amd64"