ipcad doesn't need groff to build

2012-01-17 Thread Kirill Bychkov
Hi.
net/ipcad doesn't need USE_GROFF=Yes. Packaging runs with warnings with this
option set:
===  Building package for ipcad-3.7.3p0
Create /usr/ports/packages/amd64/all/ipcad-3.7.3p0.tgz
checksumming|*
| 54%mdoc warning: A .Bl directive has
no matching .El (#34)
mdoc warning: A .Bl directive has no matching .El (#63)
Link to /usr/ports/packages/amd64/ftp/ipcad-3.7.3p0.tgz
Link to /usr/ports/packages/amd64/cdrom/ipcad-3.7.3p0.tgz

So...

Index: Makefile
===
RCS file: /cvs/ports/net/ipcad/Makefile,v
retrieving revision 1.19
diff -u -r1.19 Makefile
--- Makefile17 Dec 2011 22:01:13 -  1.19
+++ Makefile17 Jan 2012 21:47:20 -
@@ -18,7 +18,6 @@
 MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE:=ipcad/}

 CONFIGURE_STYLE=   gnu
-USE_GROFF= Yes

 NO_REGRESS=Yes

Manpages still nice and readable.



Re: ipcad doesn't need groff to build

2012-01-17 Thread Stuart Henderson
On 2012-01-17, Kirill Bychkov ya...@linklevel.net wrote:
 Hi.
 net/ipcad doesn't need USE_GROFF=Yes. Packaging runs with warnings with this
 option set:
===  Building package for ipcad-3.7.3p0
 Create /usr/ports/packages/amd64/all/ipcad-3.7.3p0.tgz
 checksumming|*
 | 54%mdoc warning: A .Bl directive has
 no matching .El (#34)
 mdoc warning: A .Bl directive has no matching .El (#63)
 Link to /usr/ports/packages/amd64/ftp/ipcad-3.7.3p0.tgz
 Link to /usr/ports/packages/amd64/cdrom/ipcad-3.7.3p0.tgz

 So...

 Index: Makefile
===
 RCS file: /cvs/ports/net/ipcad/Makefile,v
 retrieving revision 1.19
 diff -u -r1.19 Makefile
 --- Makefile  17 Dec 2011 22:01:13 -  1.19
 +++ Makefile  17 Jan 2012 21:47:20 -
 @@ -18,7 +18,6 @@
  MASTER_SITES=${MASTER_SITE_SOURCEFORGE:=ipcad/}

  CONFIGURE_STYLE= gnu
 -USE_GROFF=   Yes

  NO_REGRESS=  Yes

 Manpages still nice and readable.



Hmm, there's nothing missing from the manuals with mandoc, but it does
add extra whitespace for each .Pp within the list:

-- source
.Bl -column show ip accounting checkpoint  
.It helpShow available commands
.Pp
.It show ip accounting  Show current accounting table
.It show ip accounting checkpoint   Show checkpointed accounting table
.Pp
.It clear ip accounting Move accounting to checkpoint base
.It clear ip accounting checkpoint  Clear checkpoint base
snip

-- mandoc
 help   Show available commands


 show ip accounting Show current accounting table
 show ip accounting checkpoint  Show checkpointed accounting table


 clear ip accountingMove accounting to checkpoint base
 clear ip accounting checkpoint Clear checkpoint base

-- groff
   Recognized commands are:
 help   Show available commands

 show ip accounting Show current accounting table
 show ip accounting checkpoint  Show checkpointed accounting table

 clear ip accountingMove accounting to checkpoint base
 clear ip accounting checkpoint Clear checkpoint base


Ingo, Kristaps, any comments? should they be using multiple .Bl/.El or
is this something mandoc should handle differently?

I think switching USE_GROFF is worthy of a revision bump.