Re: mail/solid-pop3d: APOP not working for big endian machines

[Michael Warmuth]

Hi,

Stuart Henderson wrote:

A simpler fix, and, after some head-scratching, repair PKGNAME
(unless I miss something not mentioned in commit logs as to why
it happened like that...)
ok?


Fine. That's better (APOP tested on sparc64 and amd64).

I don't know about the correct package naming, though.

Regards,

Michael

Re: mail/solid-pop3d: APOP not working for big endian machines

[Stuart Henderson]

On 2008/11/09 17:04, Michael Warmuth wrote:
> Hello,
>
> the flavor apop of solid-pop3d does not work on sparc64.
>
> The problem is caused by failing detection of big
> endianess in md5.c (Linux-specific?):

A simpler fix, and, after some head-scratching, repair PKGNAME
(unless I miss something not mentioned in commit logs as to why
it happened like that...)

ok?

Index: Makefile
===
RCS file: /cvs/ports/mail/solid-pop3d/Makefile,v
retrieving revision 1.17
diff -u -p -r1.17 Makefile
--- Makefile2 Jul 2008 14:32:30 -   1.17
+++ Makefile11 Nov 2008 15:48:52 -
@@ -4,7 +4,7 @@ COMMENT=flexible POP3 server
 
 VERSION=   0.15
 DISTNAME=  solid-pop3d-${VERSION}
-PKGNAME=   ${DISTNAME}p0   # also see below
+PKGNAME=   ${DISTNAME}p3
 CATEGORIES=mail
 MASTER_SITES=  ftp://dione.ids.pl/pub/solidpop3d/
 
@@ -31,7 +31,6 @@ NO_REGRESS=   Yes
 # enable support for APOP authentication.
 .if ${FLAVOR:L:Mapop}
 CONFIGURE_ARGS+= --enable-userconfig --enable-apop
-PKGNAME=${DISTNAME}p2
 .else
 CONFIGURE_ARGS+= --disable-userconfig --disable-apop
 .endif
Index: patches/patch-src_md5_c
===
RCS file: patches/patch-src_md5_c
diff -N patches/patch-src_md5_c
--- /dev/null   1 Jan 1970 00:00:00 -
+++ patches/patch-src_md5_c 11 Nov 2008 15:48:52 -
@@ -0,0 +1,11 @@
+$OpenBSD$
+--- src/md5.c.orig Tue Nov 11 15:42:29 2008
 src/md5.c  Tue Nov 11 15:42:38 2008
+@@ -38,6 +38,7 @@
+ #endif
+ 
+ #include "md5.h"
++#include "config.h"
+ 
+ #ifdef _LIBC
+ #include 

mail/solid-pop3d: APOP not working for big endian machines

[Michael Warmuth]

Hello,

the flavor apop of solid-pop3d does not work on sparc64.

The problem is caused by failing detection of big
endianess in md5.c (Linux-specific?):
#ifdef _LIBC
#include 
#if __BYTE_ORDER == __BIG_ENDIAN
#define WORDS_BIGENDIAN 1
#endif
#endif

Patch (tested on sparc64 and amd64) is attached.

Please comment.

Thanks,

Michael
--- src/md5.c.orig  Sun Nov  9 15:35:13 2008
+++ src/md5.c   Sun Nov  9 15:47:54 2008
@@ -46,6 +46,10 @@
 #endif
 #endif
 
+#if _BYTE_ORDER == _BIG_ENDIAN
+#define WORDS_BIGENDIAN 1
+#endif 
+
 #ifdef WORDS_BIGENDIAN
 #define SWAP(n)\
 (((n) << 24) | (((n) & 0xff00) << 8) | (((n) >> 8) & 0xff00) | ((n) >> 24))