Re: make clean=depends to clean also test-deps
On Sun, Nov 15, 2020 at 01:19:47AM +0100, Marc Espie wrote: > On Sat, Nov 14, 2020 at 07:36:31PM +, Mikolaj Kucharski wrote: > > Hi, > > > > Before I dig into this, would it be okay, if make clean=depends also > > cleaned up test dependencies? I often use clean-depends to clean up all > > dependencies, but that leaves behind ports in test dependencies. > > > > Would it be okay to include test deps during make clean-depends? > > That would be okay but this will be complicated. Okay. > Specifically, because test-depends are somewhat outside of the normal > depends, and clean=depends uses all-dir-depends, which does not have > test-depends. Okay. > and all-dir-depends shouldn't get test depends because of the way it's > generally used. I don't know. Would need to dig into this. > So this means more variables and more targets... > > The other issue is: what semantics. > make clean=depends will clean build/run depends recursively Yes, it does clean recursively. > if you include test-depends, you might clean up a lot of things... > specifically because test-depends are *outside* the normal build. This is *exactlty* what I want. I want it to clean it all, recursively. > So, what recursive semantics do you want for test depends ?... probably none ? I don't understand this question. -- Regards, Mikolaj
Re: make clean=depends to clean also test-deps
Marc Espie: > On Sat, Nov 14, 2020 at 07:36:31PM +, Mikolaj Kucharski wrote: > > Before I dig into this, would it be okay, if make clean=depends also > > cleaned up test dependencies? Yes, please! > The other issue is: what semantics. > make clean=depends will clean build/run depends recursively I would expect the same for test depends. -- Christian "naddy" Weisgerber na...@mips.inka.de
Re: make clean=depends to clean also test-deps
On Sat, Nov 14, 2020 at 07:36:31PM +, Mikolaj Kucharski wrote: > Hi, > > Before I dig into this, would it be okay, if make clean=depends also > cleaned up test dependencies? I often use clean-depends to clean up all > dependencies, but that leaves behind ports in test dependencies. > > Would it be okay to include test deps during make clean-depends? That would be okay but this will be complicated. Specifically, because test-depends are somewhat outside of the normal depends, and clean=depends uses all-dir-depends, which does not have test-depends. and all-dir-depends shouldn't get test depends because of the way it's generally used. So this means more variables and more targets... The other issue is: what semantics. make clean=depends will clean build/run depends recursively if you include test-depends, you might clean up a lot of things... specifically because test-depends are *outside* the normal build. So, what recursive semantics do you want for test depends ?... probably none ?
make clean=depends to clean also test-deps
Hi, Before I dig into this, would it be okay, if make clean=depends also cleaned up test dependencies? I often use clean-depends to clean up all dependencies, but that leaves behind ports in test dependencies. Would it be okay to include test deps during make clean-depends? -- Regards, Mikolaj
