[SOLVED] Re: net/zabbix-5.0.5 : Zabbix wrongly reporting down hosts as up

2020-11-25 Thread Federico Churca-Torrusio
On retrying the upgrade today, planning to upgrade Zabbix with -D snapshot,
I found you brought 5.0.5 into -stable. The upgrade went smooth as silk,
thanks!


Re: net/zabbix-5.0.5 : Zabbix wrongly reporting down hosts as up

2020-11-20 Thread Federico Churca-Torrusio
Sorry, you are right! Combing through my logs I just found that I was, in
fact, running 5.0.3 instead of 5.0.5 . I'll separately try both installing
zabbix from ports and pointing zabbix to the old fping. Sorry for the mess!



On Fri, Nov 20, 2020 at 6:48 PM Stuart Henderson 
wrote:

> On 2020/11/20 17:30, Federico Churca-Torrusio wrote:
> > >Simplest fix is probably to update zabbix to the version in -current,
> > >ports diff for this below.
> > >
> > >The actual commit fixing it is in
> > >
> >
> https://git.zabbix.com/projects/ZBX/repos/zabbix/commits/8cf3bbc393db3e48ac2401e50d1d880f53e8b758#src/libs/zbxicmpping/icmpping.c
> >
> > I thought of that, but I don't think it would work. According to
> > Zabbix's Jira [1] , that particular commit was already merged into Zabbix
> > 5.0.5 . Most curious.
> >
> > [1]: https://support.zabbix.com/browse/ZBX-18365
>
> You said you were running OpenBSD 6.8 which comes with 5.0.3
>


Re: net/zabbix-5.0.5 : Zabbix wrongly reporting down hosts as up

2020-11-20 Thread Stuart Henderson
On 2020/11/20 17:30, Federico Churca-Torrusio wrote:
> >Simplest fix is probably to update zabbix to the version in -current,
> >ports diff for this below.
> >
> >The actual commit fixing it is in
> >
> https://git.zabbix.com/projects/ZBX/repos/zabbix/commits/8cf3bbc393db3e48ac2401e50d1d880f53e8b758#src/libs/zbxicmpping/icmpping.c
> 
> I thought of that, but I don't think it would work. According to
> Zabbix's Jira [1] , that particular commit was already merged into Zabbix
> 5.0.5 . Most curious.
> 
> [1]: https://support.zabbix.com/browse/ZBX-18365

You said you were running OpenBSD 6.8 which comes with 5.0.3



Re: net/zabbix-5.0.5 : Zabbix wrongly reporting down hosts as up

2020-11-20 Thread Federico Churca-Torrusio
>Simplest fix is probably to update zabbix to the version in -current,
>ports diff for this below.
>
>The actual commit fixing it is in
>
https://git.zabbix.com/projects/ZBX/repos/zabbix/commits/8cf3bbc393db3e48ac2401e50d1d880f53e8b758#src/libs/zbxicmpping/icmpping.c

I thought of that, but I don't think it would work. According to
Zabbix's Jira [1] , that particular commit was already merged into Zabbix
5.0.5 . Most curious.

[1]: https://support.zabbix.com/browse/ZBX-18365


Re: net/zabbix-5.0.5 : Zabbix wrongly reporting down hosts as up

2020-11-20 Thread Stuart Henderson
On 2020/11/20 16:38, Federico Churca-Torrusio wrote:
> Hello
> 
> On upgrading, my Zabbix server started to wrongly report every host as up.
> According to other info I've found, it's very similar to Zabbix issue
> ZBX-18365 [1] , where Zabbix misinterprets fping's output as of fping 5.0 ,
> but it should have been fixed as of Zabbix 5.0.5 . This particular
> installation has OpenBSD -release on an amd64 virtual machine with
> syspatches, with Zabbix and fping from pkg_add . A workaround mentioned for
> other OS's was to downgrade fping 5 to fping 4 , but I haven't tried that
> yet; so far, I have rolled back to 6.7 .
> 
> Is this issue reported elsewhere for OpenBSD? How could I pin fping so it
> doesn't upgrade on pkg_add -u ? Would it be "canon" to graft in an old
> /usr/local/sbin/fping ?
> 
> Old versions:
> * OpenBSD 6.7
> * Zabbix 4.0.19 from pkg_add
> * fping 4.2 from pkg_add
> 
> New versions:
> * OpenBSD 6.8
> * Zabbix 5.0.5 from pkg_add
> * fping 5.0 from pkg_add
> 
> [1]: https://support.zabbix.com/browse/ZBX-18365
> 
> Thanks
> 
> Federico Churca-Torrusio

Simplest fix is probably to update zabbix to the version in -current,
ports diff for this below.

The actual commit fixing it is in
https://git.zabbix.com/projects/ZBX/repos/zabbix/commits/8cf3bbc393db3e48ac2401e50d1d880f53e8b758#src/libs/zbxicmpping/icmpping.c


Index: Makefile
===
RCS file: /cvs/ports/net/zabbix/Makefile,v
retrieving revision 1.169
diff -u -p -r1.169 Makefile
--- Makefile12 Sep 2020 12:47:01 -  1.169
+++ Makefile20 Nov 2020 19:50:50 -
@@ -5,7 +5,7 @@ COMMENT-server =network and application
 COMMENT-proxy =network and application monitoring - proxy
 COMMENT-web =  network and application monitoring - web frontend
 
-VERSION =  5.0.3
+VERSION =  5.0.5
 DISTNAME = zabbix-${VERSION}
 FULLPKGNAME-main = zabbix-agent-${VERSION}
 FULLPKGPATH-main = net/zabbix,-main
Index: distinfo
===
RCS file: /cvs/ports/net/zabbix/distinfo,v
retrieving revision 1.52
diff -u -p -r1.52 distinfo
--- distinfo12 Sep 2020 12:47:01 -  1.52
+++ distinfo20 Nov 2020 19:50:50 -
@@ -1,2 +1,2 @@
-SHA256 (zabbix-5.0.3.tar.gz) = NPy8a9yVxhinkDyhdDTP6xrRLwzeu8ddNZkJddNyg7U=
-SIZE (zabbix-5.0.3.tar.gz) = 18893485
+SHA256 (zabbix-5.0.5.tar.gz) = 7G01ICvwMIr3iX50TwhnEh/VThkfz6OVvyJ1ypTvkoA=
+SIZE (zabbix-5.0.5.tar.gz) = 19153153
Index: patches/patch-src_libs_zbxnix_daemon_c
===
RCS file: /cvs/ports/net/zabbix/patches/patch-src_libs_zbxnix_daemon_c,v
retrieving revision 1.14
diff -u -p -r1.14 patch-src_libs_zbxnix_daemon_c
--- patches/patch-src_libs_zbxnix_daemon_c  27 Jul 2020 14:32:03 -  
1.14
+++ patches/patch-src_libs_zbxnix_daemon_c  20 Nov 2020 19:50:50 -
@@ -2,7 +2,7 @@ $OpenBSD: patch-src_libs_zbxnix_daemon_c
 Index: src/libs/zbxnix/daemon.c
 --- src/libs/zbxnix/daemon.c.orig
 +++ src/libs/zbxnix/daemon.c
-@@ -308,7 +308,7 @@ intdaemon_start(int allow_root, const char *user, 
uns
+@@ -311,7 +311,7 @@ intdaemon_start(int allow_root, const char *user, 
uns
if (0 == allow_root && 0 == getuid())   /* running as root? */
{
if (NULL == user)
Index: pkg/PLIST-web
===
RCS file: /cvs/ports/net/zabbix/pkg/PLIST-web,v
retrieving revision 1.39
diff -u -p -r1.39 PLIST-web
--- pkg/PLIST-web   27 Jul 2020 14:32:03 -  1.39
+++ pkg/PLIST-web   20 Nov 2020 19:50:50 -
@@ -600,6 +600,9 @@ zabbix/include/classes/html/CRedirectBut
 zabbix/include/classes/html/CRow.php
 zabbix/include/classes/html/CRowHeader.php
 zabbix/include/classes/html/CScriptTag.php
+zabbix/include/classes/html/CSelect.php
+zabbix/include/classes/html/CSelectOption.php
+zabbix/include/classes/html/CSelectOptionGroup.php
 zabbix/include/classes/html/CSeverity.php
 zabbix/include/classes/html/CSeverityCheckBoxList.php
 zabbix/include/classes/html/CSimpleButton.php
@@ -609,6 +612,7 @@ zabbix/include/classes/html/CSubmitButto
 zabbix/include/classes/html/CSup.php
 zabbix/include/classes/html/CTabView.php
 zabbix/include/classes/html/CTable.php
+zabbix/include/classes/html/CTableColumn.php
 zabbix/include/classes/html/CTableInfo.php
 zabbix/include/classes/html/CTag.php
 zabbix/include/classes/html/CTextArea.php
@@ -1089,6 +1093,7 @@ zabbix/js/class.sidebar.js
 zabbix/js/class.template.js
 zabbix/js/colorpicker.js
 zabbix/js/common.js
+zabbix/js/component.z-select.js
 zabbix/js/csvggraphwidget.js
 zabbix/js/dashboard.grid.js
 zabbix/js/flickerfreescreen.js
@@ -1106,6 +,7 @@ zabbix/js/pages/
 zabbix/js/pages/items.js
 zabbix/js/pages/popup.condition.common.js
 zabbix/js/pages/popup.operation.common.js
+zabbix/js/pages/setup.js
 zabbix/js/servercheck.js
 

net/zabbix-5.0.5 : Zabbix wrongly reporting down hosts as up

2020-11-20 Thread Federico Churca-Torrusio
Hello

On upgrading, my Zabbix server started to wrongly report every host as up.
According to other info I've found, it's very similar to Zabbix issue
ZBX-18365 [1] , where Zabbix misinterprets fping's output as of fping 5.0 ,
but it should have been fixed as of Zabbix 5.0.5 . This particular
installation has OpenBSD -release on an amd64 virtual machine with
syspatches, with Zabbix and fping from pkg_add . A workaround mentioned for
other OS's was to downgrade fping 5 to fping 4 , but I haven't tried that
yet; so far, I have rolled back to 6.7 .

Is this issue reported elsewhere for OpenBSD? How could I pin fping so it
doesn't upgrade on pkg_add -u ? Would it be "canon" to graft in an old
/usr/local/sbin/fping ?

Old versions:
* OpenBSD 6.7
* Zabbix 4.0.19 from pkg_add
* fping 4.2 from pkg_add

New versions:
* OpenBSD 6.8
* Zabbix 5.0.5 from pkg_add
* fping 5.0 from pkg_add

[1]: https://support.zabbix.com/browse/ZBX-18365

Thanks

Federico Churca-Torrusio