Re: new: net/go-ipfs
Hi! Looks like user.list needs another bump as 823 is now opendkim. Also this should have 'NO_TEST=Yes'. With those changes OK abieber@ Cheers, Aaron -- PGP: 0x1F81112D62A9ADCE / 3586 3350 BFEA C101 DB1A 4AF0 1F81 112D 62A9 ADCE
Re: new: net/go-ipfs
Hi Fabian, On Thu, Sep 20, 2018 at 11:32:53AM +0100, Edd Barrett wrote: > Here's some more comments. It's all minor stuff from here on. We dropped the ball on go-ipfs. In addition to my prior comments, attached is an update to 0.4.18 and a new user.list diff. I also bumped the daemon_timeout in the rc script, as the ipfs can take quite some time to come down. (ipfs still destroys my DSL router, probably due to the sheer number of TCP connections it uses, but upstream are working on fixing that with QUIC) -- Best Regards Edd Barrett http://www.theunixzoo.co.uk go-ipfs-0.4.18.tgz Description: application/tar-gz Index: user.list === RCS file: /cvs/ports/infrastructure/db/user.list,v retrieving revision 1.329 diff -u -p -r1.329 user.list --- user.list 20 Nov 2018 10:52:25 - 1.329 +++ user.list 24 Nov 2018 17:14:11 - @@ -331,3 +331,4 @@ id usergroup port options 820 _arpwatch _arpwatch net/arpwatch 821 _tenshi_tenshi sysutils/tenshi 822 _apertium-apy _apertium-apy www/apertium-apy +823 _ipfs _ipfs net/go-ipfs
Re: new: net/go-ipfs
On Wed, 19 Sep 2018 at 21:44:51 +0200, Fabian Raetz wrote: > On Tue, Sep 18, 2018 at 11:07:00PM +0100, Edd Barrett wrote: > > Hi, > > > > Thanks for working on this. > > > > On Sun, Sep 16, 2018 at 09:52:52PM +0200, Fabian Raetz wrote: > > > I'm running an ipfs node at home and pinned a "Hello, OpenBSD!" > > > file [1] for you :) > > > > Works! And via `ipfs cat` (once you start the daemon). > > > > > You can also mount the world at /ipfs. > > > > If we enabled the fuse support ;) How hard is that by the way? > > Hi Edd, > > hehe, I also had to smile about this too. IPFS implements fuse by using > https://github.com/bazil/fuse, which has no support for OpenBSD. > > @abieber looked into adding support for OpenBSD in 2017 > (https://github.com/bazil/fuse/pull/104). His branch compiles but > go test fails for me. I think there is some more work involved to get this > into a useable shape. Turn out our implementation of /dev/fuseX doesn't expose the things required to make this work. > > I propose that we leave fuse deactived for now and don't talk about > fuse in DESCR. Agree. > > > > > > The tar.gz provided by upstream contains files at the root without an > > > go-ipfs > > > folder. I did the following to unpack everything in WRKDIST instead of in > > > WRKDIR directly. Is there a better approch to do this? > > > > I'm not aware of one, but the other porters might know a trick. > > > > > By default, ipfs creates all files in ~/.ipfs. This can be changed by > > > specifing IPFS_PATH. Personally I don't like a hidden folder at > > > /var/ipfs/.ipfs > > > which is why I set IPFS_PATH=/var/ipfs in the rc file. > > > This requires users of ipfs to always remember to set IPFS_PATH=/var/ipfs > > > > > > What would you prefer? > > > > > > 2.1) Setting HOME of the _ipfs user to /var/ipfs and have the data > > > under /var/ipfs/.ipfs. > > > 2.2) Setting IPFS_PATH=/var/ipfs in the rc file and whenever a user wants > > > to > > > interact with ipfs. > > > > Wouldn't a normal user want the IPFS files under the default ~/.ipfs? So > > they wouldn't need to remember anything? > > Yes, you're right. Adding IPFS_PATH would only be necessary, if you want > to interact with the ipfs daemon that is started by the rc file. > > As a normal user you can still use ipfs and have your files in ~/.ipfs. > > > > > The rc script doesn't work though? > > > > ---8<--- > > $ doas rcctl start ipfs > > ipfs(failed) > > --->8--- > > > > If you add `-d` you will see why: > > > > ---8<--- > > $ doas rcctl -d start ipfs > > doing _rc_parse_conf > > doing _rc_quirks > > ipfs_flags empty, using default >daemon< > > doing _rc_parse_conf /var/run/rc.d/ipfs > > doing _rc_quirks > > doing rc_check > > ipfs > > doing _rc_wait start > > doing rc_start > > doing rc_check > > Initializing daemon... > > 23:03:41.326 ERROR cmd/ipfs: setting file descriptor limit: cannot set > > rlimit, IPFS_FD_MAX is larger than the hard limit daemon.go:200 > > Error: no IPFS repo found in /var/ipfs. > > please run: 'ipfs init' > > doing _rc_rm_runfile > > (failed) > > --->8--- > > > > If that's correct, we'd need instructions for the user on how to up the > > fd limit. Probably via a pkg README. > > > > My only other comment is that the Makefile has a lot of whitespace. Can > > we make it look closer to other port Makefiles? > > I removed some empty lines and hope that goes into the right direction. > > New port is attached. > > Thanks, > Fabian > > > > > -- > > Best Regards > > Edd Barrett > > > > http://www.theunixzoo.co.uk > diff --git a/infrastructure/db/user.list b/infrastructure/db/user.list > index fc8521ab6fd..db8d79c3ab6 100644 > --- a/infrastructure/db/user.list > +++ b/infrastructure/db/user.list > @@ -327,3 +327,4 @@ id user group port options > 816 _libpostal geo/libpostal > 817 _netshot _netshotsysutils/netshot > 818 _vnu _vnuwww/vnu > +819 _ipfs_ipfs net/go-ipfs -- PGP: 0x1F81112D62A9ADCE / 3586 3350 BFEA C101 DB1A 4AF0 1F81 112D 62A9 ADCE
Re: new: net/go-ipfs
Hi Fabian, On Wed, Sep 19, 2018 at 09:44:51PM +0200, Fabian Raetz wrote: > @abieber looked into adding support for OpenBSD in 2017 > (https://github.com/bazil/fuse/pull/104). His branch compiles but > go test fails for me. I think there is some more work involved to get this > into a useable shape. > > I propose that we leave fuse deactived for now and don't talk about > fuse in DESCR. That's fine, thanks for looking. > New port is attached. Here's some more comments. It's all minor stuff from here on. The whitespace looks much better, thanks. I wonder if the user and service name should be '_go-ipfs' and 'go-ipfs' to accommodate different implementations in the future (Maybe /var/go-ipfs too?). I don't feel strongly about this though. The user is created with /bin/sh as a shell. Some other ports create users with /sbin/nologin as a shell. Can we get away with that? (You'd need the `ipfs init` described in the README to work without the user having proper shell). Again, it's not a big deal if it isn't possible. I'm now torn about whether to set the $HOME for the user to /var/ipfs. If we do, then it simplifies the 'ipfs init' command and the RC script. Did you have any other thoughts on that? Also optionally, you could mention the web UI in the README (http://127.0.0.1:5001/webui). It's very shiny. Cheers -- Best Regards Edd Barrett http://www.theunixzoo.co.uk
Re: new: net/go-ipfs
On Tue, Sep 18, 2018 at 11:07:00PM +0100, Edd Barrett wrote: > Hi, > > Thanks for working on this. > > On Sun, Sep 16, 2018 at 09:52:52PM +0200, Fabian Raetz wrote: > > I'm running an ipfs node at home and pinned a "Hello, OpenBSD!" > > file [1] for you :) > > Works! And via `ipfs cat` (once you start the daemon). > > > You can also mount the world at /ipfs. > > If we enabled the fuse support ;) How hard is that by the way? Hi Edd, hehe, I also had to smile about this too. IPFS implements fuse by using https://github.com/bazil/fuse, which has no support for OpenBSD. @abieber looked into adding support for OpenBSD in 2017 (https://github.com/bazil/fuse/pull/104). His branch compiles but go test fails for me. I think there is some more work involved to get this into a useable shape. I propose that we leave fuse deactived for now and don't talk about fuse in DESCR. > > > The tar.gz provided by upstream contains files at the root without an > > go-ipfs > > folder. I did the following to unpack everything in WRKDIST instead of in > > WRKDIR directly. Is there a better approch to do this? > > I'm not aware of one, but the other porters might know a trick. > > > By default, ipfs creates all files in ~/.ipfs. This can be changed by > > specifing IPFS_PATH. Personally I don't like a hidden folder at > > /var/ipfs/.ipfs > > which is why I set IPFS_PATH=/var/ipfs in the rc file. > > This requires users of ipfs to always remember to set IPFS_PATH=/var/ipfs > > > > What would you prefer? > > > > 2.1) Setting HOME of the _ipfs user to /var/ipfs and have the data > > under /var/ipfs/.ipfs. > > 2.2) Setting IPFS_PATH=/var/ipfs in the rc file and whenever a user wants to > > interact with ipfs. > > Wouldn't a normal user want the IPFS files under the default ~/.ipfs? So > they wouldn't need to remember anything? Yes, you're right. Adding IPFS_PATH would only be necessary, if you want to interact with the ipfs daemon that is started by the rc file. As a normal user you can still use ipfs and have your files in ~/.ipfs. > > The rc script doesn't work though? > > ---8<--- > $ doas rcctl start ipfs > ipfs(failed) > --->8--- > > If you add `-d` you will see why: > > ---8<--- > $ doas rcctl -d start ipfs > doing _rc_parse_conf > doing _rc_quirks > ipfs_flags empty, using default >daemon< > doing _rc_parse_conf /var/run/rc.d/ipfs > doing _rc_quirks > doing rc_check > ipfs > doing _rc_wait start > doing rc_start > doing rc_check > Initializing daemon... > 23:03:41.326 ERROR cmd/ipfs: setting file descriptor limit: cannot set > rlimit, IPFS_FD_MAX is larger than the hard limit daemon.go:200 > Error: no IPFS repo found in /var/ipfs. > please run: 'ipfs init' > doing _rc_rm_runfile > (failed) > --->8--- > > If that's correct, we'd need instructions for the user on how to up the > fd limit. Probably via a pkg README. > > My only other comment is that the Makefile has a lot of whitespace. Can > we make it look closer to other port Makefiles? I removed some empty lines and hope that goes into the right direction. New port is attached. Thanks, Fabian > > -- > Best Regards > Edd Barrett > > http://www.theunixzoo.co.uk go-ipfs-v1.tar.gz Description: Binary data diff --git a/infrastructure/db/user.list b/infrastructure/db/user.list index fc8521ab6fd..db8d79c3ab6 100644 --- a/infrastructure/db/user.list +++ b/infrastructure/db/user.list @@ -327,3 +327,4 @@ id usergroup port options 816_libpostal geo/libpostal 817 _netshot _netshotsysutils/netshot 818 _vnu _vnuwww/vnu +819 _ipfs _ipfs net/go-ipfs
Re: new: net/go-ipfs
On Tue, Sep 18, 2018 at 11:07:00PM +0100, Edd Barrett wrote: > If that's correct, we'd need instructions for the user on how to up the > fd limit. Probably via a pkg README. Fabian already has a README, I just missed it! Bravo! -- Best Regards Edd Barrett http://www.theunixzoo.co.uk
Re: new: net/go-ipfs
Hi, Thanks for working on this. On Sun, Sep 16, 2018 at 09:52:52PM +0200, Fabian Raetz wrote: > I'm running an ipfs node at home and pinned a "Hello, OpenBSD!" > file [1] for you :) Works! And via `ipfs cat` (once you start the daemon). > You can also mount the world at /ipfs. If we enabled the fuse support ;) How hard is that by the way? > The tar.gz provided by upstream contains files at the root without an go-ipfs > folder. I did the following to unpack everything in WRKDIST instead of in > WRKDIR directly. Is there a better approch to do this? I'm not aware of one, but the other porters might know a trick. > By default, ipfs creates all files in ~/.ipfs. This can be changed by > specifing IPFS_PATH. Personally I don't like a hidden folder at > /var/ipfs/.ipfs > which is why I set IPFS_PATH=/var/ipfs in the rc file. > This requires users of ipfs to always remember to set IPFS_PATH=/var/ipfs > > What would you prefer? > > 2.1) Setting HOME of the _ipfs user to /var/ipfs and have the data > under /var/ipfs/.ipfs. > 2.2) Setting IPFS_PATH=/var/ipfs in the rc file and whenever a user wants to > interact with ipfs. Wouldn't a normal user want the IPFS files under the default ~/.ipfs? So they wouldn't need to remember anything? The rc script doesn't work though? ---8<--- $ doas rcctl start ipfs ipfs(failed) --->8--- If you add `-d` you will see why: ---8<--- $ doas rcctl -d start ipfs doing _rc_parse_conf doing _rc_quirks ipfs_flags empty, using default >daemon< doing _rc_parse_conf /var/run/rc.d/ipfs doing _rc_quirks doing rc_check ipfs doing _rc_wait start doing rc_start doing rc_check Initializing daemon... 23:03:41.326 ERROR cmd/ipfs: setting file descriptor limit: cannot set rlimit, IPFS_FD_MAX is larger than the hard limit daemon.go:200 Error: no IPFS repo found in /var/ipfs. please run: 'ipfs init' doing _rc_rm_runfile (failed) --->8--- If that's correct, we'd need instructions for the user on how to up the fd limit. Probably via a pkg README. My only other comment is that the Makefile has a lot of whitespace. Can we make it look closer to other port Makefiles? -- Best Regards Edd Barrett http://www.theunixzoo.co.uk
