Re: new port for sxiv
The replacement find command doesn't quite reproduce the effect of the linux find command in the original manpage, so I've tweeked it a bit. I mentioned the problem upstream, maybe it will be fixed in the next release. Attached is the diff to sxiv in cvs. Index: sxiv/patches/patch-sxiv_1 === RCS file: sxiv/patches/patch-sxiv_1 diff -N sxiv/patches/patch-sxiv_1 --- /dev/null 1 Jan 1970 00:00:00 - +++ sxiv/patches/patch-sxiv_1 1 Mar 2012 18:33:55 - @@ -0,0 +1,12 @@ +$OpenBSD$ +--- sxiv.1.origThu Mar 1 12:42:54 2012 sxiv.1 Thu Mar 1 13:21:38 2012 +@@ -301,7 +301,7 @@ Additionally, run the following command afterwards ins + to remove empty subdirectories: + .P + .RS +-find \-type d \-empty \-delete ++find . \-depth \-type d \-empty ! \-name '.' \-exec rmdir {} \\; + .RE + .SH AUTHORS + .EX pgpy5r5tK4KeY.pgp Description: PGP signature
Re: new port for sxiv
anthonyjbent...@gmail.com (Anthony J. Bentley), 2012.02.27 (Mon) 05:13 (CET): Matthew Via writes: Attached is a port for sxiv, a lightweight tiling-wm friendly image viewer. This is my first port, so please let me know if there's anything I should change. [snip] Attached is a cleaned-up version. On first use this seems like a nice program, may replace feh for me... yup, nice and fast one, the only thing missing for my (qiv) usage pattern: run custom commands on images. minor glitch in sxiv(1), section THUMBNAIL CACHING: ``find -type d -empty -delete'' should read: ``find -type d -empty -print0 | xargs -0 rmdir'' Bye, Marcus
Re: new port for sxiv
Attached is an updated port with the manpage line changed, thanks for the catch. Also of note, the contents of the main.c patch is now upstream, so the next release should not need the patch. -via On 18:47 Mon 27 Feb , MERIGHI Marcus wrote: anthonyjbent...@gmail.com (Anthony J. Bentley), 2012.02.27 (Mon) 05:13 (CET): Matthew Via writes: Attached is a port for sxiv, a lightweight tiling-wm friendly image viewer. This is my first port, so please let me know if there's anything I should change. [snip] Attached is a cleaned-up version. On first use this seems like a nice program, may replace feh for me... yup, nice and fast one, the only thing missing for my (qiv) usage pattern: run custom commands on images. minor glitch in sxiv(1), section THUMBNAIL CACHING: ``find -type d -empty -delete'' should read: ``find -type d -empty -print0 | xargs -0 rmdir'' Bye, Marcus sxiv.tar.gz Description: application/tar-gz pgpaRB3PjxQnh.pgp Description: PGP signature
new port for sxiv
Attached is a port for sxiv, a lightweight tiling-wm friendly image viewer. This is my first port, so please let me know if there's anything I should change. Thank you, via sxiv.tar.gz Description: application/tar-gz pgpvsB28QilqC.pgp Description: PGP signature
Re: new port for sxiv
On Sun, 26 Feb 2012 20:41:09 -0500 Matthew Via v...@matthewvia.info wrote: Attached is a port for sxiv, a lightweight tiling-wm friendly image viewer. This is my first port, so please let me know if there's anything I should change. Thank you, via Just checked on amd64 and it works fine. In fact, awesome - it compiles in about 2 seconds and loads images instantly!
Re: new port for sxiv
Matthew Via writes: Attached is a port for sxiv, a lightweight tiling-wm friendly image viewer. This is my first port, so please let me know if there's anything I should change. You can make the patch a lot shorter by setting MAKE_FLAGS appropriately in the port Makefile (CC=${CXX}, etc.). Make sure it respects the user's CFLAGS. There are also some spacing-only changes that make the patch hard to read. Don't hardcode /usr/local or /usr/X11R6. Use ${PREFIX} and ${X11BASE} instead. The Makefile should have an RCS id at the top. You get this for free by whittling down /usr/ports/infrastructure/templates/Makefile.template rather than starting from scratch. Don't capitalize the first letter in COMMENT. There are no regression tests, so set NO_REGRESS = Yes (otherwise make regress gives an error). Remember to run make port-lib-depends-check. You forgot to set WANTLIB. Attached is a cleaned-up version. On first use this seems like a nice program, may replace feh for me... sxiv.tar.gz Description: gzip compressed data, from Unix