Re: textproc/wkhtmltopdf - switch to QT5

2015-11-15 Thread Frank Groeneveld

On 11/15/15 13:56, Rafael Sadowski wrote:

Why? Is there any benefit from Qt5 now?


It was suggested earlier on the list and I thought Amit had a good point:

On 11/11/15 20:53, Amit Kulkarni wrote:

why have multi-packages for the same functionality? eventually the
ports@ tree will move towards qt5. qt4 is deprecated and over time
will suffer bit-rot, so if it works equally well with stock qt5 (with
missing features), IMHO wkhtmltopdf should be switched to work with
qt5 only.


Are you not able to use the QT5 version? Or is there another reason to 
use the QT4 version?


Frank



Re: textproc/wkhtmltopdf - switch to QT5

2015-11-15 Thread Rafael Sadowski
On Sun Nov 15, 2015 at 09:36:39AM +0100, Frank Groeneveld wrote:
> The following diff changes the textproc/wkhtmltopdf port to use QT5 instead
> of QT4. Any comments?
> 
Why? Is there any benefit from Qt5 now?

Looks like the next release will require Qt5:

https://github.com/wkhtmltopdf/wkhtmltopdf/blob/0.13/README.md#013-alpha

Cheers, Rafael



textproc/wkhtmltopdf - switch to QT5

2015-11-15 Thread Frank Groeneveld
The following diff changes the textproc/wkhtmltopdf port to use QT5 
instead of QT4. Any comments?


Thanks!

Frank
Index: Makefile
===
RCS file: /cvs/ports/textproc/wkhtmltopdf/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Makefile
--- Makefile4 Nov 2015 21:11:16 -   1.1.1.1
+++ Makefile15 Nov 2015 08:33:27 -
@@ -7,6 +7,7 @@ GH_PROJECT =wkhtmltopdf
 GH_TAGNAME =   0.12.2.4
 
 DISTNAME = wkhtmltopdf-${GH_TAGNAME}
+REVISION = 0
 
 SHARED_LIBS =  wkhtmltox 0.0 # 0.12
 
@@ -19,11 +20,11 @@ MAINTAINER =Frank Groeneveld