Re: update net/kristall

2024-04-25 Thread Omar Polo
On 2024/04/18 23:29:20 +0200, Solene Rapenne  wrote:
> this updates kristall to latest commit
> 
> not sure if we want to keep it, we have
> many good gemini browsers nowadays and with
> much less dependencies than this one

I wouldn't remove this only due to the number of dependencies, otherwise
we could clean up a good chunk of the port tree.  It is true however
that it wasn't updated for more than two years...

It still fills a niche for folks using a lot of qt applications maybe.

In case you want to update it, here's an improved diff that:

 - fixes the shebang in doc/gem-to-man.sh
 - fixes the installation path for the manpage
 - makes sure that the CFLAGS are propagated

that is ofc ok op@ to commit if you want to go ahead with it.

It works more or less for me.  I personally hate the way it renders the
text, inter-word spacing is abnormal and makes it illegible for me, and
it doesn't render the icons inside the buttons for forward and backward
navigation and to refresh the page.


Index: Makefile
===
RCS file: /home/cvs/ports/net/kristall/Makefile,v
diff -u -p -r1.5 Makefile
--- Makefile24 Apr 2023 11:41:24 -  1.5
+++ Makefile25 Apr 2024 08:14:29 -
@@ -1,11 +1,10 @@
 COMMENT =  graphical multi-protocol navigator
 
-DISTNAME = kristall-202500
+DISTNAME = kristall-2024010500
 
 GH_ACCOUNT =   MasterQ32
 GH_PROJECT =   kristall
-GH_COMMIT =9744a24ffbf4d5ea6ad8b418d740c90336ee33b8
-REVISION = 1
+GH_COMMIT =b4c677cdb5a9d7337758bcad45db5b21e2b85280
 
 CATEGORIES =   net x11
 
@@ -30,6 +29,12 @@ LIB_DEPENDS =audio/pulseaudio \
 USE_GMAKE =Yes
 
 NO_TEST =  Yes
+
+MAKE_ENV +=KRISTALL_VERSION=${DISTNAME} \
+   CFLAGS="${CFLAGS}" \
+   CXXFLAGS="${CXXFLAGS}"
+
+FAKE_FLAGS =   mandir="${DESTDIR}${PREFIX}/man/man1"
 
 ALL_TARGET =   kristall
 
Index: distinfo
===
RCS file: /home/cvs/ports/net/kristall/distinfo,v
diff -u -p -r1.2 distinfo
--- distinfo20 Nov 2021 10:33:41 -  1.2
+++ distinfo25 Apr 2024 07:49:43 -
@@ -1,2 +1,2 @@
-SHA256 (kristall-202500-9744a24f.tar.gz) = 
LmKSQEGWbMpV5G7+Bljhbxg8IKi4mH/a6uh9IuL1qfo=
-SIZE (kristall-202500-9744a24f.tar.gz) = 22016994
+SHA256 (kristall-2024010500-b4c677cd.tar.gz) = 
NqtkRCpYcE/lXYdiWbtyNDhIrVLn84P0cV2M8ngoQDk=
+SIZE (kristall-2024010500-b4c677cd.tar.gz) = 22026147
Index: patches/patch-doc_gem-to-man_awk
===
RCS file: patches/patch-doc_gem-to-man_awk
diff -N patches/patch-doc_gem-to-man_awk
--- /dev/null   1 Jan 1970 00:00:00 -
+++ patches/patch-doc_gem-to-man_awk25 Apr 2024 07:54:09 -
@@ -0,0 +1,9 @@
+Index: doc/gem-to-man.awk
+--- doc/gem-to-man.awk.orig
 doc/gem-to-man.awk
+@@ -1,4 +1,4 @@
+-#!/usr/bin/env -S awk -f
++#!/usr/bin/awk -f
+ 
+ BEGIN {
+ preformatted=0
Index: patches/patch-src_kristall_pro
===
RCS file: /home/cvs/ports/net/kristall/patches/patch-src_kristall_pro,v
diff -u -p -r1.2 patch-src_kristall_pro
--- patches/patch-src_kristall_pro  11 Mar 2022 19:46:12 -  1.2
+++ patches/patch-src_kristall_pro  25 Apr 2024 07:49:43 -
@@ -1,14 +0,0 @@
-Prevent git run at every ${CC} call
-
-Index: src/kristall.pro
 src/kristall.pro.orig
-+++ src/kristall.pro
-@@ -9,7 +9,7 @@ greaterThan(QT_MAJOR_VERSION, 4): QT += widgets networ
- # deprecated API in order to know how to port your code away from it.
- DEFINES += QT_DEPRECATED_WARNINGS
- 
--DEFINES += KRISTALL_VERSION="\"$(shell cd $$PWD; git describe --tags)\""
-+DEFINES += KRISTALL_VERSION="OpenBSD"
- 
- # You can also make your code fail to compile if it uses deprecated APIs.
- # In order to do so, uncomment the following line.
Index: pkg/PLIST
===
RCS file: /home/cvs/ports/net/kristall/pkg/PLIST,v
diff -u -p -r1.3 PLIST
--- pkg/PLIST   11 Mar 2022 19:46:12 -  1.3
+++ pkg/PLIST   25 Apr 2024 08:16:19 -
@@ -1,4 +1,5 @@
 @bin bin/kristall
+@man man/man1/kristall.1
 share/applications/Kristall.desktop
 share/icons/hicolor/128x128/apps/net.random-projects.kristall.png
 share/icons/hicolor/16x16/apps/net.random-projects.kristall.png
@@ -7,5 +8,7 @@ share/icons/hicolor/64x64/apps/net.rando
 share/icons/hicolor/scalable/apps/net.random-projects.kristall.svg
 @tag update-desktop-database
 @tag gtk-update-icon-cache %D/share/icons/hicolor
+share/metainfo/
+share/metainfo/Kristall.metainfo.xml
 share/mime/packages/kristall.xml
 @tag update-mime-database



delete net/kristall? (was update net/kristall)

2024-04-25 Thread Solene Rapenne
On Thu, Apr 18, 2024 at 11:29:20PM GMT, Solene Rapenne wrote:
> this updates kristall to latest commit
> 
> not sure if we want to keep it, we have
> many good gemini browsers nowadays and with
> much less dependencies than this one

on a second thought, I propose we remove this port



update net/kristall

2024-04-18 Thread Solene Rapenne
this updates kristall to latest commit

not sure if we want to keep it, we have
many good gemini browsers nowadays and with
much less dependencies than this one

diff --git a/net/kristall/Makefile b/net/kristall/Makefile
index 185bee8d7fc..a73b2fe4295 100644
--- a/net/kristall/Makefile
+++ b/net/kristall/Makefile
@@ -1,11 +1,10 @@
 COMMENT =  graphical multi-protocol navigator
 
-DISTNAME = kristall-202500
+DISTNAME = kristall-2024010500
 
 GH_ACCOUNT =   MasterQ32
 GH_PROJECT =   kristall
-GH_COMMIT =9744a24ffbf4d5ea6ad8b418d740c90336ee33b8
-REVISION = 1
+GH_COMMIT =b4c677cdb5a9d7337758bcad45db5b21e2b85280
 
 CATEGORIES =   net x11
 
@@ -31,6 +30,8 @@ USE_GMAKE =   Yes
 
 NO_TEST =  Yes
 
+MAKE_ENV +=KRISTALL_VERSION=${DISTNAME}
+
 ALL_TARGET =   kristall
 
 .include 
diff --git a/net/kristall/distinfo b/net/kristall/distinfo
index 81db07c7eed..6a758256d4b 100644
--- a/net/kristall/distinfo
+++ b/net/kristall/distinfo
@@ -1,2 +1,2 @@
-SHA256 (kristall-202500-9744a24f.tar.gz) = 
LmKSQEGWbMpV5G7+Bljhbxg8IKi4mH/a6uh9IuL1qfo=
-SIZE (kristall-202500-9744a24f.tar.gz) = 22016994
+SHA256 (kristall-2024010500-b4c677cd.tar.gz) = 
NqtkRCpYcE/lXYdiWbtyNDhIrVLn84P0cV2M8ngoQDk=
+SIZE (kristall-2024010500-b4c677cd.tar.gz) = 22026147
diff --git a/net/kristall/patches/patch-src_kristall_pro 
b/net/kristall/patches/patch-src_kristall_pro
deleted file mode 100644
index 0b0c2b9dfef..000
--- a/net/kristall/patches/patch-src_kristall_pro
+++ /dev/null
@@ -1,14 +0,0 @@
-Prevent git run at every ${CC} call
-
-Index: src/kristall.pro
 src/kristall.pro.orig
-+++ src/kristall.pro
-@@ -9,7 +9,7 @@ greaterThan(QT_MAJOR_VERSION, 4): QT += widgets networ
- # deprecated API in order to know how to port your code away from it.
- DEFINES += QT_DEPRECATED_WARNINGS
- 
--DEFINES += KRISTALL_VERSION="\"$(shell cd $$PWD; git describe --tags)\""
-+DEFINES += KRISTALL_VERSION="OpenBSD"
- 
- # You can also make your code fail to compile if it uses deprecated APIs.
- # In order to do so, uncomment the following line.
diff --git a/net/kristall/pkg/PLIST b/net/kristall/pkg/PLIST
index 757bd7eeec6..5e7a49d14d0 100644
--- a/net/kristall/pkg/PLIST
+++ b/net/kristall/pkg/PLIST
@@ -7,5 +7,7 @@ share/icons/hicolor/64x64/apps/net.random-projects.kristall.png
 share/icons/hicolor/scalable/apps/net.random-projects.kristall.svg
 @tag update-desktop-database
 @tag gtk-update-icon-cache %D/share/icons/hicolor
+share/metainfo/
+share/metainfo/Kristall.metainfo.xml
 share/mime/packages/kristall.xml
 @tag update-mime-database