Re: windowmaker diff
No objections, and another confirmation here! Thought I am running OpenBSD 5.9 RELEASE with the ports distributed with that release, the diff still worked well. I only had 36 lines of Makefile.rej to process from the patch and I am for the first time since I wanted to in the late 90s using *drawers* on the dock. :-) I'm so happy. Also, I notice that Chrome docks properly. This was a problem in .92. I tested out the Workspace pager, and it works just fine. The additional maximize options (to left, right top and bottom halves, and to the corners) are all working. Thanks for your work reyk, sebastia and David!
Re: windowmaker diff
On Mon, Jun 13, 2016 at 10:43 PM, Sebastian Reitenbach
wrote:
>
> On Wednesday, June 8, 2016 16:49 CEST, David Coppa wrote:
>
>> On Tue, 07 Jun 2016, Reyk Floeter wrote:
>>
>> > On Tue, Jun 07, 2016 at 08:48:26PM +0200, David Coppa wrote:
>> > > On Tue, Jun 7, 2016 at 8:35 PM, Reyk Floeter wrote:
>> > > > On Tue, Jun 07, 2016 at 08:23:01PM +0200, Reyk Floeter wrote:
>> > > >> On Tue, Jun 07, 2016 at 05:27:51PM +0200, David Coppa wrote:
>> > > >> > Hi Reyk,
>> > > >> >
>> > > >> > Since I've just found (by reading your howto about the Lenovo
>> > > >> > Thinkpad
>> > > >> > X1 Carbon) that you're using Window Maker...
>> > > >> > Could you please test the attached diff that updates our windowmaker
>> > > >> > port to its latest release, 0.95.7?
>> > > >> >
>> > > >> > Ciao!
>> > > >> > David
>> > > >>
>> > > >> Sure!
>> > > >>
>> > > >
>> > > > It compiles, installed, but one annoying thing is that window-resize
>> > > > seems to be broken ('Maximize active window' gives strange results and
>> > > > covers the dock)
>> > > >
>> > > > There might be other issues.
>> > >
>> > > Can you try starting from scratch with a clean environment?
>> > >
>> > > I mean:
>> > >
>> > > $ mv ~/GNUstep ~/GNUstep.old
>> > >
>> >
>> > Yes, that helped.
>> >
>> > A few other things have changed (like the default menu, in a negative
>> > way hiding xterm and Firefox somewhere in a submenu). Maximization
>> > now includes the space behind the dock - I have to get used to this.
>> >
>> > I also don't like the new "jumping" icons. They should focus on
>> > modernizing wmaker (eg. by adding support for DPI scaling) instead
>> > bloating it with gimmicks (11 different ways of maximization?!).
>> > But there is a chance that something will happen now ;)
>> >
>> > After all, I think the ports update is OK.
>>
>> Widening the audience to ports@
>>
>> Here's a new version of the diff.
>> I've stolen some useful patches from FreeBSD, and fixed a time_t
>> issue.
>>
>> Maybe it's the right time to update our prehistoric port of Window
>> Maker...
>>
>> If you're a wmaker user, please test!
>
> finally got around to it, I use it all day with GNUstep GWorkspace
> as desktop. So far, works well for me on amd64.
>
> OK sebastia@
So I have two OKs from reyk@ and sebastia@...
If nobody objects, I'll commit my diff in the next few days.
Ciao!
David
Re: windowmaker diff
On Wednesday, June 8, 2016 16:49 CEST, David Coppa wrote:
> On Tue, 07 Jun 2016, Reyk Floeter wrote:
>
> > On Tue, Jun 07, 2016 at 08:48:26PM +0200, David Coppa wrote:
> > > On Tue, Jun 7, 2016 at 8:35 PM, Reyk Floeter wrote:
> > > > On Tue, Jun 07, 2016 at 08:23:01PM +0200, Reyk Floeter wrote:
> > > >> On Tue, Jun 07, 2016 at 05:27:51PM +0200, David Coppa wrote:
> > > >> > Hi Reyk,
> > > >> >
> > > >> > Since I've just found (by reading your howto about the Lenovo
> > > >> > Thinkpad
> > > >> > X1 Carbon) that you're using Window Maker...
> > > >> > Could you please test the attached diff that updates our windowmaker
> > > >> > port to its latest release, 0.95.7?
> > > >> >
> > > >> > Ciao!
> > > >> > David
> > > >>
> > > >> Sure!
> > > >>
> > > >
> > > > It compiles, installed, but one annoying thing is that window-resize
> > > > seems to be broken ('Maximize active window' gives strange results and
> > > > covers the dock)
> > > >
> > > > There might be other issues.
> > >
> > > Can you try starting from scratch with a clean environment?
> > >
> > > I mean:
> > >
> > > $ mv ~/GNUstep ~/GNUstep.old
> > >
> >
> > Yes, that helped.
> >
> > A few other things have changed (like the default menu, in a negative
> > way hiding xterm and Firefox somewhere in a submenu). Maximization
> > now includes the space behind the dock - I have to get used to this.
> >
> > I also don't like the new "jumping" icons. They should focus on
> > modernizing wmaker (eg. by adding support for DPI scaling) instead
> > bloating it with gimmicks (11 different ways of maximization?!).
> > But there is a chance that something will happen now ;)
> >
> > After all, I think the ports update is OK.
>
> Widening the audience to ports@
>
> Here's a new version of the diff.
> I've stolen some useful patches from FreeBSD, and fixed a time_t
> issue.
>
> Maybe it's the right time to update our prehistoric port of Window
> Maker...
>
> If you're a wmaker user, please test!
finally got around to it, I use it all day with GNUstep GWorkspace
as desktop. So far, works well for me on amd64.
OK sebastia@
>
> Ciao,
> David
>
> Index: Makefile
> ===
> RCS file: /cvs/ports/x11/windowmaker/Makefile,v
> retrieving revision 1.93
> diff -u -p -u -p -r1.93 Makefile
> --- Makefile 11 Mar 2016 20:28:33 - 1.93
> +++ Makefile 8 Jun 2016 14:16:50 -
> @@ -3,14 +3,15 @@
> COMMENT-main=window manager that emulates NEXTSTEP(tm)
> COMMENT-lang=language subpackage for Window Maker
>
> -V= 0.92.0
> +V = 0.95.7
> DISTNAME=WindowMaker-${V}
> PKGNAME-main=${DISTNAME:L}
> -REVISION-main= 56
> FULLPKGNAME-lang=windowmaker-lang-${V}
> -REVISION-lang= 5
>
> -SHARED_LIBS += wraster 5.0 # 4.0
> +SHARED_LIBS += WINGs 0.0 # 2.1
> +SHARED_LIBS += WMaker0.0 # 1.1
> +SHARED_LIBS += WUtil 0.0 # 3.0
> +SHARED_LIBS += wraster 5.1 # 4.1
>
> CATEGORIES= x11 x11/windowmaker
>
> @@ -19,22 +20,27 @@ HOMEPAGE= http://windowmaker.org/
> # GPLv2+
> PERMIT_PACKAGE_CDROM=Yes
>
> -WANTLIB += X11 Xext Xft Xinerama Xpm Xrender c expat fontconfig
> -WANTLIB += freetype jpeg m png pthread-stubs tiff gif xcb z
> +WANTLIB += ICE SM X11 Xmu Xext Xft Xinerama Xpm Xrandr Xrender
> +WANTLIB += Xt c expat fontconfig freetype gif jpeg kvm m png
> +WANTLIB += pthread pthread-stubs tiff xcb z
>
> MASTER_SITES=${MASTER_SITE_WINDOWMAKER:=source/release/}
> -EXTRACT_SUFX=.tar.bz2
>
> NO_TEST= Yes
> SEPARATE_BUILD= Yes
> CONFIGURE_STYLE= gnu
> -CONFIGURE_ARGS+= --enable-static \
> +CONFIGURE_ARGS+= --disable-magick \
> + --disable-webp \
> + --enable-randr \
> + --enable-static \
> --enable-xinerama \
> - --with-datadir="${LOCALBASE}/share/WindowMaker" \
> - --with-nlsdir="${LOCALBASE}/share/locale"
> + --localedir="${LOCALBASE}/share/locale"
>
> -CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include"
> LIBS="-L${LOCALBASE}/lib" \
> - LINGUAS='be bg bs ca cs da de el es et fi fr gl hr hu
> it ja ko ms nl no pl pt ro ru sk sv tr zh_CN zh_TW'
> +CONFIGURE_ENV= CPPFLAGS="-I${X11BASE}/include
> -I${LOCALBASE}/include" \
> + LIBS="-L${X11BASE}/lib -L${LOCALBASE}/lib" \
> + LINGUAS='*' \
> + ac_cv_lib_exif_exif_data_new_from_file=no \
> + wm_cv_func_secure_getenv=no
>
> MULTI_PACKAGES= -main -lang
>
> @@ -43,27 +49,24 @@ LIB_DEPENDS= graphics/tiff \
> graphics/png \
> g
Re: windowmaker diff
On Tue, 07 Jun 2016, Reyk Floeter wrote:
> On Tue, Jun 07, 2016 at 08:48:26PM +0200, David Coppa wrote:
> > On Tue, Jun 7, 2016 at 8:35 PM, Reyk Floeter wrote:
> > > On Tue, Jun 07, 2016 at 08:23:01PM +0200, Reyk Floeter wrote:
> > >> On Tue, Jun 07, 2016 at 05:27:51PM +0200, David Coppa wrote:
> > >> > Hi Reyk,
> > >> >
> > >> > Since I've just found (by reading your howto about the Lenovo Thinkpad
> > >> > X1 Carbon) that you're using Window Maker...
> > >> > Could you please test the attached diff that updates our windowmaker
> > >> > port to its latest release, 0.95.7?
> > >> >
> > >> > Ciao!
> > >> > David
> > >>
> > >> Sure!
> > >>
> > >
> > > It compiles, installed, but one annoying thing is that window-resize
> > > seems to be broken ('Maximize active window' gives strange results and
> > > covers the dock)
> > >
> > > There might be other issues.
> >
> > Can you try starting from scratch with a clean environment?
> >
> > I mean:
> >
> > $ mv ~/GNUstep ~/GNUstep.old
> >
>
> Yes, that helped.
>
> A few other things have changed (like the default menu, in a negative
> way hiding xterm and Firefox somewhere in a submenu). Maximization
> now includes the space behind the dock - I have to get used to this.
>
> I also don't like the new "jumping" icons. They should focus on
> modernizing wmaker (eg. by adding support for DPI scaling) instead
> bloating it with gimmicks (11 different ways of maximization?!).
> But there is a chance that something will happen now ;)
>
> After all, I think the ports update is OK.
Widening the audience to ports@
Here's a new version of the diff.
I've stolen some useful patches from FreeBSD, and fixed a time_t
issue.
Maybe it's the right time to update our prehistoric port of Window
Maker...
If you're a wmaker user, please test!
Ciao,
David
Index: Makefile
===
RCS file: /cvs/ports/x11/windowmaker/Makefile,v
retrieving revision 1.93
diff -u -p -u -p -r1.93 Makefile
--- Makefile11 Mar 2016 20:28:33 - 1.93
+++ Makefile8 Jun 2016 14:16:50 -
@@ -3,14 +3,15 @@
COMMENT-main= window manager that emulates NEXTSTEP(tm)
COMMENT-lang= language subpackage for Window Maker
-V= 0.92.0
+V =0.95.7
DISTNAME= WindowMaker-${V}
PKGNAME-main= ${DISTNAME:L}
-REVISION-main= 56
FULLPKGNAME-lang= windowmaker-lang-${V}
-REVISION-lang= 5
-SHARED_LIBS += wraster 5.0 # 4.0
+SHARED_LIBS += WINGs 0.0 # 2.1
+SHARED_LIBS += WMaker0.0 # 1.1
+SHARED_LIBS += WUtil 0.0 # 3.0
+SHARED_LIBS += wraster 5.1 # 4.1
CATEGORIES=x11 x11/windowmaker
@@ -19,22 +20,27 @@ HOMEPAGE= http://windowmaker.org/
# GPLv2+
PERMIT_PACKAGE_CDROM= Yes
-WANTLIB += X11 Xext Xft Xinerama Xpm Xrender c expat fontconfig
-WANTLIB += freetype jpeg m png pthread-stubs tiff gif xcb z
+WANTLIB += ICE SM X11 Xmu Xext Xft Xinerama Xpm Xrandr Xrender
+WANTLIB += Xt c expat fontconfig freetype gif jpeg kvm m png
+WANTLIB += pthread pthread-stubs tiff xcb z
MASTER_SITES= ${MASTER_SITE_WINDOWMAKER:=source/release/}
-EXTRACT_SUFX= .tar.bz2
NO_TEST= Yes
SEPARATE_BUILD=Yes
CONFIGURE_STYLE= gnu
-CONFIGURE_ARGS+= --enable-static \
+CONFIGURE_ARGS+= --disable-magick \
+ --disable-webp \
+ --enable-randr \
+ --enable-static \
--enable-xinerama \
- --with-datadir="${LOCALBASE}/share/WindowMaker" \
- --with-nlsdir="${LOCALBASE}/share/locale"
+ --localedir="${LOCALBASE}/share/locale"
-CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include"
LIBS="-L${LOCALBASE}/lib" \
- LINGUAS='be bg bs ca cs da de el es et fi fr gl hr hu
it ja ko ms nl no pl pt ro ru sk sv tr zh_CN zh_TW'
+CONFIGURE_ENV= CPPFLAGS="-I${X11BASE}/include -I${LOCALBASE}/include" \
+ LIBS="-L${X11BASE}/lib -L${LOCALBASE}/lib" \
+ LINGUAS='*' \
+ ac_cv_lib_exif_exif_data_new_from_file=no \
+ wm_cv_func_secure_getenv=no
MULTI_PACKAGES=-main -lang
@@ -43,27 +49,24 @@ LIB_DEPENDS=graphics/tiff \
graphics/png \
graphics/giflib
-RUN_DEPENDS-lang= x11/windowmaker>=0.90.0
+RUN_DEPENDS-lang = x11/windowmaker>=${V}
LIB_DEPENDS-lang=
WANTLIB-lang=
-post-patch:
-# Rename wrongly named locale files
- @mv ${WRKSRC}/WindowMaker/menu.cz ${WRKSRC}/WindowMaker/menu.cs
- @mv ${WRKSRC}/WindowMaker/menu.se ${WRKSRC}/WindowMaker/menu.sv
+WMAKER_SHARE = ${PREFIX}/share/WindowMaker
pre-configure:
- @perl -pi -e "s
