x11/pmenu:
Without this the debug package is useless as it does not contain any
symbols; build the port with and without the diff and note the
addition of `-g' in cc(1) lines.
I don't need the debug package or DEBUG at all right now but noticed
the lack of `-O2 -pipe' when building this port.
Fix DESCR grammar while here; I'm mailing the diff instead of
committing it right away because I'm not sure if we want to deal this
way with broken CFLAGS.
Jerome, would you mind poking upstream about the CFLAGS handling in
config.mk? If they'd simply use `CFLAGS += ...' in this file to append
their stuff as needed, we could simply drop all the quirks in our
MAKE_FLAGS and build the port with our framework's defaults, e.g. CFLAGS
being honoured as passed through the environment, I think.
Index: Makefile
=======
RCS file: /cvs/ports/x11/pmenu/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Makefile
--- Makefile4 Mar 2021 22:46:21 - 1.1.1.1
+++ Makefile7 Mar 2021 18:50:50 -
@@ -5,6 +5,7 @@ COMMENT = contextual radial menu for X11
GH_ACCOUNT = phillbush
GH_PROJECT = pmenu
GH_TAGNAME = v2.2.0
+REVISION = 0
CATEGORIES = x11
@@ -25,6 +26,12 @@ NO_TEST =Yes
MAKE_FLAGS = FREETYPEINC=${X11BASE}/include/freetype2 \
MANPREFIX=${PREFIX}/man
+
+# ${WRKSRC}/config.mk ignores the environment, i.e. it should append to
+# (`+=') not set (`=') variables.
+# XXX CPPFLAGS is empty added to the end; abuse it to avoid patches and pass
+# CFLAGS such that DEBUG is honoured as required for DEBUG_PACKAGES to work.
+MAKE_FLAGS += CPPFLAGS='${CFLAGS}'
post-install:
${INSTALL_DATA_DIR} ${PREFIX}/share/examples/pmenu
Index: pkg/DESCR
=======
RCS file: /cvs/ports/x11/pmenu/pkg/DESCR,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 DESCR
--- pkg/DESCR 4 Mar 2021 22:46:21 - 1.1.1.1
+++ pkg/DESCR 7 Mar 2021 18:36:33 -
@@ -1,6 +1,7 @@
-piemenu is a pie menu utility for X. It receives a menu specification OD
+piemenu is a pie menu utility for X. It receives a menu specification
in stdin, shows a menu for the user to select one of the options,
and outputs the option selected to stdout.
+
Features include radial Submenus (some pie-menu slices can spawn another
-menu), Icons (pie-menu slices can contain icon image),X resources support
-and Root window mode
+menu), Icons (pie-menu slices can contain icon image), X resources support
+and Root window mode.
NEW: [X11/pmenu]
Hi ports@, Found by solene@ and port requested by kn@ , so i decided to give it a go. pmenu is a configurable radial contextual menu for X11 that keep things simple and straightforward. I took maintainer as this is a fairly simple C program that shouldn't require much work for updating. The thing links against Imlib2 but portcheck complains if i add it in WANTLIB or LIB_DEPENDS. Thanks solene@ for testing and driving me to do this Any remarks welcome, Regards, Jerome pmenu-2.2.0.tar.gz Description: GNU Zip compressed data
Re: x11/pmenu:
Hi klemmens,
First of all thanks for testing and reviewing.
Nice spots in the grammar description.
I will poke upstream about adding CFLAGS +=
in the config.mk and will report back.
I didn't knew about CPPFLAGS overriding with
CFLAGS, is it a clang trick for debug?
Regards,
Jerome
Le dim. 7 mars 2021 à 20:02, Klemens Nanni a écrit :
> Without this the debug package is useless as it does not contain any
> symbols; build the port with and without the diff and note the
> addition of `-g' in cc(1) lines.
>
> I don't need the debug package or DEBUG at all right now but noticed
> the lack of `-O2 -pipe' when building this port.
>
> Fix DESCR grammar while here; I'm mailing the diff instead of
> committing it right away because I'm not sure if we want to deal this
> way with broken CFLAGS.
>
> Jerome, would you mind poking upstream about the CFLAGS handling in
> config.mk? If they'd simply use `CFLAGS += ...' in this file to append
> their stuff as needed, we could simply drop all the quirks in our
> MAKE_FLAGS and build the port with our framework's defaults, e.g. CFLAGS
> being honoured as passed through the environment, I think.
>
>
> Index: Makefile
> ===
> RCS file: /cvs/ports/x11/pmenu/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 Makefile
> --- Makefile4 Mar 2021 22:46:21 - 1.1.1.1
> +++ Makefile7 Mar 2021 18:50:50 -
> @@ -5,6 +5,7 @@ COMMENT = contextual radial menu for X11
> GH_ACCOUNT = phillbush
> GH_PROJECT = pmenu
> GH_TAGNAME = v2.2.0
> +REVISION = 0
>
> CATEGORIES = x11
>
> @@ -25,6 +26,12 @@ NO_TEST =Yes
>
> MAKE_FLAGS = FREETYPEINC=${X11BASE}/include/freetype2 \
> MANPREFIX=${PREFIX}/man
> +
> +# ${WRKSRC}/config.mk ignores the environment, i.e. it should append to
> +# (`+=') not set (`=') variables.
> +# XXX CPPFLAGS is empty added to the end; abuse it to avoid patches and
> pass
> +# CFLAGS such that DEBUG is honoured as required for DEBUG_PACKAGES to
> work.
> +MAKE_FLAGS += CPPFLAGS='${CFLAGS}'
>
> post-install:
> ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/pmenu
> Index: pkg/DESCR
> ===
> RCS file: /cvs/ports/x11/pmenu/pkg/DESCR,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 DESCR
> --- pkg/DESCR 4 Mar 2021 22:46:21 - 1.1.1.1
> +++ pkg/DESCR 7 Mar 2021 18:36:33 -
> @@ -1,6 +1,7 @@
> -piemenu is a pie menu utility for X. It receives a menu specification OD
> +piemenu is a pie menu utility for X. It receives a menu specification
> in stdin, shows a menu for the user to select one of the options,
> and outputs the option selected to stdout.
> +
> Features include radial Submenus (some pie-menu slices can spawn another
> -menu), Icons (pie-menu slices can contain icon image),X resources support
> -and Root window mode
> +menu), Icons (pie-menu slices can contain icon image), X resources support
> +and Root window mode.
>
Re: x11/pmenu:
On Sun, Mar 07, 2021 at 08:30:13PM +0100, Jerome KASPER wrote:
> Hi klemmens,
>
> First of all thanks for testing and reviewing.
> Nice spots in the grammar description.
> I will poke upstream about adding CFLAGS +=
> in the config.mk and will report back.
> I didn't knew about CPPFLAGS overriding with
> CFLAGS, is it a clang trick for debug?
No, that is just how this port's config.mk works:
$ tail $(make show=WRKSRC)/config.mk
INCS = -I${LOCALINC} -I${X11INC} -I${FREETYPEINC}
LIBS = -L${LOCALLIB} -L${X11LIB} -lm -lfontconfig -lXft -lX11
-lXinerama -lXrender -lXext -lImlib2
# flags
CPPFLAGS =
CFLAGS = -Wall -Wextra ${INCS} ${CPPFLAGS}
LDFLAGS = ${LIBS}
# compiler and linker
CC = cc
So I simply overwrite the empty string via command line such that our
CFLAGS end up at the end of the port's CFLAGS.
Hence I wouldn't do this if config.mk actually used non-empty CPPFLAGS.
Re: x11/pmenu:
On 2021/03/07 20:30, Jerome KASPER wrote: > Hi klemmens, > > First of all thanks for testing and reviewing. > Nice spots in the grammar description. > I will poke upstream about adding CFLAGS += > in the config.mk and will report back. > I didn't knew about CPPFLAGS overriding with > CFLAGS, is it a clang trick for debug? CPPFLAGS is normally "c preprocessor flags" and would normally be used when invoking the compiler to compile source code files, but not used when invoking the compiler to link objects. > > +++ pkg/DESCR 7 Mar 2021 18:36:33 - > > @@ -1,6 +1,7 @@ > > -piemenu is a pie menu utility for X. It receives a menu specification OD > > +piemenu is a pie menu utility for X. It receives a menu specification > > in stdin, shows a menu for the user to select one of the options, "from stdin" or "from standard input" would read a little better > > and outputs the option selected to stdout. > > + > > Features include radial Submenus (some pie-menu slices can spawn another > > -menu), Icons (pie-menu slices can contain icon image),X resources support > > -and Root window mode > > +menu), Icons (pie-menu slices can contain icon image), X resources support > > +and Root window mode. > >
Re: x11/pmenu:
On Sun, Mar 07, 2021 at 08:08:59PM +, Stuart Henderson wrote: > > > +++ pkg/DESCR 7 Mar 2021 18:36:33 - > > > @@ -1,6 +1,7 @@ > > > -piemenu is a pie menu utility for X. It receives a menu specification OD > > > +piemenu is a pie menu utility for X. It receives a menu specification > > > in stdin, shows a menu for the user to select one of the options, > > "from stdin" or "from standard input" would read a little better Agreed, but DESCR is taken from the project's readme as is, so I've left our copy as-is.
Re: x11/pmenu:
On 2021/03/07 21:40, Klemens Nanni wrote: > On Sun, Mar 07, 2021 at 08:08:59PM +, Stuart Henderson wrote: > > > > +++ pkg/DESCR 7 Mar 2021 18:36:33 - > > > > @@ -1,6 +1,7 @@ > > > > -piemenu is a pie menu utility for X. It receives a menu specification > > > > OD > > > > +piemenu is a pie menu utility for X. It receives a menu specification > > > > in stdin, shows a menu for the user to select one of the options, > > > > "from stdin" or "from standard input" would read a little better > Agreed, but DESCR is taken from the project's readme as is, so I've left > our copy as-is. > Hmm. That doesn't make a lot of sense to me...
Re: x11/pmenu:
On Sun, Mar 07, 2021 at 09:08:20PM +, Stuart Henderson wrote:
> On 2021/03/07 21:40, Klemens Nanni wrote:
> > On Sun, Mar 07, 2021 at 08:08:59PM +, Stuart Henderson wrote:
> > > > > +++ pkg/DESCR 7 Mar 2021 18:36:33 -
> > > > > @@ -1,6 +1,7 @@
> > > > > -piemenu is a pie menu utility for X. It receives a menu
> > > > > specification OD
> > > > > +piemenu is a pie menu utility for X. It receives a menu specification
> > > > > in stdin, shows a menu for the user to select one of the options,
> > >
> > > "from stdin" or "from standard input" would read a little better
> > Agreed, but DESCR is taken from the project's readme as is, so I've left
> > our copy as-is.
> >
>
> Hmm. That doesn't make a lot of sense to me...
Sorry for the noise; OK for that?
Index: Makefile
===
RCS file: /cvs/ports/x11/pmenu/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Makefile
--- Makefile4 Mar 2021 22:46:21 - 1.1.1.1
+++ Makefile7 Mar 2021 21:05:58 -
@@ -5,6 +5,7 @@ COMMENT = contextual radial menu for X11
GH_ACCOUNT = phillbush
GH_PROJECT = pmenu
GH_TAGNAME = v2.2.0
+REVISION = 0
CATEGORIES = x11
@@ -25,6 +26,12 @@ NO_TEST =Yes
MAKE_FLAGS = FREETYPEINC=${X11BASE}/include/freetype2 \
MANPREFIX=${PREFIX}/man
+
+# ${WRKSRC}/config.mk ignores the environment, i.e. it should append to
+# (`+=') not set (`=') variables.
+# XXX CPPFLAGS is empty added to the end; abuse it to avoid patches and pass
+# CFLAGS such that DEBUG is honoured as required for DEBUG_PACKAGES to work.
+MAKE_FLAGS += CPPFLAGS='${CFLAGS}'
post-install:
${INSTALL_DATA_DIR} ${PREFIX}/share/examples/pmenu
Index: pkg/DESCR
===
RCS file: /cvs/ports/x11/pmenu/pkg/DESCR,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 DESCR
--- pkg/DESCR 4 Mar 2021 22:46:21 - 1.1.1.1
+++ pkg/DESCR 7 Mar 2021 21:16:46 -
@@ -1,6 +1,7 @@
-piemenu is a pie menu utility for X. It receives a menu specification OD
-in stdin, shows a menu for the user to select one of the options,
+piemenu is a pie menu utility for X. It receives a menu specification
+from stdin, shows a menu for the user to select one of the options
and outputs the option selected to stdout.
+
Features include radial Submenus (some pie-menu slices can spawn another
-menu), Icons (pie-menu slices can contain icon image),X resources support
-and Root window mode
+menu), Icons (pie-menu slices can contain icon image), X resources support
+and Root window mode.
[update] x11/pmenu
pmenu 2.2.0 -> 3.1.0
Changes include: bug fixes; support for motif-like 3D relief; a new font
mechanism supporting both Xft and XLFD; and manual rewritten from man(7)
to mdoc(7).
I removed the HOMEPAGE, since it defaults to the github page. And added
myself (the program developer) as maintainer. The hack on MAKE_FLAGS is
not needed anymore.
Ok?
Cheers,
Lucas de Sena.
Index: Makefile
===
RCS file: /cvs/ports/x11/pmenu/Makefile,v
retrieving revision 1.3
diff -u -p -r1.3 Makefile
--- Makefile11 Mar 2022 20:16:55 - 1.3
+++ Makefile25 Jul 2023 13:37:14 -
@@ -2,19 +2,16 @@ COMMENT = contextual radial menu for X11
GH_ACCOUNT = phillbush
GH_PROJECT = pmenu
-GH_TAGNAME = v2.2.0
-REVISION = 0
+GH_TAGNAME = v3.1.0
CATEGORIES = x11
-MAINTAINER = Jerome Kasper
-
-HOMEPAGE = https://github.com/phillbush/pmenu
+MAINTAINER = Lucas de Sena
# MIT
PERMIT_PACKAGE =Yes
-WANTLIB += Imlib2 X11 Xext Xft Xinerama Xrender c fontconfig m
+WANTLIB += Imlib2 X11 Xext Xft Xinerama Xrender c fontconfig m
LIB_DEPENDS = graphics/imlib2
@@ -22,14 +19,8 @@ DEBUG_PACKAGES =${BUILD_PACKAGES}
NO_TEST = Yes
-MAKE_FLAGS = FREETYPEINC=${X11BASE}/include/freetype2 \
- MANPREFIX=${PREFIX}/man
-
-# ${WRKSRC}/config.mk ignores the environment, i.e. it should append to
-# (`+=') not set (`=') variables.
-# XXX CPPFLAGS is empty added to the end; abuse it to avoid patches and pass
-# CFLAGS such that DEBUG is honoured as required for DEBUG_PACKAGES to work.
-MAKE_FLAGS += CPPFLAGS='${CFLAGS}'
+MAKE_FLAGS = MANPREFIX=${PREFIX}/man \
+ PREFIX=${PREFIX}
post-install:
${INSTALL_DATA_DIR} ${PREFIX}/share/examples/pmenu
Index: distinfo
===
RCS file: /cvs/ports/x11/pmenu/distinfo,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 distinfo
--- distinfo4 Mar 2021 22:46:21 - 1.1.1.1
+++ distinfo25 Jul 2023 13:37:14 -
@@ -1,2 +1,2 @@
-SHA256 (pmenu-2.2.0.tar.gz) = KuvF+FfxyVb6W4qnpclN3cMiOY+iUvRyiy2KCDlMOIw=
-SIZE (pmenu-2.2.0.tar.gz) = 15264
+SHA256 (pmenu-3.1.0.tar.gz) = 5JzdEyyagHvZziAgEMby3GQJPCeWQuRn6BgfVMCjvQc=
+SIZE (pmenu-3.1.0.tar.gz) = 25401
Re: NEW: [X11/pmenu]
Hello Jerome, neon.king...@gmail.com (Jerome KASPER), 2021.03.04 (Thu) 01:58 (CET): > pmenu is a configurable radial contextual menu for X11 that keep things > simple and straightforward. thanks for that! I ran "make install" and tried the example in the man page. It works and looks quite pretty by default. I will use it, thanks once more! Marcus
Re: NEW: [X11/pmenu]
On Thu, 4 Mar 2021 01:58:04 +0100 Jerome KASPER : > Hi ports@, > > Found by solene@ and port requested by kn@ , so i decided to give it a go. > > pmenu is a configurable radial contextual menu for X11 that keep things > simple and straightforward. > > I took maintainer as this is a fairly simple C program that shouldn't > require > much work for updating. The thing links against Imlib2 but portcheck > complains if i add it in WANTLIB or LIB_DEPENDS. > > Thanks solene@ for testing and driving me to do this > > Any remarks welcome, > Regards, > Jerome if you add LIB_DEPENDS= graphics/imlib2 then you can add Imbli2 to WANTLIB and it's fine. I'm not sure DEBUG_PACKAGES are of any use with pmenu, I had no crash yet but it's really small so maybe we can keep debug packages? I think this would be better to set MANPREFIX and FREETYPEINC in the Makefile instead of using a patch, this will avoid work if the config.mk changes. I think this can be done using MAKE_FLAGS
Re: NEW: [X11/pmenu]
Thank you Marcus :) Glad it's working and useful. Here is the port integrating last solene@ advice. Built and tested on amd64, portcheck now happy. Regards, Jerome Le jeu. 4 mars 2021 à 13:57, Marcus MERIGHI a écrit : > Hello Jerome, > > neon.king...@gmail.com (Jerome KASPER), 2021.03.04 (Thu) 01:58 (CET): > > pmenu is a configurable radial contextual menu for X11 that keep things > > simple and straightforward. > > thanks for that! I ran "make install" and tried the example in the man > page. It works and looks quite pretty by default. I will use it, thanks > once more! > > Marcus > pmenu-2.2.0.tar.gz Description: GNU Zip compressed data
Re: NEW: [X11/pmenu]
On Thu, Mar 04, 2021 at 10:21:25PM +0100, Jerome KASPER wrote: > Thank you Marcus :) Glad it's working and useful. > Here is the port integrating last solene@ advice. > Built and tested on amd64, portcheck now happy. > > Regards, > Jerome > > Le jeu. 4 mars 2021 à 13:57, Marcus MERIGHI a écrit : > > > Hello Jerome, > > > > neon.king...@gmail.com (Jerome KASPER), 2021.03.04 (Thu) 01:58 (CET): > > > pmenu is a configurable radial contextual menu for X11 that keep things > > > simple and straightforward. > > > > thanks for that! I ran "make install" and tried the example in the man > > page. It works and looks quite pretty by default. I will use it, thanks > > once more! > > > > Marcus > > Only thing I see now is handrolled WANTLIB. I'd prefer it to be port-lib-depends-check generated: WANTLIB += Imlib2 X11 Xext Xft Xinerama Xrender c fontconfig m Otherwise, ok to import here tracey@ Test on amd64 briefly and doesn't look nearly as cool as solene's video gif. Thanks Jerome! -- Tracey Emery
Re: [update] x11/pmenu
On 2023/07/25 10:50:00 -0300, Lucas de Sena wrote: > pmenu 2.2.0 -> 3.1.0 > > Changes include: bug fixes; support for motif-like 3D relief; a new font > mechanism supporting both Xft and XLFD; and manual rewritten from man(7) > to mdoc(7). > > I removed the HOMEPAGE, since it defaults to the github page. And added > myself (the program developer) as maintainer. The hack on MAKE_FLAGS is > not needed anymore. I'd CC the previous maintainer before removing them. Or just add myself to the list. (+cc jerome) > Ok? it does not work for me anymore. I get this BadValue error when trying to use it: % echo 1 | pmenu X Error of failed request: BadValue (integer parameter out of range for operation) Major opcode of failed request: 53 (X_CreatePixmap) Value in failed request: 0x0 Serial number of failed request: 33 Current serial number in output stream: 41 whereas the currently packaged version (2.2.0p0) works perfectly fine.
Re: [update] x11/pmenu
On 2023-07-25, Omar Polo wrote:
> I'd CC the previous maintainer before removing them. Or just add
> myself to the list.
>
> (+cc jerome)
Jerome, ok?
> it does not work for me anymore. I get this BadValue error when
> trying to use it:
>
> % echo 1 | pmenu
> X Error of failed request: BadValue (integer parameter out of range for
> operation)
> Major opcode of failed request: 53 (X_CreatePixmap)
> Value in failed request: 0x0
> Serial number of failed request: 33
> Current serial number in output stream: 41
>
> whereas the currently packaged version (2.2.0p0) works perfectly fine.
Your X server has probably has no or empty X resource (no ~/.Xdefaults
file or `xrdb path/to/resources` in your `~/.xsession).
Should be fixed now, sorry for that.
Index: Makefile
=======
RCS file: /cvs/ports/x11/pmenu/Makefile,v
retrieving revision 1.3
diff -u -p -r1.3 Makefile
--- Makefile11 Mar 2022 20:16:55 - 1.3
+++ Makefile25 Jul 2023 17:15:52 -
@@ -2,19 +2,16 @@ COMMENT = contextual radial menu for X11
GH_ACCOUNT = phillbush
GH_PROJECT = pmenu
-GH_TAGNAME = v2.2.0
-REVISION = 0
+GH_TAGNAME = v3.1.1
CATEGORIES = x11
-MAINTAINER = Jerome Kasper
-
-HOMEPAGE = https://github.com/phillbush/pmenu
+MAINTAINER = Lucas de Sena
# MIT
PERMIT_PACKAGE =Yes
-WANTLIB += Imlib2 X11 Xext Xft Xinerama Xrender c fontconfig m
+WANTLIB += Imlib2 X11 Xext Xft Xinerama Xrender c fontconfig m
LIB_DEPENDS = graphics/imlib2
@@ -22,14 +19,8 @@ DEBUG_PACKAGES =${BUILD_PACKAGES}
NO_TEST = Yes
-MAKE_FLAGS = FREETYPEINC=${X11BASE}/include/freetype2 \
- MANPREFIX=${PREFIX}/man
-
-# ${WRKSRC}/config.mk ignores the environment, i.e. it should append to
-# (`+=') not set (`=') variables.
-# XXX CPPFLAGS is empty added to the end; abuse it to avoid patches and pass
-# CFLAGS such that DEBUG is honoured as required for DEBUG_PACKAGES to work.
-MAKE_FLAGS += CPPFLAGS='${CFLAGS}'
+MAKE_FLAGS = MANPREFIX=${PREFIX}/man \
+ PREFIX=${PREFIX}
post-install:
${INSTALL_DATA_DIR} ${PREFIX}/share/examples/pmenu
Index: distinfo
=======
RCS file: /cvs/ports/x11/pmenu/distinfo,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 distinfo
--- distinfo4 Mar 2021 22:46:21 - 1.1.1.1
+++ distinfo25 Jul 2023 17:15:52 -
@@ -1,2 +1,2 @@
-SHA256 (pmenu-2.2.0.tar.gz) = KuvF+FfxyVb6W4qnpclN3cMiOY+iUvRyiy2KCDlMOIw=
-SIZE (pmenu-2.2.0.tar.gz) = 15264
+SHA256 (pmenu-3.1.1.tar.gz) = 8bcMKOnv1Ky7hTWLFSL4yEplHxjzudcVjMwJvgOPvVc=
+SIZE (pmenu-3.1.1.tar.gz) = 25414
Re: [update] x11/pmenu
Hi everyone,
Lucas, feel free to take over as I'm not using pmenu .
This was the only port where I was a maintainer and as I'm not
involved in OpenBSD porting anymore, I think I should be clear
now :)
regards,
Jerome
Le mar. 25 juil. 2023 à 19:25, Lucas de Sena a écrit :
> On 2023-07-25, Omar Polo wrote:
> > I'd CC the previous maintainer before removing them. Or just add
> > myself to the list.
> >
> > (+cc jerome)
>
> Jerome, ok?
>
> > it does not work for me anymore. I get this BadValue error when
> > trying to use it:
> >
> > % echo 1 | pmenu
> > X Error of failed request: BadValue (integer parameter out of range for
> operation)
> > Major opcode of failed request: 53 (X_CreatePixmap)
> > Value in failed request: 0x0
> > Serial number of failed request: 33
> > Current serial number in output stream: 41
> >
> > whereas the currently packaged version (2.2.0p0) works perfectly fine.
>
> Your X server has probably has no or empty X resource (no ~/.Xdefaults
> file or `xrdb path/to/resources` in your `~/.xsession).
>
> Should be fixed now, sorry for that.
>
>
> Index: Makefile
> ===
> RCS file: /cvs/ports/x11/pmenu/Makefile,v
> retrieving revision 1.3
> diff -u -p -r1.3 Makefile
> --- Makefile11 Mar 2022 20:16:55 - 1.3
> +++ Makefile25 Jul 2023 17:15:52 -
> @@ -2,19 +2,16 @@ COMMENT = contextual radial menu for X11
>
> GH_ACCOUNT = phillbush
> GH_PROJECT = pmenu
> -GH_TAGNAME = v2.2.0
> -REVISION = 0
> +GH_TAGNAME = v3.1.1
>
> CATEGORIES = x11
>
> -MAINTAINER = Jerome Kasper
> -
> -HOMEPAGE = https://github.com/phillbush/pmenu
> +MAINTAINER = Lucas de Sena
>
> # MIT
> PERMIT_PACKAGE =Yes
>
> -WANTLIB += Imlib2 X11 Xext Xft Xinerama Xrender c fontconfig m
> +WANTLIB += Imlib2 X11 Xext Xft Xinerama Xrender c fontconfig m
>
> LIB_DEPENDS = graphics/imlib2
>
> @@ -22,14 +19,8 @@ DEBUG_PACKAGES =${BUILD_PACKAGES}
>
> NO_TEST = Yes
>
> -MAKE_FLAGS = FREETYPEINC=${X11BASE}/include/freetype2 \
> - MANPREFIX=${PREFIX}/man
> -
> -# ${WRKSRC}/config.mk ignores the environment, i.e. it should append to
> -# (`+=') not set (`=') variables.
> -# XXX CPPFLAGS is empty added to the end; abuse it to avoid patches and
> pass
> -# CFLAGS such that DEBUG is honoured as required for DEBUG_PACKAGES to
> work.
> -MAKE_FLAGS += CPPFLAGS='${CFLAGS}'
> +MAKE_FLAGS = MANPREFIX=${PREFIX}/man \
> + PREFIX=${PREFIX}
>
> post-install:
> ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/pmenu
> Index: distinfo
> ===
> RCS file: /cvs/ports/x11/pmenu/distinfo,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 distinfo
> --- distinfo4 Mar 2021 22:46:21 - 1.1.1.1
> +++ distinfo25 Jul 2023 17:15:52 -
> @@ -1,2 +1,2 @@
> -SHA256 (pmenu-2.2.0.tar.gz) = KuvF+FfxyVb6W4qnpclN3cMiOY+iUvRyiy2KCDlMOIw=
> -SIZE (pmenu-2.2.0.tar.gz) = 15264
> +SHA256 (pmenu-3.1.1.tar.gz) = 8bcMKOnv1Ky7hTWLFSL4yEplHxjzudcVjMwJvgOPvVc=
> +SIZE (pmenu-3.1.1.tar.gz) = 25414
>
Re: [update] x11/pmenu
On 2023/07/25 14:25:30 -0300, Lucas de Sena wrote: > On 2023-07-25, Omar Polo wrote: > > it does not work for me anymore. I get this BadValue error when > > trying to use it: > > > > % echo 1 | pmenu > > X Error of failed request: BadValue (integer parameter out of range for > > operation) > > Major opcode of failed request: 53 (X_CreatePixmap) > > Value in failed request: 0x0 > > Serial number of failed request: 33 > > Current serial number in output stream: 41 > > > > whereas the currently packaged version (2.2.0p0) works perfectly fine. > > Your X server has probably has no or empty X resource (no ~/.Xdefaults > file or `xrdb path/to/resources` in your `~/.xsession). I do have a ~/.Xdefaults with stuff (quite a bit actually), but no ~/.Xresources and I'm not using xrdb. Most programs (e.g. xterm) automatically picks up ~/.Xdefaults upon startup, while with some other programs (including pmenu) it's ignored (but it's not a regression.) > Should be fixed now, sorry for that. works for me; committed, thanks!
