Re: CVS Commit Overview for 2007-07-11

2007-07-23 Thread Samuele Kaplun 
In data lunedì 23 luglio 2007, Ferran Jorba scribacchiaste dette parole:
 Hello Samuele,
 I don't know about this one, but I have to maintain a parallel one about
 graphic files (currently jpg, gif and png), so I can apply a different
 logic for URLs if they are images (typically for icons) or fulltext; see
 an early implementation at http://ddd.uab.cat/record/17654.

 Thanks,

 Ferran

Hi Ferran,
thanks for the advice. Meanwhile I'd just removed that hardcoded list about 
recognized extensions and just took the one coming from mimetypes module in 
Python. This list was just used by the submission engine in order to discover 
the format in general of a file, but the code was a bit broken (and was also 
missing pngs).
For the future when it will come to just graphics I will definitly take in 
account your list.
Best regards,
Samuele

Re: CVS Commit Overview for 2007-07-11

2007-07-23 Thread Ferran Jorba 
Hello Samuele,

 2007-07-11  Samuele Kaplun samuele.kap...@cern.ch

   * modules/websubmit/lib/websubmit_config.py: Added png to the list
   of recognized extension. Are there any other extensions missing? Do
   we need this list?

I don't know about this one, but I have to maintain a parallel one about
graphic files (currently jpg, gif and png), so I can apply a different
logic for URLs if they are images (typically for icons) or fulltext; see
an early implementation at http://ddd.uab.cat/record/17654.

Thanks,

Ferran