[task #9397] BibCirculation: enhance demo data

[noreply [Samuele Kaplun]]

This is an automated notification sent by LCG Savannah.
It relates to:
task #9397, project CDS Invenio

==
 LATEST MODIFICATIONS of task #9397:
==

Update of task #9397 (project cdsware):

 Assigned to:jsilvest => jgarcial   


==
 OVERVIEW of task #9397:
==

URL:
  

 Summary: BibCirculation: enhance demo data 
 Project: CDS Invenio
Submitted by: simko
Submitted on: 2009-03-27 11:56
 Should Start On: 2009-03-27 00:00
   Should be Finished on: 2009-03-27 00:00
Category: BibCirculation
Priority: 7 - High
  Status: None
 Privacy: Public
Percent Complete: 0%
 Assigned to: jgarcial
 Open/Closed: Open
 Discussion Lock: Any
  Effort: 0.00

___


Demo data for BibCirculation should be enhanced to cover various scenarios -
a book existing in many copies, spread in many libraries, with different
return time policies.  Some of the books should be on loan already, some with
waiting clients, etc, at the moment of Atlantis installation.

This will allow to easily create tests later. (see another savannah task)



___

Carbon-Copy List:

CC Address  | Comment
+-
2195| -UPD-
1576| -SUB-




==

This item URL is:
  

___
  Message sent via/by LCG Savannah
  http://savannah.cern.ch/

[task #9398] BibCirculation: improve coding

[noreply [Samuele Kaplun]]

This is an automated notification sent by LCG Savannah.
It relates to:
task #9398, project CDS Invenio

==
 LATEST MODIFICATIONS of task #9398:
==

Update of task #9398 (project cdsware):

 Assigned to:jsilvest => jgarcial   


==
 OVERVIEW of task #9398:
==

URL:
  

 Summary: BibCirculation: improve coding
 Project: CDS Invenio
Submitted by: simko
Submitted on: 2009-03-27 12:12
 Should Start On: 2009-03-27 00:00
   Should be Finished on: 2009-03-27 00:00
Category: BibCirculation
Priority: 7 - High
  Status: None
 Privacy: Public
Percent Complete: 0%
 Assigned to: jgarcial
 Open/Closed: Open
 Discussion Lock: Any
  Effort: 0.00

___


Coding in BibCirculation should be improved.  Examples (some more urgent than
others):

* All the "if foo != None" comparisons should be fixed, using either "if foo"
technique, or if needed "if foo is not None" technique.  See PEP 8.

* Empty docstrings should not be used, as in:

def get_item_requests_historical_overview(recid):
 """
 """

They should be either completed, or removed.

* Variable warnings should be fixed, some of these may be serious.  If some
variables are dummy in their use, then use a "dummy" prefix for them, so that
pylint does not complain.

W:1223:new_borrower: Unused variable 'res'
W:1379:Template.tmpl_item_search_result: Unused variable 'nb_records'
W:2082:Template.tmpl_all_requests: Unused variable 'name_link'
W:2087:Template.tmpl_all_requests: Unused variable 'item_link'
W:2093:Template.tmpl_all_requests: Unused variable 'status_link'
W:2186:Template.tmpl_get_item_requests_details: Unused variable 'name_link'
W:2193:Template.tmpl_get_item_requests_details: Unused variable
'status_link'
W:221:WebInterfaceHoldingsPages.display: Unused variable 'order'
W:2228:Template.tmpl_get_item_requests_details: Unused variable
'cancel_request_link'
W:2260:Template.tmpl_get_item_requests_details: Using possibly undefined loop
variable 'recid'
W:3100:Template.tmpl_borrower_request_details: Unused variable 'borid'
W:310:WebInterfaceHoldingsPages.request: Unused variable 'order'
W:3825:Template.tmpl_associate_barcode: Unused variable 'book_author'
W:3825:Template.tmpl_associate_barcode: Unused variable 'book_editor'
W:3825:Template.tmpl_associate_barcode: Unused variable 'book_year'
W:399:WebInterfaceHoldingsPages.send: Unused variable 'order'
W:4677:Template.tmpl_update_borrower_info_step3: Unused variable
'borrower_id'
W:5133:Template.tmpl_update_library_info_step3: Unused variable 'notes'
W:5205:Template.tmpl_update_library_info_step4: Unused variable 'library_id'
W:5523:Template.tmpl_add_new_copy_step3: Unused variable 'today'
W:707:loan_on_desk_step5: Unused variable 'ccid'
W:979:Template.tmpl_get_next_waiting_loan_request: Unused variable
'select_link'




___

Carbon-Copy List:

CC Address  | Comment
+-
2195| -UPD-
1576| -SUB-




==

This item URL is:
  

___
  Message sent via/by LCG Savannah
  http://savannah.cern.ch/

[task #9399] BibCirculation: add test cases

[noreply [Samuele Kaplun]]

This is an automated notification sent by LCG Savannah.
It relates to:
task #9399, project CDS Invenio

==
 LATEST MODIFICATIONS of task #9399:
==

Update of task #9399 (project cdsware):

 Assigned to:jsilvest => jgarcial   


==
 OVERVIEW of task #9399:
==

URL:
  

 Summary: BibCirculation: add test cases
 Project: CDS Invenio
Submitted by: simko
Submitted on: 2009-03-27 12:15
 Should Start On: 2009-03-27 00:00
   Should be Finished on: 2009-03-27 00:00
Category: BibCirculation
Priority: 7 - High
  Status: None
 Privacy: Public
Percent Complete: 0%
 Assigned to: jgarcial
 Open/Closed: Open
 Discussion Lock: Any
  Effort: 0.00

___


Once we have nice test data (see also task #9397), some web test cases should
be written (or registered with Selenium IDE) in order to assure that the
module works as expected.  (Currently it tracebacks at places due to
CERN-specific stuff, see another Savannah task.)



___

Carbon-Copy List:

CC Address  | Comment
+-
2195| -UPD-
1576| -SUB-




==

This item URL is:
  

___
  Message sent via/by LCG Savannah
  http://savannah.cern.ch/

[task #9400] BibCirculation: decernify

[noreply [Samuele Kaplun]]

This is an automated notification sent by LCG Savannah.
It relates to:
task #9400, project CDS Invenio

==
 LATEST MODIFICATIONS of task #9400:
==

Update of task #9400 (project cdsware):

 Assigned to:jsilvest => jgarcial   


==
 OVERVIEW of task #9400:
==

URL:
  

 Summary: BibCirculation: decernify
 Project: CDS Invenio
Submitted by: simko
Submitted on: 2009-03-27 12:24
 Should Start On: 2009-03-27 00:00
   Should be Finished on: 2009-03-27 00:00
Category: BibCirculation
Priority: 9 - Immediate
  Status: None
 Privacy: Public
Percent Complete: 0%
 Assigned to: jgarcial
 Open/Closed: Open
 Discussion Lock: Any
  Effort: 0.00

___


All CERN-specific parts of BibCirculation should be made configurable via
some CFG_BIBCIRCULATION_* variables, or hidden inside "if CFG_CERN_SITE"
branches.  This is rather urgent, because tracebacks occur in non-CERN
setup.

Examples:

* Hardcoded strings "CERN Library"
  should become configurable via variables like
CFG_BIBCIRCULATION_OVERDUE_LETTER_SENDER.

* Ditto other hardcoded strings such as "joaquim...".

* get_user_info_from_ldap(), and bibcirculation_cern_ldap in particular,
should be made fully optional.  E.g. read from LDAP only when defined, and
read from CERN LDAP only if CFG_CERN_SITE is set to 1, otherwise read user
info from local database. 

Currently loan requests traceback due to this on Atlantis, e.g.:




___

Follow-up Comments:


---
List-Post: project-invenio-devel@cern.ch
Date: 2009-09-07 09:08  By: Tibor Simko 
Another example: bibcirculation.py as of git/master/2009-09-07 
tries to import invenio.external_authentication_cern_wrapper, 
even when CFG_CERN_SITE is 0, leading to a traceback about
non-existing cern_nice_soap_credentials.txt.





___

Carbon-Copy List:

CC Address  | Comment
+-
2195| -UPD-
1576| -SUB-




==

This item URL is:
  

___
  Message sent via/by LCG Savannah
  http://savannah.cern.ch/

Re: [patch] Websearch: add a newline before printing Marc tags

[Ferran Jorba]

Hello Tibor,

> Please note that for offline non-XML MARC processing, you may want to
> prefer the `Text MARC' output format (tm) rather than the `HTML MARC'
> (hm) one.
>
> $ wget -O z.txt 'http://invenio-demo.cern.ch/search?p=ellis&of=tm'

Oh, that's great!  I didn't know this one.  I see that it even works
with 0.92.1.

Thanks again,

Ferran

Re: [patch] Websearch: add a newline before printing Marc tags

[Tibor Simko]

Hi Ferran:

On Thu, 15 Oct 2009, Ferran Jorba wrote:
> could you please apply this tiny patch?

Thanks, committed.

Please note that for offline non-XML MARC processing, you may want to
prefer the `Text MARC' output format (tm) rather than the `HTML MARC'
(hm) one.

$ wget -O z.txt 'http://invenio-demo.cern.ch/search?p=ellis&of=tm'

Best regards
-- 
Tibor Simko ** CERN Document Server ** 

[patch] Websearch: add a newline before printing Marc tags

[Ferran Jorba]

Hi Tibor,

could you please apply this tiny patch?  I've refreshed it to apply
cleanly to current git tree.

Thanks,

Ferran
Websearch: add a newline before printing Marc tags

 The output of Marc format in search_engine.py is useful for offline
 processing.  Adding a newline before  simplifies it.
---

Index: cds-invenio/modules/websearch/lib/search_engine.py
===
--- cds-invenio.orig/modules/websearch/lib/search_engine.py	2009-10-15 10:22:58.0 +0200
+++ cds-invenio/modules/websearch/lib/search_engine.py	2009-10-15 10:29:38.0 +0200
@@ -3371,16 +3371,16 @@
 
 elif format == "hm":
 if record_exist_p == -1:
-out += "" + cgi.escape(get_fieldvalues_alephseq_like(recID, ["001", CFG_OAI_ID_FIELD, "980"])) + ""
+out += "\n" + cgi.escape(get_fieldvalues_alephseq_like(recID, ["001", CFG_OAI_ID_FIELD, "980"])) + ""
 else:
-out += "" + cgi.escape(get_fieldvalues_alephseq_like(recID, ot)) + ""
+out += "\n" + cgi.escape(get_fieldvalues_alephseq_like(recID, ot)) + ""
 
 elif format.startswith("h") and ot:
 ## user directly asked for some tags to be displayed only
 if record_exist_p == -1:
-out += "" + get_fieldvalues_alephseq_like(recID, ["001", CFG_OAI_ID_FIELD, "980"]) + ""
+out += "\n" + get_fieldvalues_alephseq_like(recID, ["001", CFG_OAI_ID_FIELD, "980"]) + ""
 else:
-out += "" + get_fieldvalues_alephseq_like(recID, ot) + ""
+out += "\n" + get_fieldvalues_alephseq_like(recID, ot) + ""
 
 elif format == "hd":
 # HTML detailed format

[task #11895] Every item in Atom feed is duplicated on every refresh in Thunderbird

[noreply [Victor Engmark]]

This is an automated notification sent by LCG Savannah.
It relates to:
task #11895, project CDS Invenio

==
 OVERVIEW of task #11895:
==

URL:
  

 Summary: Every item in Atom feed is duplicated on every
refresh in Thunderbird
 Project: CDS Invenio
Submitted by: vengmark
Submitted on: 2009-10-15 07:49
 Should Start On: 2009-10-15 00:00
   Should be Finished on: 2009-10-15 00:00
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
Percent Complete: 0%
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
  Effort: 0.00

___


How to reproduce:
1. Install Thunderbird 2.0.0.23.
2. Create an account for web feeds.
3. Subscribe to the feed .
4. Wait for Thunderbird to refresh the feed twice.

What happens:
On the second and subsequent refreshes, a duplicate of each item in the feed
appears as unread.

What should happen:
Only one copy of each item should appear in the feed reading list.

Possible cause:
The feed is not valid Atom:


Other information:
I'm running Ubuntu 9.04.
I've subscribed to 20+ other feeds where this problem does not appear.



___

Carbon-Copy List:

CC Address  | Comment
+-
3964| -SUB-




==

This item URL is:
  

___
  Message sent via/by LCG Savannah
  http://savannah.cern.ch/