Re: [prometheus-developers] Welcoming Matthias Loibl as a new Prometheus team member

2021-11-26 Thread Matthias Loibl 

Thanks everyone! Appreciate it!

On 11/26/21 11:11, Matthias Rampke wrote:

Welcome to the other Matthias >:)

/MR

On Thu, Nov 25, 2021 at 2:11 PM Goutham Veeramachaneni 
 wrote:


Welcome Matthias! Looong overdue :)

Thanks
Goutham

On Thu, Nov 25, 2021 at 2:31 PM Julien Pivotto
 wrote:

Welcome!!

On 25 Nov 12:32, Julius Volz wrote:
> Hi Prometheans,
>
> Please welcome Matthias Loibl as a new member to the
Prometheus team!
> Matthias has been a friend of the Prometheus project for a
long time and
> has helped out with a lot of community work (meetups,
evangelism,
> contributor office hours, best practices around SLOs, and more).
>
> Cheers,
> Julius
>
> --
> You received this message because you are subscribed to the
Google Groups "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails
from it, send an email to
prometheus-developers+unsubscr...@googlegroups.com
.
> To view this discussion on the web visit

https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6Yoz4nb69BhUt_q7JS%2BhuYveHiUuYbn_FABb0_biAyVzW3g%40mail.gmail.com.

-- 
Julien Pivotto

@roidelapluie

-- 
You received this message because you are subscribed to the

Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from
it, send an email to
prometheus-developers+unsubscr...@googlegroups.com
.
To view this discussion on the web visit

https://groups.google.com/d/msgid/prometheus-developers/20211125133143.GB465801%40hydrogen.

-- 
You received this message because you are subscribed to the Google

Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit

https://groups.google.com/d/msgid/prometheus-developers/CAKQV3GEsD5U0JnSRBQRDYKpY7XPB8QHoo%3Dev2UB_eg57SbbYZA%40mail.gmail.com

.

--
You received this message because you are subscribed to the Google 
Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send 
an email to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/CAMV%3D_gb%3DbhowCBqq242%3DthiGasAUCa57%3DXLKP-M-6sdJS%3DqJ1w%40mail.gmail.com 
.


--
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/49e05634-3c57-6c0d-dac3-fa731c686d9e%40gmail.com.

Re: [prometheus-developers] Evolving remote APIs

2021-11-26 Thread 'Fabian Reinartz' via Prometheus Developers 
> As maintainer of Prometheus server, in general, I am worried that
> getting a wal that'd be more "able" than the actual Prometheus TSDB
> would weaken the Prometheus server use case in favor of SaaS platforms.
>
> It does not sound great for the users who rely on Prometheus
> alone, which I think will continue to represent a large part of our
> community in the future.
>

Where do you see the downside for these users? It doesn't seem that a
structured remote-write API would take anything away from
users using the Prometheus server with local storage.


> Additionally, the Query Engine should take advantage of those new
> properties as well: until we do not support that in Prometheus TSDB,
> it's harder to take advantage of the OpenMetrics types in the language.
>

True, though I don't understand why this is an argument against the
remote-write protocol supporting the instrumentation data model.

Tailing whatever structure TSDB currently supports, which will probably be
a moving target for some time, seems like it would cause unnecessary
change frequency to the API or require waiting a few years before making
any changes at all.
Or is the goal to not give service offerings access to more structure than
Prometheus itself can make use of?


I should say that I'm primarily speaking from technical curiosity here. Our
own offering doesn't need such fundamental changes, though
they would make some things a bit simpler of course.


On another front, from an efficiency standpoint, don't we want to batch
> samples from exact same ts in many cases (e.g network partition)?
>

Could you elaborate with an example?

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/CAG97UEmPzxB5Sr1rOpjYOrRURBuU%3DFP4YsWM-0mk6o9XZt4xBQ%40mail.gmail.com.

Re: [prometheus-developers] Evolving remote APIs

2021-11-26 Thread Bartłomiej Płotka 
>  directly stream OpenMetrics (or a proto-equivalent) from there,

On another front, from an efficiency standpoint, don't we want to batch
samples from exact same ts in many cases (e.g network partition)?

Kind Regards,
Bartek Płotka (@bwplotka)


On Thu, Nov 25, 2021 at 10:25 PM Julien Pivotto 
wrote:

> On 25 Nov 10:35, Fabian Reinartz wrote:
> > The point on TSDB becoming more structured is interesting – how firm are
> > these plans at this point? Any rough timelines?
> > My first hunch would've been to explore integrating directly at the
> > scraping layer to directly stream OpenMetrics (or a proto-equivalent)
> from
> > there, backed by a separate, per-write-target WAL.
> > This wouldn't constrain it by the currently supported storage data model
> > and generally decouple the two aspects, which also seems more aligned
> with
> > recent developments like the agent mode.
> > Any thoughts on that general direction?
>
> As maintainer of Prometheus server, in general, I am worried that
> getting a wal that'd be more "able" than the actual Prometheus TSDB
> would weaken the Prometheus server use case in favor of SaaS platforms.
>
> It does not sound great for the users who rely on Prometheus
> alone, which I think will continue to represent a large part of our
> community in the future.
>
> Additionally, the Query Engine should take advantage of those new
> properties as well: until we do not support that in Prometheus TSDB,
> it's harder to take advantage of the OpenMetrics types in the language.
>
> --
> Julien Pivotto
> @roidelapluie
>
> --
> You received this message because you are subscribed to the Google Groups
> "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to prometheus-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/prometheus-developers/20211125212505.GA1108440%40hydrogen
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/CAMssQwbZjTsY9fdaascMxwOn%2BK0ypSqKAMPj-gtJtet3d7LAxg%40mail.gmail.com.

Re: [prometheus-developers] Enabling auto-merge

2021-11-26 Thread Augustin Husson 
Yup, you need to go in the settings -> options. Then scroll to the "Merge
Button" section, you have a the option "Allow auto-merge":

[image: image.png]

Le ven. 26 nov. 2021 à 11:10, Matthias Rampke  a
écrit :

> Ah, I didn't understand at first that this is a per-pull-request thing.
> What is the right way to enable this? Do I change the repository
> configuration by hand?
>
> /MR
>
> On Thu, Nov 25, 2021 at 5:16 PM Julien Pivotto 
> wrote:
>
>> Hello,
>>
>> I have enabled "auto merge" in prometheus/prometheus with the following
>> checks:
>>
>> build
>> test_mixins
>> test_windows
>> test_go
>> test_ui
>> Fuzzing
>> lint
>>
>> It's an experiment, we can revert if we wish. Also, it's opt in per pull
>> request ofc.
>>
>> On 25 Nov 09:44, Levi Harrison wrote:
>> > Hi Augustin,
>> >
>> > That's one thing I was slightly confused about. In the official
>> > documentation (
>> >
>> https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request
>> )
>> > it says "when all required reviews are met and status checks have
>> passed",
>> > which makes me think that it doesn't take the "required status check"
>> > distinction into consideration, instead just waiting for all of them to
>> > pass, required or not. I agree with you that for auto-merge all jobs
>> should
>> > be mandatory.
>> >
>> > Thanks,
>> > Levi
>> >
>> > On Thu, Nov 25, 2021 at 9:32 AM Augustin Husson <
>> husson.augus...@gmail.com>
>> > wrote:
>> >
>> > > Hi Levi,
>> > >
>> > > From my point of view, yeah it's safe to activate it. But before doing
>> > > that, maybe we should take a look at the different jobs and figure out
>> > > which one are mandatory ? Probably all jobs are mandatory (that's my
>> > > feeling at least).
>> > >
>> > > Cheers,
>> > > Augustin.
>> > >
>> > > Le jeu. 25 nov. 2021 à 15:24, Levi Harrison <
>> levisamuelharri...@gmail.com>
>> > > a écrit :
>> > >
>> > >> Hi all,
>> > >>
>> > >> Picking up the previous thread (
>> > >>
>> https://groups.google.com/g/prometheus-developers/c/tPLOmT9pnBw/m/kxLn0q59AgAJ
>> ),
>> > >> I'd like to re-propose allowing auto-merge as a merge option.
>> > >>
>> > >> Auto-merge is a merge option, to be used in conjugation with other
>> merge
>> > >> options like squash merge, that once "enabled" for a pull request
>> (the same
>> > >> action as clicking the merge button), will automatically merge the
>> pull
>> > >> request once all checks have passed and required approvals have been
>> > >> submitted. If more commits are added by contributors without write
>> access
>> > >> in the period between when auto-merge is enabled and the PR is
>> merged,
>> > >> auto-merge will be canceled.
>> > >>
>> > >> Auto-merge won't just merge any PR once it's green, it requires the
>> same
>> > >> intentional action from a maintainer as regularly merging a PR does.
>> > >> Auto-merge also doesn't equate an approval as a merge action, unless
>> it is
>> > >> one of the requirements to merge and auto-merge is enabled. I
>> believe we
>> > >> only require approvals on release branches, so only if a maintainer
>> has
>> > >> decided to enable auto-merge for a PR to a release branch would an
>> approval
>> > >> ever cause a PR to be auto-merged.
>> > >>
>> > >>
>> > >>
>> https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request
>> > >>
>> > >> Personally, I could see this being useful when myself or a
>> contributor
>> > >> has just pushed to PR and I want to merge it, but also can't sit
>> around for
>> > >> 20 minutes until all the checks pass.
>> > >>
>> > >> Thanks (and congratulations to all the new team members),
>> > >> Levi
>> > >>
>> > >> --
>> > >> You received this message because you are subscribed to the Google
>> Groups
>> > >> "Prometheus Developers" group.
>> > >> To unsubscribe from this group and stop receiving emails from it,
>> send an
>> > >> email to prometheus-developers+unsubscr...@googlegroups.com.
>> > >> To view this discussion on the web visit
>> > >>
>> https://groups.google.com/d/msgid/prometheus-developers/b32fd1fc-2e43-4177-a17f-7b7207ff2d42n%40googlegroups.com
>> > >> <
>> https://groups.google.com/d/msgid/prometheus-developers/b32fd1fc-2e43-4177-a17f-7b7207ff2d42n%40googlegroups.com?utm_medium=email&utm_source=footer
>> >
>> > >> .
>> > >>
>> > >
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> Groups "Prometheus Developers" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> an email to prometheus-developers+unsubscr...@googlegroups.com.
>> > To view this discussion on the web visit
>> https://groups.google.com/d/msgid/prometheus-developers/CAJrMkW6uv8p_Mhffk2LwEuPZmNb0qBDQrVuQb1HxNqTc-mdG3A%40mail.gmail.com
>> .
>>
>> --
>> Julien Pivotto
>> @roidelapluie
>>
>> --
>> You received this message because you are subscribed to th

Re: [prometheus-developers] Welcoming Matthias Loibl as a new Prometheus team member

2021-11-26 Thread Matthias Rampke 
Welcome to the other Matthias >:)

/MR

On Thu, Nov 25, 2021 at 2:11 PM Goutham Veeramachaneni 
wrote:

> Welcome Matthias! Looong overdue :)
>
> Thanks
> Goutham
>
> On Thu, Nov 25, 2021 at 2:31 PM Julien Pivotto 
> wrote:
>
>> Welcome!!
>>
>> On 25 Nov 12:32, Julius Volz wrote:
>> > Hi Prometheans,
>> >
>> > Please welcome Matthias Loibl as a new member to the Prometheus team!
>> > Matthias has been a friend of the Prometheus project for a long time and
>> > has helped out with a lot of community work (meetups, evangelism,
>> > contributor office hours, best practices around SLOs, and more).
>> >
>> > Cheers,
>> > Julius
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> Groups "Prometheus Developers" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> an email to prometheus-developers+unsubscr...@googlegroups.com.
>> > To view this discussion on the web visit
>> https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6Yoz4nb69BhUt_q7JS%2BhuYveHiUuYbn_FABb0_biAyVzW3g%40mail.gmail.com
>> .
>>
>> --
>> Julien Pivotto
>> @roidelapluie
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Prometheus Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to prometheus-developers+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/prometheus-developers/20211125133143.GB465801%40hydrogen
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to prometheus-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/prometheus-developers/CAKQV3GEsD5U0JnSRBQRDYKpY7XPB8QHoo%3Dev2UB_eg57SbbYZA%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/CAMV%3D_gb%3DbhowCBqq242%3DthiGasAUCa57%3DXLKP-M-6sdJS%3DqJ1w%40mail.gmail.com.

Re: [prometheus-developers] Enabling auto-merge

2021-11-26 Thread Matthias Rampke 
Ah, I didn't understand at first that this is a per-pull-request thing.
What is the right way to enable this? Do I change the repository
configuration by hand?

/MR

On Thu, Nov 25, 2021 at 5:16 PM Julien Pivotto 
wrote:

> Hello,
>
> I have enabled "auto merge" in prometheus/prometheus with the following
> checks:
>
> build
> test_mixins
> test_windows
> test_go
> test_ui
> Fuzzing
> lint
>
> It's an experiment, we can revert if we wish. Also, it's opt in per pull
> request ofc.
>
> On 25 Nov 09:44, Levi Harrison wrote:
> > Hi Augustin,
> >
> > That's one thing I was slightly confused about. In the official
> > documentation (
> >
> https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request
> )
> > it says "when all required reviews are met and status checks have
> passed",
> > which makes me think that it doesn't take the "required status check"
> > distinction into consideration, instead just waiting for all of them to
> > pass, required or not. I agree with you that for auto-merge all jobs
> should
> > be mandatory.
> >
> > Thanks,
> > Levi
> >
> > On Thu, Nov 25, 2021 at 9:32 AM Augustin Husson <
> husson.augus...@gmail.com>
> > wrote:
> >
> > > Hi Levi,
> > >
> > > From my point of view, yeah it's safe to activate it. But before doing
> > > that, maybe we should take a look at the different jobs and figure out
> > > which one are mandatory ? Probably all jobs are mandatory (that's my
> > > feeling at least).
> > >
> > > Cheers,
> > > Augustin.
> > >
> > > Le jeu. 25 nov. 2021 à 15:24, Levi Harrison <
> levisamuelharri...@gmail.com>
> > > a écrit :
> > >
> > >> Hi all,
> > >>
> > >> Picking up the previous thread (
> > >>
> https://groups.google.com/g/prometheus-developers/c/tPLOmT9pnBw/m/kxLn0q59AgAJ
> ),
> > >> I'd like to re-propose allowing auto-merge as a merge option.
> > >>
> > >> Auto-merge is a merge option, to be used in conjugation with other
> merge
> > >> options like squash merge, that once "enabled" for a pull request
> (the same
> > >> action as clicking the merge button), will automatically merge the
> pull
> > >> request once all checks have passed and required approvals have been
> > >> submitted. If more commits are added by contributors without write
> access
> > >> in the period between when auto-merge is enabled and the PR is merged,
> > >> auto-merge will be canceled.
> > >>
> > >> Auto-merge won't just merge any PR once it's green, it requires the
> same
> > >> intentional action from a maintainer as regularly merging a PR does.
> > >> Auto-merge also doesn't equate an approval as a merge action, unless
> it is
> > >> one of the requirements to merge and auto-merge is enabled. I believe
> we
> > >> only require approvals on release branches, so only if a maintainer
> has
> > >> decided to enable auto-merge for a PR to a release branch would an
> approval
> > >> ever cause a PR to be auto-merged.
> > >>
> > >>
> > >>
> https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request
> > >>
> > >> Personally, I could see this being useful when myself or a contributor
> > >> has just pushed to PR and I want to merge it, but also can't sit
> around for
> > >> 20 minutes until all the checks pass.
> > >>
> > >> Thanks (and congratulations to all the new team members),
> > >> Levi
> > >>
> > >> --
> > >> You received this message because you are subscribed to the Google
> Groups
> > >> "Prometheus Developers" group.
> > >> To unsubscribe from this group and stop receiving emails from it,
> send an
> > >> email to prometheus-developers+unsubscr...@googlegroups.com.
> > >> To view this discussion on the web visit
> > >>
> https://groups.google.com/d/msgid/prometheus-developers/b32fd1fc-2e43-4177-a17f-7b7207ff2d42n%40googlegroups.com
> > >> <
> https://groups.google.com/d/msgid/prometheus-developers/b32fd1fc-2e43-4177-a17f-7b7207ff2d42n%40googlegroups.com?utm_medium=email&utm_source=footer
> >
> > >> .
> > >>
> > >
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "Prometheus Developers" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to prometheus-developers+unsubscr...@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/prometheus-developers/CAJrMkW6uv8p_Mhffk2LwEuPZmNb0qBDQrVuQb1HxNqTc-mdG3A%40mail.gmail.com
> .
>
> --
> Julien Pivotto
> @roidelapluie
>
> --
> You received this message because you are subscribed to the Google Groups
> "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to prometheus-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/prometheus-developers/20211125171629.GA774651%40hydrogen
> .
>

-- 
You received this message be