Re: [prometheus-developers] Re: Helm charts home

2020-06-19 Thread André Bauer 
Why would you want to add "helm-chart" in the name of the chart and have 
multiple repos?

Imho it would be:

helm-charts/prometheus
helm-charts/alertmanager
helm-charts/...

and so on. So being "helm-charts" the repos main directory and the charts 
inside of it.
Adding "helm-chart" to the name would also waste chars in helms limited 
release name lenght.

Maintenance of single repos for every chart would also be total overkill. 
Imagine alone changes in the CI would be done multiple times.



zanh...@gmail.com schrieb am Freitag, 19. Juni 2020 um 16:36:05 UTC+2:

> Hi Stuart,
>
> No. My ideal expectation would be different repos, unless cost and / or 
> maintenance is too high. 
>
> Best,
> Mingchin
>
> On Fri, Jun 19, 2020 at 10:26 PM Stuart Clark  
> wrote:
>
>> On 2020-06-19 15:09, Mingchin Hsieh wrote:
>> > Hi,
>> > 
>> > I sort of agree with Stuart's idea; only a little tweak: adding
>> > helm-chart as prefix or suffix. For example,
>> > 
>> > Prefix approach -
>> > helm-chart-prometheus-adapter
>> > helm-chart-prometheus-blackbox-exporter
>> > helm-chart-prometheus-cloudwatch-exporter
>> > helm-chart-prometheus-consul-exporter
>> > helm-chart-prometheus-couchdb-exporter
>> > helm-chart-prometheus-mongodb-exporter
>> > helm-chart-prometheus-mysql-exporter
>> > helm-chart-prometheus-nats-exporter
>> > helm-chart-prometheus-node-exporter
>> > helm-chart-prometheus-operator
>> > helm-chart-prometheus-postgres-exporter
>> > helm-chart-prometheus-pushgateway
>> > helm-chart-prometheus-rabbitmq-exporter
>> > helm-chart-prometheus-redis-exporter
>> > helm-chart-prometheus-snmp-exporter
>> > helm-chart-prometheus-to-sd
>> > helm-chart-prometheus
>> > 
>> > Suffix approach -
>> > prometheus-adapter-helm-chart
>> > prometheus-blackbox-exporter-helm-chart
>> > prometheus-cloudwatch-exporter-helm-chart
>> > prometheus-consul-exporter-helm-chart
>> > prometheus-couchdb-exporter-helm-chart
>> > prometheus-mongodb-exporter-helm-chart
>> > prometheus-mysql-exporter-helm-chart
>> > prometheus-nats-exporter-helm-chart
>> > prometheus-node-exporter-helm-chart
>> > prometheus-operator-helm-chart
>> > prometheus-postgres-exporter-helm-chart
>> > prometheus-pushgateway-helm-chart
>> > prometheus-rabbitmq-exporter-helm-chart
>> > prometheus-redis-exporter-helm-chart
>> > prometheus-snmp-exporter-helm-chart
>> > prometheus-to-sd-helm-chart
>> > prometheus-helm-chart
>> > 
>> > This is due to there are some existing repos in prometheus-community
>> > that focus on each component implementation level (e.g. docker image
>> > or stand-alone service). Mixing together might be harder to put on
>> > hub.helm.sh [1]. But, the owners of prometheus-community hold their
>> > right for the final decision.
>> > 
>> > BTW, would any prometheus-community owners / members explain the
>> > current testing infrastructure? Currently helm chart testing infra is
>> > based on Google Bazel + CircleCI. There's some limitation over there,
>> > e.g. the chart owners / approvers debug the testing infra is hard. I
>> > think all the current prometheus related helm chart owners would like
>> > to know how hard would be for migration / automation.
>> > 
>> > Best,
>> > Mingchin
>> > 
>> > On Fri, Jun 19, 2020 at 8:55 PM Stuart Clark
>> >  wrote:
>> > 
>> >> On 2020-06-19 13:30, André Bauer wrote:
>> >>> Hey guys,
>> >>> 
>> >>> great to see there is already some effort to move the chart out of
>> >> the
>> >>> stable repo :)
>> >>> 
>> >>> As i understand that "prometheus" is not the perfect fit for the
>> >> chart
>> >>> name, as it also installs other components from the prometheus eco
>> >>> system, i'm also not the biggest fan of umbrella charts.
>> >>> From our experience at kiwigrid this can lead to updating issues.
>> >>> For example you'd need to update proemtheus server but because of
>> >> the
>> >>> umbrella it could alreadya fail and exit

Re: [prometheus-developers] Re: Helm charts home

2020-06-19 Thread André Bauer 
Hey guys,

great to see there is already some effort to move the chart out of the 
stable repo :)

As i understand that "prometheus" is not the perfect fit for the chart 
name, as it also installs other components from the prometheus eco system, 
i'm also not the biggest fan of umbrella charts.
>From our experience at kiwigrid this can lead to updating issues.
For example you'd need to update proemtheus server but because of the 
umbrella it could alreadya fail and exit in the alertmanager update step.
Therefore we switched to single chart installs now as you're able to update 
single components, without the need to run the update for all charts under 
the umbrella, which is much more error resistent from our experience.

Nevertheless an umbrella chart might be good starting point for testing 
Prometheus with all of its available components.

Where i see problems is to deprecate the chart in stable and change the way 
the chart works in the new repo.
Maybe such changes should be done in an earlier step in the stable chart 
repo?
At least doumentation of the upgrade path should be clear and possible, 
without the need to have manual steps like pvc backup / restore because the 
name of the pvc changed.

Kind regards
André


Naseem Ullah schrieb am Montag, 15. Juni 2020 um 03:13:57 UTC+2:

> Yes a single repo called helm-charts to host all charts.
>
> Also, as per 
> https://prometheus.io/docs/introduction/overview/#architecture we should 
> have a prometheus-server chart that would be part of the umbrella 
> prometheus chart if we want to follow this pattern.
>
>
> On Sunday, June 14, 2020 at 12:32:26 PM UTC-4, Augustin Husson wrote:
>
>> Or just helm-chart with inside all chart relative to the prometheus tools 
>> like node-exporter, alertmanager ...etc.
>>
>> Le dim. 14 juin 2020 à 13:52, Mingchin Hsieh  a 
>> écrit :
>>
> Hi Frederic,
>>>
>>> Yes. I think I would keep straightforward naming as 
>>> prometheus-helm-chart, i.e. 
>>>
>>> https://github.com/prometheus-community/prometheus-helm-chart
>>>
>>> If you guys have better idea on naming, please advice.
>>>
>>> Best,
>>>
>> Ming 
>>>
>>> On Tuesday, June 9, 2020 at 6:44:26 PM UTC+8, Frederic Branczyk wrote:
>>>
>> I personally think the amount of things happening in these charts is too 
 big to represent "prometheus". Same goes for the prometheus-operator 
 chart. 
 Both of these cover a very large surface and as a result issues frequently 
 get filed against the upstream projects confusing problems with the charts 
 with the scope of the projects themselves.

 If a chart was in the community org then it should really only deploy 
 and configure Prometheus in my opinion. Meta charts that configure 
 multiple 
 sub-charts would be ok, but under a different name (which is why we called 
 the project that integrates the two worlds tightly with each other 
 kube-prometheus ).

 On Thu, 4 Jun 2020 at 23:50, Mingchin Hsieh  wrote:

>>> Hi guys, 
>
> I am one of Helm Prometheus chart maintainers:
>
>
> https://github.com/helm/charts/blob/master/stable/prometheus/Chart.yaml#L18
>
> I hope I could help to move Helm Prometheus chart for looking new 
> home. If after deprecation date, I will host it on my personal repo.
>
> Best,
> Ming
>
> On Tuesday, March 31, 2020 at 11:38:58 AM UTC+8, Naseem Ullah wrote:
>>
>> As per the helm charts stable repo deprecation timeline 
>> , the various 
>> prometheus related helm charts such as prometheus 
>> ,
>>  prometheus-operator 
>> 
>> , prometheus-adapter 
>> 
>> , prometheus-node-exporter 
>> 
>>  and 
>> the various other exporters will require a new home and none more 
>> fitting 
>> than https://github.com/prometheus-community.We have had successful 
>> migrations of the sort with other CNCF projects, namely Jaeger (
>> https://github.com/jaegertracing/helm-charts)  and Fluent Bit(
>> https://github.com/fluent/helm-charts).
>>
> -- 
> You received this message because you are subscribed to the Google 
> Groups "Prometheus Developers" group.
>
 To unsubscribe from this group and stop receiving emails from it, send 
> an email to prometheus-developers+unsub...@googlegroups.com.


> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/prometheus-developers/53909810-686f-4550-977a-4f1c721dc8fao%40googlegroups.com
>  
>