Re: [prometheus-developers] Memcached exporter Multi-target

2022-09-19 Thread 'Mateus Dubiela' via Prometheus Developers
Hi!

The PR  is now
there, let me know if there is anything that could be improved.

Thanks! Regards

On Fri, Sep 2, 2022 at 11:18 AM 'Mateus Dubiela' via Prometheus Developers <
prometheus-developers@googlegroups.com> wrote:

> Thanks for the feedback!
>
> I see that you already have opened an issue there
> , I'll refer
> to it when we start implementing.
>
> Your solution seem more clean, and something we thought about, for us the
> problems were that the because changing in prometheus itself might
> compromise our whole monitoring infra we choose the external service
> discovery + multi-target exporter route to be safer.
>
> A feedback I would give on implementing the multiple aws service discovery
> services on the same object, would be that their output and configurations
> might differ and you might end up having a complex base element.
>
> I'm happy to collaborate on that effort if you want.
>
> Thank you again!
>
> On Friday, September 2, 2022 at 7:26:49 AM UTC-3 sup...@gmail.com wrote:
>
>> Hey, that would be a great feature to have.
>>
>> I would start by opening an issue on the exporter repo.
>>
>> I also have this need, and have been starting the work to refactor the
>> AWS code in Prometheus to support "roles" like the kubernetes_sd_configs so
>> we can add direct support for something like this:
>>
>> aws_sd_configs:
>> - role: elasticache
>>   region: foo
>>
>> My target is to merge ec2, lightsail, and add elasticache and rds.
>>
>> On Fri, Sep 2, 2022 at 12:23 PM 'Mateus Dubiela' via Prometheus
>> Developers  wrote:
>>
>>> Hello folks!
>>>
>>> We are looking into adding support for multi-target 
>>>  to the memcached 
>>> exporter . The reasoning 
>>> here is to be able to use the elasticache service discovery 
>>>  and be able to do 
>>> the same thing as the redis exporter 
>>> .
>>>
>>> As per the CONTRIBUTING.md 
>>> 
>>>  asking the mailing list is a sensible thing to do, to have an open 
>>> discussion and also ask if someone else was working on this.
>>>
>>> Thank you!
>>>
>>>
>>> --
>>> Confidentiality note: This e-mail may contain confidential information
>>> from Nu Holdings Ltd and/or its affiliates. If you have received it by
>>> mistake, please let us know by e-mail reply and delete it from your system;
>>> you may not copy this message or disclose its contents to anyone; for
>>> details about what personal information we collect and why, please refer to
>>> our privacy policy
>>> .
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Prometheus Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to prometheus-devel...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/prometheus-developers/CA%2BgrcXiw_qV6Fx65v271GKfwsKDeAOuSv%3D2_6sqm0SM%2BQo-NbA%40mail.gmail.com
>>> 
>>> .
>>>
>>
> --
> Confidentiality note: This e-mail may contain confidential information
> from Nu Holdings Ltd and/or its affiliates. If you have received it by
> mistake, please let us know by e-mail reply and delete it from your system;
> you may not copy this message or disclose its contents to anyone; for
> details about what personal information we collect and why, please refer to
> our privacy policy .
>
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Prometheus Developers" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/prometheus-developers/eZlKWDBc4S0/unsubscribe
> .
> To unsubscribe from this group and all its topics, send an email to
> prometheus-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/prometheus-developers/311d963a-4462-40b4-b86e-3f68444db4fcn%40googlegroups.com
> 
> .
>

-- 

Confidentiality note: This e-mail may contain confidential information 
from Nu Holdings Ltd and/or its affiliates. If you have received it by 
mistake, please let us know by e-mail reply and delete it from your system; 
you may not copy this message or 

Re: [prometheus-developers] Memcached exporter Multi-target

2022-09-02 Thread 'Mateus Dubiela' via Prometheus Developers
Thanks for the feedback!

I see that you already have opened an issue there 
, I'll refer 
to it when we start implementing.

Your solution seem more clean, and something we thought about, for us the 
problems were that the because changing in prometheus itself might 
compromise our whole monitoring infra we choose the external service 
discovery + multi-target exporter route to be safer.

A feedback I would give on implementing the multiple aws service discovery 
services on the same object, would be that their output and configurations 
might differ and you might end up having a complex base element.

I'm happy to collaborate on that effort if you want.

Thank you again!

On Friday, September 2, 2022 at 7:26:49 AM UTC-3 sup...@gmail.com wrote:

> Hey, that would be a great feature to have.
>
> I would start by opening an issue on the exporter repo.
>
> I also have this need, and have been starting the work to refactor the AWS 
> code in Prometheus to support "roles" like the kubernetes_sd_configs so we 
> can add direct support for something like this:
>
> aws_sd_configs:
> - role: elasticache
>   region: foo
>
> My target is to merge ec2, lightsail, and add elasticache and rds.
>
> On Fri, Sep 2, 2022 at 12:23 PM 'Mateus Dubiela' via Prometheus Developers 
>  wrote:
>
>> Hello folks!
>>
>> We are looking into adding support for multi-target 
>>  to the memcached 
>> exporter . The reasoning 
>> here is to be able to use the elasticache service discovery 
>>  and be able to do 
>> the same thing as the redis exporter 
>> .
>>
>> As per the CONTRIBUTING.md 
>> 
>>  asking the mailing list is a sensible thing to do, to have an open 
>> discussion and also ask if someone else was working on this.
>>
>> Thank you!
>>
>>
>> --
>> Confidentiality note: This e-mail may contain confidential information 
>> from Nu Holdings Ltd and/or its affiliates. If you have received it by 
>> mistake, please let us know by e-mail reply and delete it from your system; 
>> you may not copy this message or disclose its contents to anyone; for 
>> details about what personal information we collect and why, please refer to 
>> our privacy policy 
>> .
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Prometheus Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to prometheus-devel...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/prometheus-developers/CA%2BgrcXiw_qV6Fx65v271GKfwsKDeAOuSv%3D2_6sqm0SM%2BQo-NbA%40mail.gmail.com
>>  
>> 
>> .
>>
>
-- 

Confidentiality note: This e-mail may contain confidential information 
from Nu Holdings Ltd and/or its affiliates. If you have received it by 
mistake, please let us know by e-mail reply and delete it from your system; 
you may not copy this message or disclose its contents to anyone; for 
details about what personal information we collect and why, please refer to 
our privacy policy .

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/311d963a-4462-40b4-b86e-3f68444db4fcn%40googlegroups.com.


Re: [prometheus-developers] Memcached exporter Multi-target

2022-09-02 Thread Ben Kochie
Hey, that would be a great feature to have.

I would start by opening an issue on the exporter repo.

I also have this need, and have been starting the work to refactor the AWS
code in Prometheus to support "roles" like the kubernetes_sd_configs so we
can add direct support for something like this:

aws_sd_configs:
- role: elasticache
  region: foo

My target is to merge ec2, lightsail, and add elasticache and rds.

On Fri, Sep 2, 2022 at 12:23 PM 'Mateus Dubiela' via Prometheus Developers <
prometheus-developers@googlegroups.com> wrote:

> Hello folks!
>
> We are looking into adding support for multi-target 
>  to the memcached 
> exporter . The reasoning 
> here is to be able to use the elasticache service discovery 
>  and be able to do 
> the same thing as the redis exporter 
> .
>
> As per the CONTRIBUTING.md 
> 
>  asking the mailing list is a sensible thing to do, to have an open 
> discussion and also ask if someone else was working on this.
>
> Thank you!
>
>
> --
> Confidentiality note: This e-mail may contain confidential information
> from Nu Holdings Ltd and/or its affiliates. If you have received it by
> mistake, please let us know by e-mail reply and delete it from your system;
> you may not copy this message or disclose its contents to anyone; for
> details about what personal information we collect and why, please refer to
> our privacy policy .
>
> --
> You received this message because you are subscribed to the Google Groups
> "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to prometheus-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/prometheus-developers/CA%2BgrcXiw_qV6Fx65v271GKfwsKDeAOuSv%3D2_6sqm0SM%2BQo-NbA%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/CABbyFmoMVwF0ZRUrgnBPpJ11kxhku2Xp-bZ-ER7uJhJA4ACEXw%40mail.gmail.com.


[prometheus-developers] Memcached exporter Multi-target

2022-09-02 Thread 'Mateus Dubiela' via Prometheus Developers
Hello folks!

We are looking into adding support for multi-target
 to the
memcached exporter .
The reasoning here is to be able to use the elasticache service
discovery  and
be able to do the same thing as the redis exporter
.

As per the CONTRIBUTING.md

asking the mailing list is a sensible thing to do, to have an open
discussion and also ask if someone else was working on this.

Thank you!

-- 

Confidentiality note: This e-mail may contain confidential information 
from Nu Holdings Ltd and/or its affiliates. If you have received it by 
mistake, please let us know by e-mail reply and delete it from your system; 
you may not copy this message or disclose its contents to anyone; for 
details about what personal information we collect and why, please refer to 
our privacy policy .

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/CA%2BgrcXiw_qV6Fx65v271GKfwsKDeAOuSv%3D2_6sqm0SM%2BQo-NbA%40mail.gmail.com.