Re: [protobuf] Compatibility error on adding sub message type in existing proto file

2022-12-04 Thread Robert Yokota
Hi,

I believe this is coming from the Confluent compatibility checker.  (I work
for Confluent.)

A forward compatibility check is just a backward compatibility check with
the arguments reversed.  Since removing a message is not backward
compatible, adding a message is not forward compatible.

Hope that helps,
Robert

On Sun, Dec 4, 2022 at 6:35 AM 'Adam Cozzette' via Protocol Buffers <
protobuf@googlegroups.com> wrote:

> I don't think we maintain any code that returns that kind of error. Do you
> know where that error is coming from? Is it from some external protobuf
> compatibility checker?
>
> On Thu, Dec 1, 2022 at 4:21 AM Komal Kamble 
> wrote:
>
>>
>> Hello Adam Cozzette,
>> We are getting Found incompatibility change error of type MESSAGE_REMOVED.
>>
>>
>> On 02-Nov-2022, at 11:41 PM, Adam Cozzette  wrote:
>>
>> 
>> Adding more message types to the proto file is fine and has no
>> compatibility issues. Can you say more about the error you're getting?
>>
>> On Wed, Nov 2, 2022 at 7:03 AM Komal Kamble 
>> wrote:
>>
>>> Hello ProtocolBufferSupport team,
>>>
>>> If I have a proto file with multiple sub-message types defined and If I
>>> want to add more sub-message types in the same file I am getting BACKWARD
>>> and FORWARD compatibility errors.
>>>
>>> I am using com.github.os72:protoc-jar-maven-plugin:3.11.4 plugin in java
>>> module to compile proto files and kafka-protobuf-provider:6.1.6 for
>>> ProtobufSchema object.
>>>
>>> The query is getting compatibility errors is it correct behavior or not?
>>>
>>> I didn't find any documentation in protocol-buffer user guide regarding
>>> adding more sub-message types in the existing proto file.
>>>
>>> Could you please help me to understand the standard behavior of the
>>> protocol buffer?
>>>
>>>
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Protocol Buffers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to protobuf+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/protobuf/8373c01f-8e61-4469-80e5-82a859035f2dn%40googlegroups.com
>>> 
>>> .
>>>
>> --
> You received this message because you are subscribed to the Google Groups
> "Protocol Buffers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to protobuf+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/protobuf/CADqAXr5pxtdS8Lcw-oXFNPdR3FDNi6_vngBMqjh4Pm%3Dh-QfEvA%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/protobuf/CAG0mBZQ%2BMH6TNucLz3z3jtT8vwFY%3DGH_bKRH%2BBF8jmnXMyNEqA%40mail.gmail.com.


Re: [protobuf] Compatibility error on adding sub message type in existing proto file

2022-12-04 Thread 'Adam Cozzette' via Protocol Buffers
I don't think we maintain any code that returns that kind of error. Do you
know where that error is coming from? Is it from some external protobuf
compatibility checker?

On Thu, Dec 1, 2022 at 4:21 AM Komal Kamble 
wrote:

>
> Hello Adam Cozzette,
> We are getting Found incompatibility change error of type MESSAGE_REMOVED.
>
>
> On 02-Nov-2022, at 11:41 PM, Adam Cozzette  wrote:
>
> 
> Adding more message types to the proto file is fine and has no
> compatibility issues. Can you say more about the error you're getting?
>
> On Wed, Nov 2, 2022 at 7:03 AM Komal Kamble 
> wrote:
>
>> Hello ProtocolBufferSupport team,
>>
>> If I have a proto file with multiple sub-message types defined and If I
>> want to add more sub-message types in the same file I am getting BACKWARD
>> and FORWARD compatibility errors.
>>
>> I am using com.github.os72:protoc-jar-maven-plugin:3.11.4 plugin in java
>> module to compile proto files and kafka-protobuf-provider:6.1.6 for
>> ProtobufSchema object.
>>
>> The query is getting compatibility errors is it correct behavior or not?
>>
>> I didn't find any documentation in protocol-buffer user guide regarding
>> adding more sub-message types in the existing proto file.
>>
>> Could you please help me to understand the standard behavior of the
>> protocol buffer?
>>
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Protocol Buffers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to protobuf+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/protobuf/8373c01f-8e61-4469-80e5-82a859035f2dn%40googlegroups.com
>> 
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/protobuf/CADqAXr5pxtdS8Lcw-oXFNPdR3FDNi6_vngBMqjh4Pm%3Dh-QfEvA%40mail.gmail.com.