Re: Patch to quiet compiler warnings from generated service code

[Kenton Varda]

I've made this change in SVN.  Thanks.

On Thu, Oct 2, 2008 at 12:40 PM, Caleb <[EMAIL PROTECTED]> wrote:

>
> When run with high warning levels, gcc complains that the 'request'
> and 'response' arguments are unused for all of the stub service
> functions generated by the protoc compiler.  Here's the 2-line patch
> to fix this.
>
> --- src/google/protobuf/compiler/cpp/cpp_service.cc.orig
> 2008-10-02 15:36:56.0 -0400
> +++ src/google/protobuf/compiler/cpp/cpp_service.cc 2008-10-02
> 15:37:07.0 -0400
> @@ -219,8 +219,8 @@
>
> printer->Print(sub_vars,
>   "void $classname$::$name$(::google::protobuf::RpcController*
> controller,\n"
> -  " const $input_type$* request,\n"
> -  " $output_type$* response,\n"
> +  " const $input_type$*,\n"
> +  " $output_type$*,\n"
>   " ::google::protobuf::Closure* done)
> {\n"
>   "  controller->SetFailed(\"Method $name$() not implemented.\");
> \n"
>   "  done->Run();\n"
>
>
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To post to this group, send email to protobuf@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en
-~--~~~~--~~--~--~---

Patch to quiet compiler warnings from generated service code

[Caleb]

When run with high warning levels, gcc complains that the 'request'
and 'response' arguments are unused for all of the stub service
functions generated by the protoc compiler.  Here's the 2-line patch
to fix this.

--- src/google/protobuf/compiler/cpp/cpp_service.cc.orig
2008-10-02 15:36:56.0 -0400
+++ src/google/protobuf/compiler/cpp/cpp_service.cc 2008-10-02
15:37:07.0 -0400
@@ -219,8 +219,8 @@

 printer->Print(sub_vars,
   "void $classname$::$name$(::google::protobuf::RpcController*
controller,\n"
-  " const $input_type$* request,\n"
-  " $output_type$* response,\n"
+  " const $input_type$*,\n"
+  " $output_type$*,\n"
   " ::google::protobuf::Closure* done)
{\n"
   "  controller->SetFailed(\"Method $name$() not implemented.\");
\n"
   "  done->Run();\n"



--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To post to this group, send email to protobuf@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en
-~--~~~~--~~--~--~---