[jira] [Updated] (PROTON-34) JythonTest.java not executing the jython tests missing
[ https://issues.apache.org/jira/browse/PROTON-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated PROTON-34: Attachment: PROTON-34.patch Attaching patch which fixes the unit tests. It was missing a dir in the python lookup path. JythonTest.java not executing the jython tests missing -- Key: PROTON-34 URL: https://issues.apache.org/jira/browse/PROTON-34 Project: Qpid Proton Issue Type: Bug Components: proton-j Reporter: Hiram Chirino Attachments: PROTON-34.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-35) Convert to a maven multi-module build
Hiram Chirino created PROTON-35: --- Summary: Convert to a maven multi-module build Key: PROTON-35 URL: https://issues.apache.org/jira/browse/PROTON-35 Project: Qpid Proton Issue Type: Improvement Reporter: Hiram Chirino Priority: Minor Having a multi-module build just means having a pom.xml at the root of the project. This way it will be easier to add additional optional modules in the future and setup CI builds of the java bits. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-35) Convert to a maven multi-module build
[ https://issues.apache.org/jira/browse/PROTON-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated PROTON-35: Attachment: PROTON-35.patch attaching patch that implements the conversion to muli-module. Convert to a maven multi-module build - Key: PROTON-35 URL: https://issues.apache.org/jira/browse/PROTON-35 Project: Qpid Proton Issue Type: Improvement Reporter: Hiram Chirino Priority: Minor Attachments: PROTON-35.patch Having a multi-module build just means having a pom.xml at the root of the project. This way it will be easier to add additional optional modules in the future and setup CI builds of the java bits. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PROTON-34) JythonTest.java not executing the jython tests missing
[ https://issues.apache.org/jira/browse/PROTON-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey reassigned PROTON-34: - Assignee: Rob Godfrey JythonTest.java not executing the jython tests missing -- Key: PROTON-34 URL: https://issues.apache.org/jira/browse/PROTON-34 Project: Qpid Proton Issue Type: Bug Components: proton-j Reporter: Hiram Chirino Assignee: Rob Godfrey Attachments: PROTON-34.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-34) JythonTest.java not executing the jython tests missing
[ https://issues.apache.org/jira/browse/PROTON-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-34. --- Resolution: Fixed patch applied JythonTest.java not executing the jython tests missing -- Key: PROTON-34 URL: https://issues.apache.org/jira/browse/PROTON-34 Project: Qpid Proton Issue Type: Bug Components: proton-j Reporter: Hiram Chirino Assignee: Rob Godfrey Attachments: PROTON-34.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-21) Extract the logical AMQP frame handling to an AbstractConnectionHandler
[ https://issues.apache.org/jira/browse/PROTON-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated PROTON-21: Attachment: PROTON-21-v3.patch Attaching new rebased patch that includes the recent changes. Should apply cleanly to trunk rev 1390467 Extract the logical AMQP frame handling to an AbstractConnectionHandler --- Key: PROTON-21 URL: https://issues.apache.org/jira/browse/PROTON-21 Project: Qpid Proton Issue Type: Improvement Reporter: Hiram Chirino Attachments: PROTON-21-v2.patch, PROTON-21-v3.patch Right now all the logic that handles logical AMQP frame events is inside of the TransportImpl class. That interface only allows you to pump bytes in and out of the connection. If we extract all the handling logic to an AbstractConnectionHandler you should be able to use that directly and pump logical AMQP frames and avoid the frame encoding/decoding phase that the TransportImpl also does. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-21) Extract the logical AMQP frame handling to an AbstractConnectionHandler
[ https://issues.apache.org/jira/browse/PROTON-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated PROTON-21: Attachment: (was: PROTON-21-v2.patch) Extract the logical AMQP frame handling to an AbstractConnectionHandler --- Key: PROTON-21 URL: https://issues.apache.org/jira/browse/PROTON-21 Project: Qpid Proton Issue Type: Improvement Reporter: Hiram Chirino Attachments: PROTON-21-v3.patch Right now all the logic that handles logical AMQP frame events is inside of the TransportImpl class. That interface only allows you to pump bytes in and out of the connection. If we extract all the handling logic to an AbstractConnectionHandler you should be able to use that directly and pump logical AMQP frames and avoid the frame encoding/decoding phase that the TransportImpl also does. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-13) Add JUnit test to proton-j that executes the python unit tests
[ https://issues.apache.org/jira/browse/PROTON-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-13. --- Resolution: Fixed Patch applied Add JUnit test to proton-j that executes the python unit tests -- Key: PROTON-13 URL: https://issues.apache.org/jira/browse/PROTON-13 Project: Qpid Proton Issue Type: Test Components: proton-j Reporter: Hiram Chirino Assignee: Rob Godfrey Attachments: PROTON-13-v2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-35) Convert to a maven multi-module build
[ https://issues.apache.org/jira/browse/PROTON-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated PROTON-35: Component/s: proton-j Convert to a maven multi-module build - Key: PROTON-35 URL: https://issues.apache.org/jira/browse/PROTON-35 Project: Qpid Proton Issue Type: Improvement Components: proton-j Reporter: Hiram Chirino Priority: Minor Attachments: PROTON-35.patch Having a multi-module build just means having a pom.xml at the root of the project. This way it will be easier to add additional optional modules in the future and setup CI builds of the java bits. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-21) Extract the logical AMQP frame handling to an AbstractConnectionHandler
[ https://issues.apache.org/jira/browse/PROTON-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464703#comment-13464703 ] Rob Godfrey commented on PROTON-21: --- I'm holding off on applying this until the work in moving the Java API over to the new design for Transport is in place to bring it into line with the C. At that point the way to integrate with code which requires a frame level transport should be clearer and hopefully provided in such a way as to be identical between the Java engine and the C engine. I'm hoping to get the API stuff up to date in the next few days. Overall I think the goal here is to ensure that the Java and C provide identical interfaces and not to create APIs which are Java specific. Apologies for my tardiness in this, have been distracted by other day job issues, but should have more time available going forward Extract the logical AMQP frame handling to an AbstractConnectionHandler --- Key: PROTON-21 URL: https://issues.apache.org/jira/browse/PROTON-21 Project: Qpid Proton Issue Type: Improvement Reporter: Hiram Chirino Attachments: PROTON-21-v3.patch Right now all the logic that handles logical AMQP frame events is inside of the TransportImpl class. That interface only allows you to pump bytes in and out of the connection. If we extract all the handling logic to an AbstractConnectionHandler you should be able to use that directly and pump logical AMQP frames and avoid the frame encoding/decoding phase that the TransportImpl also does. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-35) Convert to a maven multi-module build
[ https://issues.apache.org/jira/browse/PROTON-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464784#comment-13464784 ] Joseph Ottinger commented on PROTON-35: --- But make... makes the whole CI bit less easy as well. Maven still wins there. It's doable with make, it's doable with ant, rake, buildr, gradle, etc., but maven is idiomatic and everywhere. :) Convert to a maven multi-module build - Key: PROTON-35 URL: https://issues.apache.org/jira/browse/PROTON-35 Project: Qpid Proton Issue Type: Improvement Components: proton-j Reporter: Hiram Chirino Priority: Minor Attachments: PROTON-35.patch Having a multi-module build just means having a pom.xml at the root of the project. This way it will be easier to add additional optional modules in the future and setup CI builds of the java bits. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-35) Convert to a maven multi-module build
[ https://issues.apache.org/jira/browse/PROTON-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464821#comment-13464821 ] Hiram Chirino commented on PROTON-35: - I wouldn't go that far as to suggest we use maven to build C. I'd rather keep things simple, and let maven build what it's best a building.. and use make to build what it's best a building. I think it's kinda crazy to force one or the other. Convert to a maven multi-module build - Key: PROTON-35 URL: https://issues.apache.org/jira/browse/PROTON-35 Project: Qpid Proton Issue Type: Improvement Components: proton-j Reporter: Hiram Chirino Priority: Minor Attachments: PROTON-35.patch Having a multi-module build just means having a pom.xml at the root of the project. This way it will be easier to add additional optional modules in the future and setup CI builds of the java bits. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-37) Fix failing python tests for Proton-J
Rob Godfrey created PROTON-37: - Summary: Fix failing python tests for Proton-J Key: PROTON-37 URL: https://issues.apache.org/jira/browse/PROTON-37 Project: Qpid Proton Issue Type: Bug Components: proton-j Reporter: Rob Godfrey Assignee: Rob Godfrey Of the tests running against the engine, the following are currently failing even though the functionality should be complete: proton_tests.engine.CreditTest.testDrainFlow proton_tests.engine.CreditTest.testDrainZero proton_tests.engine.LinkTest.test_multiple proton_tests.engine.PipelineTest.test -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-35) Convert to a maven multi-module build
[ https://issues.apache.org/jira/browse/PROTON-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464985#comment-13464985 ] Rafael H. Schloming commented on PROTON-35: --- I agree with Hiram on the C front. In fact I think, given the project goals, that building C with maven is really a non starter from *both* the proton-j and proton-c angle. In the C world Maven is definitely not considered idomatic, and there are many places the C implementation will need to reach where a Java build dependency would be a blocker (e.g. linux kernel). In the Java world I can't imagine a Maven build with a C dependency would be the most popular thing either. Given that we want maximum adoption, reach, and ubiquity on both fronts, I think it would be very counter productive to try to build C with maven or Java with cmake. Regarding the patch, I think there are a few points from IRC worth bringing up here. As I understand it the motivation of this has to do with maven's ability to automatically perform release management tasks, i.e. it needs to be in a particular place in the SVN tree hierarchy relative to where the trunk part is. That said it's a bit of a kludge given that the top level directory is really composed of independent components, e.g. proton-j, proton-c, and the tests directory can all be checked out and used standalone which is I think important for the idomaticness/adoption of each sub portion. I'm also concerned that from the perspective of the people navigating the directory looking for the C code (or the javascript code when that arrives) that a top level pom.xml would be a big misdirection. Are there other options here we could consider that would make maven happy? Hiram pointed out on IRC that moving the trunk up a level would facilitate independent releases of proton-j and proton-c and would eliminate the desire for this extra pom.xml since the source tree would match maven's conventions, however I'm not sure we're ready to say whether or not we're doing independent releases yet and I don't particularly relish the idea of moving everything around, and if we are going to move stuff I'd rather go to git anyways. Would a git repo change the situation at all since we would not be forced to choose the point at which we put the giant trunk in the middle of our directory path, or would maven's conventions still balk at multiple independent builds sharing a single repo? Convert to a maven multi-module build - Key: PROTON-35 URL: https://issues.apache.org/jira/browse/PROTON-35 Project: Qpid Proton Issue Type: Improvement Components: proton-j Reporter: Hiram Chirino Priority: Minor Attachments: PROTON-35.patch Having a multi-module build just means having a pom.xml at the root of the project. This way it will be easier to add additional optional modules in the future and setup CI builds of the java bits. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-14) addModified method in ConnectionImpl can cause infinite loop
[ https://issues.apache.org/jira/browse/PROTON-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-14. --- Resolution: Fixed This appears to have been applied addModified method in ConnectionImpl can cause infinite loop Key: PROTON-14 URL: https://issues.apache.org/jira/browse/PROTON-14 Project: Qpid Proton Issue Type: Bug Components: proton-j Reporter: Rajith Attapattu When adding a new Head, you need to clear any pointers that it has to it's next and prev and also when adding an item to the tail it should clear it's next. The above bug resulted in infinite loops. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
