[jira] [Commented] (PROTON-121) Platform specific code is mixed in with platform independent code
[ https://issues.apache.org/jira/browse/PROTON-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577691#comment-13577691 ] Andrew Stitcher commented on PROTON-121: The file error.c still uses strerror_r(); we still need to review the engine portions and ensure they are only dependent on ANSI C headers. Platform specific code is mixed in with platform independent code - Key: PROTON-121 URL: https://issues.apache.org/jira/browse/PROTON-121 Project: Qpid Proton Issue Type: Bug Components: proton-c Reporter: Andrew Stitcher Assignee: Andrew Stitcher Fix For: 0.4 the function pn_error_from errno() is platform specific and so should not be in error.c which is (everywhere else) purely platform independent. It should be moved to a platform (POSIX) specific file (perhaps a file with only this single function). [The clue for this is the #define POSIX_C_SOURCE at the top of error.c] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-236) Porting Issue -- Visual Studio does not provide a getopt() function
[ https://issues.apache.org/jira/browse/PROTON-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mary hinton updated PROTON-236: --- Attachment: (was: getopt.c) Porting Issue -- Visual Studio does not provide a getopt() function --- Key: PROTON-236 URL: https://issues.apache.org/jira/browse/PROTON-236 Project: Qpid Proton Issue Type: Improvement Components: proton-c Environment: Windows using Visual Studio 2010 Reporter: Mary hinton Fix For: 0.4 Since Visual Studio 2010 does not provide a getopt(), I used the getopt() function found in the GNU library getopt.h and getopt.c. I made a few minor changes and will attach these files to this JIRA. Besides the proton.c file, the proton project workspace for Visual Studio would need to include getopt() files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-236) Porting Issue -- Visual Studio does not provide a getopt() function
[ https://issues.apache.org/jira/browse/PROTON-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mary hinton updated PROTON-236: --- Attachment: getopt.h Porting Issue -- Visual Studio does not provide a getopt() function --- Key: PROTON-236 URL: https://issues.apache.org/jira/browse/PROTON-236 Project: Qpid Proton Issue Type: Improvement Components: proton-c Environment: Windows using Visual Studio 2010 Reporter: Mary hinton Fix For: 0.4 Attachments: getopt.c, getopt.h Since Visual Studio 2010 does not provide a getopt(), I used the getopt() function found in the GNU library getopt.h and getopt.c. I made a few minor changes and will attach these files to this JIRA. Besides the proton.c file, the proton project workspace for Visual Studio would need to include getopt() files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-236) Porting Issue -- Visual Studio does not provide a getopt() function
[ https://issues.apache.org/jira/browse/PROTON-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming updated PROTON-236: --- Assignee: Cliff Jansen Porting Issue -- Visual Studio does not provide a getopt() function --- Key: PROTON-236 URL: https://issues.apache.org/jira/browse/PROTON-236 Project: Qpid Proton Issue Type: Improvement Components: proton-c Environment: Windows using Visual Studio 2010 Reporter: Mary hinton Assignee: Cliff Jansen Fix For: 0.4 Attachments: freegetopt-0.11.tar.gz, getopt.c, getopt.h Since Visual Studio 2010 does not provide a getopt(), I used the getopt() function found in the GNU library getopt.h and getopt.c. I made a few minor changes and will attach these files to this JIRA. Besides the proton.c file, the proton project workspace for Visual Studio would need to include getopt() files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-237) Porting Issue -- basename() not found in Visual Studio 2010
Mary hinton created PROTON-237: -- Summary: Porting Issue -- basename() not found in Visual Studio 2010 Key: PROTON-237 URL: https://issues.apache.org/jira/browse/PROTON-237 Project: Qpid Proton Issue Type: Improvement Components: proton-c Environment: Windows Visual Studio 2010 Reporter: Mary hinton Fix For: 0.4 The basename() function in proton.c is not found in Visual Studio 2010. It is in Visual Studio 2012 when the filesystem header is included. It is only used in a printf statement and is not needed for porting to Visual Studio 2010: printf(Usage: %s [-h] [-c [user[:password]@]host[:port]] [-a address] [-m sasl-mech]\n, basename(argv[0])); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-238) Initial CTest support
[ https://issues.apache.org/jira/browse/PROTON-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577866#comment-13577866 ] Cliff Jansen commented on PROTON-238: - See https://reviews.apache.org/r/9433 to view or download the patch. It's as small as I could make it. Initial CTest support - Key: PROTON-238 URL: https://issues.apache.org/jira/browse/PROTON-238 Project: Qpid Proton Issue Type: New Feature Components: proton-c Affects Versions: 0.3 Environment: Mainly proton-c and interop testing. Reporter: Cliff Jansen Assignee: Cliff Jansen This is a proposal for starting to use CMake's built in CTest capabilities in order to allow a unified test mechanism on multiple platforms. For the supplied review patch, it assumes that instead of using trunk/config.sh and calling proton-test directly, you do: cd path/to/trunk mkdir build cd build cmake .. make ctest Assuming the make succeeds, this will test two targets for now (proton-c and proton-jni), but the newer proposed tests (i.e. performance) can be added as well. Once the desired work flow is captured, this can be tweaked to run in a platform neutral way. CMake even has the capability to run CTest from inside the Visual Studio IDE. Concepts and strategies are stolen from the qpid/cpp tree. By default, you just get a brief summary of the tests. Also try ctest -V [ to see the full output ] ctest -N [ to list the available tests ] ctest -R proton-c [ just run the one test in this case, or a regexp if supplied ] ctest -E regexp [ run all tests except ones that match regexp ] Fancier tests can use cmake scripts to do things in a platform neutral manner (move files around), run the test from a different directory, etc. Python scripts and Java programs are already platform neutral, so there is no need to make changes for those. Tests can be conditionally configured (in the example proton-jni will not be configured if maven or java aren't found). Note that if you wish to just build and test proton-c, there is no requirement to build from within the specific directory .../trunk/build. This restriction currently exists for testing proton-jni using maven, but perhaps that can be relaxed in future. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-240) Incorrect encoding of described arrays.
Alan Conway created PROTON-240: -- Summary: Incorrect encoding of described arrays. Key: PROTON-240 URL: https://issues.apache.org/jira/browse/PROTON-240 Project: Qpid Proton Issue Type: Bug Components: proton-c Reporter: Alan Conway Assignee: Alan Conway The new interop test (tests/python/interop.py) are skipping the test for described arrays because it fails. To reproduce: remove the line raise Skipped() and run the tests with: . config.sh; tests/python/proton-test *.interop.* -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-240) Incorrect encoding of described arrays.
[ https://issues.apache.org/jira/browse/PROTON-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577934#comment-13577934 ] Rafael H. Schloming commented on PROTON-240: Is this possibly a duplicate of PROTON-232? Incorrect encoding of described arrays. --- Key: PROTON-240 URL: https://issues.apache.org/jira/browse/PROTON-240 Project: Qpid Proton Issue Type: Bug Components: proton-c Reporter: Alan Conway Assignee: Alan Conway The new interop test (tests/python/interop.py) are skipping the test for described arrays because it fails. To reproduce: remove the line raise Skipped() and run the tests with: . config.sh; tests/python/proton-test *.interop.* -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-232) described arrays seem to force the descriptor to be of the same type as the array
[ https://issues.apache.org/jira/browse/PROTON-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577959#comment-13577959 ] Alan Conway commented on PROTON-232: See PROTON-240, it provides a test case. described arrays seem to force the descriptor to be of the same type as the array - Key: PROTON-232 URL: https://issues.apache.org/jira/browse/PROTON-232 Project: Qpid Proton Issue Type: Bug Components: proton-c Reporter: Rafael H. Schloming Assignee: Rafael H. Schloming -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
