[jira] [Commented] (PROTON-465) FindPerlLibs.cmake module in Proton behaves differently to Qpid's Perl detection
[ https://issues.apache.org/jira/browse/PROTON-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151665#comment-14151665 ] ASF subversion and git services commented on PROTON-465: Commit 1628177 from [~mcpierce] in branch 'proton/trunk' [ https://svn.apache.org/r1628177 ] PROTON-465: FindPerlLibs fails on Ubuntu 12 If the search for libperl.so fails using the standard search in CMake, then this alternative tool kicks in and searchs other known locations for the file. > FindPerlLibs.cmake module in Proton behaves differently to Qpid's Perl > detection > > > Key: PROTON-465 > URL: https://issues.apache.org/jira/browse/PROTON-465 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.5 > Environment: Ubuntu 11.10 (at least) >Reporter: Fraser Adams >Assignee: Darryl L. Pierce >Priority: Minor > > With Proton when I do cmake .. it barfs with > -- Trying alternative search for Perl > -- PerlLibs Not Found > Though I can get it to play nicely by doing > cmake .. -DPERL_LIBRARY=`locate -n 1 libperl.so` > This might not be so unreasonable as I'm using a fairly old version of Ubuntu > that needs upgrading, however the Perl detection on Qpid works perfectly well > for me (and I'd assume for others too) which suggests that it's possibly more > thorough. > At the very least it would seem sensible to maintain consistency with the > cmake modules across various Qpid components. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (PROTON-465) FindPerlLibs.cmake module in Proton behaves differently to Qpid's Perl detection
[ https://issues.apache.org/jira/browse/PROTON-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce resolved PROTON-465. - Resolution: Fixed Fix Version/s: 0.8 > FindPerlLibs.cmake module in Proton behaves differently to Qpid's Perl > detection > > > Key: PROTON-465 > URL: https://issues.apache.org/jira/browse/PROTON-465 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.5 > Environment: Ubuntu 11.10 (at least) >Reporter: Fraser Adams >Assignee: Darryl L. Pierce >Priority: Minor > Fix For: 0.8 > > > With Proton when I do cmake .. it barfs with > -- Trying alternative search for Perl > -- PerlLibs Not Found > Though I can get it to play nicely by doing > cmake .. -DPERL_LIBRARY=`locate -n 1 libperl.so` > This might not be so unreasonable as I'm using a fairly old version of Ubuntu > that needs upgrading, however the Perl detection on Qpid works perfectly well > for me (and I'd assume for others too) which suggests that it's possibly more > thorough. > At the very least it would seem sensible to maintain consistency with the > cmake modules across various Qpid components. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PROTON-702) Windows proton-c selector can forget timer events
Cliff Jansen created PROTON-702: --- Summary: Windows proton-c selector can forget timer events Key: PROTON-702 URL: https://issues.apache.org/jira/browse/PROTON-702 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.8 Environment: Windows Reporter: Cliff Jansen Assignee: Cliff Jansen Fix For: 0.8 A pn_selector_update to the identical deadline value will turn off the timer notification. This causes several ctest failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-702) Windows proton-c selector can forget timer events
[ https://issues.apache.org/jira/browse/PROTON-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151877#comment-14151877 ] ASF subversion and git services commented on PROTON-702: Commit 1628215 from cliffjan...@apache.org in branch 'proton/trunk' [ https://svn.apache.org/r1628215 ] PROTON-702: mark interest in timer based on existence of deadline, not change in deadline > Windows proton-c selector can forget timer events > - > > Key: PROTON-702 > URL: https://issues.apache.org/jira/browse/PROTON-702 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.8 > Environment: Windows >Reporter: Cliff Jansen >Assignee: Cliff Jansen > Fix For: 0.8 > > > A pn_selector_update to the identical deadline value will turn off the timer > notification. > This causes several ctest failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (PROTON-702) Windows proton-c selector can forget timer events
[ https://issues.apache.org/jira/browse/PROTON-702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cliff Jansen resolved PROTON-702. - Resolution: Fixed > Windows proton-c selector can forget timer events > - > > Key: PROTON-702 > URL: https://issues.apache.org/jira/browse/PROTON-702 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.8 > Environment: Windows >Reporter: Cliff Jansen >Assignee: Cliff Jansen > Fix For: 0.8 > > > A pn_selector_update to the identical deadline value will turn off the timer > notification. > This causes several ctest failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (PROTON-648) Memory leaks on aborted connections.
[
https://issues.apache.org/jira/browse/PROTON-648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rafael H. Schloming resolved PROTON-648.
Resolution: Duplicate
Fix Version/s: 0.8
> Memory leaks on aborted connections.
>
>
> Key: PROTON-648
> URL: https://issues.apache.org/jira/browse/PROTON-648
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: 0.7, 0.8
>Reporter: Marcel Meulemans
>Assignee: Rafael H. Schloming
> Fix For: 0.8
>
> Attachments: leak.c
>
>
> When a connection is aborted, open sessions can not be ended and attached
> links can not be not detached properly. Because of this there are some
> references to connection/sessions/links that are not released properly:
> # The session state does not release references to links in the
> {{local_handles/remote_handles}} hash map. This causes a leak because the
> session references links and the links reference the session but the engine
> does have a reference to any of these objects anymore.
> # The transport does not release references to sessions in the
> {{local_channels/remote_channels}} hash map. This is not really a leak
> because the references are released in {{pn_transport_free}}, but i.m.o. they
> should be release when the connection is unbound from the transport, i.e.
> {{pn_unbind_transport()}}.
> The leak can be observed by using the attached test program with ActiveMQ.
> When ActiveMQ is shutdown with CTRL-C it just kills the connection causing a
> transport error (connection aborted) on the client side. When this happens
> the program leaks. See below for the program/valgrind output of the program
> with and without the patch.
> The patch can be found here:
> https://github.com/marcelmeulemans/qpid-proton/commit/e5300da7be015ea874248b6593040d1bd50ac0e3
> - The removed commented code in {{pn_session_finalize}} is the right idea in
> the wrong place; {{pn_session_finalize}} is never called because the
> references that this code releases still exist. The code has been moved to a
> new function {{pn_cleanup_session}} in the transport "class".
> - The {{pn_cleanup_session}} call from {{pn_remove_session}} is needed in the
> case the session is freed ({{pn_session_free}}) manually from application
> code.
> - The {{pn_cleanup_session}} call from {{pn_transport_unbind}} is needed in
> the case the session is automatically freed via the connection.
> - The changes in {{pn_session_close}} solve the real leak describe in *1*
> above.
> *Valgrind output without patch*:
> {noformat}
> ==5607== Memcheck, a memory error detector
> ==5607== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al.
> ==5607== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright info
> ==5607== Command: ./leak.symbols
> ==5607==
> Connected to 127.0.0.1:5672
> [0x6671b80]: -> SASL
> [0x6671b80]: <- SASL
> [0x6671b80]:0 <- @sasl-mechanisms(64)
> [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS, :PLAIN]]
> [0x6671b80]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, initial-response=b""]
> [0x6671b80]:0 <- @sasl-outcome(68) [code=0]
> [0x6671b80]: <- AMQP
> [0x6671b80]: -> AMQP
> [0x6671b80]:0 -> @open(16) [container-id="leak", hostname="leak"]
> [0x6671b80]:0 -> @begin(17) [next-outgoing-id=0, incoming-window=2147483647,
> outgoing-window=0]
> [0x6671b80]:0 -> @attach(18) [name="leak", handle=0, role=true,
> snd-settle-mode=0, rcv-settle-mode=1, source=@source(40)
> [address="queue://leak", durable=0, timeout=0, dynamic=false],
> target=@target(41) [address="queue://leak", durable=0, timeout=0,
> dynamic=false], initial-delivery-count=0]
> [0x6671b80]:0 -> @flow(19) [incoming-window=2147483647, next-outgoing-id=0,
> outgoing-window=0, handle=0, delivery-count=0, link-credit=8, drain=false]
> [0x6671b80]:0 <- @open(16) [container-id="", hostname="",
> max-frame-size=1048576]
> [0x6671b80]:0 <- @begin(17) [remote-channel=0, next-outgoing-id=1,
> incoming-window=0, outgoing-window=0, handle-max=1024]
> [0x6671b80]:0 <- @attach(18) [name="leak", handle=0, role=false,
> snd-settle-mode=2, rcv-settle-mode=0, source=@source(40)
> [address="queue://leak"], target=@target(41) [address="queue://leak"],
> incomplete-unsettled=false, initial-delivery-count=0]
> [0x6671b80]:0 -> @close(24) [error=@error(29)
> [condition=:"amqp:connection:framing-error"]]
> [0x6671b80]:ERROR amqp:connection:framing-error connection aborted
> [0x6671b80]:ERROR[-2] connection aborted
> [0x6671b80]: <- EOS
> [0x6671b80]: -> EOS (-2) connection aborted
> Closed 127.0.0.1:5672
> close: Bad file descriptor
> ==5607==
> ==5607== HEAP SUMMARY:
> ==5607== in use at exit: 14,904 bytes in 306 blocks
> ==5607== total heap usage: 508 allocs, 202 frees, 1,151,697 bytes allocated
> ==5607==
> ==5607== 14,90
[jira] [Commented] (PROTON-700) small performance improvement from inling one fn.
[ https://issues.apache.org/jira/browse/PROTON-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152149#comment-14152149 ] ASF subversion and git services commented on PROTON-700: Commit 1628274 from [~mgoulish] in branch 'proton/trunk' [ https://svn.apache.org/r1628274 ] PROTON-700 By not saying 'static' on previous checkin, I broke debug builds. > small performance improvement from inling one fn. > - > > Key: PROTON-700 > URL: https://issues.apache.org/jira/browse/PROTON-700 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: michael goulish >Assignee: michael goulish >Priority: Minor > > inlining the internal function pn_data_node() improves speed somewhere > between 2.6% and 6%, depending on architecture. > This is based on testing I did with two C-based clients written at the engine > interface level. > The higher 6% figure was seen on a more modern machine with recent Intel > processors, the lower figure was seen on an older box with AMD processors. > But the effect is real: after 5- repetition before the change & 50 after, > T-test indicates odds of this happening by chance is 2.0e-18 . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PROTON-703) inlining performance improvements
michael goulish created PROTON-703: -- Summary: inlining performance improvements Key: PROTON-703 URL: https://issues.apache.org/jira/browse/PROTON-703 Project: Qpid Proton Issue Type: Improvement Components: proton-c Reporter: michael goulish Assignee: michael goulish Priority: Minor omnibus jira for any other inlining performance improvements i may find. notes to self: * don't affect public APIs. * don't forget to test Debug build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-676) proton-c: transport layer SSL failures not propagated back to Messenger in pni_connection_readable
[ https://issues.apache.org/jira/browse/PROTON-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152212#comment-14152212 ] ASF subversion and git services commented on PROTON-676: Commit 1628292 from r...@apache.org in branch 'proton/trunk' [ https://svn.apache.org/r1628292 ] PROTON-676: applied patch from dominic > proton-c: transport layer SSL failures not propagated back to Messenger in > pni_connection_readable > -- > > Key: PROTON-676 > URL: https://issues.apache.org/jira/browse/PROTON-676 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans > Attachments: 24_ssl_transport_failure_fix_messenger.c.patch > > > When an ssl failure occurs during connection at the transport layer the error > is not propagated back to messenger (it is ignored). > Patch attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-676) proton-c: transport layer SSL failures not propagated back to Messenger in pni_connection_readable
[ https://issues.apache.org/jira/browse/PROTON-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152282#comment-14152282 ] ASF subversion and git services commented on PROTON-676: Commit 1628314 from [~astitcher] in branch 'proton/trunk' [ https://svn.apache.org/r1628314 ] PROTON-676: Removed file added in error > proton-c: transport layer SSL failures not propagated back to Messenger in > pni_connection_readable > -- > > Key: PROTON-676 > URL: https://issues.apache.org/jira/browse/PROTON-676 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans > Attachments: 24_ssl_transport_failure_fix_messenger.c.patch > > > When an ssl failure occurs during connection at the transport layer the error > is not propagated back to messenger (it is ignored). > Patch attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url
[ https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152286#comment-14152286 ] ASF subversion and git services commented on PROTON-693: Commit 1628315 from [~astitcher] in branch 'proton/trunk' [ https://svn.apache.org/r1628315 ] PROTON-693: If the system doesn't have port definitions for amqp/amqps use the default values of 5672/5671. - Not all systems have /etc/service (or similar) files that define these ports, but our tests use them and the defaults are these strings. > Python Url class to wrap C function pni_parse_url > - > > Key: PROTON-693 > URL: https://issues.apache.org/jira/browse/PROTON-693 > Project: Qpid Proton > Issue Type: Improvement > Components: python-binding >Affects Versions: 0.8 >Reporter: Alan Conway >Assignee: Alan Conway > Fix For: 0.8 > > > Add a Url class to the python binding that wraps the C function pni_url_parse. > Also added unit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Proton 0.8 RC1
Hi Everyone, I've created 0.8 RC1 and posted it in the usual locations. The source can be found here: http://people.apache.org/~rhs/qpid-proton-0.8rc1/ Java binaries are available here: https://repository.apache.org/content/repositories/orgapacheqpid-1015/ Please check it out and follow up with email and/or JIRAs as appropriate. Thanks, ---Rafael
[jira] [Commented] (PROTON-676) proton-c: transport layer SSL failures not propagated back to Messenger in pni_connection_readable
[ https://issues.apache.org/jira/browse/PROTON-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152440#comment-14152440 ] Robbie Gemmell commented on PROTON-676: --- The original commit on this JIRA, r1626980, looks to have actually contained the patches on PROTON-675. > proton-c: transport layer SSL failures not propagated back to Messenger in > pni_connection_readable > -- > > Key: PROTON-676 > URL: https://issues.apache.org/jira/browse/PROTON-676 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans > Attachments: 24_ssl_transport_failure_fix_messenger.c.patch > > > When an ssl failure occurs during connection at the transport layer the error > is not propagated back to messenger (it is ignored). > Patch attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-676) proton-c: transport layer SSL failures not propagated back to Messenger in pni_connection_readable
[ https://issues.apache.org/jira/browse/PROTON-676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-676: -- Assignee: Rafael H. Schloming > proton-c: transport layer SSL failures not propagated back to Messenger in > pni_connection_readable > -- > > Key: PROTON-676 > URL: https://issues.apache.org/jira/browse/PROTON-676 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Rafael H. Schloming > Attachments: 24_ssl_transport_failure_fix_messenger.c.patch > > > When an ssl failure occurs during connection at the transport layer the error > is not propagated back to messenger (it is ignored). > Patch attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-676) proton-c: transport layer SSL failures not propagated back to Messenger in pni_connection_readable
[ https://issues.apache.org/jira/browse/PROTON-676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-676: -- Fix Version/s: 0.8 > proton-c: transport layer SSL failures not propagated back to Messenger in > pni_connection_readable > -- > > Key: PROTON-676 > URL: https://issues.apache.org/jira/browse/PROTON-676 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Rafael H. Schloming > Fix For: 0.8 > > Attachments: 24_ssl_transport_failure_fix_messenger.c.patch > > > When an ssl failure occurs during connection at the transport layer the error > is not propagated back to messenger (it is ignored). > Patch attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-675) proton-c: Messenger doesn't provide a way of setting the SSL peer authentication mode
[
https://issues.apache.org/jira/browse/PROTON-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152441#comment-14152441
]
Robbie Gemmell commented on PROTON-675:
---
This commit against PROTON-676 seems to have contained the attached patches
from this JIRA:
{noformat}
Commit 1626980 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1626980 ]
PROTON-676: patch from dominic for setter for SSL peer authentication mode
{noformat}
> proton-c: Messenger doesn't provide a way of setting the SSL peer
> authentication mode
> -
>
> Key: PROTON-675
> URL: https://issues.apache.org/jira/browse/PROTON-675
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: 0.7
>Reporter: Dominic Evans
>Assignee: Rafael H. Schloming
> Fix For: 0.8
>
> Attachments:
> 23_add_messenger_set_ssl_peer_authentication_mode_method_messenger.c.patch,
> 23_add_messenger_set_ssl_peer_authentication_mode_method_messenger.h.patch
>
>
> Messenger doesn't provide a way of setting the SSL peer authentication mode
> when a trust certificate is being used (it is hardcoded to:
> PN_SSL_VERIFY_PEER_NAME). We want the option to be able to optionally
> specify PN_SSL_VERIFY_PEER instead.
> Patch attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
