Re: [VOTE] Release Qpid Proton 0.10 (RC3)
+1 Built visual studio (2008, 2010, 2012, 2013)(x86, x64). Ran tests against qpidd and activemq 5.12 brokers using qpid client auth. - Original Message - > From: "Robbie Gemmell" > To: us...@qpid.apache.org, proton@qpid.apache.org > Sent: Tuesday, August 11, 2015 4:08:01 PM > Subject: [VOTE] Release Qpid Proton 0.10 (RC3) > > Hi all, > > I have put up a third cut for 0.10, please test it and vote accordingly. > > Since RC2 there have been fixes for PROTON-978, PROTON-975, and PROTON-899. > > The release archive and sig/checksums can be grabbed from: > https://dist.apache.org/repos/dist/dev/qpid/proton/0.10-rc3/ > > Maven artifacts for the Java bits can be found in a temporary staging repo > at: > https://repository.apache.org/content/repositories/orgapacheqpid-1042 > > It is tagged as 0.10-rc3. You may need to fetch the tags explicitly to > see it, e.g: "git fetch --tags" > > Regards, > Robbie > > - > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org > >
Re: How to copy a pn_message?
On Mon, 2015-08-10 at 14:32 +, Dominic Evans wrote: > Hi Alan, > > -aconway wrote: - > > I don't see any pn_message_copy function in the proton library, is > > there an > > efficient way to make an independent copy of a message? I can > > encode and > > decode but that seems like a long way around. > > I actually had a patch lying around to add pn_message_copy() that I'd > been > using for a C++ wrapper, but never pushed upstream as I didn't know > if anyone > else would ever need it. > > Attached fwiw. > I need it, I am sure I am not alone! There's no attachment, probably stripped by the list, anyway it needs to be in a JIRA for legal checkbox. Please make one and assign it to me. Thanks! Cheers, Alan.
[jira] [Commented] (PROTON-949) proton doesn't build with ccache swig
[ https://issues.apache.org/jira/browse/PROTON-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682465#comment-14682465 ] Andrew Stitcher commented on PROTON-949: mailing list message with some info: http://qpid.2158936.n2.nabble.com/Heads-Up-Proton-master-can-t-be-built-with-ccache-swig-td7624358.html > proton doesn't build with ccache swig > - > > Key: PROTON-949 > URL: https://issues.apache.org/jira/browse/PROTON-949 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Reporter: michael goulish > > Thanks to aconway for finding this and saving me a day of madness and horror. > On freshly-downloaded proton tree, if I use this swig: >/usr/lib64/ccache/swig > the build fails this way: > qpid-proton/build/proton-c/bindings/python/cprotonPYTHON_wrap.c:4993:25: > error: 'PN_HANDLE' undeclared (first use in this function) > PNI_PYTRACER = *((PN_HANDLE *)(argp)); > -- > but if I delete that swig executable, and use the one in /bin/swig , > then everything works. > yikes. > aconway believes the bug is in ccache-swig, not in proton, but I want to put > this here in case this bites someone else in Proton Land. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [VOTE] Release Qpid Proton 0.10 (RC3)
+1 I tested proton-c against Dispatch Router. It all looks good. -Ted On 08/11/2015 04:08 PM, Robbie Gemmell wrote: Hi all, I have put up a third cut for 0.10, please test it and vote accordingly. Since RC2 there have been fixes for PROTON-978, PROTON-975, and PROTON-899. The release archive and sig/checksums can be grabbed from: https://dist.apache.org/repos/dist/dev/qpid/proton/0.10-rc3/ Maven artifacts for the Java bits can be found in a temporary staging repo at: https://repository.apache.org/content/repositories/orgapacheqpid-1042 It is tagged as 0.10-rc3. You may need to fetch the tags explicitly to see it, e.g: "git fetch --tags" Regards, Robbie
[jira] [Resolved] (PROTON-974) single symbol for mechanisms in sasl-mechanisms not recognised
[
https://issues.apache.org/jira/browse/PROTON-974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher resolved PROTON-974.
Resolution: Fixed
Fix Version/s: 0.11
0.10.1
> single symbol for mechanisms in sasl-mechanisms not recognised
> --
>
> Key: PROTON-974
> URL: https://issues.apache.org/jira/browse/PROTON-974
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: 0.10
>Reporter: Gordon Sim
>Assignee: Andrew Stitcher
> Fix For: 0.10.1, 0.11
>
>
> E.g. if a broker sends a sasl-mechanisms frame with a single symbol as the
> value of the mechanisms field, then it appears that the cyrus-sasl support in
> proton-c doesn't recognise that offered mechanism(?)
> {noformat}
> [0x2605d80]: -> SASL
> [0x2605d80]: <- SASL
> [0x2605d80]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS]
> [0x2605d80]:sasl error: SASL(-4): no mechanism available: No worthy mechs
> found
> [0x2605d80]:ERROR amqp:unauthorized-access Authentication failed
> [0x2605d80]: -> EOS
> ERROR:root:amqp:unauthorized-access: Authentication failed
> {noformat}
> From the spec, section 1.4:
> {quote}
> The multiple attribute of a field description controls whether multiple
> element values are permitted in the representation. A single element of the
> type specified in the field description is always permitted. Multiple values
> are represented by the use of an array where the type of the elements in the
> array is the type defined in the field definition.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-974) single symbol for mechanisms in sasl-mechanisms not recognised
[
https://issues.apache.org/jira/browse/PROTON-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682426#comment-14682426
]
ASF subversion and git services commented on PROTON-974:
Commit dd49dc9e7945a113c0cf89e2e5da3ada24f3d8a9 in qpid-proton's branch
refs/heads/0.10.x from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=dd49dc9 ]
PROTON-974: Accept a single symbol in SASL mechs frame
- As well as an array of symbols
- This is a specific interop issue with qpidd AMQP 1.0 support
> single symbol for mechanisms in sasl-mechanisms not recognised
> --
>
> Key: PROTON-974
> URL: https://issues.apache.org/jira/browse/PROTON-974
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: 0.10
>Reporter: Gordon Sim
>Assignee: Andrew Stitcher
>
> E.g. if a broker sends a sasl-mechanisms frame with a single symbol as the
> value of the mechanisms field, then it appears that the cyrus-sasl support in
> proton-c doesn't recognise that offered mechanism(?)
> {noformat}
> [0x2605d80]: -> SASL
> [0x2605d80]: <- SASL
> [0x2605d80]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS]
> [0x2605d80]:sasl error: SASL(-4): no mechanism available: No worthy mechs
> found
> [0x2605d80]:ERROR amqp:unauthorized-access Authentication failed
> [0x2605d80]: -> EOS
> ERROR:root:amqp:unauthorized-access: Authentication failed
> {noformat}
> From the spec, section 1.4:
> {quote}
> The multiple attribute of a field description controls whether multiple
> element values are permitted in the representation. A single element of the
> type specified in the field description is always permitted. Multiple values
> are represented by the use of an array where the type of the elements in the
> array is the type defined in the field definition.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-974) single symbol for mechanisms in sasl-mechanisms not recognised
[
https://issues.apache.org/jira/browse/PROTON-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682422#comment-14682422
]
ASF subversion and git services commented on PROTON-974:
Commit e47f671d79f51ee4374b113f3360b0d05f51d30f in qpid-proton's branch
refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=e47f671 ]
PROTON-974: Accept a single symbol in SASL mechs frame
- As well as an array of symbols
- This is a specific interop issue with qpidd AMQP 1.0 support
> single symbol for mechanisms in sasl-mechanisms not recognised
> --
>
> Key: PROTON-974
> URL: https://issues.apache.org/jira/browse/PROTON-974
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: 0.10
>Reporter: Gordon Sim
>Assignee: Andrew Stitcher
>
> E.g. if a broker sends a sasl-mechanisms frame with a single symbol as the
> value of the mechanisms field, then it appears that the cyrus-sasl support in
> proton-c doesn't recognise that offered mechanism(?)
> {noformat}
> [0x2605d80]: -> SASL
> [0x2605d80]: <- SASL
> [0x2605d80]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS]
> [0x2605d80]:sasl error: SASL(-4): no mechanism available: No worthy mechs
> found
> [0x2605d80]:ERROR amqp:unauthorized-access Authentication failed
> [0x2605d80]: -> EOS
> ERROR:root:amqp:unauthorized-access: Authentication failed
> {noformat}
> From the spec, section 1.4:
> {quote}
> The multiple attribute of a field description controls whether multiple
> element values are permitted in the representation. A single element of the
> type specified in the field description is always permitted. Multiple values
> are represented by the use of an array where the type of the elements in the
> array is the type defined in the field definition.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[VOTE] Release Qpid Proton 0.10 (RC3)
Hi all, I have put up a third cut for 0.10, please test it and vote accordingly. Since RC2 there have been fixes for PROTON-978, PROTON-975, and PROTON-899. The release archive and sig/checksums can be grabbed from: https://dist.apache.org/repos/dist/dev/qpid/proton/0.10-rc3/ Maven artifacts for the Java bits can be found in a temporary staging repo at: https://repository.apache.org/content/repositories/orgapacheqpid-1042 It is tagged as 0.10-rc3. You may need to fetch the tags explicitly to see it, e.g: "git fetch --tags" Regards, Robbie
[jira] [Updated] (PROTON-899) Unnecessary relative path in include
[ https://issues.apache.org/jira/browse/PROTON-899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-899: -- Fix Version/s: (was: 0.10.1) 0.10 Bringing back into 0.10 as we need a respin for another issue. > Unnecessary relative path in include > > > Key: PROTON-899 > URL: https://issues.apache.org/jira/browse/PROTON-899 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.9.1 >Reporter: Tomas Soltys >Assignee: Andrew Stitcher > Labels: easyfix, patch > Fix For: 0.10 > > Attachments: codec.c.patch, messenger.c.patch, transport.c.patch > > > Files: > proton-c/src/codec/codec.c > proton-c/src/messenger/messenger.c > proton-c/src/transport/transport.c > contain include with relative path: > #include "../log_private.h" > This is causing problem when porting on OpenVMS platform. > I suggest that above include should change to > #include "log_private.h" > There is no need to have "../" since compiler flags already contain include > path to directory where log_private.h resides. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[CANCELLED] [VOTE] Release Qpid Proton 0.10 (RC2)
I am cancelling the vote on the seconr RC for Proton 0.10, and will shortly be preparing a third RC. The changes in RC2 uncovered a issue, that while present previously was not causing an observable problem before hand but now does following the additional validation included in RC2 and this needs a fix. Additionally, the earlier issue with DIGEST-MD5 now has a fix available and this will also be picked up. Robbie
[jira] [Updated] (PROTON-975) connecting with DIGEST-MD5 fails if buffer containing outcome and first encrypted frame is received
[ https://issues.apache.org/jira/browse/PROTON-975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-975: -- Fix Version/s: (was: 0.10.1) 0.10 Bringing back in to 0.10 since we need a respin for another issue. > connecting with DIGEST-MD5 fails if buffer containing outcome and first > encrypted frame is received > --- > > Key: PROTON-975 > URL: https://issues.apache.org/jira/browse/PROTON-975 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.10 >Reporter: Ken Giusti >Assignee: Andrew Stitcher >Priority: Blocker > Fix For: 0.10 > > Attachments: send.py > > > I'm hitting an occasional client crash when using an DIGEST-MD5 SASL mech to > talk to the qpidd broker. > I've built the broker using the 0.10rc1 as the proton library. > I'm using a pyngus based client. I will upload this reproducer. > Best I can tell, the client pushes a single buffer to the transport that > contains both the SASL outcome frame from qpidd and the first encrypted > frame. SASL does not handle this case correctly and attempts to parse the > encrypted frame as cleartext. > I will open another bug against the frame decode to prevent parsing invalid > frames. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (PROTON-975) connecting with DIGEST-MD5 fails if buffer containing outcome and first encrypted frame is received
[ https://issues.apache.org/jira/browse/PROTON-975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-975. Resolution: Fixed > connecting with DIGEST-MD5 fails if buffer containing outcome and first > encrypted frame is received > --- > > Key: PROTON-975 > URL: https://issues.apache.org/jira/browse/PROTON-975 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.10 >Reporter: Ken Giusti >Assignee: Andrew Stitcher >Priority: Blocker > Fix For: 0.10.1 > > Attachments: send.py > > > I'm hitting an occasional client crash when using an DIGEST-MD5 SASL mech to > talk to the qpidd broker. > I've built the broker using the 0.10rc1 as the proton library. > I'm using a pyngus based client. I will upload this reproducer. > Best I can tell, the client pushes a single buffer to the transport that > contains both the SASL outcome frame from qpidd and the first encrypted > frame. SASL does not handle this case correctly and attempts to parse the > encrypted frame as cleartext. > I will open another bug against the frame decode to prevent parsing invalid > frames. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-978) Framing errors after SASL exchange when max-frame-size is configured
[ https://issues.apache.org/jira/browse/PROTON-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682306#comment-14682306 ] ASF subversion and git services commented on PROTON-978: Commit 3103ea7435bb5fce5b58176ebd362169351c16a8 in qpid-proton's branch refs/heads/0.10.x from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=3103ea7 ] PROTON-978: Fix server "pipelined" SASL frame read processing - Previously we were erroneously trying to process the AMQP header as a SASL frame. > Framing errors after SASL exchange when max-frame-size is configured > > > Key: PROTON-978 > URL: https://issues.apache.org/jira/browse/PROTON-978 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.10 >Reporter: Ted Ross >Priority: Blocker > Fix For: 0.10 > > Attachments: commit-0d2ef9f, commit-34b4c6d > > > Detected in Proton 0.10-RC2 > If the server side of a transport has a non-zero max-frame-size (e.g. 65536), > framing errors will occur between the SASL and AMQP sections of the > connection protocol because pn_read_frame will read the AMQP header as though > it were a frame. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-978) Framing errors after SASL exchange when max-frame-size is configured
[ https://issues.apache.org/jira/browse/PROTON-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682296#comment-14682296 ] ASF subversion and git services commented on PROTON-978: Commit cbba30d6908bc16c232bd760fa48c04240731c56 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=cbba30d ] PROTON-978: Fix server "pipelined" SASL frame read processing - Previously we were erroneously trying to process the AMQP header as a SASL frame. > Framing errors after SASL exchange when max-frame-size is configured > > > Key: PROTON-978 > URL: https://issues.apache.org/jira/browse/PROTON-978 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.10 >Reporter: Ted Ross >Priority: Blocker > Fix For: 0.10 > > Attachments: commit-0d2ef9f, commit-34b4c6d > > > Detected in Proton 0.10-RC2 > If the server side of a transport has a non-zero max-frame-size (e.g. 65536), > framing errors will occur between the SASL and AMQP sections of the > connection protocol because pn_read_frame will read the AMQP header as though > it were a frame. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-978) Framing errors after SASL exchange when max-frame-size is configured
[ https://issues.apache.org/jira/browse/PROTON-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682291#comment-14682291 ] Andrew Stitcher commented on PROTON-978: As far as I can tell this will happen on the server if the client is "pipelining" frames. That is it has sent AMQP header before it actually receives the SASL outcome frame. This is of entire legitimate behaviour, but the buggy behaviour seems bounded to this case. > Framing errors after SASL exchange when max-frame-size is configured > > > Key: PROTON-978 > URL: https://issues.apache.org/jira/browse/PROTON-978 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.10 >Reporter: Ted Ross >Priority: Blocker > Fix For: 0.10 > > Attachments: commit-0d2ef9f, commit-34b4c6d > > > Detected in Proton 0.10-RC2 > If the server side of a transport has a non-zero max-frame-size (e.g. 65536), > framing errors will occur between the SASL and AMQP sections of the > connection protocol because pn_read_frame will read the AMQP header as though > it were a frame. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-978) Framing errors after SASL exchange when max-frame-size is configured
[ https://issues.apache.org/jira/browse/PROTON-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross updated PROTON-978: Attachment: commit-34b4c6d Proposed patch that fixes the problem. > Framing errors after SASL exchange when max-frame-size is configured > > > Key: PROTON-978 > URL: https://issues.apache.org/jira/browse/PROTON-978 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.10 >Reporter: Ted Ross >Priority: Blocker > Fix For: 0.10 > > Attachments: commit-0d2ef9f, commit-34b4c6d > > > Detected in Proton 0.10-RC2 > If the server side of a transport has a non-zero max-frame-size (e.g. 65536), > framing errors will occur between the SASL and AMQP sections of the > connection protocol because pn_read_frame will read the AMQP header as though > it were a frame. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-978) Framing errors after SASL exchange when max-frame-size is configured
[ https://issues.apache.org/jira/browse/PROTON-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross updated PROTON-978: Attachment: commit-0d2ef9f Test update to detect the issue. > Framing errors after SASL exchange when max-frame-size is configured > > > Key: PROTON-978 > URL: https://issues.apache.org/jira/browse/PROTON-978 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.10 >Reporter: Ted Ross >Priority: Blocker > Fix For: 0.10 > > Attachments: commit-0d2ef9f, commit-34b4c6d > > > Detected in Proton 0.10-RC2 > If the server side of a transport has a non-zero max-frame-size (e.g. 65536), > framing errors will occur between the SASL and AMQP sections of the > connection protocol because pn_read_frame will read the AMQP header as though > it were a frame. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (PROTON-899) Unnecessary relative path in include
[
https://issues.apache.org/jira/browse/PROTON-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682268#comment-14682268
]
Tomas Soltys edited comment on PROTON-899 at 8/11/15 6:44 PM:
--
UNIX path
{{/path/to/dir1/../dir2}}
in OpenVMS world would look similar to this
{{U2:[path.to.dir1.-.dir2]}}
where U2 represents device (like C: in Windows)
Even though OpenVMS compiler claims that it does understand UNIX-style path
names, my experience is that it does not understand "..".
I was not able to find any documentation exactly stating that this is the
problem nor how the path should look like, but my trial-and-error approach
showed that when ".." is used in relative path compiler won't be able to find
the include.
was (Author: solttom):
UNIX path
/path/to/dir1/../dir2
in OpenVMS world would look similar to this
U2:[path.to.dir1.-.dir2]
where U2 represents device (like C: in Windows)
Even though OpenVMS compiler claims that it does understand UNIX-style path
names, my experience is that it does not understand "..".
I was not able to find any documentation exactly stating that this is the
problem nor how the path should look like, but my trial-and-error approach
showed that when ".." is used in relative path compiler won't be able to find
the include.
> Unnecessary relative path in include
>
>
> Key: PROTON-899
> URL: https://issues.apache.org/jira/browse/PROTON-899
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: 0.9.1
>Reporter: Tomas Soltys
>Assignee: Andrew Stitcher
> Labels: easyfix, patch
> Fix For: 0.10.1
>
> Attachments: codec.c.patch, messenger.c.patch, transport.c.patch
>
>
> Files:
> proton-c/src/codec/codec.c
> proton-c/src/messenger/messenger.c
> proton-c/src/transport/transport.c
> contain include with relative path:
> #include "../log_private.h"
> This is causing problem when porting on OpenVMS platform.
> I suggest that above include should change to
> #include "log_private.h"
> There is no need to have "../" since compiler flags already contain include
> path to directory where log_private.h resides.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (PROTON-978) Framing errors after SASL exchange when max-frame-size is configured
Ted Ross created PROTON-978: --- Summary: Framing errors after SASL exchange when max-frame-size is configured Key: PROTON-978 URL: https://issues.apache.org/jira/browse/PROTON-978 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.10 Reporter: Ted Ross Priority: Blocker Fix For: 0.10 Detected in Proton 0.10-RC2 If the server side of a transport has a non-zero max-frame-size (e.g. 65536), framing errors will occur between the SASL and AMQP sections of the connection protocol because pn_read_frame will read the AMQP header as though it were a frame. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-899) Unnecessary relative path in include
[ https://issues.apache.org/jira/browse/PROTON-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682268#comment-14682268 ] Tomas Soltys commented on PROTON-899: - UNIX path /path/to/dir1/../dir2 in OpenVMS world would look similar to this U2:[path.to.dir1.-.dir2] where U2 represents device (like C: in Windows) Even though OpenVMS compiler claims that it does understand UNIX-style path names, my experience is that it does not understand "..". I was not able to find any documentation exactly stating that this is the problem nor how the path should look like, but my trial-and-error approach showed that when ".." is used in relative path compiler won't be able to find the include. > Unnecessary relative path in include > > > Key: PROTON-899 > URL: https://issues.apache.org/jira/browse/PROTON-899 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.9.1 >Reporter: Tomas Soltys >Assignee: Andrew Stitcher > Labels: easyfix, patch > Fix For: 0.10.1 > > Attachments: codec.c.patch, messenger.c.patch, transport.c.patch > > > Files: > proton-c/src/codec/codec.c > proton-c/src/messenger/messenger.c > proton-c/src/transport/transport.c > contain include with relative path: > #include "../log_private.h" > This is causing problem when porting on OpenVMS platform. > I suggest that above include should change to > #include "log_private.h" > There is no need to have "../" since compiler flags already contain include > path to directory where log_private.h resides. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (PROTON-899) Unnecessary relative path in include
[ https://issues.apache.org/jira/browse/PROTON-899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher resolved PROTON-899. Resolution: Fixed > Unnecessary relative path in include > > > Key: PROTON-899 > URL: https://issues.apache.org/jira/browse/PROTON-899 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.9.1 >Reporter: Tomas Soltys >Assignee: Andrew Stitcher > Labels: easyfix, patch > Fix For: 0.10.1 > > Attachments: codec.c.patch, messenger.c.patch, transport.c.patch > > > Files: > proton-c/src/codec/codec.c > proton-c/src/messenger/messenger.c > proton-c/src/transport/transport.c > contain include with relative path: > #include "../log_private.h" > This is causing problem when porting on OpenVMS platform. > I suggest that above include should change to > #include "log_private.h" > There is no need to have "../" since compiler flags already contain include > path to directory where log_private.h resides. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-899) Unnecessary relative path in include
[ https://issues.apache.org/jira/browse/PROTON-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682152#comment-14682152 ] ASF subversion and git services commented on PROTON-899: Commit e87f6171921d9e02643edc9c2eb07da3d185c9b3 in qpid-proton's branch refs/heads/0.10.x from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=e87f617 ] PROTON-899: Changed relative includes to be "direct" Fix from Tomas Soltys > Unnecessary relative path in include > > > Key: PROTON-899 > URL: https://issues.apache.org/jira/browse/PROTON-899 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.9.1 >Reporter: Tomas Soltys >Assignee: Andrew Stitcher > Labels: easyfix, patch > Fix For: 0.10.1 > > Attachments: codec.c.patch, messenger.c.patch, transport.c.patch > > > Files: > proton-c/src/codec/codec.c > proton-c/src/messenger/messenger.c > proton-c/src/transport/transport.c > contain include with relative path: > #include "../log_private.h" > This is causing problem when porting on OpenVMS platform. > I suggest that above include should change to > #include "log_private.h" > There is no need to have "../" since compiler flags already contain include > path to directory where log_private.h resides. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-899) Unnecessary relative path in include
[ https://issues.apache.org/jira/browse/PROTON-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682146#comment-14682146 ] ASF subversion and git services commented on PROTON-899: Commit 0fc7bff9b76dad48fb48f881664b900488975323 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=0fc7bff ] PROTON-899: Changed relative includes to be "direct" Fix from Tomas Soltys > Unnecessary relative path in include > > > Key: PROTON-899 > URL: https://issues.apache.org/jira/browse/PROTON-899 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.9.1 >Reporter: Tomas Soltys >Assignee: Andrew Stitcher > Labels: easyfix, patch > Fix For: 0.10.1 > > Attachments: codec.c.patch, messenger.c.patch, transport.c.patch > > > Files: > proton-c/src/codec/codec.c > proton-c/src/messenger/messenger.c > proton-c/src/transport/transport.c > contain include with relative path: > #include "../log_private.h" > This is causing problem when porting on OpenVMS platform. > I suggest that above include should change to > #include "log_private.h" > There is no need to have "../" since compiler flags already contain include > path to directory where log_private.h resides. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-899) Unnecessary relative path in include
[ https://issues.apache.org/jira/browse/PROTON-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682137#comment-14682137 ] Andrew Stitcher commented on PROTON-899: Interesting - I noticed this issue some time back, back but thought it was purely aesthetic, so didn't do anything. For my general edification, can you say why it causes problems on OpenVMS. > Unnecessary relative path in include > > > Key: PROTON-899 > URL: https://issues.apache.org/jira/browse/PROTON-899 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.9.1 >Reporter: Tomas Soltys >Assignee: Andrew Stitcher > Labels: easyfix, patch > Fix For: 0.10.1 > > Attachments: codec.c.patch, messenger.c.patch, transport.c.patch > > > Files: > proton-c/src/codec/codec.c > proton-c/src/messenger/messenger.c > proton-c/src/transport/transport.c > contain include with relative path: > #include "../log_private.h" > This is causing problem when porting on OpenVMS platform. > I suggest that above include should change to > #include "log_private.h" > There is no need to have "../" since compiler flags already contain include > path to directory where log_private.h resides. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (PROTON-899) Unnecessary relative path in include
[ https://issues.apache.org/jira/browse/PROTON-899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher reassigned PROTON-899: -- Assignee: Andrew Stitcher > Unnecessary relative path in include > > > Key: PROTON-899 > URL: https://issues.apache.org/jira/browse/PROTON-899 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.9.1 >Reporter: Tomas Soltys >Assignee: Andrew Stitcher > Labels: easyfix, patch > Fix For: 0.10.1 > > Attachments: codec.c.patch, messenger.c.patch, transport.c.patch > > > Files: > proton-c/src/codec/codec.c > proton-c/src/messenger/messenger.c > proton-c/src/transport/transport.c > contain include with relative path: > #include "../log_private.h" > This is causing problem when porting on OpenVMS platform. > I suggest that above include should change to > #include "log_private.h" > There is no need to have "../" since compiler flags already contain include > path to directory where log_private.h resides. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [VOTE] Release Qpid Proton 0.10 (RC2)
-1 unfortunately. I've been testing against Dispatch and I'm seeing lots of timeouts on the tests. It turns out that pn_read_frame is used to parse text that is not a frame header. It's actually the AMQP header so it interprets the string "AMQP" as the frame length. Now that we're testing frames against the max-frame-size, this causes a framing error which drops the connection. It's interesting to note that this mis-parse is not a regression. It's been happening all along but was not noticed because "AMQP" is much larger than the typical number of available bytes. Before RC2, pn_read_frame would simply return zero for this non-frame and things muddled along more or less correctly. -Ted On 08/10/2015 02:34 PM, Robbie Gemmell wrote: Hi all, I have put up a second cut for 0.10, please test it and vote accordingly. This fixes a crash (PROTON-976) reported against the previous spin, and adds a known issue (PROTON-975) of possible failure using the DIGEST-MD5 mechanism against non-proton servers. The release archive and sig/checksums can be grabbed from: https://dist.apache.org/repos/dist/dev/qpid/proton/0.10-rc2/ Maven artifacts for the Java bits can be found in a temporary staging repo at: https://repository.apache.org/content/repositories/orgapacheqpid-1041 Regards, Robbie
[jira] [Commented] (PROTON-975) connecting with DIGEST-MD5 fails if buffer containing outcome and first encrypted frame is received
[ https://issues.apache.org/jira/browse/PROTON-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681983#comment-14681983 ] ASF subversion and git services commented on PROTON-975: Commit daba85301f0cf785ae07bf5f1ba1a580736c88cb in qpid-proton's branch refs/heads/0.10.x from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=daba853 ] PROTON-975: Fix to ensure that we switch to decrypting incoming frames early enough > connecting with DIGEST-MD5 fails if buffer containing outcome and first > encrypted frame is received > --- > > Key: PROTON-975 > URL: https://issues.apache.org/jira/browse/PROTON-975 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.10 >Reporter: Ken Giusti >Assignee: Andrew Stitcher >Priority: Blocker > Fix For: 0.10.1 > > Attachments: send.py > > > I'm hitting an occasional client crash when using an DIGEST-MD5 SASL mech to > talk to the qpidd broker. > I've built the broker using the 0.10rc1 as the proton library. > I'm using a pyngus based client. I will upload this reproducer. > Best I can tell, the client pushes a single buffer to the transport that > contains both the SASL outcome frame from qpidd and the first encrypted > frame. SASL does not handle this case correctly and attempts to parse the > encrypted frame as cleartext. > I will open another bug against the frame decode to prevent parsing invalid > frames. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-975) connecting with DIGEST-MD5 fails if buffer containing outcome and first encrypted frame is received
[ https://issues.apache.org/jira/browse/PROTON-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681909#comment-14681909 ] ASF subversion and git services commented on PROTON-975: Commit a1345a2788475b432ab34b209f1e92d0d2f6 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=a1345a2 ] PROTON-975: Fix to ensure that we switch to decrypting incoming frames early enough > connecting with DIGEST-MD5 fails if buffer containing outcome and first > encrypted frame is received > --- > > Key: PROTON-975 > URL: https://issues.apache.org/jira/browse/PROTON-975 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.10 >Reporter: Ken Giusti >Assignee: Andrew Stitcher >Priority: Blocker > Fix For: 0.10.1 > > Attachments: send.py > > > I'm hitting an occasional client crash when using an DIGEST-MD5 SASL mech to > talk to the qpidd broker. > I've built the broker using the 0.10rc1 as the proton library. > I'm using a pyngus based client. I will upload this reproducer. > Best I can tell, the client pushes a single buffer to the transport that > contains both the SASL outcome frame from qpidd and the first encrypted > frame. SASL does not handle this case correctly and attempts to parse the > encrypted frame as cleartext. > I will open another bug against the frame decode to prevent parsing invalid > frames. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-865) C++ reactor client binding
[ https://issues.apache.org/jira/browse/PROTON-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681879#comment-14681879 ] ASF subversion and git services commented on PROTON-865: Commit c84062aa5af6f02bf7dbfdc2c9550a8196665885 in qpid-proton's branch refs/heads/cjansen-cpp-client from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=c84062a ] PROTON-865: Update to-do list in README.md > C++ reactor client binding > -- > > Key: PROTON-865 > URL: https://issues.apache.org/jira/browse/PROTON-865 > Project: Qpid Proton > Issue Type: New Feature > Environment: C++ >Reporter: Cliff Jansen >Assignee: Cliff Jansen > > This JIRA tracks initial work on a C++ binding to the Proton reactor event > based model with an eye to providing an API very similar to the python > client. As stated on the Proton list, the broad goals are: > to make it easy to write simple programs > natural to build out more complicated ones > very similar API to the Python client > lean and performant > The initial introduction with accompanying HelloWorld can be found at > https://github.com/apache/qpid-proton/pull/18 > Ongoing work is proceeding in my github account in branch cpp-work > https://github.com/cliffjansen/qpid-proton/tree/cpp-work > commit 1453f57ca3f446450ef654505548f1947cb7a0f1 adds listener support, > exceptions and a logging interface. > The initial implementation will provide no thread safety guarantees, but the > bone structure should allow that to be added later with no API change. I > still hold out hope of eventually allowing multiple threads processing > separate connections concurrently. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [VOTE] Release Qpid Proton 0.10 (RC2)
On 10 August 2015 at 19:34, Robbie Gemmell wrote: > Hi all, > > I have put up a second cut for 0.10, please test it and vote accordingly. > > This fixes a crash (PROTON-976) reported against the previous spin, > and adds a known issue (PROTON-975) of possible failure using the > DIGEST-MD5 mechanism against non-proton servers. > > The release archive and sig/checksums can be grabbed from: > https://dist.apache.org/repos/dist/dev/qpid/proton/0.10-rc2/ > > Maven artifacts for the Java bits can be found in a temporary staging repo at: > https://repository.apache.org/content/repositories/orgapacheqpid-1041 > > Regards, > Robbie Making my +1 explicit. I gave things a kick of the tyres as follows: - Verified checksums ok. - Checked LICENCE and NOTICE present and look ok. - Ran the build and tests via Maven. - Ran the build/tests/install via CMake. - Built qpid-cpp 0.34 against the above install. - Ran the JMS client build+tests from master against the staging repo. - Ran the JMS client HelloWorld example against the earlier built 0.34 cpp broker. - Ran the ActiveMQ build + amqp tests from master using the staging repo. - Ran the python simple_send.py and simple_recv.py examples (via the CMake built proton-c) against the 0.34 broker, using the ANONYMOUS, PLAIN (without SSL), and SCRAM-SHA-1 SASL mechansims. - Used "python setup.py build install" to build python bindings and proton-c via python (2.7) and used simple_send_recv with that. Robbie
