Re: Best practices using proton-j Reactor

2016-02-04 Thread Robbie Gemmell 
Hi Sree,

I'm not too familiar with the Reactor bits, I've never used them
beyong the send/recv examples, but I'll try to answer what I can.
Perhaps other folks can chime in if they know more (even if based on
knowledge of the proton-c reactor). Responses inline.

On 3 February 2016 at 20:05, Garlapati Sreeram Kumar  wrote:
> Hello Folks!
>
> Couple of Questions on Proton-j Reactor usage-pattern:
>
> 1. In the current version of proton-j: 1 Reactor instance is tied to 1 
> connection – is there any way to associate 1 Reactor per Link.

I think its actually each Connection (and related bits) is tied to a
single Reactor rather than the reverse, but no I wouldnt expect you
can associate a different reactor (though you could perhaps associate
a different Handler) with each link since that would presumably
involve multiple threads.

The proton engine can only be used by a single thread at a time. This
essentially encompasses everything relating to a given Transport as a
group except for the Message objects (which themselves still need to
be accessed by 1 thread at a time) since they are formed seperately
either from scratch or from bytes taken from a Delivery. The reactor
bits are one implementation of achieving that single-threaded access.

> Or in other words, If there are multiple links attached to one Connection, 
> which is handled by one Reactor instance - What is the recommendation to use 
> reactor in such a way that One link will not impact others – the unhandled 
> exceptions and the time it takes to process.
> Here’s the Problem: When one of the links perform I/O upon any event 
> dispatched (ex: onDelivery) by the Reactor pump – all other links are 
> starving for messages as that I/O is blocking the thread in which 
> reactor.run() – which absolutely makes sense from Reactor pump (the 
> reactor.run()) perspective.
>

Do you mean for example taking a long time to process a particular
delivery before accepting/etc? I think the reactor is built around
assumption that events will be handled quickly. There does seem to be
support for scheduling tasks and inserting your own selectables, so
one approach might be to offload any long running processing of
deliveries to another thread and construct a way to monitor their
progress and then have the reactor take any subsequent action. In
terms of IO I would expect that to be non-blocking? I'm not sure what
exceptions you are referring to.

> 2. What is the Best way to gracefully Stop the Reactor.
> In our Tests – where we  are Starting a Reactor per testclass and calling 
> reactor.free as part of class cleanup – throws exception: 
> reactor:org.apache.qpid.proton.engine.HandlerException: 
> java.nio.channels.ClosedSelectorException
> Do we need to handle this by try-catch’ing the reactor.run() block ?
>

I'm not entirely sure about this. The examples mostly look to take
advantage of the reactor exiting once there is no outstanding work (no
scheduled tasks, and no other selectables to process (e.g for outgoing
connections, or an acceptor for incoming ones)). Anything that calls
free() does it from the thread running the reactor, right after run()
returns. The wakeup() method is noted in the javadoc as the only
method that can be safely called while another thread is still
processing the reactor.

> Thanks a lot for such a Wonderful Collaboration!
> Sree
>

[jira] [Commented] (PROTON-515) Port to OpenVMS

2016-02-04 Thread Tomas Soltys (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132258#comment-15132258
 ] 

Tomas Soltys commented on PROTON-515:
-

thanks for the patch. It works perfectly.

> Port to OpenVMS
> ---
>
> Key: PROTON-515
> URL: https://issues.apache.org/jira/browse/PROTON-515
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: 0.11.1
> Environment: OpenVMS
>Reporter: Tomas Soltys
>Assignee: Andrew Stitcher
>  Labels: OpenVMS, patch
> Attachments: 
> 0001-PROTON-515-Change-pn_handle_t-to-be-void-to-get-arou.patch, io.c.patch, 
> object.h.patch
>
>
> There is a need for proton-c port to OpenVMS platform.
> To make proton-c functional on OpenVMS few changes in the source code are 
> required.
> Here is list of files I have identified which require some attention:
> proton-c/src/platform_fmt.h
> proton-c/src/posix/driver.c
> proton-c/src/object/object.c
> proton-c/src/codec/codec.c



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Release Qpid Proton 0.12.0

2016-02-04 Thread Chuck Rolke 
Well spotted, Andrew.

proton-c/bindings/cpp/CMakeLists.txt install target qpid-proton-cpp needs 
RUNTIME DESTINATION

 install(TARGETS qpid-proton-cpp
   EXPORT  proton
   ARCHIVE DESTINATION ${LIB_INSTALL_DIR}
   LIBRARY DESTINATION ${LIB_INSTALL_DIR}
+  RUNTIME DESTINATION bin )

That puts the cpp DLLs in the install/bin folder

-C

- Original Message -
> From: "Andrew Stitcher" 
> To: proton@qpid.apache.org, us...@qpid.apache.org
> Sent: Thursday, February 4, 2016 2:31:36 PM
> Subject: Re: [VOTE] Release Qpid Proton 0.12.0
> 
> On Wed, 2016-02-03 at 07:10 -0800, Justin Ross wrote:
> > The artifacts proposed for release:
> > 
> > https://dist.apache.org/repos/dist/dev/qpid/proton/0.12.0-rc/
> > 
> > Please indicate your vote below.  If you favor releasing the 0.12.0
> > RC bits
> > as 0.12.0 GA, vote +1.  If you have reason to think the RC is not
> > ready for
> > release, vote -1.
> 
> -1
> 
> On windows the C++ binding library does not get installed on "make
> install" [1]. As the C++ binding is one of the big features for 0.12 I
> think we should respin to fix this.
> 
> Andrew
> 
> [1] https://issues.apache.org/jira/browse/PROTON-1127
> 
> 
> -
> To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org
> For additional commands, e-mail: users-h...@qpid.apache.org
> 
>

Query on Messenger API

2016-02-04 Thread Snehadeepa Snehanadhan 
Hi team,

  I have a requirement where I am trying to use Proton Messenger API to send 
and receive message between Java and NodeJS application. Send and receive works 
beautifully, however I have run into an issue where some messages are delayed 
(to the extend of a minute.. ), This happens quite frequently. Any thought on 
this? How can I improve on message delivery time.

- Thanks & Regards
Sneha.

Snehadeepa | Senior Developer | IDBS
sn...@idbs.com | +44 1483 595055 ext. 127 | 
www.idbs.com
2 Occam Court, Surrey Research Park, Guildford, Surrey, GU2 7QB, UK.
_

Powering Science for a Better Future
 Follow us on 
LinkedIn
 and Twitter

Re: [VOTE] Release Qpid Proton 0.12.0

2016-02-04 Thread Robbie Gemmell 
On 3 February 2016 at 15:10, Justin Ross  wrote:
> The artifacts proposed for release:
>
> https://dist.apache.org/repos/dist/dev/qpid/proton/0.12.0-rc/
>
> Please indicate your vote below.  If you favor releasing the 0.12.0 RC bits
> as 0.12.0 GA, vote +1.  If you have reason to think the RC is not ready for
> release, vote -1.
>
> Thanks,
> Justin

+1

I tested the RC out as follows:
 - Verified sigs and checksums.
 - Checked LICENCE+NOTICE present.
 - Ran the maven build, tests.
 - Ran the CMake build, tests, and install.
 - Built Qpid C++ trunk build against earlier install.
 - Built Qpid Dispatch master and 0.5 builds against against earlier install.
 - Used the staging repo to run the Qpid JMS master build and tests.
 - Used the staging repo to run the ActiveMQ master build and tests
(with the needed test updates).
 - Ran the JMS client HelloWorld example against the earlier built C++
broker, ActiveMQ broker, and Dispatch routers, as well as the 6.0.0
Qpid Java broker.

I didn't try qpid-cpp 0.34 against it, I assume the situtation there
hasn't changed since 0.12.0-beta. We might want to release note that
issue or mention it on the download page in some way to cover the
period until the next cpp release is available, I'll mention it on
PROTON-1050.

Robbie

[jira] [Commented] (PROTON-1126) Allow setting connection properties in BlockingConnection

2016-02-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132449#comment-15132449
 ] 

ASF GitHub Bot commented on PROTON-1126:


GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-proton/pull/64

PROTON-1126 - Allowed setting connection properties, offered_capabili…

…ties and desired_capabilities on BlockingConnection

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-proton PROTON-1126

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #64


commit ba05b7a10f9941f4e16359ff4b49020545ab3a36
Author: Ganesh Murthy 
Date:   2016-02-04T15:12:28Z

PROTON-1126 - Allowed setting connection properties, offered_capabilities 
and desired_capabilities on BlockingConnection




> Allow setting connection properties in BlockingConnection
> -
>
> Key: PROTON-1126
> URL: https://issues.apache.org/jira/browse/PROTON-1126
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.11.1
>Reporter: Ganesh Murthy
>Priority: Minor
> Fix For: 0.13.0
>
>
> The BlockingConnection class in proton/bindings/python/proton/utils.py does 
> not have a way to set the connection properties. 
> connection properties are sent as part of the AMQP open frame.
> Allow the connection properties to be set on the BlockingConnection



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] qpid-proton pull request: PROTON-1126 - Allowed setting connection...

2016-02-04 Thread ganeshmurthy 
GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-proton/pull/64

PROTON-1126 - Allowed setting connection properties, offered_capabili…

…ties and desired_capabilities on BlockingConnection

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-proton PROTON-1126

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #64


commit ba05b7a10f9941f4e16359ff4b49020545ab3a36
Author: Ganesh Murthy 
Date:   2016-02-04T15:12:28Z

PROTON-1126 - Allowed setting connection properties, offered_capabilities 
and desired_capabilities on BlockingConnection




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (PROTON-1050) 0.12.0 release tasks

2016-02-04 Thread Robbie Gemmell (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132459#comment-15132459
 ] 

Robbie Gemmell commented on PROTON-1050:


I think we should probably mention something somwhere (release notes and/or 
download page) about vthe very slight build issue  between proton 0.12.0 and 
qpid-cpp-0.34 given it wont be resolved out-the-box until the next cpp release 
is available.

http://mail-archives.apache.org/mod_mbox/qpid-proton/201601.mbox/%3CCAFitrpRam52e2NH_pSL8zxgQ5G1MBC-X0WGLmbGHBVpw-NgOxg%40mail.gmail.com%3E

> 0.12.0 release tasks
> 
>
> Key: PROTON-1050
> URL: https://issues.apache.org/jira/browse/PROTON-1050
> Project: Qpid Proton
>  Issue Type: Task
>  Components: release
>Reporter: Justin Ross
>Assignee: Justin Ross
> Fix For: 0.12.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (PROTON-1128) [C++ binding] Symbol exports use wrong directive for proton::condition

2016-02-04 Thread Andrew Stitcher (JIRA) 
Andrew Stitcher created PROTON-1128:
---

 Summary: [C++ binding] Symbol exports use wrong directive for 
proton::condition
 Key: PROTON-1128
 URL: https://issues.apache.org/jira/browse/PROTON-1128
 Project: Qpid Proton
  Issue Type: Bug
  Components: cpp-binding
Affects Versions: 0.12.0
Reporter: Andrew Stitcher
Assignee: Andrew Stitcher
Priority: Minor


The C++ binding API header file incorrectly uses PN_CPP_EXPORT rather than 
PN_CPP_EXTERN.

In theory on Windows (the only system where these directives are currently 
active) this could mean that user programs using the proton::condition API 
would be unable to do so as the program would be exporting the API rather than 
importing it.

However in limited tests using VS 2015 it doesn't seem to actually be causing a 
problem.

It may be that it is problematic in other (earlier) VS compilers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PROTON-1128) [C++ binding] Symbol exports use wrong directive for proton::condition

2016-02-04 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132831#comment-15132831
 ] 

ASF subversion and git services commented on PROTON-1128:
-

Commit 4ea3d26257ff5f707dfd7b44214ad22857d7b364 in qpid-proton's branch 
refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=4ea3d26 ]

PROTON-1128: [C++ binding] Fix incorrect symbol export declaration.


> [C++ binding] Symbol exports use wrong directive for proton::condition
> --
>
> Key: PROTON-1128
> URL: https://issues.apache.org/jira/browse/PROTON-1128
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: 0.12.0
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Minor
>
> The C++ binding API header file incorrectly uses PN_CPP_EXPORT rather than 
> PN_CPP_EXTERN.
> In theory on Windows (the only system where these directives are currently 
> active) this could mean that user programs using the proton::condition API 
> would be unable to do so as the program would be exporting the API rather 
> than importing it.
> However in limited tests using VS 2015 it doesn't seem to actually be causing 
> a problem.
> It may be that it is problematic in other (earlier) VS compilers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Release Qpid Proton 0.12.0

2016-02-04 Thread Andrew Stitcher 
On Wed, 2016-02-03 at 07:10 -0800, Justin Ross wrote:
> The artifacts proposed for release:
> 
> https://dist.apache.org/repos/dist/dev/qpid/proton/0.12.0-rc/
> 
> Please indicate your vote below.  If you favor releasing the 0.12.0
> RC bits
> as 0.12.0 GA, vote +1.  If you have reason to think the RC is not
> ready for
> release, vote -1.

-1

On windows the C++ binding library does not get installed on "make
install" [1]. As the C++ binding is one of the big features for 0.12 I
think we should respin to fix this.

Andrew

[1] https://issues.apache.org/jira/browse/PROTON-1127

RFI in 0.12 PROTON-1127: Install C++ binding library correctly

2016-02-04 Thread Andrew Stitcher 
Simple 1 line fix to the CMakefiles; looks bad for C++ on Windows if we
don't fix this!

https://issues.apache.org/jira/browse/PROTON-1127

Andrew

Re: [VOTE] Release Qpid Proton 0.12.0

2016-02-04 Thread Jakub Scholz 
+1

- I checked the JMS client with 0.12.0-rc against MRG-M 3.2 and against
Qpid C++ broker (trunk with 0.12.0-rc)
- I checked the Qpid Messaging C++ client build with 0.12.0-rc against
MRG-M 3.0

On Wed, Feb 3, 2016 at 4:10 PM, Justin Ross  wrote:

> The artifacts proposed for release:
>
> https://dist.apache.org/repos/dist/dev/qpid/proton/0.12.0-rc/
>
> Please indicate your vote below.  If you favor releasing the 0.12.0 RC bits
> as 0.12.0 GA, vote +1.  If you have reason to think the RC is not ready for
> release, vote -1.
>
> Thanks,
> Justin
>

[jira] [Created] (PROTON-1127) [Windows] qpid-proton-cpp.dll not installed by "make install" target

2016-02-04 Thread Andrew Stitcher (JIRA) 
Andrew Stitcher created PROTON-1127:
---

 Summary: [Windows] qpid-proton-cpp.dll not installed by "make 
install" target
 Key: PROTON-1127
 URL: https://issues.apache.org/jira/browse/PROTON-1127
 Project: Qpid Proton
  Issue Type: Bug
  Components: cpp-binding
Affects Versions: 0.12.0
 Environment: Windows MSVC
Reporter: Andrew Stitcher
Assignee: Andrew Stitcher
 Fix For: 0.12.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (PROTON-1125) c++: core dump on empty address in link options

2016-02-04 Thread Robbie Gemmell (JIRA) 

 [ 
https://issues.apache.org/jira/browse/PROTON-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated PROTON-1125:
---
Affects Version/s: 0.12.0
Fix Version/s: (was: 0.12.0)
   0.13.0
   0.12.1

Updating the versions to reflect that the commit missed the 0.12.0 RC currently 
under vote, and so would actually be in either a 0.12.1 (if it occurs) or else 
0.13.0 unless a respin becomes necessary that lets it be included in 0.12.0.

> c++: core dump on empty address in link options
> ---
>
> Key: PROTON-1125
> URL: https://issues.apache.org/jira/browse/PROTON-1125
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: 0.11.1, 0.12.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Blocker
> Fix For: 0.12.1, 0.13.0
>
>
> See:
> https://scan4.coverity.com/reports.htm#v14284/p10556/fileInstanceId=8369775=1901068=122279=1901068-29
> This is just the core dump on empty address fix from proton-1122, separated 
> for 0,12 release.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [VOTE] Release Qpid Proton 0.12.0

2016-02-04 Thread Michael Goulish 
+1

Testing done:  I used it with all of my performance tests:

  * point-to-point communication with C and CPP clients.
  * many CPP senders and receivers intermediated by a router

The CPP clients exercise the proton::handler event interface.






- Original Message -
The artifacts proposed for release:

https://dist.apache.org/repos/dist/dev/qpid/proton/0.12.0-rc/

Please indicate your vote below.  If you favor releasing the 0.12.0 RC bits
as 0.12.0 GA, vote +1.  If you have reason to think the RC is not ready for
release, vote -1.

Thanks,
Justin

[jira] [Commented] (PROTON-1127) [Windows] qpid-proton-cpp.dll not installed by "make install" target

2016-02-04 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132691#comment-15132691
 ] 

ASF subversion and git services commented on PROTON-1127:
-

Commit 135aebb2bc87ff792a4019651d380b5044f8acff in qpid-proton's branch 
refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=135aebb ]

PROTON-1127: [C++ binding] Install qpid-proton-cpp.dll


> [Windows] qpid-proton-cpp.dll not installed by "make install" target
> 
>
> Key: PROTON-1127
> URL: https://issues.apache.org/jira/browse/PROTON-1127
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: 0.12.0
> Environment: Windows MSVC
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
> Fix For: 0.12.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PROTON-1126) Allow setting connection properties in BlockingConnection

2016-02-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132953#comment-15132953
 ] 

ASF GitHub Bot commented on PROTON-1126:


Github user grs commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/64#discussion_r51931527
  
--- Diff: proton-c/bindings/python/proton/reactor.py ---
@@ -671,7 +671,11 @@ def connect(self, url=None, urls=None, address=None, 
handler=None, reconnect=Non
 """
 conn = self.connection(handler)
 conn.container = self.container_id or str(generate_uuid())
-
+
+conn.offered_capabilities = kwargs.get('offered_capabilities')
+conn.desired_capabilities = kwargs.get('desired_capabilities')
+conn.properties = kwargs.get('properties')
--- End diff --

looks good


> Allow setting connection properties in BlockingConnection
> -
>
> Key: PROTON-1126
> URL: https://issues.apache.org/jira/browse/PROTON-1126
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.11.1
>Reporter: Ganesh Murthy
>Priority: Minor
> Fix For: 0.13.0
>
>
> The BlockingConnection class in proton/bindings/python/proton/utils.py does 
> not have a way to set the connection properties. 
> connection properties are sent as part of the AMQP open frame.
> Allow the connection properties to be set on the BlockingConnection



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] qpid-proton pull request: PROTON-1126 - Allowed setting connection...

2016-02-04 Thread grs 
Github user grs commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/64#discussion_r51931488
  
--- Diff: proton-c/bindings/python/proton/__init__.py ---
@@ -2445,10 +2445,10 @@ def wrap(impl):
 else:
   return Connection(impl)
 
-  def __init__(self, impl = pn_connection):
+  def __init__(self, impl=pn_connection):
 Wrapper.__init__(self, impl, pn_connection_attachments)
 
-  def _init(self):
+  def _init(self, **kwargs):
--- End diff --

don't need this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (PROTON-1126) Allow setting connection properties in BlockingConnection

2016-02-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132951#comment-15132951
 ] 

ASF GitHub Bot commented on PROTON-1126:


Github user grs commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/64#discussion_r51931488
  
--- Diff: proton-c/bindings/python/proton/__init__.py ---
@@ -2445,10 +2445,10 @@ def wrap(impl):
 else:
   return Connection(impl)
 
-  def __init__(self, impl = pn_connection):
+  def __init__(self, impl=pn_connection):
 Wrapper.__init__(self, impl, pn_connection_attachments)
 
-  def _init(self):
+  def _init(self, **kwargs):
--- End diff --

don't need this


> Allow setting connection properties in BlockingConnection
> -
>
> Key: PROTON-1126
> URL: https://issues.apache.org/jira/browse/PROTON-1126
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.11.1
>Reporter: Ganesh Murthy
>Priority: Minor
> Fix For: 0.13.0
>
>
> The BlockingConnection class in proton/bindings/python/proton/utils.py does 
> not have a way to set the connection properties. 
> connection properties are sent as part of the AMQP open frame.
> Allow the connection properties to be set on the BlockingConnection



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] qpid-proton pull request: PROTON-1126 - Allowed setting connection...

2016-02-04 Thread grs 
Github user grs commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/64#discussion_r51931527
  
--- Diff: proton-c/bindings/python/proton/reactor.py ---
@@ -671,7 +671,11 @@ def connect(self, url=None, urls=None, address=None, 
handler=None, reconnect=Non
 """
 conn = self.connection(handler)
 conn.container = self.container_id or str(generate_uuid())
-
+
+conn.offered_capabilities = kwargs.get('offered_capabilities')
+conn.desired_capabilities = kwargs.get('desired_capabilities')
+conn.properties = kwargs.get('properties')
--- End diff --

looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] qpid-proton pull request: PROTON-1126 - Allowed setting connection...

2016-02-04 Thread grs 
Github user grs commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/64#discussion_r51931427
  
--- Diff: proton-c/bindings/python/proton/__init__.py ---
@@ -2445,10 +2445,10 @@ def wrap(impl):
 else:
   return Connection(impl)
 
-  def __init__(self, impl = pn_connection):
+  def __init__(self, impl=pn_connection):
--- End diff --

don't need this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (PROTON-1126) Allow setting connection properties in BlockingConnection

2016-02-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132949#comment-15132949
 ] 

ASF GitHub Bot commented on PROTON-1126:


Github user grs commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/64#discussion_r51931427
  
--- Diff: proton-c/bindings/python/proton/__init__.py ---
@@ -2445,10 +2445,10 @@ def wrap(impl):
 else:
   return Connection(impl)
 
-  def __init__(self, impl = pn_connection):
+  def __init__(self, impl=pn_connection):
--- End diff --

don't need this


> Allow setting connection properties in BlockingConnection
> -
>
> Key: PROTON-1126
> URL: https://issues.apache.org/jira/browse/PROTON-1126
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.11.1
>Reporter: Ganesh Murthy
>Priority: Minor
> Fix For: 0.13.0
>
>
> The BlockingConnection class in proton/bindings/python/proton/utils.py does 
> not have a way to set the connection properties. 
> connection properties are sent as part of the AMQP open frame.
> Allow the connection properties to be set on the BlockingConnection



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] qpid-proton pull request: PROTON-1126 - Allowed setting connection...

2016-02-04 Thread grs 
Github user grs commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/64#discussion_r51931699
  
--- Diff: tests/python/proton_tests/utils.py ---
@@ -72,6 +76,24 @@ def wait(self):
 self.event.wait(self.timeout)
 
 
+class ConnPropertiesServer(EchoServer):
+ def __init__(self, url, timeout):
+EchoServer.__init__(self, url, timeout)
+self.properties_received = False
+self.offered_capabilities_received = False
+self.desired_capabilities_received = False
+
+ def on_link_opening(self, event):
--- End diff --

this is fine; could also be on_connection_opening which might be clearer in 
intent, but this works also


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (PROTON-1126) Allow setting connection properties in BlockingConnection

2016-02-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132956#comment-15132956
 ] 

ASF GitHub Bot commented on PROTON-1126:


Github user grs commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/64#discussion_r51931699
  
--- Diff: tests/python/proton_tests/utils.py ---
@@ -72,6 +76,24 @@ def wait(self):
 self.event.wait(self.timeout)
 
 
+class ConnPropertiesServer(EchoServer):
+ def __init__(self, url, timeout):
+EchoServer.__init__(self, url, timeout)
+self.properties_received = False
+self.offered_capabilities_received = False
+self.desired_capabilities_received = False
+
+ def on_link_opening(self, event):
--- End diff --

this is fine; could also be on_connection_opening which might be clearer in 
intent, but this works also


> Allow setting connection properties in BlockingConnection
> -
>
> Key: PROTON-1126
> URL: https://issues.apache.org/jira/browse/PROTON-1126
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: 0.11.1
>Reporter: Ganesh Murthy
>Priority: Minor
> Fix For: 0.13.0
>
>
> The BlockingConnection class in proton/bindings/python/proton/utils.py does 
> not have a way to set the connection properties. 
> connection properties are sent as part of the AMQP open frame.
> Allow the connection properties to be set on the BlockingConnection



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)