GitHub user rkuska opened a pull request:

    https://github.com/apache/qpid-proton/pull/69

    Preserve environment variables when running Popen.

    `Popen` does not inherit environment variables of current process
    when run with `env` argument defined (and not None). We therefore
    pass copy of the current environment with PYTHONPATH modified to
    our needs.
    
    
    See:
    ```
    >>> subprocess.Popen('/usr/bin/echo $LD_LIBRARY_PATH', shell=True, 
env={'PYTHONPATH': '.'}, stdout=subprocess.PIPE).stdout.read()
    b'\n'
    >>> subprocess.Popen('/usr/bin/echo $LD_LIBRARY_PATH', shell=True, 
stdout=subprocess.PIPE).stdout.read()
    b'/opt/rh/rh-python34/root/usr/lib64\n'
    ```
    
    This may lead to failure when trying to install python bindings of 
qpid-proton.
    https://bugzilla.redhat.com/show_bug.cgi?id=1312590

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rkuska/qpid-proton master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton/pull/69.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #69
    
----
commit bbb42e7d933298fa4cc8036aeb6a7da7e53fe078
Author: Robert Kuska <rku...@redhat.com>
Date:   2016-03-02T09:31:05Z

    Preserve environment variables when running Popen.
    
    `Popen` does not inherit environment variables of current process
    when run with `env` argument defined (and not None). We therefore
    pass copy of the current environment with PYTHONPATH modified to
    our needs.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to