[GitHub] qpid-proton pull request: [PROTON-1096]: expose seting MessageForm...
Github user tourili commented on the pull request: https://github.com/apache/qpid-proton/pull/53#issuecomment-172977081 Thank you. Sorry for hijacking this thread. I am answering you on the mailing list... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: [PROTON-1096]: expose seting MessageForm...
Github user gemmellr commented on the pull request: https://github.com/apache/qpid-proton/pull/53#issuecomment-172958834 I have replied to your thread on the mailing list, please keep general discussion there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: [PROTON-1096]: expose seting MessageForm...
Github user tourili commented on the pull request: https://github.com/apache/qpid-proton/pull/53#issuecomment-172944770 Hi I have a question about the proton-j. Is proton-j a valid option for developing **android client** to connect to **azure service bus**. Please if any one can confirm a way or another to acheive this. I appreciate a lot Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: [PROTON-1096]: expose seting MessageForm...
Github user gemmellr commented on the pull request: https://github.com/apache/qpid-proton/pull/53#issuecomment-172938973 Hi Sreeram, As you might have already seen from the JIRA update or commit just now, I have made a further update here to go back to using an int to carry the 32bit value for the message format. My change to use a long had caused some compatibility issues that I don't think it is important enough a change to warrant, so I've put it back to the int. If you were just using an int (as your original PR would have needed), or perhaps explicitly casting a long to int, then you shouldnt have to change anything, but if you were now passing in a long directly after the earlier changes you will need to make some updates too, in which case apologies for any hassle caused. Robbie --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: [PROTON-1096]: expose seting MessageForm...
Github user SreeramGarlapati commented on the pull request: https://github.com/apache/qpid-proton/pull/53#issuecomment-173046439 Not a problem Robbie! Will merge this soon. Thanks for the Update! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: [PROTON-1096]: expose seting MessageForm...
Github user gemmellr commented on the pull request: https://github.com/apache/qpid-proton/pull/53#issuecomment-171342712 Hi Sreeram, I have made some changes that should let you do what you want. They change the API a little by usling a long to make it more intuitive (the message-format field is an unsigned int) and also implement the incoming side so that [proton-j] recievers can inspect the value should it have been adjusted. Robbie As an aside, some hints/tips regarding the Apache<->GitHub integration: If you create a JIRA before the pull request and include the JIRA key in the PR title then a bot will update the JIRA with notice of creation of the PR, and also seperately for any comments made on the PR. If you also include the JIRA key in any commits, then if they are merged as-is their details will be added as a comment on JIRA when pushed to the ASF repo, helping keep the details together for later reference. For example, see #6 and its associated JIRA PROTON 814 (missed out the dash to avoid it being updated). (mentioning PROTON-1096 here to have the bot update it too) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: [PROTON-1096]: expose seting MessageForm...
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: [PROTON-1096]: expose seting MessageForm...
Github user SreeramGarlapati commented on the pull request: https://github.com/apache/qpid-proton/pull/53#issuecomment-171362388 Awesome! Thanks a lot Robbie. Details about JIRA integration is helpful. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
