[jira] [Comment Edited] (PROTON-1042) Can't distinguish between null target and null address on a target
[ https://issues.apache.org/jira/browse/PROTON-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998492#comment-14998492 ] Robbie Gemmell edited comment on PROTON-1042 at 11/10/15 12:34 PM: --- I would like to request this change for inclusion in 0.11.0. Without the change Gordon made, it isn't possible for components using proton-c to distinguish between whether an arriving link attach frame had no target, or no address in its target. This distinction is crucial for supporting the anonymous relay node and ensuring the proper attach response is sent to clients (e.g see issued caused noted on QPID-6754 and DISPATCH-192). I have tested the change by applying it to the first RC and using it with qpidd tuink, dispatch 0.5, and dispatch master. was (Author: gemmellr): I would like to request this change for inclusion in 0.11.0. Without the change Gordon made, it isn't possible for components using proton to distinguish between whether an arriving link attach frame had no target, or no address in its target. This distinction is crucial for supporting the anonymous relay node and ensuring the proper attach response is sent to clients (e.g see issued caused noted on QPID-6754 and DISPATCH-192). I have tested the change by applying it to the first RC and using it with qpidd tuink, dispatch 0.5, and dispatch master. > Can't distinguish between null target and null address on a target > -- > > Key: PROTON-1042 > URL: https://issues.apache.org/jira/browse/PROTON-1042 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.11 >Reporter: Gordon Sim >Assignee: Gordon Sim > Fix For: 0.12.0 > > > In both cases pn_terminus_get_type() returns PN_UNSPECIFIED. Looking at the > source for pn_do_attach() in transport.c, it appears that 'target' is used to > hold the target address and if that is not specified (and the target is not > a coordinator, it is left as unspecified). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (PROTON-1042) Can't distinguish between null target and null address on a target
[ https://issues.apache.org/jira/browse/PROTON-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998492#comment-14998492 ] Robbie Gemmell edited comment on PROTON-1042 at 11/10/15 12:34 PM: --- I would like to request this change for inclusion in 0.11.0. Without the change Gordon made, it isn't possible for components using proton-c to distinguish between whether an arriving link attach frame had no target, or no address in its target. This distinction is crucial for supporting the anonymous relay node and ensuring the proper attach response is sent to clients (e.g see issued caused noted on QPID-6754 and DISPATCH-192). I have tested the change by applying it to the first RC and using it with qpidd trunk, dispatch 0.5, and dispatch master. was (Author: gemmellr): I would like to request this change for inclusion in 0.11.0. Without the change Gordon made, it isn't possible for components using proton-c to distinguish between whether an arriving link attach frame had no target, or no address in its target. This distinction is crucial for supporting the anonymous relay node and ensuring the proper attach response is sent to clients (e.g see issued caused noted on QPID-6754 and DISPATCH-192). I have tested the change by applying it to the first RC and using it with qpidd tuink, dispatch 0.5, and dispatch master. > Can't distinguish between null target and null address on a target > -- > > Key: PROTON-1042 > URL: https://issues.apache.org/jira/browse/PROTON-1042 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.11 >Reporter: Gordon Sim >Assignee: Gordon Sim > Fix For: 0.12.0 > > > In both cases pn_terminus_get_type() returns PN_UNSPECIFIED. Looking at the > source for pn_do_attach() in transport.c, it appears that 'target' is used to > hold the target address and if that is not specified (and the target is not > a coordinator, it is left as unspecified). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
