[jira] [Resolved] (PROTON-967) [proton-j] make empty frame logging actually mention that it is an empty frame.
[ https://issues.apache.org/jira/browse/PROTON-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved PROTON-967. --- Resolution: Fixed > [proton-j] make empty frame logging actually mention that it is an empty > frame. > --- > > Key: PROTON-967 > URL: https://issues.apache.org/jira/browse/PROTON-967 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: 0.9.1 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 0.10 > > > The empty frame logging (when it happens, PROTON-966) currently just logs > "null", which isn't particularly clear that it means an empty frame. We > should update it to actually say "Empty Frame". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-967) [proton-j] make empty frame logging actually mention that it is an empty frame.
[ https://issues.apache.org/jira/browse/PROTON-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647484#comment-14647484 ] ASF subversion and git services commented on PROTON-967: Commit 77fa91e9cdbc640ffd67d331d3553d3e5060865e in qpid-proton's branch refs/heads/master from Robert Gemmell [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=77fa91e ] PROTON-966, PROTON-967: add EmptyFrame body and pass to frame handler like any other. Utilise this to make empty frame logging/tracing actually say Empty Frame instead of just null. > [proton-j] make empty frame logging actually mention that it is an empty > frame. > --- > > Key: PROTON-967 > URL: https://issues.apache.org/jira/browse/PROTON-967 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: 0.9.1 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 0.10 > > > The empty frame logging (when it happens, PROTON-966) currently just logs > "null", which isn't particularly clear that it means an empty frame. We > should update it to actually say "Empty Frame". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-967) [proton-j] make empty frame logging actually mention that it is an empty frame.
[ https://issues.apache.org/jira/browse/PROTON-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-967: -- Summary: [proton-j] make empty frame logging actually mention that it is an empty frame. (was: make empty frame logging actually mention that it is an empty frame.) > [proton-j] make empty frame logging actually mention that it is an empty > frame. > --- > > Key: PROTON-967 > URL: https://issues.apache.org/jira/browse/PROTON-967 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: 0.9.1 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 0.10 > > > The empty frame logging (when it happens, PROTON-966) currently just logs > "null", which isn't particularly clear that it means an empty frame. We > should update it to actually say "Empty Frame". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PROTON-967) make empty frame logging actually mention that it is an empty frame.
Robbie Gemmell created PROTON-967: - Summary: make empty frame logging actually mention that it is an empty frame. Key: PROTON-967 URL: https://issues.apache.org/jira/browse/PROTON-967 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.9.1 Reporter: Robbie Gemmell Assignee: Robbie Gemmell Priority: Minor Fix For: 0.10 The empty frame logging (when it happens, PROTON-966) currently just logs "null", which isn't particularly clear that it means an empty frame. We should update it to actually say "Empty Frame". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Empty frame
On 07/29/2015 02:39 PM, Tomáš Šoltys wrote: Does this mean that for example I will set timeout to 10 seconds and message processing in PN_TRANSFER will take 1 minute or more that connection will eventually timeout? Is my assumption correct? What you set as the idle timeout determines the rate at which the remote peer must send heartbeats (or other traffic). What the remote peer specifies as their idle timeout determines the rate the local process must send out heartbeats. If you don't process the connection (call pn_transport_tick and write out any data from the transport to the wire) sufficiently frequently then the heartbeats won't be sent sufficiently frequently and the remote peer may time out the connection. Likewise, detecting the connection is idle locally involves calling on_transport_tick sufficiently frequently. I'm not entirely sure how the code works internall, so I don't know for example whether it would timeout the connection if the heartbeats that had arrived on the local socket were pumped into the transport late. I suspect that is down to the order of processing input and calling on_transport_tick. In generaly though, you want to ensure that you can process the connection (do any input and output and call tick) in a timely manner, and if you need to do any task that may prevent that, it should be done on a separate thread (or written in such a way that it doesn't require the thread to be blocked from any other wokr for the duration of the task).
Re: Empty frame
Hi Gordon, Thanks a lot for help. Does this mean that for example I will set timeout to 10 seconds and message processing in PN_TRANSFER will take 1 minute or more that connection will eventually timeout? Is my assumption correct? Thanks and regards, Tomas 2015-07-28 13:09 GMT+02:00 Gordon Sim : > On 07/28/2015 10:57 AM, Tomáš Šoltys wrote: > >> So to make it work it is enough to set idle timeout on both sides and >> proton will handle rest? >> > > If an idle timeout is set by the local application, then proton will raise > an error if there is no incoming traffic for that time. > > If an idle timeout is specified by the remote peer, proton will emit empty > frames into its output stream provided the pn_transport_tick() function is > called frequently enough. > > Is heartbeat being sent by pn_transport_tick() ? >> If so in what event it should be sent? In PN_TRANSPORT ? >> > > Yes, the pn_transport_tick will trigger the writing of empty frames to the > transport and this should result in a transport event as for any other > write. > -- Tomáš Šoltys tomas.sol...@gmail.com http://www.range-software.com (+420) 776-843-663
[jira] [Updated] (PROTON-962) heartbeat/empty frame trace has spurious newline
[ https://issues.apache.org/jira/browse/PROTON-962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-962: -- Affects Version/s: (was: 0.11) 0.9.1 Fix Version/s: (was: 0.11) 0.10 Changing fox-for to 0.10, since it has yet to branch this will be included unless action is taken otheriwise. > heartbeat/empty frame trace has spurious newline > > > Key: PROTON-962 > URL: https://issues.apache.org/jira/browse/PROTON-962 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.9.1 >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Trivial > Fix For: 0.10 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Empty frame
On 07/28/2015 10:57 AM, Tomáš Šoltys wrote: So to make it work it is enough to set idle timeout on both sides and proton will handle rest? If an idle timeout is set by the local application, then proton will raise an error if there is no incoming traffic for that time. If an idle timeout is specified by the remote peer, proton will emit empty frames into its output stream provided the pn_transport_tick() function is called frequently enough. Is heartbeat being sent by pn_transport_tick() ? If so in what event it should be sent? In PN_TRANSPORT ? Yes, the pn_transport_tick will trigger the writing of empty frames to the transport and this should result in a transport event as for any other write.
Re: Empty frame
Hi Gordon, thanks for the answer. So to make it work it is enough to set idle timeout on both sides and proton will handle rest? Is heartbeat being sent by pn_transport_tick() ? If so in what event it should be sent? In PN_TRANSPORT ? Regards, Tomas 2015-07-28 11:01 GMT+02:00 Gordon Sim : > On 07/28/2015 08:17 AM, Tomáš Šoltys wrote: > >> Hi, >> >> I am looking for a way hot to send a heartbeat. I have found something >> about sending an empty frame and pn_transport_set_idle_timeout() >> >> Is this somewhat related? Is there a way how to send/receive heartbeats? >> > > In AMQP 1.0, heartbeats are configured separately in each direction. That > is, each of the connected processes indicates how frequently the remote > peer should send some traffic in order to prevent the connection timing out > due to being idle. > > So in proton, to indicate to the remote peer that they should send > heartbeats, you do indeed set the idle timeout. Proton will advertise half > that time to the peer such that they should then send heartbeats frequently > enough to avoid the connection timing out when connected. > > The sending out of heartbeats by the local peer is controlled by the > remote peer and whatever idle timeout it has advertised. > > -- Tomáš Šoltys tomas.sol...@gmail.com http://www.range-software.com (+420) 776-843-663
Re: Empty frame
On 07/28/2015 08:17 AM, Tomáš Šoltys wrote: Hi, I am looking for a way hot to send a heartbeat. I have found something about sending an empty frame and pn_transport_set_idle_timeout() Is this somewhat related? Is there a way how to send/receive heartbeats? In AMQP 1.0, heartbeats are configured separately in each direction. That is, each of the connected processes indicates how frequently the remote peer should send some traffic in order to prevent the connection timing out due to being idle. So in proton, to indicate to the remote peer that they should send heartbeats, you do indeed set the idle timeout. Proton will advertise half that time to the peer such that they should then send heartbeats frequently enough to avoid the connection timing out when connected. The sending out of heartbeats by the local peer is controlled by the remote peer and whatever idle timeout it has advertised.
Empty frame
Hi, I am looking for a way hot to send a heartbeat. I have found something about sending an empty frame and pn_transport_set_idle_timeout() Is this somewhat related? Is there a way how to send/receive heartbeats? Thanks and regards, Tomas
[jira] [Resolved] (PROTON-962) heartbeat/empty frame trace has spurious newline
[ https://issues.apache.org/jira/browse/PROTON-962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved PROTON-962. --- Resolution: Fixed > heartbeat/empty frame trace has spurious newline > > > Key: PROTON-962 > URL: https://issues.apache.org/jira/browse/PROTON-962 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.11 >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Trivial > Fix For: 0.11 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-962) heartbeat/empty frame trace has spurious newline
[ https://issues.apache.org/jira/browse/PROTON-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642914#comment-14642914 ] ASF subversion and git services commented on PROTON-962: Commit a9b3fbcd06b4afcd98702789f4d184fb33f760cd in qpid-proton's branch refs/heads/master from [~gsim] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=a9b3fbc ] PROTON-962: remove spurious newline from trace of heartbeat frame > heartbeat/empty frame trace has spurious newline > > > Key: PROTON-962 > URL: https://issues.apache.org/jira/browse/PROTON-962 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.11 >Reporter: Gordon Sim >Assignee: Gordon Sim >Priority: Trivial > Fix For: 0.11 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PROTON-962) heartbeat/empty frame trace has spurious newline
Gordon Sim created PROTON-962: - Summary: heartbeat/empty frame trace has spurious newline Key: PROTON-962 URL: https://issues.apache.org/jira/browse/PROTON-962 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.11 Reporter: Gordon Sim Assignee: Gordon Sim Priority: Trivial Fix For: 0.11 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
