[Prototype-core] Re: Cant disable button tag. (input type=button works ok)
Patches here: http://github.com/jdalton/prototype/commit/723c26518392d838cf9ec368eddfba0c1874bac1 and http://github.com/jdalton/prototype/commit/8eaae75066531993eba13df5eb1469016435843b they need unit tests though :) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Cant disable button tag. (input type=button works ok)
John, I don't think it's a good idea to give buttons full Form.Element interface. While enable/disable would work correctly, getValue/ setValue would yield unexpected results. Giving buttons a method which doesn't work as documented could be unintuitive, imho. - kangax On May 7, 10:42 am, John-David Dalton [EMAIL PROTECTED] wrote: Patches here:http://github.com/jdalton/prototype/commit/723c26518392d838cf9ec368ed... andhttp://github.com/jdalton/prototype/commit/8eaae75066531993eba13df5eb... they need unit tests though :) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Cant disable button tag. (input type=button works ok)
Patched to work with getValue, setValue. http://github.com/jdalton/prototype/commit/3b03b76660bc29ba5d8a6ef4e06c99c8faded107 Unit tests: http://github.com/jdalton/prototype/commit/101d23d64aba2c0c459c97fa684a9079a7beb140 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Cant disable button tag. (input type=button works ok)
That's not quite what I was talking about : ) How about just extending buttons with enable/disable and serialize? (and i.e. keeping getValue/setValue logic consistent) Are there other ones that would make sense? - kangax On May 7, 12:27 pm, John-David Dalton [EMAIL PROTECTED] wrote: Patched to work with getValue, setValue.http://github.com/jdalton/prototype/commit/3b03b76660bc29ba5d8a6ef4e0... Unit tests:http://github.com/jdalton/prototype/commit/101d23d64aba2c0c459c97fa68... --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Cant disable button tag. (input type=button works ok)
The getValue and setValue, use the Form.Element.Serializers anyway. So when I added serialization it adds the getValue and setValue. The browser sees the innerHTML of the button element as its value so this is consistent. - JDD --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
