Re: [ptxdist] [PATCH] ibrdtn: add packaging rules for IBR-DTN and dtndht

[Roland Hieber]

On 18.08.2016 08:53, Michael Olbrich wrote:
> And check your configure options. You need to specify everything that is
> optional or may be auto detected. Please look at some other rules for
> guidance or ask me if you are unsure if an option should be specified.

Uh, good point. Most of the --disable/--enable options seem to be built
in a way that their state is autodetected, except when overwritten on
the command line. But not for every --disable there is also a matching
--enable (that would let the configure fail if things are wrong)!

For example, in ibrcommon, only --disable-netlink really works and
disables netlink support, but --enable-netlink also disables netlink
support, because AC_ARG_ENABLE only checks for the existence of the
--*-netlink switches, not for their actual value. [0]

One could argue that configure (without --disable-netlink) will try to
detect libnl3 and find it every time because it is listed as a
dependency in the rules and is therefore built before ibrcommon.  On the
other hand, if things go wrong somehow, libnl3 could not be detected
although it should be, and configure will not interpret that as a
failure and happily build without netlink support.  So it seems like a
better solution to me if we patch those AC_ARG_ENABLE calls so they
respect the actual value of the command line switch, like in [1].

Same applies e.g. for --enable-debug and --enable-gcov (no
--disable-debug or --disable-gcov), and I didn't look into the other
ibrdtn packages yet...

[0]:
https://github.com/ibrdtn/ibrdtn/blob/master/ibrcommon/configure.ac#L217
[1]: https://autotools.io/autoconf/arguments.html

 - Roland



signature.asc
Description: OpenPGP digital signature
___
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] AT91bootstrap with ptxdist

[Guillermo Rodriguez Garcia]

Hello all,

I am trying to compile AT91bootstrap with ptxdist and I have found the
following minor issues:

1. Starting from end of 2014, at91bootstrap releases are no longer
published on ftp://www.at91.com/pub/.. The "official" source now seems
to be the at91bootstrap repo. The ftp site contains versions up to
3.7.1 (Nov 2014), while the github repo contains versions from 3.7
(Sep 2014) onwards.

I can just send a patch to update the URL but that would break if
someone wants to use an old at91bootstrap version. How should this be
handled?

2. Also, at91bootstrap.make assumes that the name of the generated
image is *boot-$(AT91BOOTSTRAP2_VERSION).bin, whereas this now seems
to be *boot-*-$(AT91BOOTSTRAP2_VERSION).bin.

Likewise I could send a patch for this but it will break for older
at91bootstrap versions. How should this be handled?

Other than this all works fine.

Thanks,

Guillermo Rodriguez Garcia
guille.rodrig...@gmail.com

___
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] [PATCHv2] dnsmasq: fix overwritten PKG_CONFIG

[Robert Schwebel]

The dnsmasq package has a handwritten Makefile, which overwrites the
PKG_CONFIG set by ptxdist.

Set the variable to the right value.

Signed-off-by: Robert Schwebel 
---

Changes since (implicit) v1:

* break long lines

 rules/dnsmasq.make | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/rules/dnsmasq.make b/rules/dnsmasq.make
index a9e3e49..7693e93 100644
--- a/rules/dnsmasq.make
+++ b/rules/dnsmasq.make
@@ -59,7 +59,11 @@ ifdef DNSMASQ_DNSSEC
 DNSMASQ_COPT += -DHAVE_DNSSEC
 endif
 
-DNSMASQ_MAKEVARS := PREFIX=/usr AWK=awk COPTS='$(DNSMASQ_COPT)'
+DNSMASQ_MAKEVARS := \
+   PREFIX=/usr \
+   AWK=awk \
+   COPTS='$(DNSMASQ_COPT)' \
+   PKG_CONFIG='$(PTXDIST_SYSROOT_CROSS)/bin/$(COMPILER_PREFIX)pkg-config'
 
 $(STATEDIR)/dnsmasq.prepare:
@$(call targetinfo)
-- 
2.8.1


___
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH 1/4] dnsmasq: fix overwritten PKG_CONFIG

[Robert Schwebel]

On Sat, Aug 20, 2016 at 07:47:05PM +0200, Robert Schwebel wrote:
> The dnsmasq package has a handwritten Makefile, which overwrites the
> PKG_CONFIG set by ptxdist.
> 
> Set the variable to the right value.
> 
> Signed-off-by: Robert Schwebel 
> ---
>  rules/dnsmasq.make | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/dnsmasq.make b/rules/dnsmasq.make
> index a9e3e49..494b34f 100644
> --- a/rules/dnsmasq.make
> +++ b/rules/dnsmasq.make
> @@ -59,7 +59,7 @@ ifdef DNSMASQ_DNSSEC
>  DNSMASQ_COPT += -DHAVE_DNSSEC
>  endif
>  
> -DNSMASQ_MAKEVARS := PREFIX=/usr AWK=awk COPTS='$(DNSMASQ_COPT)'
> +DNSMASQ_MAKEVARS := PREFIX=/usr AWK=awk COPTS='$(DNSMASQ_COPT)' 
> PKG_CONFIG='$(PTXDIST_SYSROOT_CROSS)/bin/$(COMPILER_PREFIX)pkg-config'

should break long lines, will send an updated patch
  
>  $(STATEDIR)/dnsmasq.prepare:
>   @$(call targetinfo)
> -- 
> 2.8.1
> 
> 
> ___
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] [PATCHv2] host-qemu: enable libusb by default

[Robert Schwebel]

From: Alexander Aring 

Alexander Aring added --enable-libusb in DistroKit, in order to be able
to test 802.15.4 USB devices from within a qemu simulator.

Signed-off-by: Alexander Aring 
[ported to ptxdist mainline]
Signed-off-by: Robert Schwebel 
---

Changes since (implicit) v1:

* select HOST_LIBUSB as well

 rules/host-qemu.in   | 1 +
 rules/host-qemu.make | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/rules/host-qemu.in b/rules/host-qemu.in
index 0d45714..25843fc 100644
--- a/rules/host-qemu.in
+++ b/rules/host-qemu.in
@@ -6,6 +6,7 @@ menuconfig HOST_QEMU
prompt "host-side qemu"
select HOST_GLIB
select HOST_ZLIB
+   select HOST_LIBUSB  if HOST_QEMU_SYS
select HOST_PIXMAN  if HOST_QEMU_SYS
 
 if HOST_QEMU
diff --git a/rules/host-qemu.make b/rules/host-qemu.make
index 556df20..eae6a52 100644
--- a/rules/host-qemu.make
+++ b/rules/host-qemu.make
@@ -104,7 +104,7 @@ HOST_QEMU_CONF_OPT  := \
--disable-libiscsi \
--disable-libnfs \
--disable-smartcard \
-   --disable-libusb \
+   --enable-libusb \
--disable-usb-redir \
--disable-lzo \
--disable-snappy \
-- 
2.8.1


___
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH 4/4] host-qemu: enable libusb by default

[Robert Schwebel]

On Sat, Aug 20, 2016 at 07:47:08PM +0200, Robert Schwebel wrote:
> From: Alexander Aring 
> 
> Alexander Aring added --enable-libusb in DistroKit, in order to be able
> to test 802.15.4 USB devices from within a qemu simulator.
> 
> Signed-off-by: Alexander Aring 
> [ported to ptxdist mainline]
> Signed-off-by: Robert Schwebel 
> ---
>  rules/host-qemu.make | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/host-qemu.make b/rules/host-qemu.make
> index 556df20..eae6a52 100644
> --- a/rules/host-qemu.make
> +++ b/rules/host-qemu.make
> @@ -104,7 +104,7 @@ HOST_QEMU_CONF_OPT:= \
>   --disable-libiscsi \
>   --disable-libnfs \
>   --disable-smartcard \
> - --disable-libusb \
> + --enable-libusb \
>   --disable-usb-redir \
>   --disable-lzo \
>   --disable-snappy \
> -- 
> 2.8.1

This needs HOST_LIBUSB, will fix.

rsc
-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] host-qemu: use internel pixman instead of systemwide

[Robert Schwebel]

On Sun, Aug 21, 2016 at 08:52:27PM +0200, Robert Schwebel wrote:
> On Sun, Aug 21, 2016 at 08:49:39PM +0200, Robert Schwebel wrote:
> > Currently, host-qemu tries to use a systemwide installed pixman version.
> > QEMU's handwritten configure script determines the include and library
> > paths with pkg-config, but as our host-pkg-config doesn't find pixman-1,
> > the compilation breaks down with:
> > 
> > In file included from [...]/qemu-2.6.0/include/ui/console.h:4:0, from 
> > vl.c:75:
> > [...]/qemu-2.6.0/include/ui/qemu-pixman.h:14:20: fatal error: pixman.h: No 
> > such file or directory
> > compilation terminated.
> > [...]/qemu-2.6.0/rules.mak:57: recipe for target 'vl.o' failed
> > make[1]: *** [vl.o] Error 1
> > 
> > Switch to using the pixman variant shipped with qemu.
> 
> I'm not entirely sure if the reasoning is right, but at least qemu
> doesn't find pixman.h, even if it is installed. So any feedback about
> this is welcome.
> 
> The OSELAS.BSP-Pengutronix-AllYes test BSP doesn't have host-qemu
> enabled, so I assume this is the reason our sisiphus autobuilder doesn't
> find it.

Discussed with mol and found the reson: the new host-qemu.in has a
select to host-pixman. If we use the upstream .in file as well, the
issue is fixed.

Please drop this patch.

rsc
-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
ptxdist mailing list
ptxdist@pengutronix.de