Re: [ptxdist] [PATCH] gdb: add option for 11.1 and later

2022-11-04 Thread Ladislav Michl
Hi Philipp!

On Thu, Nov 03, 2022 at 05:55:42PM +0100, Philipp Zabel wrote:
> GDB requires GMP since version 11.1. Add an option to allow selecting
> LIBGMP for newer toolchains. This is somewhat analogous to commit
> bc5cac5c54d2 ("glibc: add option for 2.34 and later").

before adding one more analogous commit, what about turning both of
them to something like
def_bool $(success,test "you_test_goes_there")


> Signed-off-by: Philipp Zabel 
> ---
>  rules/gdb.in | 8 
>  1 file changed, 8 insertions(+)
> 
> diff --git a/rules/gdb.in b/rules/gdb.in
> index 1dd2213abc8a..3014271de9c1 100644
> --- a/rules/gdb.in
> +++ b/rules/gdb.in
> @@ -7,6 +7,7 @@ menuconfig GDB
>   select LIBC_DL
>   select GCCLIBS_GCC_S
>   select NCURSES
> + select LIBGMP   if GDB_11_1
>   help
> The GNU Debugger
>  
> @@ -25,5 +26,12 @@ config GDB_SHARED
> If not set, the build option
> LDFLAGS=-static will be activated.
>  
> +config GDB_11_1
> + bool
> + prompt "gdb-11.1 or later"
> + help
> +   Since gdb-11.1, GMP is a required dependency. Enable this option
> +   if your toolchain gdb version is 11.1 or later.
> +
>  endif
>  
> -- 
> 2.30.2
> 



[ptxdist] [PATCH] gdb: add option for 11.1 and later

2022-11-03 Thread Philipp Zabel
GDB requires GMP since version 11.1. Add an option to allow selecting
LIBGMP for newer toolchains. This is somewhat analogous to commit
bc5cac5c54d2 ("glibc: add option for 2.34 and later").

Signed-off-by: Philipp Zabel 
---
 rules/gdb.in | 8 
 1 file changed, 8 insertions(+)

diff --git a/rules/gdb.in b/rules/gdb.in
index 1dd2213abc8a..3014271de9c1 100644
--- a/rules/gdb.in
+++ b/rules/gdb.in
@@ -7,6 +7,7 @@ menuconfig GDB
select LIBC_DL
select GCCLIBS_GCC_S
select NCURSES
+   select LIBGMP   if GDB_11_1
help
  The GNU Debugger
 
@@ -25,5 +26,12 @@ config GDB_SHARED
  If not set, the build option
  LDFLAGS=-static will be activated.
 
+config GDB_11_1
+   bool
+   prompt "gdb-11.1 or later"
+   help
+ Since gdb-11.1, GMP is a required dependency. Enable this option
+ if your toolchain gdb version is 11.1 or later.
+
 endif
 
-- 
2.30.2