On Wed, Jan 04, 2023 at 03:47:43PM +0100, Ladislav Michl wrote:
> Do not force INITMETHOD to allow BSPs to use alternative inits
> on their own (minit for example)
>
> Now that initmethod.in part of patch is questionable, but it breaks
> various ways without it, for example:
> WARNING: unmet direct dependencies detected for RC_ONCE
> Depends on [n]: INITMETHOD [=n]
> Selected by [m]:
> - DROPBEAR [=m] && RUNTIME [=y]
>
> Any other ideas?
I think it should be possible to add a
source "generated/initmethod-choice.in"
(name TBD) inside the initmethod choice. This way you can add your own
initmethod instead of disabling it. Maybe split the existing ones into
separate files for consistency.
Regards,
Michael
> Thak you,
> ladis
> ---
> rules/dropbear.in | 1 -
> rules/initmethod.in | 4 ++--
> rules/lldpd.in | 1 -
> 3 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/rules/dropbear.in b/rules/dropbear.in
> index 95beb09bf..7b5736696 100644
> --- a/rules/dropbear.in
> +++ b/rules/dropbear.in
> @@ -6,7 +6,6 @@ menuconfig DROPBEAR
> select LIBC_UTIL
> select LIBC_CRYPT
> select GCCLIBS_GCC_S
> - select INITMETHOD
> select RC_ONCE if RUNTIME
> select BUSYBOX_START_STOP_DAEMONif
> DROPBEAR_STARTSCRIPT
> select BUSYBOX_FEATURE_START_STOP_DAEMON_FANCY if
> DROPBEAR_STARTSCRIPT
> diff --git a/rules/initmethod.in b/rules/initmethod.in
> index 489fd365d..4066a05ba 100644
> --- a/rules/initmethod.in
> +++ b/rules/initmethod.in
> @@ -33,6 +33,6 @@ choice
>
> endchoice
>
> -source "generated/initmethod.in"
> -
> endif
> +
> +source "generated/initmethod.in"
> diff --git a/rules/lldpd.in b/rules/lldpd.in
> index 8b253ba83..d2afccbd0 100644
> --- a/rules/lldpd.in
> +++ b/rules/lldpd.in
> @@ -3,7 +3,6 @@
> menuconfig LLDPD
> tristate
> prompt "lldpd "
> - select INITMETHOD
> select LIBBSD
> select LIBCAP
> select LIBEVENT
> --
> 2.32.0
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
