Re: [Pulp-dev] Settings merge proposal.

[Brian Bouterse]

It's always good to discuss important changes. Thanks for bringing it up.

I think we do need to adopt the overwrite-not-merge approach here to allow
users to opt-out of settings we've opted them into. With a merge strategy
they can't. Say they wanted to log w/ a different formatter to match how
their splunk logging already works in their environments. When they specify
their formatter, it will merge in addition to the Pulp formatters, so they
will get every log line twice I believe.

Am I thinking about this right?

On Tue, Aug 21, 2018 at 11:06 AM, Jeff Ortel  wrote:

> This issue[1] highlighted a shortcoming in how server.yaml is applied to
> the settings.py.  Mainly that the marge algorithm does not support removing
> unwanted properties such as the logging handlers.  The change proposed on
> #3879 is to replace entire top-level properties (trees) instead of the
> fine-grained merge.  The "logging" section is somewhat unique and the
> original problem has been mitigated by #3883
>  which changed the logging default to
> CONSOLE.
>
> Do we still want/need to change the way server.yml is applied to
> settings.py as proposed on #3879?  There are pros/cons to either approach
> and thought it should be discussed before moving forward.
>
>
> [1] https://pulp.plan.io/issues/3879
> [2] https://pulp.plan.io/issues/3883 
>
> ___
> Pulp-dev mailing list
> Pulp-dev@redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
>
___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev

[Pulp-dev] Settings merge proposal.

[Jeff Ortel]

This issue[1] highlighted a shortcoming in how server.yaml is applied to 
the settings.py.  Mainly that the marge algorithm does not support 
removing unwanted properties such as the logging handlers.  The change 
proposed on #3879 is to replace entire top-level properties (trees) 
instead of the fine-grained merge.  The "logging" section is somewhat 
unique and the original problem has been mitigated by #3883 
 which changed the logging default to 
CONSOLE.


Do we still want/need to change the way server.yml is applied to 
settings.py as proposed on #3879?  There are pros/cons to either 
approach and thought it should be discussed before moving forward.



[1] https://pulp.plan.io/issues/3879
[2] https://pulp.plan.io/issues/3883 
___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev