Re: [pulseaudio-discuss] [PATCH] Make pulse build with clang again
'Twas brillig, and Maarten Bosmans at 28/09/11 20:54 did gyre and gimble:
> 2011/9/28 Maarten Bosmans :
>> 2011/9/28 Arun Raghavan :
>>> On Wed, 2011-09-28 at 09:50 +0200, Maarten Bosmans wrote:
This patch was sent to the list before, but was deemend to riscy pre-1.0.
So now I'll resend. It does touch de same code as David fixed with
42bcb418aed SSE/MMX: Fix problem with highpitched
noise on i386, but I leaves his solution intact, so it should be safe.
The problem this patch is trying to solve is that the (pa_reg_x86) is not
meaningfull with the "m" modifier. GCC ignores
this, but clang (correctly) whines about it.
>>>
>>> Do we have an easy way to make sure the problem David fixed continues to
>>> not be there with this patch?
>>
>> There's no regression test for this. I have some tests here locally
>> and will try it.
>
> OK, so I have verified it, the patch is safe.
>
> This is tested with a new test: svolume-test, which I added in order
> to be able to verify the further orcification of the svolume functions
> I did. Basically it is just the testing code that was already present
> in the svolume_{arm,mmx,sse,orc}.c files beefed up a bit.:
> https://github.com/mkbosmans/pulseaudio/commit/cf0c5c9ad47ba0434b0518ca79ca802d0e62153a
>
> Running svolume-test with David's patch reversed exits with an error
> status and both with current git master and with my patch on top of
> that succeeds.
Interesting. The problem we had was 32-bit only before when adjusting
channel volumes separately - this introduced artefacts into the sound
produced... dunno if your test covers this case or not, but it's nice to
see that the test actually errors out with David's patch reverted.
Am just testing now (along with all the other pending patches), so will
likely push this in a couple hours.
Col
--
Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/
Day Job:
Tribalogic Limited http://www.tribalogic.net/
Open Source:
Mageia Contributor http://www.mageia.org/
PulseAudio Hacker http://www.pulseaudio.org/
Trac Hacker http://trac.edgewall.org/
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] Make pulse build with clang again
'Twas brillig, and Maarten Bosmans at 28/09/11 08:50 did gyre and gimble: > The casts are not supported there. OK pushed now. Sorry for the previous paranoia. As it turns out there would have been plenty time for testing. Such is life. Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/ ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH 0/3] Results from debugging a rewind problem
'Twas brillig, and Tanu Kaskinen at 29/09/11 16:54 did gyre and gimble: > module-null-sink has a bug (fix to be posted later) that > causes it to use 10 second buffer instead of the intended 2 > second buffer. That's actually sort of nice, because that > made another bug visible. When moving streams away from the > null sink, streams sometimes played silence for a while to > the new sink. The culprit turned out to be a bug in rewind > handling when a stream moving is finished. The first patch > fixes that. > > The second patch just adds some documentation and FIXME > notes - a result of thinking through what really should > happen when a stream is moved. > > The third patch adds some assistance for debugging future > bugs. The added memblockq information was successfully used > in debugging this rewinding bug. > > Tanu Kaskinen (3): > sink: Move updating the requested latency after the rewind request > when finishing a stream move. > sink: Add some comments about the rewind handling during stream > moves. > memblockq: Improve debuggability by storing a name and a sample spec. > > src/modules/echo-cancel/module-echo-cancel.c |8 +- > src/modules/module-combine-sink.c|3 +- > src/modules/module-equalizer-sink.c |4 +- > src/modules/module-ladspa-sink.c |2 +- > src/modules/module-loopback.c|3 +- > src/modules/module-virtual-sink.c|2 +- > src/modules/module-virtual-source.c |4 +- > src/modules/rtp/module-rtp-recv.c|3 +- > src/modules/rtp/module-rtp-send.c|3 +- > src/pulse/stream.c |3 +- > src/pulsecore/memblockq.c| 15 +++- > src/pulsecore/memblockq.h| 11 ++- > src/pulsecore/play-memchunk.c|2 +- > src/pulsecore/protocol-esound.c |6 +- > src/pulsecore/protocol-http.c|3 +- > src/pulsecore/protocol-native.c | 12 +++- > src/pulsecore/protocol-simple.c |6 +- > src/pulsecore/sink-input.c | 24 +--- > src/pulsecore/sink.c | 87 > -- > src/pulsecore/sound-file-stream.c|2 +- > src/pulsecore/source-output.c|6 +- > src/tests/memblockq-test.c |7 ++- > 22 files changed, 167 insertions(+), 49 deletions(-) > Thanks for this. All three patches pushed now. I think the comment formatting is fine, although if there is general consensus on widening the standard comment width, we could clean it up later if someone cares enough. Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/ ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH v3 4/7] bluetooth: Set off profile on SCO disconnect
Hi,
I've not tested the code, but Luiz' review is good enough for me. :)
Just one nitpick, mostly for the sake of uniformity with the rest of the
code ...
On Tue, 2011-09-20 at 13:55 +0200, Frédéric Dalleau wrote:
> Sends a message from IO thread to main thread using pa_msgobject when POLLERR
> or POLLHUP is received on SCO socket.
> ---
> src/modules/bluetooth/module-bluetooth-device.c | 136
> ++-
> 1 files changed, 84 insertions(+), 52 deletions(-)
>
> diff --git a/src/modules/bluetooth/module-bluetooth-device.c
> b/src/modules/bluetooth/module-bluetooth-device.c
> index 08ab868..3db9e8f 100644
> --- a/src/modules/bluetooth/module-bluetooth-device.c
> +++ b/src/modules/bluetooth/module-bluetooth-device.c
> @@ -126,7 +126,9 @@ struct hsp_info {
> pa_hook_slot *source_state_changed_slot;
> };
>
> -struct userdata {
> +struct bluetooth_device {
What's the rationale behind this? While the whole "struct userdata"
business makes code navigation just a bit hard sometimes, broadly it's
handy as a convention across modules.
Would it make sense perhaps to make a separate msgobject for the
bluetooth device/card with just the pa_card so you can pass that around
instead?
> +pa_msgobject parent;
> +
> pa_core *core;
[...]
> @@ -2824,13 +2853,16 @@ int pa__init(pa_module* m) {
> goto fail;
> }
>
> -m->userdata = u = pa_xnew0(struct userdata, 1);
> +u = pa_msgobject_new(bluetooth_device);
> +memset(((char*)u)+sizeof(u->parent), 0, sizeof(*u)-sizeof(u->parent));
Maybe I'm being dense, but why is sizeof(*u) not sufficient here?
-- Arun
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] osx: don't build the once-test binary on OS X
'Twas brillig, and Daniel Mack at 29/09/11 12:25 did gyre and gimble:
> From: Daniel Mack
>
> This patch was already added earlier with commit ID 2f86ba4f, but the
> changes got reverted by commit 3adc43b ("win32: Make once-test work").
>
> However, this still doesn't work on OSX as here, pthread is in general
> available, but the barrier APIs aren't.
Thanks pushed for now pending (perhaps?) a fix to actually make the test
work.
Col
--
Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/
Day Job:
Tribalogic Limited http://www.tribalogic.net/
Open Source:
Mageia Contributor http://www.mageia.org/
PulseAudio Hacker http://www.pulseaudio.org/
Trac Hacker http://trac.edgewall.org/
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] doc: Add an example stream-restore fallback table file.
Thanks, pushed with a minor change to explain the ; char is also a comment. Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/ ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [gentoo-user] PulseAudio 1.0-r1 + Skype ==> Garbled output sound
'Twas brillig, and Jan Steffens at 30/09/11 17:19 did gyre and gimble: > In any case, Colin should have a patch ready shortly. I think: http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=7563e0bbb54fbac54e77f3a62d9761a70f3a559c Should do the trick. Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/ ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] null-sink: Set latency range at the time of initialization of module.
'Twas brillig, and sudarshan.bi...@nokia.com at 30/09/11 10:49 did gyre and gimble: > From: Sudarshan Bisht This looks good to me. Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/ ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] stream-restore: simple fallback volume table
'Twas brillig, and Colin Guthrie at 30/09/11 11:29 did gyre and gimble: > 'Twas brillig, and Tanu Kaskinen at 30/09/11 10:05 did gyre and gimble: >> On Fri, 2011-09-30 at 11:12 +0300, David Henningsson wrote: >>> Would it be possible to have some documentation, that would at least >>> explain the expected format of this fallback volume table? >> >> Good point. I'll write something. What would be the best location for >> the documentation - a text file, a wiki page or a comment in the code? >> I'd choose the text file, because I think such file format >> specifications should come with the code, but having it as a comment in >> the code would be too cumbersome to link to from the wiki etc. > > Does the file format accept comments? If so then perhaps just an > annotated example file with comments would suffice? > > If we need to link it from the wiki then a link to the cgit view would > be perfectly acceptable. OK, pushed now with a minor tweak to allow lines starting with ; to be comments too in order to maintain consistency with the other types of files we read (config files etc.) Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/ ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] udev detect not working
> From: pulseaudio-discuss-bounces+j- > frankish=slb@lists.freedesktop.org [mailto:pulseaudio-discuss- > bounces+j-frankish=slb@lists.freedesktop.org] On Behalf Of Colin > Guthrie > Sent: Friday, 30 September, 2011 16:35 > To: pulseaudio-discuss@lists.freedesktop.org > Subject: Re: [pulseaudio-discuss] udev detect not working > > 'Twas brillig, and John Frankish at 30/09/11 12:47 did gyre and gimble: > > Re-starting this thread with a modified title.. > > > > The results are the same with several versions of pulseaudio, > > including pulseaudio-1.0 > > > > pulseaudio - > > . > > D: [pulseaudio] cli-command.c: Checking for existence of > > '/usr/local/lib/pulse-0.99/modules/module-udev-detect.so': success > > I: [pulseaudio] module-udev-detect.c: Found 0 cards. > > I: [pulseaudio] module.c: Loaded "module-udev-detect" (index: #4; > argument: ""). > > > > This occurs on both a dell d430 and a macmini server. > > > > Using tinycorelinux with linux-2.6.33.3 glibc-2.11.1 and udev-151 the udev > detection works. > > Using tinycorelinux with linux-3.0.3 with eglibc-2.13 and udev-151 the > > udev detection does not work > > > > I'm using the same config files and udev rules in both cases > > > > Is there any pulseaudio udev module or udevadm troubleshooting I can > try? > > There may be some udevadm tricks (I'm not an expert), but other than that > you could just scatter some more debug statements throughout udev-detect > code and try and suss it out. > Thanks for the suggestion, but scattering debug statements in the udev-detect code it a little beyond me (unless somebody suggests what to put where). Does anybody else have any ideas? ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
