Re: [pulseaudio-discuss] express my interests in applying GSoC 2012

[Arun Raghavan]

Hi,

On Tue, 2012-03-20 at 22:48 +0800, rong deng wrote:
> Hi all,
> 
> 
> This is Deng Zhenrong from Shanghai China, I've already used Linux as
> my main desktop for several years. Now I would like to express my
> interests in applying pulseaudio's projects for this  year's GSoC in
> this mail.

Excellent! :)

> Glancing through the ideas, I find I'm interested in several few
> already. :) But I'd like to focus on one thing which is test/log
> facilities for now. I'm still doing my homework on this topic and I'll
> come up with more detailed info in later days.

Great! I'll be adding some rough work estimates to that page soon -- the
log/test project is likely to not constitute enough work for a summer
and could be grouped with some other task(s) of interest to you. I'm
open to a proposal with sufficient meant to prove otherwise, though.

Do feel free to ping me or the others on IRC (my nick is Ford_Prefect)
if you have any questions.

Cheers,
Arun


___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] express my interests in applying GSoC 2012

[David Henningsson]

2012-03-21 15:29, rong deng skrev:
> 在 2012年3月21日 下午3:21，David Henningsson 
>  >写道：
> 
> On 03/20/2012 03:48 PM, rong deng wrote:
> 
> Hi all,
> 
> This is Deng Zhenrong from Shanghai China, I've already used
> Linux as my
> main desktop for several years. Now I would like to express my
> interests
> in applying pulseaudio's projects for this year's GSoC in this mail.
> 
> 
> Hi Deng and welcome to PulseAudio! :-)
> 
> 
> Hi David,
> 
> Thanks for replying this message.
> 
> More contributors are always welcome. As for GSoC, I have never
> mentored anyone and won't be able to do so this summer either, so
> I'll let somebody else answer to that.
> 
> 
> No problem. :-)
> 
> 
> Glancing through the ideas, I find I'm interested in several few
> already. :) But I'd like to focus on one thing which is test/log
> facilities for now. I'm still doing my homework on this topic
> and I'll
> come up with more detailed info in later days.
> 
> So to get my hands dirty, I've already downloaded pulseaudio
> source code
> and compile it and set it up. Now I find there's a compilation
> warning,
> and here's my patch to fix it, cool :)
> 
> I'm attaching the patch generated from git format-patch, I'm not
> sure
> whether it's OK, as I see it from the mailing list, other developers
> send patches directly in mails. This patch is my first one to get
> familiar with the workflow, if there's anything wrong, please
> tell me. :)
> 
> 
> As for the patch, I believe you did most things right. :-) Some
> people prefer you send the patch using "git send-email", but for me,
> it does not matter much.
> 
> 
> OK. I'll try to use "git send-email" for later patches. I haven't set up 
> this mail system yet, I'll try to figure it out...

A google search for "gmail git send-email" seems to suggest a few good
hints, so shouldn't be too difficult I hope.

> As for using the PRI-prefixes, it seems we do not use this anywhere
> else in the code. Therefore I have two questions:
> 
> 1) Do you think there is a risk that some compiler that we want to
> build PulseAudio under, does not support these prefixes (remember,
> this is not only used in Linux, but in Windows, Mac OS, OS/2 IIRC
> and others)?
> 
> 
> No, I don't think it's a risk, as this PRI-prefix is defined in 
> inttypes.h header file, and according to manual, it is a standard.
> 
> 2) Would "%llx" solve this warning equally well?
> 
> On 32-bit system, yes, but then, it's not portable.
> To print uin64_t on 32 bit system, we should use %llx,
> but to print it on 64 bit system, we should use %lx instead. PRI-prefix 
> help us handle this.
> 
> Yes, there IS another way to handle, we can explicitly cast 
> 'pa_channel_position_mask_t' to 'unsigned long long' and use %llx.

A quick grep through the code shows that this is how we've been doing it
up till now, so we should probably keep it that way for consistency.

So, just for education, would you mind resending the patch with git
send-email, and using %llx ? Thanks!

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] express my interests in applying GSoC 2012

[rong deng]

在 2012年3月21日 下午3:21，David Henningsson 写道：

> On 03/20/2012 03:48 PM, rong deng wrote:
>
>> Hi all,
>>
>> This is Deng Zhenrong from Shanghai China, I've already used Linux as my
>> main desktop for several years. Now I would like to express my interests
>> in applying pulseaudio's projects for this  year's GSoC in this mail.
>>
>
> Hi Deng and welcome to PulseAudio! :-)
>
>
Hi David,

Thanks for replying this message.


> More contributors are always welcome. As for GSoC, I have never mentored
> anyone and won't be able to do so this summer either, so I'll let somebody
> else answer to that.
>
>
No problem. :-)


>  Glancing through the ideas, I find I'm interested in several few
>> already. :) But I'd like to focus on one thing which is test/log
>> facilities for now. I'm still doing my homework on this topic and I'll
>> come up with more detailed info in later days.
>>
>> So to get my hands dirty, I've already downloaded pulseaudio source code
>> and compile it and set it up. Now I find there's a compilation warning,
>> and here's my patch to fix it, cool :)
>>
>> I'm attaching the patch generated from git format-patch, I'm not sure
>> whether it's OK, as I see it from the mailing list, other developers
>> send patches directly in mails. This patch is my first one to get
>> familiar with the workflow, if there's anything wrong, please tell me. :)
>>
>
> As for the patch, I believe you did most things right. :-) Some people
> prefer you send the patch using "git send-email", but for me, it does not
> matter much.
>
>
OK. I'll try to use "git send-email" for later patches. I haven't set up
this mail system yet, I'll try to figure it out...


> As for using the PRI-prefixes, it seems we do not use this anywhere else
> in the code. Therefore I have two questions:
>
> 1) Do you think there is a risk that some compiler that we want to build
> PulseAudio under, does not support these prefixes (remember, this is not
> only used in Linux, but in Windows, Mac OS, OS/2 IIRC and others)?
>
>
No, I don't think it's a risk, as this PRI-prefix is defined in inttypes.h
header file, and according to manual, it is a standard.


> 2) Would "%llx" solve this warning equally well?
>
>
On 32-bit system, yes, but then, it's not portable.
To print uin64_t on 32 bit system, we should use %llx,
but to print it on 64 bit system, we should use %lx instead. PRI-prefix
help us handle this.

Yes, there IS another way to handle, we can explicitly
cast 'pa_channel_position_mask_t'  to 'unsigned long long' and use %llx.

It's up to you guys whether it should use PRI-prefix or use this cast. I'm
OK with these both methods. :)

--rong
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] express my interests in applying GSoC 2012

[David Henningsson]

On 03/20/2012 03:48 PM, rong deng wrote:

Hi all,

This is Deng Zhenrong from Shanghai China, I've already used Linux as my
main desktop for several years. Now I would like to express my interests
in applying pulseaudio's projects for this  year's GSoC in this mail.


Hi Deng and welcome to PulseAudio! :-)

More contributors are always welcome. As for GSoC, I have never mentored 
anyone and won't be able to do so this summer either, so I'll let 
somebody else answer to that.



Glancing through the ideas, I find I'm interested in several few
already. :) But I'd like to focus on one thing which is test/log
facilities for now. I'm still doing my homework on this topic and I'll
come up with more detailed info in later days.

So to get my hands dirty, I've already downloaded pulseaudio source code
and compile it and set it up. Now I find there's a compilation warning,
and here's my patch to fix it, cool :)

I'm attaching the patch generated from git format-patch, I'm not sure
whether it's OK, as I see it from the mailing list, other developers
send patches directly in mails. This patch is my first one to get
familiar with the workflow, if there's anything wrong, please tell me. :)


As for the patch, I believe you did most things right. :-) Some people 
prefer you send the patch using "git send-email", but for me, it does 
not matter much.


As for using the PRI-prefixes, it seems we do not use this anywhere else 
in the code. Therefore I have two questions:


1) Do you think there is a risk that some compiler that we want to build 
PulseAudio under, does not support these prefixes (remember, this is not 
only used in Linux, but in Windows, Mac OS, OS/2 IIRC and others)?


2) Would "%llx" solve this warning equally well?

--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH] loopback: Fix crash if Max Request change at unload

[David Henningsson]

On 03/20/2012 06:10 PM, Dalleau, Frederic wrote:

Hi David,

On Tue, Mar 20, 2012 at 4:06 PM, David Henningsson
  wrote:

On 02/10/2012 05:39 PM, Frédéric Dalleau wrote:


Module-bluetooth-policy can load and unload module-loopback on demand.
Sometimes if there is an error, module-loopback can be unloaded early.
When module-loopback is loaded, it attaches a sink and the sink
calls sink_input_update_max_request for which there is a callback.



Hmm, I saw this as well and committed a patch for it today (before I checked
this post unfortunately!)

Would you mind reviewing my patch "Never call adjust_rates after teardown"
to see if it affects/resolves your problem as well?



I'm in the middle of something, I hope I can look at your patch within
a day or two.
 From reading the code, I think it could reduce bug frequency.
Have you reproduced the crash yourself?


No, I just saw the crash report on launchpad and tried to figure out the 
likely cause for it. The person in question had combined 
module-null-sink with module-loopback and got a segfault from 
sink_input_update_max_request calling adjust_rates with a null u->source.


For reference, the stack trace is here:

https://bugs.launchpad.net/bugs/946400

--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss