Re: [pulseaudio-discuss] [PATCH v7 00/33] raop2 support for module-raop-sink

[Anton Lundin]

On 06 November, 2016 - Hajime Fujita wrote:

> This patch set adds a support for UDP version of RAOP (so called
> raop2). Most of the RAOP devices (e.g. AppleTV, AirportExpress,
> third party AV receivers) today use UDP version, so this patch
> set is expected to support those devices.
> 

I've took a close look at the non-raop changes and those LGTM.

Feel free to add a Reviewed-by: Anton Lundin  to them
if you feel for it.

I've tested and glanced at the raop-code and it ain't perfect but its
way better than the current code for anything modern, so I'd suggest
merging this.

Feel free to add a Tested-by: Anton Lundin  to them
if you feel for it.


//Anton


-- 
Anton Lundin+46702-161604
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [ANNOUNCE] PulseAudio 9.99.1 (a.k.a. v10.0 release candidate 1)

[Felipe Sateler]

On 3 January 2017 at 13:29, Tanu Kaskinen  wrote:
>
> Hi all!
>
> The first release candidate for PulseAudio 10.0 is now out. As always,
> the purpose of the release candidate is to get some testing done before
> the final version is released. So, please test this on your own
> machine, and if you're a distro maintainer and you have some suitable
> channel for prereleases, push this also to poor unsuspecting users and
> report back what kind of regressions they find!

I have uploaded the RC to debian experimental, so it should make it
easier to install/test on debian-based distros. It built on all
release architectures[1]

The hard freeze for the next debian release is on Jan 25th. I'm still
undecided on whether to push for 10 (or an RC) for stretch, I guess we
can see for a week or so if reports pop up.

[1] https://buildd.debian.org/status/package.php?p=pulseaudio=experimental

-- 

Saludos,
Felipe Sateler
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

[pulseaudio-discuss] [PATCH] enhancement of module-combine-sink for slave control while module is up

[Steffen Pfendtner]

Hi,

Here comes my first try to allow a dedicated control of what sinks shall be 
added or removed from the combine sink.
My goal is to allow pulseaudio-dlna to add new DLNA sinks to a existing combine 
sink. This way we get a uninterrupted braodcast to several DLNA 
receivers at once.

I have tried to keep the modifications to the module itsself. However as I need 
two CLI commands I did have to extend the sink struct with two 
new function pointers.


Steffen Pfendtner (1):
  added two new commands to native API to control the combine sink
slaves after the combine sink has been created

 src/modules/module-combine-sink.c | 92 +++
 src/pulsecore/cli-command.c   | 78 +
 src/pulsecore/sink.c  | 32 ++
 src/pulsecore/sink.h  |  8 
 4 files changed, 210 insertions(+)

-- 
1.9.1

___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

[pulseaudio-discuss] [PATCH] added two new commands to native API to control the combine sink slaves after the combine sink has been created

[Steffen Pfendtner]

---
 src/modules/module-combine-sink.c | 92 +++
 src/pulsecore/cli-command.c   | 78 +
 src/pulsecore/sink.c  | 32 ++
 src/pulsecore/sink.h  |  8 
 4 files changed, 210 insertions(+)

diff --git a/src/modules/module-combine-sink.c 
b/src/modules/module-combine-sink.c
index b6322c6..4a91901 100644
--- a/src/modules/module-combine-sink.c
+++ b/src/modules/module-combine-sink.c
@@ -1249,6 +1249,95 @@ static pa_hook_result_t 
sink_state_changed_hook_cb(pa_core *c, pa_sink *s, struc
 return PA_HOOK_OK;
 }
 
+void update_slaves_prop(pa_sink *combine_sink, struct userdata *u) {
+
+uint32_t idx;
+char *t;
+bool first = true;
+struct output *o;
+pa_proplist *pl;
+
+PA_IDXSET_FOREACH(o, u->outputs, idx) {
+char *e;
+if (first) {
+e = pa_sprintf_malloc("%s", pa_strnull(o->sink->name));
+first = false;
+} else {
+e = pa_sprintf_malloc("%s, %s", t, pa_strnull(o->sink->name));
+pa_xfree(t);
+}
+t = e;
+}
+/* if still first we have no outputs in the list */
+if (first) {
+t = pa_sprintf_malloc("");
+}
+
+pl = pa_proplist_new();
+pa_proplist_setf(pl, "combine.slaves", t);
+pa_xfree(t);
+pa_sink_update_proplist(combine_sink, PA_UPDATE_REPLACE, pl);
+pa_proplist_free(pl);
+}
+
+/* Called from main context on native API call */
+static int add_output(pa_sink *combine_sink, pa_sink *slave_sink) {
+struct userdata *u;
+struct output *o;
+
+pa_sink_assert_ref(combine_sink);
+pa_sink_assert_ref(slave_sink);
+pa_assert_se(u = combine_sink->userdata);
+
+if (u->automatic) {
+pa_log("combine sink is automatic, cannot add: '%s'.", 
slave_sink->name);
+return -2;
+}
+
+if ((o = find_output(u, slave_sink))) {
+pa_log("Sink already on combine sink: '%s'.", slave_sink->name);
+return -3;
+}
+
+if (!(o = output_new(u, slave_sink))) {
+pa_log("Failed to add sink to combine sink: '%s'.", slave_sink->name);
+return -4;
+}
+output_verify(o);
+update_slaves_prop(combine_sink, u);
+
+pa_log("Add output sink");
+return 0;
+}
+
+/* Called from main context on native API call */
+static int del_output(pa_sink *combine_sink, pa_sink *slave_sink) {
+struct userdata *u;
+struct output *o;
+
+pa_sink_assert_ref(combine_sink);
+pa_sink_assert_ref(slave_sink);
+pa_assert_se(u = combine_sink->userdata);
+
+if (u->automatic) {
+pa_log("combine sink is automatic, cannot del: '%s'.", 
slave_sink->name);
+return -2;
+}
+
+if (!(o = find_output(u, slave_sink))) {
+pa_log("Could not remove %s from combine sink, output was not found",
+slave_sink->name);
+return -3;
+}
+
+pa_idxset_remove_by_data(u->outputs, o, NULL);
+output_free(o);
+update_description(u);
+update_slaves_prop(combine_sink, u);
+pa_log("Del output sink");
+return 0;
+}
+
 int pa__init(pa_module*m) {
 struct userdata *u;
 pa_modargs *ma = NULL;
@@ -1401,6 +1490,9 @@ int pa__init(pa_module*m) {
 u->sink->set_state = sink_set_state;
 u->sink->update_requested_latency = sink_update_requested_latency;
 u->sink->userdata = u;
+u->sink->module = m;
+u->sink->combine_add_output = add_output;
+u->sink->combine_del_output = del_output;
 
 pa_sink_set_rtpoll(u->sink, u->rtpoll);
 pa_sink_set_asyncmsgq(u->sink, u->thread_mq.inq);
diff --git a/src/pulsecore/cli-command.c b/src/pulsecore/cli-command.c
index 9a73605..ba168d5 100644
--- a/src/pulsecore/cli-command.c
+++ b/src/pulsecore/cli-command.c
@@ -135,6 +135,8 @@ static int pa_cli_command_sink_port(pa_core *c, 
pa_tokenizer *t, pa_strbuf *buf,
 static int pa_cli_command_source_port(pa_core *c, pa_tokenizer *t, pa_strbuf 
*buf, bool *fail);
 static int pa_cli_command_port_offset(pa_core *c, pa_tokenizer *t, pa_strbuf 
*buf, bool *fail);
 static int pa_cli_command_dump_volumes(pa_core *c, pa_tokenizer *t, pa_strbuf 
*buf, bool *fail);
+static int pa_cli_command_combine_sink_add_output(pa_core *c, pa_tokenizer *t, 
pa_strbuf *buf, bool *fail);
+static int pa_cli_command_combine_sink_del_output(pa_core *c, pa_tokenizer *t, 
pa_strbuf *buf, bool *fail);
 
 /* A method table for all available commands */
 
@@ -191,6 +193,8 @@ static const struct command commands[] = {
 { "set-log-meta",pa_cli_command_log_meta,   "Show 
source code location in log messages (args: bool)", 2},
 { "set-log-time",pa_cli_command_log_time,   "Show 
timestamps in log messages (args: bool)", 2},
 { "set-log-backtrace",   pa_cli_command_log_backtrace,  "Show 
backtrace in log messages (args: frames)", 2},
+{ "combine-sink-add-output", pa_cli_command_combine_sink_add_output, "Add 
a output sink to the