Re: [pulseaudio-discuss] [PATCH] man/pulse-cli-syntax: document option `set-log-target`
On Tue, 2012-07-10 at 19:26 +0200, Paul Menzel wrote: > Am Dienstag, den 10.07.2012, 00:59 +0800 schrieb Deng Zhengrong: > > > > + set-log-target target > > + Change the log > > target(null,auto,syslog,stderr,file:PATH). > > In English a space is always added before a parenthesis (. Maybe also > add a space after each comma »,«. > > Change the log target (null, auto, syslog, stderr, file:PATH). > > Sorry, it just came to my mind that you can also note what the default > target is. So I guess you can try out `--subject-prefix="PATCH v3"` > now. ;-) I don't really agree about noting the default target. That belongs in the daemon.conf documentation, not in the cli syntax documentation. As far as I can see, knowing the default target doesn't help the user when he wants to change the log target at runtime with pacmd. The meaning of the different targets, especially "auto", could be explained somehow, however. Thank you very much for doing patch review, btw! It's appreciated. -- Tanu ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] man/pulse-cli-syntax: document option `set-log-target`
Dear Deng, thank you very much for the updated patch. Am Dienstag, den 10.07.2012, 00:59 +0800 schrieb Deng Zhengrong: > --- > man/pulse-cli-syntax.5.xml.in | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/man/pulse-cli-syntax.5.xml.in b/man/pulse-cli-syntax.5.xml.in > index 9d3f278..d7f3f11 100644 > --- a/man/pulse-cli-syntax.5.xml.in > +++ b/man/pulse-cli-syntax.5.xml.in > @@ -258,6 +258,11 @@ USA. > > > > + set-log-target target > + Change the log > target(null,auto,syslog,stderr,file:PATH). In English a space is always added before a parenthesis (. Maybe also add a space after each comma »,«. Change the log target (null, auto, syslog, stderr, file:PATH). Sorry, it just came to my mind that you can also note what the default target is. So I guess you can try out `--subject-prefix="PATCH v3"` now. ;-) > + > + > + >set-log-time boolean >Show timestamps in log messages. > Thanks, Paul signature.asc Description: This is a digitally signed message part ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] man/pulse-cli-syntax: document option `set-log-target`
2012/7/10 David Henningsson : > On 07/09/2012 07:01 PM, rong deng wrote: >> >> How to add the nicely "v2" just before >> the email subject? :) > > > You edit the patch file with your favorite editor right before you send it > with "git send-email". Oh, thanks for the tips. > > >> 2012/7/10 Deng Zhengrong : >>> >>> --- >>> man/pulse-cli-syntax.5.xml.in | 5 + >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/man/pulse-cli-syntax.5.xml.in >>> b/man/pulse-cli-syntax.5.xml.in >>> index 9d3f278..d7f3f11 100644 >>> --- a/man/pulse-cli-syntax.5.xml.in >>> +++ b/man/pulse-cli-syntax.5.xml.in >>> @@ -258,6 +258,11 @@ USA. >>> >>> >>> >>> + set-log-target target >>> + Change the log >>> target(null,auto,syslog,stderr,file:PATH). >>> + > > > What about the newfile: thing? The new file thing is not implemented for pacmd set-log-target yet. Because I don't see the usage for this tool to use newfile. When we want to use this pacmd, we can just set file to another new file by ourselves. If you think it's useful, I can help port that part of implementation to pacmd set-log-target as well. Just say it and I'll do the rest of the porting. ;) ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] man/pulse-cli-syntax: document option `set-log-target`
On 07/09/2012 07:01 PM, rong deng wrote: How to add the nicely "v2" just before the email subject? :) You edit the patch file with your favorite editor right before you send it with "git send-email". 2012/7/10 Deng Zhengrong : --- man/pulse-cli-syntax.5.xml.in | 5 + 1 file changed, 5 insertions(+) diff --git a/man/pulse-cli-syntax.5.xml.in b/man/pulse-cli-syntax.5.xml.in index 9d3f278..d7f3f11 100644 --- a/man/pulse-cli-syntax.5.xml.in +++ b/man/pulse-cli-syntax.5.xml.in @@ -258,6 +258,11 @@ USA. + set-log-target target + Change the log target(null,auto,syslog,stderr,file:PATH). + What about the newfile: thing? + + set-log-time boolean Show timestamps in log messages. -- 1.7.11.1 ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] man/pulse-cli-syntax: document option `set-log-target`
The new version is sent. BTW: How to add the nicely "v2" just before the email subject? :) 2012/7/10 Deng Zhengrong : > --- > man/pulse-cli-syntax.5.xml.in | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/man/pulse-cli-syntax.5.xml.in b/man/pulse-cli-syntax.5.xml.in > index 9d3f278..d7f3f11 100644 > --- a/man/pulse-cli-syntax.5.xml.in > +++ b/man/pulse-cli-syntax.5.xml.in > @@ -258,6 +258,11 @@ USA. > > > > + set-log-target target > + Change the log > target(null,auto,syslog,stderr,file:PATH). > + > + > + >set-log-time boolean >Show timestamps in log messages. > > -- > 1.7.11.1 > ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
[pulseaudio-discuss] [PATCH] man/pulse-cli-syntax: document option `set-log-target`
--- man/pulse-cli-syntax.5.xml.in | 5 + 1 file changed, 5 insertions(+) diff --git a/man/pulse-cli-syntax.5.xml.in b/man/pulse-cli-syntax.5.xml.in index 9d3f278..d7f3f11 100644 --- a/man/pulse-cli-syntax.5.xml.in +++ b/man/pulse-cli-syntax.5.xml.in @@ -258,6 +258,11 @@ USA. + set-log-target target + Change the log target(null,auto,syslog,stderr,file:PATH). + + + set-log-time boolean Show timestamps in log messages. -- 1.7.11.1 ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
