Re: [pulseaudio-discuss] [PATCH] osx: don't build the once-test binary on OS X
2011/10/3 Maarten Bosmans : > A good solution would be to make the test compile and run on OSX, but > then, if ther's now way it will pass on OSX or the result is just not > meaningful, return 77 or add the test to XFAIL_TESTS, so that the > failing on OSX is ignored. See http://www.gnu.org/s/hello/manual/automake/Simple-Tests.html Maarten ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] osx: don't build the once-test binary on OS X
2011/10/1 Colin Guthrie :
> 'Twas brillig, and Daniel Mack at 29/09/11 12:25 did gyre and gimble:
>> From: Daniel Mack
>>
>> This patch was already added earlier with commit ID 2f86ba4f, but the
>> changes got reverted by commit 3adc43b ("win32: Make once-test work").
>>
>> However, this still doesn't work on OSX as here, pthread is in general
>> available, but the barrier APIs aren't.
>
> Thanks pushed for now pending (perhaps?) a fix to actually make the test
> work.
A good solution would be to make the test compile and run on OSX, but
then, if ther's now way it will pass on OSX or the result is just not
meaningful, return 77 or add the test to XFAIL_TESTS, so that the
failing on OSX is ignored.
Maarten
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] osx: don't build the once-test binary on OS X
'Twas brillig, and Daniel Mack at 29/09/11 12:25 did gyre and gimble:
> From: Daniel Mack
>
> This patch was already added earlier with commit ID 2f86ba4f, but the
> changes got reverted by commit 3adc43b ("win32: Make once-test work").
>
> However, this still doesn't work on OSX as here, pthread is in general
> available, but the barrier APIs aren't.
Thanks pushed for now pending (perhaps?) a fix to actually make the test
work.
Col
--
Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/
Day Job:
Tribalogic Limited http://www.tribalogic.net/
Open Source:
Mageia Contributor http://www.mageia.org/
PulseAudio Hacker http://www.pulseaudio.org/
Trac Hacker http://trac.edgewall.org/
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] osx: don't build the once-test binary on OS X
2011/9/29 Daniel Mack :
> From: Daniel Mack
>
> This patch was already added earlier with commit ID 2f86ba4f, but the
> changes got reverted by commit 3adc43b ("win32: Make once-test work").
That would be my fault.
> However, this still doesn't work on OSX as here, pthread is in general
> available, but the barrier APIs aren't.
Isn't there a way to make once-test work without using bariers? It
think that that's what I have done for the win32 case, or am I smoking
something here?
Maarten
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
[pulseaudio-discuss] [PATCH] osx: don't build the once-test binary on OS X
From: Daniel Mack
This patch was already added earlier with commit ID 2f86ba4f, but the
changes got reverted by commit 3adc43b ("win32: Make once-test work").
However, this still doesn't work on OSX as here, pthread is in general
available, but the barrier APIs aren't.
---
src/Makefile.am |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 7f547cd..fdb2e99 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -244,7 +244,6 @@ TESTS = \
TESTS_norun = \
mcalign-test \
- once-test \
pacat-simple \
parec-simple \
extended-test \
@@ -262,6 +261,11 @@ TESTS += \
usergroup-test
endif
+if !OS_IS_DARWIN
+TESTS_norun += \
+ once-test
+endif
+
if HAVE_SIGXCPU
TESTS_norun += \
cpulimit-test \
--
1.7.2
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
