[pulseaudio-discuss] [PATCH 0/8] more Coverity fixes and cleanups
some more Coverity fixes and cleanups also addresses Hajime Fujita's earlier review comments Peter Meerwald-Stadler (8): raop: Fix potential dereference after NULL check raop: Fix potential NULL dereference raop: Log if pa_atoi() fails, latency is not used anyway raop: Error out on parsing server port component core: Assert return value of pa_shared_set/_remove() in dbus-shared core: Document behaviour of pa_shared_remove() in case name does not exist oss: Fix dead code pulse: Explicitly ignore pa_mainloop_run() return value in thread function src/modules/oss/module-oss.c | 2 +- src/modules/raop/raop-client.c | 50 +- src/modules/raop/raop-sink.c | 10 + src/pulse/thread-mainloop.c| 2 +- src/pulsecore/dbus-shared.c| 4 ++-- src/pulsecore/shared.c | 2 +- src/pulsecore/shared.h | 4 +++- 7 files changed, 44 insertions(+), 30 deletions(-) -- 2.7.4 ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH 0/8] more Coverity fixes and cleanups
Hi Peter, Thank you for the fix; raop patches look good to me. Best, Hajime > On Mar 8, 2017, at 9:09 AM, Peter Meerwald-Stadler wrote: > > some more Coverity fixes and cleanups > also addresses Hajime Fujita's earlier review comments > > Peter Meerwald-Stadler (8): > raop: Fix potential dereference after NULL check > raop: Fix potential NULL dereference > raop: Log if pa_atoi() fails, latency is not used anyway > raop: Error out on parsing server port component > core: Assert return value of pa_shared_set/_remove() in dbus-shared > core: Document behaviour of pa_shared_remove() in case name does not >exist > oss: Fix dead code > pulse: Explicitly ignore pa_mainloop_run() return value in thread >function > > src/modules/oss/module-oss.c | 2 +- > src/modules/raop/raop-client.c | 50 +- > src/modules/raop/raop-sink.c | 10 + > src/pulse/thread-mainloop.c| 2 +- > src/pulsecore/dbus-shared.c| 4 ++-- > src/pulsecore/shared.c | 2 +- > src/pulsecore/shared.h | 4 +++- > 7 files changed, 44 insertions(+), 30 deletions(-) > > -- > 2.7.4 > > ___ > pulseaudio-discuss mailing list > pulseaudio-discuss@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH 0/8] more Coverity fixes and cleanups
On 08.03.2017 16:09, Peter Meerwald-Stadler wrote: some more Coverity fixes and cleanups also addresses Hajime Fujita's earlier review comments Peter Meerwald-Stadler (8): raop: Fix potential dereference after NULL check raop: Fix potential NULL dereference raop: Log if pa_atoi() fails, latency is not used anyway raop: Error out on parsing server port component core: Assert return value of pa_shared_set/_remove() in dbus-shared core: Document behaviour of pa_shared_remove() in case name does not exist oss: Fix dead code pulse: Explicitly ignore pa_mainloop_run() return value in thread function src/modules/oss/module-oss.c | 2 +- src/modules/raop/raop-client.c | 50 +- src/modules/raop/raop-sink.c | 10 + src/pulse/thread-mainloop.c| 2 +- src/pulsecore/dbus-shared.c| 4 ++-- src/pulsecore/shared.c | 2 +- src/pulsecore/shared.h | 4 +++- 7 files changed, 44 insertions(+), 30 deletions(-) Look good to me, except where noted. ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH 0/8] more Coverity fixes and cleanups
> Thank you for the fix; raop patches look good to me. thanks, pushed the first 4 (raop) patches > > some more Coverity fixes and cleanups > > also addresses Hajime Fujita's earlier review comments > > > > Peter Meerwald-Stadler (8): > > raop: Fix potential dereference after NULL check > > raop: Fix potential NULL dereference > > raop: Log if pa_atoi() fails, latency is not used anyway > > raop: Error out on parsing server port component > > core: Assert return value of pa_shared_set/_remove() in dbus-shared > > core: Document behaviour of pa_shared_remove() in case name does not > >exist > > oss: Fix dead code > > pulse: Explicitly ignore pa_mainloop_run() return value in thread > >function -- Peter Meerwald-Stadler Mobile: +43 664 24 44 418 ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH 0/8] more Coverity fixes and cleanups
> > Peter Meerwald-Stadler (8): > >raop: Fix potential dereference after NULL check > >raop: Fix potential NULL dereference > >raop: Log if pa_atoi() fails, latency is not used anyway > >raop: Error out on parsing server port component > >core: Assert return value of pa_shared_set/_remove() in dbus-shared > >core: Document behaviour of pa_shared_remove() in case name does not > > exist > >oss: Fix dead code > >pulse: Explicitly ignore pa_mainloop_run() return value in thread > > function > Look good to me, except where noted. entire series is now applied after addressing Georg's comments -- Peter Meerwald-Stadler Mobile: +43 664 24 44 418 ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
