Re: [pulseaudio-discuss] [PATCH 2/2] Warn on loading module-dbus-protocol

2014-12-08 Thread Tanu Kaskinen 
On Thu, 2014-12-04 at 20:34 +0500, Alexander E. Patrakov wrote:
 See also
 https://www.mail-archive.com/ubuntu-audio-dev@lists.launchpad.net/msg00268.html
 
 The warning may be useful for users who carried over the module-loading
 statement from default configuration files shipped with old PulseAudio
 versions.
 
 Signed-off-by: Alexander E. Patrakov patra...@gmail.com
 ---
  src/modules/dbus/module-dbus-protocol.c | 5 +
  1 file changed, 5 insertions(+)
 
 diff --git a/src/modules/dbus/module-dbus-protocol.c 
 b/src/modules/dbus/module-dbus-protocol.c
 index ab5546f..e5f1221 100644
 --- a/src/modules/dbus/module-dbus-protocol.c
 +++ b/src/modules/dbus/module-dbus-protocol.c
 @@ -529,6 +529,11 @@ int pa__init(pa_module *m) {
  
  pa_assert(m);
  
 +pa_log_warn(module-dbus-protocol is currently unsupported, and can 
 sometimes cause PulseAudio crashes.);
 +pa_log_warn(The most popular use cases for module-dbus-protocol are 
 related to changing 
 +equalizer settings and LADSPA plugin parameters at 
 runtime.);
 +pa_log_warn(If you don't use such functionality, it's possible that you 
 don't actually need this module.);
 +
  if (!(ma = pa_modargs_new(m-argument, valid_modargs))) {
  pa_log(Failed to parse module arguments.);
  goto fail;

Thanks, pushed.

-- 
Tanu

___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

[pulseaudio-discuss] [PATCH 2/2] Warn on loading module-dbus-protocol

2014-12-04 Thread Alexander E. Patrakov 
See also
https://www.mail-archive.com/ubuntu-audio-dev@lists.launchpad.net/msg00268.html

The warning may be useful for users who carried over the module-loading
statement from default configuration files shipped with old PulseAudio
versions.

Signed-off-by: Alexander E. Patrakov patra...@gmail.com
---
 src/modules/dbus/module-dbus-protocol.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/src/modules/dbus/module-dbus-protocol.c 
b/src/modules/dbus/module-dbus-protocol.c
index ab5546f..e5f1221 100644
--- a/src/modules/dbus/module-dbus-protocol.c
+++ b/src/modules/dbus/module-dbus-protocol.c
@@ -529,6 +529,11 @@ int pa__init(pa_module *m) {
 
 pa_assert(m);
 
+pa_log_warn(module-dbus-protocol is currently unsupported, and can 
sometimes cause PulseAudio crashes.);
+pa_log_warn(The most popular use cases for module-dbus-protocol are 
related to changing 
+equalizer settings and LADSPA plugin parameters at runtime.);
+pa_log_warn(If you don't use such functionality, it's possible that you 
don't actually need this module.);
+
 if (!(ma = pa_modargs_new(m-argument, valid_modargs))) {
 pa_log(Failed to parse module arguments.);
 goto fail;
-- 
2.1.3

___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss