Re: [pulseaudio-discuss] [PATCH v6 00/37] raop2 support for module-raop-sink

[Hajime Fujita]

Hi Arun,

> On Feb 15, 2016, at 3:32 AM, Arun Raghavan  wrote:
> 
> On 12 February 2016 at 12:03, Hajime Fujita  wrote:
>> Hi Arun,
>> 
>> Arun Raghavan wrote:
>>> Hi Hajime,
>>> I'm still working on this, it's slow going since I have other things to
>>> do in parallel.
>> 
>> Thank you for your reply. Yeah that's totally fine. Just wanted make sure if 
>> it was appropriate to submit a new series.
>> 
>>> It's a bit hard to review this work properly per-commit, so I'm going
>>> to try to summarise the issues I've found at one go.
>>> 
>>> * There are some style issues that I'm fixing up as I find, and I'll
>>> just have that as a commit on top of your tree.
>>> 
>>> * While testing, I see there are two instances loaded every time (one
>>> for IPv4 and one for IPv6) -- wouldn't it be more user friendly to make
>>> sure we load only one? This doesn't appear to be a new issue, so not a
>>> blocker on this series
>> 
>> I've been aware of this for a while. I think my thought was that some user 
>> might want to explicitly choose IPv4 or v6 address. I'm not sure if it is a 
>> real need though.
>> 
>>> 
>>> * I tried this against Airserver on a Mac (worked) and a current
>>> generation Apple TV (did not work) -- just got stuck trying to start
>>> playback
>> 
>> Hmm you mean the latest Apple TV which came out last year? I currently don't 
>> have that one so it'll be a bit hard to debug... let me check the price :)
> 
> That's the one. I might be able to try again and get you a packet
> capture if that helps.

Yeah that’d definitely help.


Thank you,
Hajime

> 
> -- Arun
> ___
> pulseaudio-discuss mailing list
> pulseaudio-discuss@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH v6 00/37] raop2 support for module-raop-sink

[Hajime Fujita]

Hi Arun,

Arun Raghavan wrote:
> Hi Hajime,
> I'm still working on this, it's slow going since I have other things to
> do in parallel.

Thank you for your reply. Yeah that's totally fine. Just wanted make sure if it 
was appropriate to submit a new series.

> It's a bit hard to review this work properly per-commit, so I'm going
> to try to summarise the issues I've found at one go. 
> 
> * There are some style issues that I'm fixing up as I find, and I'll
> just have that as a commit on top of your tree.
> 
> * While testing, I see there are two instances loaded every time (one
> for IPv4 and one for IPv6) -- wouldn't it be more user friendly to make
> sure we load only one? This doesn't appear to be a new issue, so not a
> blocker on this series

I've been aware of this for a while. I think my thought was that some user 
might want to explicitly choose IPv4 or v6 address. I'm not sure if it is a 
real need though.

> 
> * I tried this against Airserver on a Mac (worked) and a current
> generation Apple TV (did not work) -- just got stuck trying to start
> playback

Hmm you mean the latest Apple TV which came out last year? I currently don't 
have that one so it'll be a bit hard to debug... let me check the price :)

> 
> Will reply again once I'm through the patch set.
> 
> Regards,
> Arun
> 
> On Wed, 2016-02-10 at 18:50 -0600, Hajime Fujita wrote:
>> Hi Arun,
>>
>> Are you still going through the patches?
>> If you are done, I'll submit a new series of patches that address
>> your comments.
>>
>>
>> Thanks,
>> Hajime
>>
>> Hajime Fujita wrote:
>>> Arun Raghavan wrote:
 On Sun, 2016-01-31 at 22:15 -0600, Hajime Fujita wrote:
> From: Hajime Fujita 
>
> This is basically same as the previous patch series,
> with several patches squashed for conciseness, rebased
> on the latest master.
> http://lists.freedesktop.org/archives/pulseaudio-discuss/2015-O
> ctober
> /024547.html
>
> This patch set adds a support for UDP version of RAOP (so
> called
> raop2). Most of the RAOP devices (e.g. AppleTV, AirportExpress,
> third party AV receivers) today use UDP version, so this patch
> set is expected to support those devices.
>
> Also the patches can be seen from here:
> https://github.com/hfujita/pulseaudio-raop2/compare/323dc5bf...
> hf/rao
> p2-v4-v8.0
>

 Thank you for your perseverance in getting this through. I'm
 going to
 try to do a pass through the list in the coming days.

 I'm using the raop2-v4-v8.0 branch. Please let me know if I
 should be
 looking at something else.
>>>
>>> Hi Arun,
>>>
>>> Thank you for taking a look at this.
>>> Yes, that is the right one. I'll start addressing your comments.
>>>
>>>
>>> Best,
>>> Hajime
>>>

 Regards,
 Arun
 ___
 pulseaudio-discuss mailing list
 pulseaudio-discuss@lists.freedesktop.org
 https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

>>>
>>> ___
>>> pulseaudio-discuss mailing list
>>> pulseaudio-discuss@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
>>>
>>
>> ___
>> pulseaudio-discuss mailing list
>> pulseaudio-discuss@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
> ___
> pulseaudio-discuss mailing list
> pulseaudio-discuss@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
> 

___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH v6 00/37] raop2 support for module-raop-sink

[Arun Raghavan]

Hi Hajime,
I'm still working on this, it's slow going since I have other things to
do in parallel.

It's a bit hard to review this work properly per-commit, so I'm going
to try to summarise the issues I've found at one go. 

* There are some style issues that I'm fixing up as I find, and I'll
just have that as a commit on top of your tree.

* While testing, I see there are two instances loaded every time (one
for IPv4 and one for IPv6) -- wouldn't it be more user friendly to make
sure we load only one? This doesn't appear to be a new issue, so not a
blocker on this series

* I tried this against Airserver on a Mac (worked) and a current
generation Apple TV (did not work) -- just got stuck trying to start
playback

Will reply again once I'm through the patch set.

Regards,
Arun

On Wed, 2016-02-10 at 18:50 -0600, Hajime Fujita wrote:
> Hi Arun,
> 
> Are you still going through the patches?
> If you are done, I'll submit a new series of patches that address
> your comments.
> 
> 
> Thanks,
> Hajime
> 
> Hajime Fujita wrote:
> > Arun Raghavan wrote:
> > > On Sun, 2016-01-31 at 22:15 -0600, Hajime Fujita wrote:
> > > > From: Hajime Fujita 
> > > > 
> > > > This is basically same as the previous patch series,
> > > > with several patches squashed for conciseness, rebased
> > > > on the latest master.
> > > > http://lists.freedesktop.org/archives/pulseaudio-discuss/2015-O
> > > > ctober
> > > > /024547.html
> > > > 
> > > > This patch set adds a support for UDP version of RAOP (so
> > > > called
> > > > raop2). Most of the RAOP devices (e.g. AppleTV, AirportExpress,
> > > > third party AV receivers) today use UDP version, so this patch
> > > > set is expected to support those devices.
> > > > 
> > > > Also the patches can be seen from here:
> > > > https://github.com/hfujita/pulseaudio-raop2/compare/323dc5bf...
> > > > hf/rao
> > > > p2-v4-v8.0
> > > > 
> > > 
> > > Thank you for your perseverance in getting this through. I'm
> > > going to
> > > try to do a pass through the list in the coming days.
> > > 
> > > I'm using the raop2-v4-v8.0 branch. Please let me know if I
> > > should be
> > > looking at something else.
> > 
> > Hi Arun,
> > 
> > Thank you for taking a look at this.
> > Yes, that is the right one. I'll start addressing your comments.
> > 
> > 
> > Best,
> > Hajime
> > 
> > > 
> > > Regards,
> > > Arun
> > > ___
> > > pulseaudio-discuss mailing list
> > > pulseaudio-discuss@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
> > > 
> > 
> > ___
> > pulseaudio-discuss mailing list
> > pulseaudio-discuss@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
> > 
> 
> ___
> pulseaudio-discuss mailing list
> pulseaudio-discuss@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH v6 00/37] raop2 support for module-raop-sink

[Hajime Fujita]

Hi Arun,

Are you still going through the patches?
If you are done, I'll submit a new series of patches that address your comments.


Thanks,
Hajime

Hajime Fujita wrote:
> Arun Raghavan wrote:
>> On Sun, 2016-01-31 at 22:15 -0600, Hajime Fujita wrote:
>>> From: Hajime Fujita 
>>>
>>> This is basically same as the previous patch series,
>>> with several patches squashed for conciseness, rebased
>>> on the latest master.
>>> http://lists.freedesktop.org/archives/pulseaudio-discuss/2015-October
>>> /024547.html
>>>
>>> This patch set adds a support for UDP version of RAOP (so called
>>> raop2). Most of the RAOP devices (e.g. AppleTV, AirportExpress,
>>> third party AV receivers) today use UDP version, so this patch
>>> set is expected to support those devices.
>>>
>>> Also the patches can be seen from here:
>>> https://github.com/hfujita/pulseaudio-raop2/compare/323dc5bf...hf/rao
>>> p2-v4-v8.0
>>>
>>
>> Thank you for your perseverance in getting this through. I'm going to
>> try to do a pass through the list in the coming days.
>>
>> I'm using the raop2-v4-v8.0 branch. Please let me know if I should be
>> looking at something else.
> 
> Hi Arun,
> 
> Thank you for taking a look at this.
> Yes, that is the right one. I'll start addressing your comments.
> 
> 
> Best,
> Hajime
> 
>>
>> Regards,
>> Arun
>> ___
>> pulseaudio-discuss mailing list
>> pulseaudio-discuss@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
>>
> 
> ___
> pulseaudio-discuss mailing list
> pulseaudio-discuss@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
> 

___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH v6 00/37] raop2 support for module-raop-sink

[Arun Raghavan]

On Sun, 2016-01-31 at 22:15 -0600, Hajime Fujita wrote:
> From: Hajime Fujita 
> 
> This is basically same as the previous patch series,
> with several patches squashed for conciseness, rebased
> on the latest master.
> http://lists.freedesktop.org/archives/pulseaudio-discuss/2015-October
> /024547.html
> 
> This patch set adds a support for UDP version of RAOP (so called
> raop2). Most of the RAOP devices (e.g. AppleTV, AirportExpress,
> third party AV receivers) today use UDP version, so this patch
> set is expected to support those devices.
> 
> Also the patches can be seen from here:
> https://github.com/hfujita/pulseaudio-raop2/compare/323dc5bf...hf/rao
> p2-v4-v8.0
> 

Thank you for your perseverance in getting this through. I'm going to
try to do a pass through the list in the coming days.

I'm using the raop2-v4-v8.0 branch. Please let me know if I should be
looking at something else.

Regards,
Arun
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH v6 00/37] raop2 support for module-raop-sink

[Hajime Fujita]

Arun Raghavan wrote:
> On Sun, 2016-01-31 at 22:15 -0600, Hajime Fujita wrote:
>> From: Hajime Fujita 
>>
>> This is basically same as the previous patch series,
>> with several patches squashed for conciseness, rebased
>> on the latest master.
>> http://lists.freedesktop.org/archives/pulseaudio-discuss/2015-October
>> /024547.html
>>
>> This patch set adds a support for UDP version of RAOP (so called
>> raop2). Most of the RAOP devices (e.g. AppleTV, AirportExpress,
>> third party AV receivers) today use UDP version, so this patch
>> set is expected to support those devices.
>>
>> Also the patches can be seen from here:
>> https://github.com/hfujita/pulseaudio-raop2/compare/323dc5bf...hf/rao
>> p2-v4-v8.0
>>
> 
> Thank you for your perseverance in getting this through. I'm going to
> try to do a pass through the list in the coming days.
> 
> I'm using the raop2-v4-v8.0 branch. Please let me know if I should be
> looking at something else.

Hi Arun,

Thank you for taking a look at this.
Yes, that is the right one. I'll start addressing your comments.


Best,
Hajime

> 
> Regards,
> Arun
> ___
> pulseaudio-discuss mailing list
> pulseaudio-discuss@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
> 

___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

[pulseaudio-discuss] [PATCH v6 00/37] raop2 support for module-raop-sink

[Hajime Fujita]

From: Hajime Fujita 

This is basically same as the previous patch series,
with several patches squashed for conciseness, rebased
on the latest master.
http://lists.freedesktop.org/archives/pulseaudio-discuss/2015-October/024547.html

This patch set adds a support for UDP version of RAOP (so called
raop2). Most of the RAOP devices (e.g. AppleTV, AirportExpress,
third party AV receivers) today use UDP version, so this patch
set is expected to support those devices.

Also the patches can be seen from here:
https://github.com/hfujita/pulseaudio-raop2/compare/323dc5bf...hf/raop2-v4-v8.0

Colin Leroy (5):
  rtp: New pa_rtsp_options function
  raop: Fix sink getting destroyed after one use
  raop: fix sequence number overflow
  raop: fix typos
  raop: Fix packet retransmission

Hajime Fujita (11):
  Support IPv6 address in pa_socket_client_new_string()
  rtp: Freeing ioline when disconnecting
  rtp: Introduce pa_rtsp_exec_ready()
  raop: Add UDP protocol handling
  raop: Add address to RAOP device description
  raop: Add IPv6 support
  raop: Silently drop out-of-history retransmission request
  raop: Stop recording when RTSP FLUSH is issued
  raop: Disable is_recording flag when tearing down the connection
  raop: Discard data upon getting EAGAIN on a socket
  raop: Fix memory leaks

Martin Blanchard (17):
  raop: Cosmetic fixes / Match coding style
  raop: Add pulsecore/core-utils a pa_str_in_list function
  raop: Parse server capabilities on discovery
  rtp: Random seq number at the beginning of the session
  raop: Do not send audio before RECORD response
  raop: Better playback resume handling
  raop: Extract encryption related code into a separate file
  raop: Add a MD5 hashing fuction
  raop: Add BA (Basic) and DA (Digest) HTTP authentication helpers
  raop: Add the core implementation of RAOP authentication
  raop: Merge TCP and UDP code paths + refactoring
  raop: Prefer ALAC encoding to raw PCM if supported by server
  raop: Update and standardise source file headers
  raop: Rework packet's store memory management
  raop: Remove unimplemented code (PCM and AAC)
  raop: Correctly wrap RTP packet sequence number
  raop: Add back initial volume RTSP SET_PARAMETER request on connect

Matthias Wabersich (1):
  raop: Packet retransmission support for UDP

Stephen Paul Weber (1):
  raop: Do not flush when RTSP object is not ready

ced2c (2):
  raop: Fix #36: invalid access to freed object
  raop: Fix #37: OOB access in rtsp_auth_cb

 src/Makefile.am |8 +-
 src/modules/raop/base64.c   |  124 ---
 src/modules/raop/base64.h   |   32 -
 src/modules/raop/module-raop-discover.c |  253 +++--
 src/modules/raop/module-raop-sink.c |  636 +--
 src/modules/raop/raop-client.c  | 1767 +++
 src/modules/raop/raop-client.h  |   83 ++
 src/modules/raop/raop-crypto.c  |  146 +++
 src/modules/raop/raop-crypto.h  |   35 +
 src/modules/raop/raop-packet-buffer.c   |  161 +++
 src/modules/raop/raop-packet-buffer.h   |   40 +
 src/modules/raop/raop-sink.c|  669 
 src/modules/raop/raop-sink.h|   33 +
 src/modules/raop/raop-util.c|  209 
 src/modules/raop/raop-util.h|   32 +
 src/modules/raop/raop_client.c  |  563 --
 src/modules/raop/raop_client.h  |   42 -
 src/modules/rtp/rtsp_client.c   |  173 ++-
 src/modules/rtp/rtsp_client.h   |   60 +-
 src/pulsecore/core-util.c   |   20 +
 src/pulsecore/core-util.h   |5 +-
 src/pulsecore/parseaddr.c   |   11 +
 src/pulsecore/parseaddr.h   |2 +
 src/pulsecore/socket-client.c   |   21 +-
 24 files changed, 3598 insertions(+), 1527 deletions(-)
 delete mode 100644 src/modules/raop/base64.c
 delete mode 100644 src/modules/raop/base64.h
 create mode 100644 src/modules/raop/raop-client.c
 create mode 100644 src/modules/raop/raop-client.h
 create mode 100644 src/modules/raop/raop-crypto.c
 create mode 100644 src/modules/raop/raop-crypto.h
 create mode 100644 src/modules/raop/raop-packet-buffer.c
 create mode 100644 src/modules/raop/raop-packet-buffer.h
 create mode 100644 src/modules/raop/raop-sink.c
 create mode 100644 src/modules/raop/raop-sink.h
 create mode 100644 src/modules/raop/raop-util.c
 create mode 100644 src/modules/raop/raop-util.h
 delete mode 100644 src/modules/raop/raop_client.c
 delete mode 100644 src/modules/raop/raop_client.h

-- 
2.5.0

___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss