Re: [pulseaudio-discuss] [PATCH 2/4] Add A2DP AAC codec support

2018-12-19 Thread Huang-Huang Bao

On 12/20/18 1:09 AM, Pali Rohár wrote:
> On Thursday 13 December 2018 19:43:37 EHfive wrote:
>> Optional (build with --disable-bluez5-aac-codec)
>>
>> AAC User Configurations:
>>KEY VALUEDESC  
>> DEFAULT
>>aac_bitrate_mode[1, 5]   Variable Bitrate (VBR) (encoder)  5
>>0Constant Bitrate (CBR) (encoder)
>>
>>aac_fmt s16  16-bit signed LE (encoder)
>> auto
>>s32  32-bit signed LE (encoder)
>>auto
>>
>>aac_afterburner  FDK-AAC afterburner feature (encoder) on
> In my opinion, support for AAC make sense only in passthrough mode. E.g.
> when your music files are already stored in AAC and you have headset
> with AAC support; and you do not want to re-encode it twice.

I think if we have high enough sample rate and bit depth, decode -
encode wouldn't cause sound quality loss.

>
> But I do not see support for passthrough mode in this patch. It is
> planned?

Not planned.

Besides, AAC here stands for AAC-LC, so not all AAC could do what you say.

> Maybe similar thing could be useful for MPEG1 A2DP audio codec (as lot
> of people listen MP3 files), but I have not seen headset with MPEG1
> support...
>



signature.asc
Description: OpenPGP digital signature
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss


Re: [pulseaudio-discuss] [PATCH 2/4] Add A2DP AAC codec support

2018-12-19 Thread Pali Rohár
On Thursday 13 December 2018 19:43:37 EHfive wrote:
> Optional (build with --disable-bluez5-aac-codec)
> 
> AAC User Configurations:
>KEY VALUEDESC  
> DEFAULT
>aac_bitrate_mode[1, 5]   Variable Bitrate (VBR) (encoder)  5
>0Constant Bitrate (CBR) (encoder)
> 
>aac_fmt s16  16-bit signed LE (encoder)auto
>s32  32-bit signed LE (encoder)
>auto
> 
>aac_afterburner  FDK-AAC afterburner feature (encoder) on

In my opinion, support for AAC make sense only in passthrough mode. E.g.
when your music files are already stored in AAC and you have headset
with AAC support; and you do not want to re-encode it twice.

But I do not see support for passthrough mode in this patch. It is
planned?

Maybe similar thing could be useful for MPEG1 A2DP audio codec (as lot
of people listen MP3 files), but I have not seen headset with MPEG1
support...

-- 
Pali Rohár
pali.ro...@gmail.com


signature.asc
Description: PGP signature
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss