[pulseaudio-tickets] [PulseAudio] #818: syntax error in rtp.c

2010-05-08 Thread PulseAudio 
#818: syntax error in rtp.c
+---
 Reporter:  pino|   Owner:  lennart 
 Type:  defect  |  Status:  new 
Milestone:  |   Component:  module-rtp-*
 Keywords:  |  
+---
 In the pa_rtp_recv() function of rtp.c there is:

 for (cm = CMSG_FIRSTHDR(m); cm; cm = CMSG_NXTHDR(m, cm)) {
 if (cm-cmsg_level == SOL_SOCKET  cm-cmsg_type == SO_TIMESTAMP)
 memcpy(tstamp, CMSG_DATA(cm), sizeof(struct timeval));
 found_tstamp = TRUE;
 break;
 }

 There is one opening and one closing brackets less, so the loop will set
 found_tstamp TRUE and break just after the first iteration, no matter
 whether the current cmsghdr had the right payload.

-- 
Ticket URL: http://pulseaudio.org/ticket/818
PulseAudio http://pulseaudio.org/
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #818: syntax error in rtp.c

2010-05-08 Thread PulseAudio 
#818: syntax error in rtp.c
-+--
  Reporter:  pino|   Owner:  lennart 
  Type:  defect  |  Status:  new 
 Milestone:  |   Component:  module-rtp-*
Resolution:  |Keywords:  
-+--

Comment(by coling):

 Oooh, good catch. I'll get that fixed up in a mo'

-- 
Ticket URL: http://pulseaudio.org/ticket/818#comment:1
PulseAudio http://pulseaudio.org/
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #818: syntax error in rtp.c

2010-05-08 Thread PulseAudio 
#818: syntax error in rtp.c
-+--
  Reporter:  pino|   Owner:  lennart 
  Type:  defect  |  Status:  closed  
 Milestone:  |   Component:  module-rtp-*
Resolution:  fixed   |Keywords:  
-+--
Changes (by coling):

  * status:  new = closed
  * resolution:  = fixed


Comment:

 Fixed now in stable-queue and I'll push to master shortly. Many thanks for
 the report.

-- 
Ticket URL: http://pulseaudio.org/ticket/818#comment:2
PulseAudio http://pulseaudio.org/
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets