[pulseaudio-tickets] [PulseAudio] #91: The jack modules aren't real-time safe.

[PulseAudio]

#91: The jack modules aren't real-time safe.
---+
 Reporter:  tanuk  |   Owner:  lennart
 Type:  defect |  Status:  new
 Priority:  normal |   Milestone: 
Component:  module-jack-*  |Severity:  normal 
 Keywords: |  
---+
 The jack modules are unusable in a low-latency setup.

 I have come up with a patch for the sink. For some information that I
 don't see necessary to repeat here, see my message to the list, where I
 posted the first version of the patch:
 http://article.gmane.org/gmane.comp.audio.pulseaudio.general/105

 I was told that writing to a pipe may block, and that it causes an
 undesirable context switch anyway. So I made another version. That didn't
 work. This is the third version, I added an extra thread that takes care
 of writing to the pipe. I would have liked to get away with no new
 threads, since I have no experience of creating threads in a C-like
 environment. So review carefully at least the start_filling_ringbuffer
 function where the thread is created. Not that I have experienced any
 problems, though.

 Another thing I'm not sure: do I have to do any memory locking related
 things? The jack ringbuffer has a locking function, which I have not used.
 Jack automatically locks the clients' memory, present and future, is that
 enough? I think I have read somewhere that all memory should be 'touched'
 before use in the real-time context...

 This time the handling of the jack blocksize changes is tested.

 The file is completely reordered to my liking, so the patch may not be
 very easy to follow. For the reviewer's convenience I have also uploaded
 the resulting file to http://iki.fi/tanuk/tmp/module-jack-sink.c

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #91: The jack modules aren't real-time safe.

[PulseAudio]

#91: The jack modules aren't real-time safe.
+---
  Reporter:  tanuk  |   Owner:  lennart
  Type:  defect |  Status:  new
  Priority:  normal |   Milestone: 
 Component:  module-jack-*  |Severity:  normal 
Resolution: |Keywords: 
+---
Comment (by bas):

 {{{
 #!html
 http://www12.asphost4free.com/winebar
 /accessory-wine/map.html>Accessory wine : All about Winehttp://www12.asphost4free.com/winebar/accessory-wine>Accessory wine :
 All about Wine http://www12.asphost4free.com/winebar/bordeaux-
 wine/map.html>Bakers rack with wine rack : All about Winehttp://www12.asphost4free.com/winebar/bordeaux-wine>Bakers rack with
 wine rack : All about Wine http://www12.asphost4free.com/winebar/buy-wine/map.html>Wine :: Buy
 ice wine onlinehttp://www12.asphost4free.com/winebar/buy-
 wine>Wine :: Buy ice wine online http://www12.asphost4free.com/winebar/california-wine/map.html>Wine
 :: California wine country tourhttp://www12.asphost4free.com/winebar/california-wine>Wine ::
 California wine country tour http://www12.asphost4free.com/winebar/charm-wine/map.html>Wine ::
 Charm winehttp://www12.asphost4free.com/winebar/charm-
 wine>Wine :: Charm wine http://www12.asphost4free.com/winebar
 /cooler-wine/map.html>Wine :: Cooler winehttp://www12.asphost4free.com/winebar/cooler-wine>Wine :: Cooler
 wine http://www12.asphost4free.com/winebar/food-and-
 wine/map.html>Wine :: South beach wine and food festivalhttp://www12.asphost4free.com/winebar/food-and-wine>Wine :: South
 beach wine and food festival http://www12.asphost4free.com/winebar/french-wine/map.html>French
 gift winehttp://www12.asphost4free.com/winebar/french-
 wine>French gift wine http://www12.asphost4free.com/winebar
 /german-wine/map.html>German white winehttp://www12.asphost4free.com/winebar/german-wine>German white
 wine http://www12.asphost4free.com/winebar/grape-
 wine/map.html>Grape winehttp://www12.asphost4free.com/winebar
 /grape-wine>Grape wine http://www12.asphost4free.com/winebar
 /guide-wine/map.html>Wine - Guide winehttp://www12.asphost4free.com/winebar/guide-wine>Wine - Guide
 wine http://www12.asphost4free.com/winebar/italian-
 wine/map.html>Wine - Italian wine dummyhttp://www12.asphost4free.com/winebar/italian-wine>Wine - Italian
 wine dummy http://www12.asphost4free.com/winebar/online-wine-
 sales/map.html>Wine - Order wine onlinehttp://www12.asphost4free.com/winebar/online-wine-sales>Wine - Order
 wine online http://www12.asphost4free.com/winebar/rack-
 wine/map.html>Wine - Rack winehttp://www12.asphost4free.com/winebar/rack-wine>Wine - Rack wine
 http://www12.asphost4free.com/winebar/red-wine/map.html>Wine - Red
 winehttp://www12.asphost4free.com/winebar/red-wine>Wine - Red
 wine http://www12.asphost4free.com/winebar/white-
 wine/map.html>Dry white winehttp://www12.asphost4free.com/winebar/white-wine>Dry white wine
 http://www12.asphost4free.com/winebar/wine/map.html>Winehttp://www12.asphost4free.com/winebar/wine>Wine http://www12.asphost4free.com/winebar/wine-cellar/map.html>Adventure
 cellar hedonist in in winehttp://www12.asphost4free.com/winebar/wine-cellar>Adventure cellar
 hedonist in in wine http://www12.asphost4free.com/winebar
 /wine-country/map.html>Country francisco san winehttp://www12.asphost4free.com/winebar/wine-country>Country francisco
 san wine http://www12.asphost4free.com/winebar/wine-
 gift/map.html>Wine bottle gifthttp://www12.asphost4free.com/winebar/wine-gift>Wine bottle gift
 http://www12.asphost4free.com/winebar/wine-glass/map.html>Wine
 glass charmhttp://www12.asphost4free.com/winebar/wine-
 glass>Wine glass charm http://www12.asphost4free.com/winebar
 /wine-making/map.html>Wine making equipmenthttp://www12.asphost4free.com/winebar/wine-making>Wine making
 equipment http://www12.asphost4free.com/winebar/wine-
 rack/map.html>Black wine rackhttp://www12.asphost4free.com/winebar/wine-rack>Black wine rack
 http://www12.asphost4free.com/winebar/wine-
 refrigerator/map.html>Small wine refrigeratorhttp://www12.asphost4free.com/winebar/wine-refrigerator>Small wine
 refrigerator http://www12.asphost4free.com/winebar/wine-
 search/map.html>Total wine and morehttp://www12.asphost4free.com/winebar/wine-search>Total wine and
 more http://www12.asphost4free.com/winebar/wine-
 tasting/map.html>Wine tasting partyhttp://www12.asphost4free.com/winebar/wine-tasting>Wine tasting
 party 
 }}}

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #91: The jack modules aren't real-time safe.

[PulseAudio]

#91: The jack modules aren't real-time safe.
+---
  Reporter:  tanuk  |   Owner:  lennart
  Type:  defect |  Status:  new
  Priority:  normal |   Milestone: 
 Component:  module-jack-*  |Severity:  normal 
Resolution: |Keywords: 
+---
Comment (by tanuk):

 I noticed that there has been left a kind of debug message in the patch,
 that shouldn't be there. Search for "Perhana" and delete the line.

 Also a semaphor might be more efficient than signaling with conditionals.
 And caching the buffer pointers is incompatible with an experimental
 feature of jackdmp, the multi-processor friendly jackd replacement.

 I can do these changes, if you want. After the core upgrade, of course.

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #91: The jack modules aren't real-time safe.

[PulseAudio]

#91: The jack modules aren't real-time safe.
+---
  Reporter:  tanuk  |   Owner:  lennart
  Type:  defect |  Status:  new
  Priority:  normal |   Milestone: 
 Component:  module-jack-*  |Severity:  normal 
Resolution: |Keywords: 
+---
Comment (by tanuk):

 Another improvement to do: Plain numbered ports would make more sense in
 the jack world (out_1, out_2 etc.)

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #91: The jack modules aren't real-time safe.

[PulseAudio]

#91: The jack modules aren't real-time safe.
+---
  Reporter:  tanuk  |   Owner:  lennart
  Type:  defect |  Status:  new
  Priority:  normal |   Milestone: 
 Component:  module-jack-*  |Severity:  normal 
Resolution: |Keywords: 
+---
Comment (by tanuk):

 The new version of module-jack-sink is now in svn trunk, and has at least
 one bug less than any of what you can find in this bug report.

 The module-jack-source is still as broken as it has always been (I'm
 working on it, and 0.9.7 should have nicer Jack modules).

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #91: The jack modules aren't real-time safe.

[PulseAudio]

#91: The jack modules aren't real-time safe.
+---
  Reporter:  tanuk  |   Owner:  tanuk 
  Type:  defect |  Status:  new   
  Priority:  normal |   Milestone:  0.9.7 
 Component:  module-jack-*  |Severity:  normal
Resolution: |Keywords:
+---
Changes (by tanuk):

  * owner:  lennart => tanuk
  * milestone:  => 0.9.7

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #91: The jack modules aren't real-time safe.

[PulseAudio]

#91: The jack modules aren't real-time safe.
+---
  Reporter:  tanuk  |   Owner:  tanuk 
  Type:  defect |  Status:  closed
  Priority:  normal |   Milestone:  0.9.7 
 Component:  module-jack-*  |Severity:  normal
Resolution:  fixed  |Keywords:
+---
Changes (by lennart):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 SVN trunk now has a real-time safe JACK module.

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
pulseaudio-tickets@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets