[Puppet - Bug #19955] (In Topic Branch Pending Review) Misleading error when Hiera databindings fail

2013-09-25 Thread tickets

Issue #19955 has been updated by Henrik Lindberg.

Status changed from Accepted to In Topic Branch Pending Review
Target version changed from 3.x to 3.4.0
Keywords changed from error customer to error customer databinding hiera
Branch set to https://github.com/puppetlabs/puppet/pull/1941

https://github.com/puppetlabs/puppet/pull/1941

An error message like this:

Error from DataBinding 'hiera' while looking up 'apache::port', Error: , 


Will be produced when DataBindings.find raises an exception.


Bug #19955: Misleading error when Hiera databindings fail
https://projects.puppetlabs.com/issues/19955#change-98013

* Author: Dolf Schimmel
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: 
* Category: databinding
* Target version: 3.4.0
* Affected Puppet version: 
* Keywords: error customer databinding hiera
* Branch: https://github.com/puppetlabs/puppet/pull/1941

Hi,

I just put created a hiera.yaml file with some invalid contents (`echo foobar > 
/etc/puppet/hiera.yaml`). When doing a puppet run, I'm confronted with the 
following error:


Error: Could not retrieve catalog from remote server: Error 400 on SERVER: 
can't convert String into Hash at 
/etc/puppet/environments/production/manifests/cluster/core/nodes.pp:4 on node 
puppet01.dev.example.net


The contents of the nodes.pp file is:


node 'puppet01.dev.node.net' inherits basenode {

  $manage_puppet = false
  include "cluster::core::puppetmaster::pupppet"

  include basenode::general

}


Clearly the config file is not parsed, which is alright in this case. The error 
is quite misleading though, as it suggests some error had occurred in my 
manifest, while it was caused (and fixed afterwards) in hiera.yaml.

Proposed fix would be to change the error into something meaningful. Last week 
I had the same error causing me to debug for several hours, only to do a 
vagrant destroy.


root@puppet01:/etc/puppet# puppet --version
3.1.1
root@puppet01:/etc/puppet# uname -a
Linux puppet01.dev.example.net 3.2.0-23-generic #36-Ubuntu SMP Tue Apr 10 
20:39:51 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22652] ignore doesn't work if pluginsync enabled

2013-09-25 Thread tickets

Issue #22652 has been updated by Josh Cooper.


The agent sends a POST request if the [total length exceeds 
1K](https://github.com/puppetlabs/puppet/blob/master/lib/puppet/indirector/rest.rb#L91-L97)
 . It appears rack's `Request#params` returns the "union of GET and POST data" 
whereas `Request#query_string` will not obviously. We may be able to combine 
the two approaches and do something like:


def params(request)
  result = decode_params(request.params)
  query_params = CGI.parse(request.query_string)
  convert_singular_arrays_to_value(query_params)
  result.merge!(query_params)
  result.merge(extract_client_info(request))
end


For `ignore`, the `request.params` method will truncate the list, but then we 
parse the `query_string` and that overrides the value from `request.params`.

For `facts`, the `request.params` method will return the complete set (as it 
did before), and since they are not in the query_string, we'll get the same 
behavior as before.


Bug #22652: ignore doesn't work if pluginsync enabled
https://projects.puppetlabs.com/issues/22652#change-98012

* Author: Daniel Wittenberg
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: Kylo Ginsberg
* Category: 
* Target version: 3.3.1
* Affected Puppet version: 3.3.1-rc1
* Keywords: 
* Branch: https://github.com/puppetlabs/puppet/pull/1938

/var/lib/puppet//.svn directories are still pushed out even if you have a 
global ignore 
File { ignore => '.svn' }

Confirmed by downgrading the server to 3.2.4-1 and it all worked as expected, 
no .svn directories in /var/lib/puppet


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22652] ignore doesn't work if pluginsync enabled

2013-09-25 Thread tickets

Issue #22652 has been updated by Kylo Ginsberg.


Follow on to Chuck's comment.  I verified that with pull #1938 a rack-based 
puppet master doesn't create a fact yaml file.  This is because it doesn't 
actually get the facts in the catalog request, which in turn is because rack's 
.query_string method returns the empty string for the catalog query parameters 
(which is where the facts arrive).  Just guessing, but maybe this is because 
that query string would be so long?


Bug #22652: ignore doesn't work if pluginsync enabled
https://projects.puppetlabs.com/issues/22652#change-98007

* Author: Daniel Wittenberg
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: Kylo Ginsberg
* Category: 
* Target version: 3.3.1
* Affected Puppet version: 3.3.1-rc1
* Keywords: 
* Branch: https://github.com/puppetlabs/puppet/pull/1938

/var/lib/puppet//.svn directories are still pushed out even if you have a 
global ignore 
File { ignore => '.svn' }

Confirmed by downgrading the server to 3.2.4-1 and it all worked as expected, 
no .svn directories in /var/lib/puppet


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22498] --parser=future bug transforming the number '0' to '00'

2013-09-25 Thread tickets

Issue #22498 has been updated by Henrik Lindberg.

Target version changed from 3.3.0 to 3.4.0

It did not make it into 3.3.1 - which is now in RC.
It will be in 3.4.0 unless there is a 3.3.2 and enough noise is raised to get 
it in.

I changed the target to 3.4.0


Bug #22498: --parser=future bug transforming the number '0' to '00'
https://projects.puppetlabs.com/issues/22498#change-98005

* Author: Henrik Feldt
* Status: Merged - Pending Release
* Priority: Normal
* Assignee: Henrik Lindberg
* Category: parser
* Target version: 3.4.0
* Affected Puppet version: 3.2.4
* Keywords: parser, future, numeric, numerals
* Branch: 

Create a yum repo like this:

  yumrepo { 'ip-ours':
baseurl  => "$protocol://$yum_repo_server/",
descr=> 'Our yum repository',
enabled  => 1,
gpgcheck => 0,
  }

Run puppet.

You will get:

Notice: /Stage[first]/Our_yumrepo/Yumrepo[ip-ours]/gpgcheck: gpgcheck changed 
'0' to '00'.


Corresponding yum error when you try to use this config with 00.

Templated files are also changed, but that's for another bug report.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22652] ignore doesn't work if pluginsync enabled

2013-09-25 Thread tickets

Issue #22652 has been updated by Chuck Schweizer.


Ok. I have to take back my previous post.. I found out what is happening.

I have a puppetDB backend.  

The facts on the puppet master are being pulled from the PuppetDB server and 
not being updated in the puppet masters copy of the fact.yaml file.
eg.

I reloaded the client.  it had 3.3.1-rc1 before the reload, after the reload it 
has 3.2.3

the puppet/lib/yaml/facts/server01.local.domain.yaml file has the following 
entires

With this patch:

puppetversion: "3.3.1-rc1"

Once this patch is removed

puppetversion: "3.2.3"


Bug #22652: ignore doesn't work if pluginsync enabled
https://projects.puppetlabs.com/issues/22652#change-98004

* Author: Daniel Wittenberg
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: Kylo Ginsberg
* Category: 
* Target version: 3.3.1
* Affected Puppet version: 3.3.1-rc1
* Keywords: 
* Branch: https://github.com/puppetlabs/puppet/pull/1938

/var/lib/puppet//.svn directories are still pushed out even if you have a 
global ignore 
File { ignore => '.svn' }

Confirmed by downgrading the server to 3.2.4-1 and it all worked as expected, 
no .svn directories in /var/lib/puppet


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22652] ignore doesn't work if pluginsync enabled

2013-09-25 Thread tickets

Issue #22652 has been updated by Chuck Schweizer.


RHEL6 / passenger  

This is working correctly, I think the problem I saw earlier today with this 
patch is another issue which I can not currently reproduce.  I will watch for 
the unrelated problem and open a ticket if it reoccurs.   thanks,

Current I am not having any issues with this patch.


Bug #22652: ignore doesn't work if pluginsync enabled
https://projects.puppetlabs.com/issues/22652#change-98002

* Author: Daniel Wittenberg
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: Kylo Ginsberg
* Category: 
* Target version: 3.3.1
* Affected Puppet version: 3.3.1-rc1
* Keywords: 
* Branch: https://github.com/puppetlabs/puppet/pull/1938

/var/lib/puppet//.svn directories are still pushed out even if you have a 
global ignore 
File { ignore => '.svn' }

Confirmed by downgrading the server to 3.2.4-1 and it all worked as expected, 
no .svn directories in /var/lib/puppet


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Feature #22701] Support for Microsoft .msu packages

2013-09-25 Thread tickets

Issue #22701 has been updated by Celia Cottle.

Description updated


Feature #22701: Support for Microsoft .msu packages
https://projects.puppetlabs.com/issues/22701#change-98000

* Author: Celia Cottle
* Status: Unreviewed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* Affected Puppet version: 
* Keywords: windows customer
* Branch: 

[ED: SO SORRY, hit the wrong button and deleted the whole thread instead of my 
comment.]

Hi,

I had to download a .msu package to include Powershell 3.0 on my Windows 7 
Machine. Is there any support with Puppet using the Package Resource Type?


Related to Puppet - Feature #16991: Puppet should support *.msp upgrade 
packages on Windows Accepted
History

#1 UPDATED BY JOSH COOPER 10 MONTHS AGO
Status changed from Unreviewed to Accepted
Keywords set to windows

Hi Luis, can you update the ticket with the commands you use to install and 
uninstall an msu package?

#2 UPDATED BY LUIS MAYORGA 10 MONTHS AGO
I wish i know :). I guess is documented here 
http://support.microsoft.com/kb/934307. My question is if i can use the windows 
provider on Puppet for Windows.

#3 UPDATED BY LUIS MAYORGA 10 MONTHS AGO
class ps3{
file{ 'ps3':
name => 'C:\Temp\WMF30.msu',
ensure => present,
source => 'puppet:///puppetfs/WMF30.msu'
} 
exec { 'ps3':
command => 'C:\Windows\System32\wusa.exe C:\Temp\WMF30.msu /quiet /norestart 
/log C:\Temp\Poweshellv3.htm',
require => [File["ps3"],Class["netfx45"]]
}
}
#4 UPDATED BY JOSH COOPER 9 MONTHS AGO
Luis Mayorga wrote:

command => 'C:\Windows\System32\wusa.exe C:\Temp\WMF30.msu /quiet /norestart 
/log C:\Temp\Poweshellv3.htm',
Thanks Luis, how about the uninstall command? Can you uninstall a specific msu? 
Or only the product that the msu was applied to?



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Feature #22701] (Unreviewed) Support for Microsoft .msu packages

2013-09-25 Thread tickets

Issue #22701 has been reported by Celia Cottle.


Feature #22701: Support for Microsoft .msu packages
https://projects.puppetlabs.com/issues/22701

* Author: Celia Cottle
* Status: Unreviewed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* Affected Puppet version: 
* Keywords: windows customer
* Branch: 

[ED: SO SORRY, hit the wrong button and deleted the whole thread instead of my 
comment.]

Hi,

I had to download a .msu package to include Powershell 3.0 on my Windows 7 
Machine. Is there any support with Puppet using the Package Resource Type?
Support Urls

Add
Subtasks
Add
Related issues

Related to Puppet - Feature #16991: Puppet should support *.msp upgrade 
packages on Windows AcceptedLink_break
History

#1 UPDATED BY JOSH COOPER 10 MONTHS AGO
Status changed from Unreviewed to Accepted
Keywords set to windows

Hi Luis, can you update the ticket with the commands you use to install and 
uninstall an msu package?

#2 UPDATED BY LUIS MAYORGA 10 MONTHS AGO
I wish i know :). I guess is documented here 
http://support.microsoft.com/kb/934307. My question is if i can use the windows 
provider on Puppet for Windows.

#3 UPDATED BY LUIS MAYORGA 10 MONTHS AGO
class ps3{
file{ 'ps3':
name => 'C:\Temp\WMF30.msu',
ensure => present,
source => 'puppet:///puppetfs/WMF30.msu'
} 
exec { 'ps3':
command => 'C:\Windows\System32\wusa.exe C:\Temp\WMF30.msu /quiet /norestart 
/log C:\Temp\Poweshellv3.htm',
require => [File["ps3"],Class["netfx45"]]
}
}
#4 UPDATED BY JOSH COOPER 9 MONTHS AGO
Luis Mayorga wrote:

command => 'C:\Windows\System32\wusa.exe C:\Temp\WMF30.msu /quiet /norestart 
/log C:\Temp\Poweshellv3.htm',
Thanks Luis, how about the uninstall command? Can you uninstall a specific msu? 
Or only the product that the msu was applied to?



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Feature #18013] Support for Microsoft .msu packages

2013-09-25 Thread tickets

Issue #18013 has been updated by Celia Cottle.

Keywords changed from windows to windows customer

This is NOT a premium customer, I am just noting interest. It does not get 
raised priority. 
https://support.puppetlabs.com/tickets/3107


Feature #18013: Support for Microsoft .msu packages
https://projects.puppetlabs.com/issues/18013#change-97998

* Author: Luis Mayorga
* Status: Accepted
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* Affected Puppet version: 
* Keywords: windows customer
* Branch: 

Hi,

I had to download a .msu package to include Powershell 3.0 on my Windows 7 
Machine. Is there any support with Puppet using the Package Resource Type?


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Feature #16991] Puppet should support *.msp upgrade packages on Windows

2013-09-25 Thread tickets

Issue #16991 has been updated by Celia Cottle.

Keywords changed from windows msi msp package to windows msi msp package 
customer


Feature #16991: Puppet should support *.msp upgrade packages on Windows
https://projects.puppetlabs.com/issues/16991#change-97996

* Author: Krzysiek Z
* Status: Accepted
* Priority: Normal
* Assignee: 
* Category: newfeature
* Target version: 3.x
* Affected Puppet version: 3.0.0
* Keywords: windows msi msp package customer
* Branch: 

Puppet client on Windows should make enable installing *.msp upgrade packages. 
For example when I'm trying to install update file to previously installed msi 
package client responds with error message like below:

"change from absent to present failed: Don't know how to install 
'c:\AdbeRdrUpd1013.msp'"


*.msp packages are installed in the same way as *.msi files. The only 
difference is /p switch instead if /i 


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22652] ignore doesn't work if pluginsync enabled

2013-09-25 Thread tickets

Issue #22652 has been updated by Kylo Ginsberg.


Different setup: OSX/thin/rack.  I was able to repro this issue with 3.3.1-rc1, 
and it was fixed by pull #1938.


Bug #22652: ignore doesn't work if pluginsync enabled
https://projects.puppetlabs.com/issues/22652#change-97995

* Author: Daniel Wittenberg
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: Kylo Ginsberg
* Category: 
* Target version: 3.3.1
* Affected Puppet version: 3.3.1-rc1
* Keywords: 
* Branch: https://github.com/puppetlabs/puppet/pull/1938

/var/lib/puppet//.svn directories are still pushed out even if you have a 
global ignore 
File { ignore => '.svn' }

Confirmed by downgrading the server to 3.2.4-1 and it all worked as expected, 
no .svn directories in /var/lib/puppet


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Feature #22700] (In Topic Branch Pending Review) Installing Windows agent should put puppet on the PATH

2013-09-25 Thread tickets

Issue #22700 has been updated by Rob Reynolds.

Status changed from Accepted to In Topic Branch Pending Review
Support Urls set to https://github.com/puppetlabs/puppet_for_the_win/pull/55


Feature #22700: Installing Windows agent should put puppet on the PATH
https://projects.puppetlabs.com/issues/22700#change-97994

* Author: Rob Reynolds
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: Rob Reynolds
* Category: 
* Target version: 
* Affected Puppet version: 
* Keywords: windows
* Branch: 

This will add puppet.bat, facter.bat and others in the bin folder to the system 
PATH. 

Note that this is not adding ruby items to the path so it shouldn't clobber 
with current settings of the user/machine.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22498] --parser=future bug transforming the number '0' to '00'

2013-09-25 Thread tickets

Issue #22498 has been updated by Igor Berger.


Does TargetVersion=3.3.0 mean that it should be fixed in 3.3.0?

I can confirm that the problem is present in 3.3.0,
see issue https://projects.puppetlabs.com/issues/22592



Bug #22498: --parser=future bug transforming the number '0' to '00'
https://projects.puppetlabs.com/issues/22498#change-97993

* Author: Henrik Feldt
* Status: Merged - Pending Release
* Priority: Normal
* Assignee: Henrik Lindberg
* Category: parser
* Target version: 3.3.0
* Affected Puppet version: 3.2.4
* Keywords: parser, future, numeric, numerals
* Branch: 

Create a yum repo like this:

  yumrepo { 'ip-ours':
baseurl  => "$protocol://$yum_repo_server/",
descr=> 'Our yum repository',
enabled  => 1,
gpgcheck => 0,
  }

Run puppet.

You will get:

Notice: /Stage[first]/Our_yumrepo/Yumrepo[ip-ours]/gpgcheck: gpgcheck changed 
'0' to '00'.


Corresponding yum error when you try to use this config with 00.

Templated files are also changed, but that's for another bug report.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22572] (Duplicate) Incorrect exit code from puppet apply without --detailed-exitcodes on Windows

2013-09-25 Thread tickets

Issue #22572 has been updated by Rob Reynolds.

Status changed from Unreviewed to Duplicate


Bug #22572: Incorrect exit code from puppet apply without --detailed-exitcodes 
on Windows
https://projects.puppetlabs.com/issues/22572#change-97992

* Author: Igor Berger
* Status: Duplicate
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* Affected Puppet version: 3.2.4
* Keywords: windows
* Branch: 

puppet apply without --detailed-exitcodes returns 0 (success) even if 
underlying operation failed.

Attached batch script tries to start a non-existing Windows service 3 ways and 
outputs this:




[SC] StartService: OpenService FAILED 1060:
The specified service does not exist as an installed service.
sc returned: 1060
Notice: Compiled catalog for my_node in environment production in 0.14 seconds
Notice: /Stage[main]//Exec[not_there]/returns: [SC] StartService: OpenService 
FAILED 1060:
Notice: /Stage[main]//Exec[not_there]/returns:
Notice: /Stage[main]//Exec[not_there]/returns: The specified service does not 
exist as an installed service.
Error: sc start AbsentService returned 36 instead of one of [0]
Error: /Stage[main]//Exec[not_there]/returns: change from notrun to 0 failed: 
sc start AbsentService returned 36 instead of one of [0]
Notice: Finished catalog run in 1.56 seconds
puppet with --detailed-exitcodes returned: 4
Notice: Compiled catalog for my_node in environment production in 0.12 seconds
Notice: /Stage[main]//Exec[not_there]/returns: [SC] StartService: OpenService 
FAILED 1060:
Notice: /Stage[main]//Exec[not_there]/returns:
Notice: /Stage[main]//Exec[not_there]/returns: The specified service does not 
exist as an installed service.
Error: sc start AbsentService returned 36 instead of one of [0]
Error: /Stage[main]//Exec[not_there]/returns: change from notrun to 0 failed: 
sc start AbsentService returned 36 instead of one of [0]
Notice: Finished catalog run in 1.57 seconds
puppet without --detailed-exitcodes returned: 0




I expect the last attempt to return a non-0 (failure) exit code.



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22572] Incorrect exit code from puppet apply without --detailed-exitcodes on Windows

2013-09-25 Thread tickets

Issue #22572 has been updated by Rob Reynolds.


I am going to close this since it is a duplicate of 19033. Please watch that 
issue for further updates.


Bug #22572: Incorrect exit code from puppet apply without --detailed-exitcodes 
on Windows
https://projects.puppetlabs.com/issues/22572#change-97991

* Author: Igor Berger
* Status: Unreviewed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* Affected Puppet version: 3.2.4
* Keywords: windows
* Branch: 

puppet apply without --detailed-exitcodes returns 0 (success) even if 
underlying operation failed.

Attached batch script tries to start a non-existing Windows service 3 ways and 
outputs this:




[SC] StartService: OpenService FAILED 1060:
The specified service does not exist as an installed service.
sc returned: 1060
Notice: Compiled catalog for my_node in environment production in 0.14 seconds
Notice: /Stage[main]//Exec[not_there]/returns: [SC] StartService: OpenService 
FAILED 1060:
Notice: /Stage[main]//Exec[not_there]/returns:
Notice: /Stage[main]//Exec[not_there]/returns: The specified service does not 
exist as an installed service.
Error: sc start AbsentService returned 36 instead of one of [0]
Error: /Stage[main]//Exec[not_there]/returns: change from notrun to 0 failed: 
sc start AbsentService returned 36 instead of one of [0]
Notice: Finished catalog run in 1.56 seconds
puppet with --detailed-exitcodes returned: 4
Notice: Compiled catalog for my_node in environment production in 0.12 seconds
Notice: /Stage[main]//Exec[not_there]/returns: [SC] StartService: OpenService 
FAILED 1060:
Notice: /Stage[main]//Exec[not_there]/returns:
Notice: /Stage[main]//Exec[not_there]/returns: The specified service does not 
exist as an installed service.
Error: sc start AbsentService returned 36 instead of one of [0]
Error: /Stage[main]//Exec[not_there]/returns: change from notrun to 0 failed: 
sc start AbsentService returned 36 instead of one of [0]
Notice: Finished catalog run in 1.57 seconds
puppet without --detailed-exitcodes returned: 0




I expect the last attempt to return a non-0 (failure) exit code.



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Feature #22700] Installing Windows agent should put puppet on the PATH

2013-09-25 Thread tickets

Issue #22700 has been updated by Rob Reynolds.

Description updated


Feature #22700: Installing Windows agent should put puppet on the PATH
https://projects.puppetlabs.com/issues/22700#change-97990

* Author: Rob Reynolds
* Status: Accepted
* Priority: Normal
* Assignee: Rob Reynolds
* Category: 
* Target version: 
* Affected Puppet version: 
* Keywords: windows
* Branch: 

This will add puppet.bat, facter.bat and others in the bin folder to the system 
PATH. 

Note that this is not adding ruby items to the path so it shouldn't clobber 
with current settings of the user/machine.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Feature #22700] (Accepted) Installing Windows agent should put puppet on the PATH

2013-09-25 Thread tickets

Issue #22700 has been reported by Rob Reynolds.


Feature #22700: Installing Windows agent should put puppet on the PATH
https://projects.puppetlabs.com/issues/22700

* Author: Rob Reynolds
* Status: Accepted
* Priority: Normal
* Assignee: Rob Reynolds
* Category: 
* Target version: 
* Affected Puppet version: 
* Keywords: windows
* Branch: 

Putting %PROGRAMFILES%\PuppetLabs\bin


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22593] future parser lexer does not handle all kinds of interpolated expressions

2013-09-25 Thread tickets

Issue #22593 has been updated by Josh Cooper.

Target version set to 3.4.0


Bug #22593: future parser lexer does not handle all kinds of interpolated 
expressions
https://projects.puppetlabs.com/issues/22593#change-97988

* Author: Henrik Lindberg
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: Henrik Lindberg
* Category: language
* Target version: 3.4.0
* Affected Puppet version: 3.0.0
* Keywords: language lexer interpolation variables brace
* Branch: https://github.com/puppetlabs/puppet/pull/1908

There are several problems with the future parser's lexer wrt. interpolation. 
(The same problem exist in the old lexer, but is
less of a concern as the parser will give bad errors anyway).

* Interpolation does not honor nesting of braces, takes the first r-brace to be 
end of interpolated expression. This leads
  to an hard to understand syntax error (because the lexer told the parser a 
lie). I.e. the marked section is what is lexed as
  an epression, the first '}' ends the interpolation.

"${x ? { true => 'hi', default => 'goodbye'}}"
   ^--^

* Since the first bare word is lexed as a variable unless followed by '(' (i.e. 
a function call), it is impossible to use
  the expressions if, unless, case, undef, true, false without having to 
enclose them in parentheses. The lexer should translate these
  to the respective keywords instead of treating them as variables (other 
keywords does not matter as much - node in particular is
  used as a variable. In 3.x. the expressions are not r-values, but in 4x they 
will be.

This is bad because it gives the wrong error message when it can do much better 
in 3.x, and it prevents a selector expression from being
used in interpolation. For 4.x. it is bad because it also prevents using if, 
unless, and case expressions in interpolation.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22652] ignore doesn't work if pluginsync enabled

2013-09-25 Thread tickets

Issue #22652 has been updated by Josh Cooper.


The patch is working correctly in my setup Debian squeeze:


root@deb-agent:~# rm -rf /var/lib/puppet/lib/puppet/parser/functions/.svn/
root@deb-agent:~# puppet agent -t
Info: Retrieving plugin
...
Info: Applying configuration version '1380145575'
Notice: Finished catalog run in 0.38 seconds


Without the patch, I see:


root@deb-agent:~# puppet agent -t
Info: Retrieving plugin
Notice: /File[/var/lib/puppet/lib/puppet/parser/functions/.svn]/ensure: created
Notice: /File[/var/lib/puppet/lib/puppet/parser/functions/.svn/WAT]/ensure: 
defined content as '{md5}71ab23f035cfd78d785a37238d937c70'




Bug #22652: ignore doesn't work if pluginsync enabled
https://projects.puppetlabs.com/issues/22652#change-97987

* Author: Daniel Wittenberg
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: Kylo Ginsberg
* Category: 
* Target version: 3.3.1
* Affected Puppet version: 3.3.1-rc1
* Keywords: 
* Branch: https://github.com/puppetlabs/puppet/pull/1938

/var/lib/puppet//.svn directories are still pushed out even if you have a 
global ignore 
File { ignore => '.svn' }

Confirmed by downgrading the server to 3.2.4-1 and it all worked as expected, 
no .svn directories in /var/lib/puppet


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22652] ignore doesn't work if pluginsync enabled

2013-09-25 Thread tickets

Issue #22652 has been updated by Chuck Schweizer.


Ok.. now I am having problems trying to reproduce the error.

Basically I just updated 
/usr/lib/ruby/site_ruby/1.8/puppet/network/http/rack/rest.rb with the raw file 
from github.

Reverting the change fixed the issue, but now I can't reproduce it when I add 
the fix back in.  It was only happening on my NEW loads.  servers that had 
previously connected were working correctly.  I will keep trying to reproduce 
the issue.


Bug #22652: ignore doesn't work if pluginsync enabled
https://projects.puppetlabs.com/issues/22652#change-97985

* Author: Daniel Wittenberg
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: Kylo Ginsberg
* Category: 
* Target version: 3.3.1
* Affected Puppet version: 3.3.1-rc1
* Keywords: 
* Branch: https://github.com/puppetlabs/puppet/pull/1938

/var/lib/puppet//.svn directories are still pushed out even if you have a 
global ignore 
File { ignore => '.svn' }

Confirmed by downgrading the server to 3.2.4-1 and it all worked as expected, 
no .svn directories in /var/lib/puppet


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22652] ignore doesn't work if pluginsync enabled

2013-09-25 Thread tickets

Issue #22652 has been updated by Adrien Thebo.


Chuck, could you elaborate a bit more on what exactly broke and how you applied 
the patch?


Bug #22652: ignore doesn't work if pluginsync enabled
https://projects.puppetlabs.com/issues/22652#change-97984

* Author: Daniel Wittenberg
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: Kylo Ginsberg
* Category: 
* Target version: 3.3.1
* Affected Puppet version: 3.3.1-rc1
* Keywords: 
* Branch: https://github.com/puppetlabs/puppet/pull/1938

/var/lib/puppet//.svn directories are still pushed out even if you have a 
global ignore 
File { ignore => '.svn' }

Confirmed by downgrading the server to 3.2.4-1 and it all worked as expected, 
no .svn directories in /var/lib/puppet


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22699] Boolean parameters/properties (introduced in 3.3) no longer create value_collections

2013-09-25 Thread tickets

Issue #22699 has been updated by Nick Fagerlund.

Affected Puppet version set to 3.3.0
Keywords set to regression


Bug #22699: Boolean parameters/properties (introduced in 3.3) no longer create 
value_collections
https://projects.puppetlabs.com/issues/22699#change-97983

* Author: Nick Fagerlund
* Status: Unreviewed
* Priority: Normal
* Assignee: Dustin Mitchell
* Category: 
* Target version: 
* Affected Puppet version: 3.3.0
* Keywords: regression
* Branch: 

Commit ba7576d3ca6ec681301de83562ec8fd3b8207a8d ("Add DRY support for boolean 
parameters," first shipped in 3.3.0-rc1) caused boolean parameters to bypass 
the `value_collection` mechanism for declaring allowed values. (The `newvalue` 
and `newvalues` methods inside a parameter block cause new values to be added 
to the `value_collection` attr of that parameter; the `value_collection` can be 
queried once the type is loaded.)

This broke the type reference. The #doc method of Puppet::Parameter expects 
that all valid values will be queryable from the `value_collection` (`@doc += 
value_collection.doc` around line 119-ish), and now that it's empty, boolean 
parameters look like they take arbitrary strings instead of strictly limited 
values.

This should be fixed by causing boolean parameters to fill in their 
`value_collection` appropriately, so we can have a single reliable way to 
determine allowed values.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22699] Boolean parameters/properties (introduced in 3.3) no longer create value_collections

2013-09-25 Thread tickets

Issue #22699 has been updated by Nick Fagerlund.

Assignee set to Dustin Mitchell


Bug #22699: Boolean parameters/properties (introduced in 3.3) no longer create 
value_collections
https://projects.puppetlabs.com/issues/22699#change-97982

* Author: Nick Fagerlund
* Status: Unreviewed
* Priority: Normal
* Assignee: Dustin Mitchell
* Category: 
* Target version: 
* Affected Puppet version: 
* Keywords: 
* Branch: 

Commit ba7576d3ca6ec681301de83562ec8fd3b8207a8d ("Add DRY support for boolean 
parameters," first shipped in 3.3.0-rc1) caused boolean parameters to bypass 
the `value_collection` mechanism for declaring allowed values. (The `newvalue` 
and `newvalues` methods inside a parameter block cause new values to be added 
to the `value_collection` attr of that parameter; the `value_collection` can be 
queried once the type is loaded.)

This broke the type reference. The #doc method of Puppet::Parameter expects 
that all valid values will be queryable from the `value_collection` (`@doc += 
value_collection.doc` around line 119-ish), and now that it's empty, boolean 
parameters look like they take arbitrary strings instead of strictly limited 
values.

This should be fixed by causing boolean parameters to fill in their 
`value_collection` appropriately, so we can have a single reliable way to 
determine allowed values.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22699] (Unreviewed) Boolean parameters/properties (introduced in 3.3) no longer create value_collections

2013-09-25 Thread tickets

Issue #22699 has been reported by Nick Fagerlund.


Bug #22699: Boolean parameters/properties (introduced in 3.3) no longer create 
value_collections
https://projects.puppetlabs.com/issues/22699

* Author: Nick Fagerlund
* Status: Unreviewed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* Affected Puppet version: 
* Keywords: 
* Branch: 

Commit ba7576d3ca6ec681301de83562ec8fd3b8207a8d ("Add DRY support for boolean 
parameters," first shipped in 3.3.0-rc1) caused boolean parameters to bypass 
the `value_collection` mechanism for declaring allowed values. (The `newvalue` 
and `newvalues` methods inside a parameter block cause new values to be added 
to the `value_collection` attr of that parameter; the `value_collection` can be 
queried once the type is loaded.)

This broke the type reference. The #doc method of Puppet::Parameter expects 
that all valid values will be queryable from the `value_collection` (`@doc += 
value_collection.doc` around line 119-ish), and now that it's empty, boolean 
parameters look like they take arbitrary strings instead of strictly limited 
values.

This should be fixed by causing boolean parameters to fill in their 
`value_collection` appropriately, so we can have a single reliable way to 
determine allowed values.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22652] ignore doesn't work if pluginsync enabled

2013-09-25 Thread tickets

Issue #22652 has been updated by Chuck Schweizer.


this seems to break the initial Fact push to the puppet masters.   I need a 
custom fact from the client for the initial connection and it is not getting 
sent with this patch.  :(

The client was 3.2.3


Bug #22652: ignore doesn't work if pluginsync enabled
https://projects.puppetlabs.com/issues/22652#change-97981

* Author: Daniel Wittenberg
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: Kylo Ginsberg
* Category: 
* Target version: 3.3.1
* Affected Puppet version: 3.3.1-rc1
* Keywords: 
* Branch: https://github.com/puppetlabs/puppet/pull/1938

/var/lib/puppet//.svn directories are still pushed out even if you have a 
global ignore 
File { ignore => '.svn' }

Confirmed by downgrading the server to 3.2.4-1 and it all worked as expected, 
no .svn directories in /var/lib/puppet


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Feature #22617] augeas onlyif comparitor for strings that are integers should do numeric compare

2013-09-25 Thread tickets

Issue #22617 has been updated by Adrien Thebo.

Description updated


Feature #22617: augeas onlyif comparitor for strings that are integers should 
do numeric compare
https://projects.puppetlabs.com/issues/22617#change-97980

* Author: Don Law
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: 
* Category: augeas
* Target version: 
* Affected Puppet version: 2.6.18
* Keywords: numeric comparator onlyif augeas
* Branch: https://github.com/puppetlabs/puppet/pull/1934

The onlyif get comparitor always does string comparison.  This is fine until 
you try < or > (less than/greater than).  Many configuration parameters are 
numeric and should be compared as such when they are.

For an example use case, imagine a resource that enforces that the maximum 
password expiration must be less than 90 days.  If someone configures their 
system to use less than 90, no problem, but if it is configured for more than 
90, we need to set it to 90:

augeas {'testcase' :
  incl => '/home/dlaw/augeas/login.defs',
  lens => 'Login_defs.lns',
  context => '/files/home/dlaw/augeas/login.defs',
  onlyif => 'get PASS_MAX_DAYS > 90',
  changes => 'set PASS_MAX_DAYS 90',
}

The problem is if the following line appears in login.defs:

PASS_MAX_DAYS   120

the string comparision will show that 120 < 90, and the onlyif will not be true.

The following patch is a proposed fix for the problem:


--- OLD/site_ruby/1.8/puppet/provider/augeas/augeas.rb  2013-09-19 
14:09:52.0 -0400
+++ NEW/site_ruby/1.8/puppet/provider/augeas/augeas.rb  2013-09-19 
16:23:48.0 -0400
@@ -164,6 +164,10 @@
 end
   end
 
+  def is_numeric?(s)
+s.to_s.match(/\A[+-]?\d+?(\.\d+)?\Z/) == nil ? false : true
+  end
+
   # Used by the need_to_run? method to process get filters. Returns
   # true if there is a match, false if otherwise
   # Assumes a syntax of get /files/path [COMPARATOR] value
@@ -179,10 +183,14 @@
 
 #check the value in augeas
 result = @aug.get(path) || ''
-case comparator
-when "!="
+
+if comparator == "<" and is_numeric?(result) and is_numeric?(arg) 
+  return_value = result.to_s.to_f < arg.to_s.to_f
+elsif comparator == ">" and is_numeric?(result) and is_numeric?(arg) 
+  return_value = result.to_s.to_f > arg.to_s.to_f
+elsif comparator == "!="
   return_value = (result != arg)
-when "=~"
+elsif comparator == "=~"
   regex = Regexp.new(arg)
   return_value = (result =~ regex)
 else



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Feature #22617] (In Topic Branch Pending Review) augeas onlyif comparitor for strings that are integers should do numeric compare

2013-09-25 Thread tickets

Issue #22617 has been updated by Adrien Thebo.

Status changed from Unreviewed to In Topic Branch Pending Review
Keywords changed from numeric comparitor onlyif to numeric comparator onlyif 
augeas
Branch set to https://github.com/puppetlabs/puppet/pull/1934


Feature #22617: augeas onlyif comparitor for strings that are integers should 
do numeric compare
https://projects.puppetlabs.com/issues/22617#change-97979

* Author: Don Law
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: 
* Category: augeas
* Target version: 
* Affected Puppet version: 2.6.18
* Keywords: numeric comparator onlyif augeas
* Branch: https://github.com/puppetlabs/puppet/pull/1934

The onlyif get comparitor always does string comparison.  This is fine until 
you try < or > (less than/greater than).  Many configuration parameters are 
numeric and should be compared as such when they are.

For an example use case, imagine a resource that enforces that the maximum 
password expiration must be less than 90 days.  If someone configures their 
system to use less than 90, no problem, but if it is configured for more than 
90, we need to set it to 90:

augeas {'testcase' :
  incl => '/home/dlaw/augeas/login.defs',
  lens => 'Login_defs.lns',
  context => '/files/home/dlaw/augeas/login.defs',
  onlyif => 'get PASS_MAX_DAYS > 90',
  changes => 'set PASS_MAX_DAYS 90',
}

The problem is if the following line appears in login.defs:

PASS_MAX_DAYS   120

the string comparision will show that 120 < 90, and the onlyif will not be true.

The following patch is a proposed fix for the problem:

--- OLD/site_ruby/1.8/puppet/provider/augeas/augeas.rb  2013-09-19 
14:09:52.0 -0400
+++ NEW/site_ruby/1.8/puppet/provider/augeas/augeas.rb  2013-09-19 
16:23:48.0 -0400
@@ -164,6 +164,10 @@
 end
   end
 
+  def is_numeric?(s)
+s.to_s.match(/\A[+-]?\d+?(\.\d+)?\Z/) == nil ? false : true
+  end
+
   # Used by the need_to_run? method to process get filters. Returns
   # true if there is a match, false if otherwise
   # Assumes a syntax of get /files/path [COMPARATOR] value
@@ -179,10 +183,14 @@
 
 #check the value in augeas
 result = @aug.get(path) || ''
-case comparator
-when "!="
+
+if comparator == "<" and is_numeric?(result) and is_numeric?(arg) 
+  return_value = result.to_s.to_f < arg.to_s.to_f
+elsif comparator == ">" and is_numeric?(result) and is_numeric?(arg) 
+  return_value = result.to_s.to_f > arg.to_s.to_f
+elsif comparator == "!="
   return_value = (result != arg)
-when "=~"
+elsif comparator == "=~"
   regex = Regexp.new(arg)
   return_value = (result =~ regex)
 else



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Feature #4761] (Accepted) Allow verbose and debug options to be specified in configuration file in addition to command line

2013-09-25 Thread tickets

Issue #4761 has been updated by Josh Cooper.

Status changed from Needs More Information to Accepted

This is also a pain on windows when running as a service.


Feature #4761: Allow verbose and debug options to be specified in configuration 
file in addition to command line
https://projects.puppetlabs.com/issues/4761#change-97978

* Author: Mathias Gug
* Status: Accepted
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* Affected Puppet version: 
* Keywords: 
* Branch: 

If the verbose or debug option is set in /etc/puppet/puppet.conf, the puppet 
agent doesn't seem to respect them. It seems that these two options can only be 
set on the command line.

Being able to set them in the configuration file would be helpful when 
debugging puppet agents running into system on EC2.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #17031] Can't add domain user account as a member of a local group

2013-09-25 Thread tickets

Issue #17031 has been updated by Ethan Brown.


Rob Reynolds wrote:
> Ethan Brown wrote:
> 
> 
> > * Well-known SIDs like SYSTEM (S-1-5-18), Local Service (S-1-5-19), Network 
> > Service (S-1-5-20) are not globally unique and would require a host prefix 
> > if used in any sort of comparison.
> 
> Do you have a reference? This is a pretty scary proposition if true.
> 
> I agree if the wording is the distinguished name / domain of the well known 
> SIDs are not unique with every OS version (sometimes `BUILTIN\SYSTEM` 
> sometimes `NT AUTHORITY\SYSTEM`, etc).

I'm not even certain if the situation I'm trying to bring to light is worth 
mentioning, and I don't have a domain handy to verify if it's an issue. My 
point here is that there could be a collision if the `objectSID` property of 
the `WIN32OLE` instance only returns a well-known SID like `S-1-5-19`.  If a 
manifest tried to add `HOST1\Network Service` and `HOST2\Network Service`, I 
believe their `objectSID` values are the same, and only the first would be 
added.  So in this case, the host is necessary for the comparison.  I can't 
think of any reason that someone would want to add well-known accounts from two 
separate hosts to a local group. Keep in mind though that groups may contain 
groups so it's not implausible to add the domain admin groups from two separate 
domains to the local admin group, which might create the same issue.


Bug #17031: Can't add domain user account as a member of a local group
https://projects.puppetlabs.com/issues/17031#change-97976

* Author: Josh Cooper
* Status: Accepted
* Priority: High
* Assignee: Josh Cooper
* Category: 
* Target version: 3.x
* Affected Puppet version: 2.7.6
* Keywords: windows user group domain
* Branch: 

This is a common need when managing domain service accounts that need to be a 
member of the local Administrators account. I thought it would be resolved once 
#16581 was fixed, but there's a more fundamental issue with the group provider, 
so I'm filing this as a separate issue.

First, it attempts to add members to the group using an ADSI path of 
`WinNT://WIN-QP47VOHA2P4/BIZARRO\albert,user`, but it needs to be 
`WinNT://WIN-QP47VOHA2P4/BIZARRO/albert,user`


def add_members(*names)
  names.each do |name|
native_group.Add(Puppet::Util::ADSI::User.uri(name))
  end
end


It may be possible to just use the SID form `WinNT://` but I'm not sure if 
that will work in a non-domain environment.

Second, when calculating whether the group's members are insync? it compares 
names:


  members_to_add = desired_members - current_members
  add_members(*members_to_add)


However the ADSI provider returns current members as, e.g. `albert`. But since 
this doesn't match `BIZARRO\albert`, the provider will think the resource is 
out of sync and will attempt to re-add a user that is already a member of the 
group and fail:


err: /Stage[main]//Group[Foobars]/members: change from albertAdministrator to 
BIZARRO\albert Administrator failed: Add
OLE error code:80070562 in Active Directory
  The specified account name is already a member of the group.

HRESULT error code:0x80020009
  Exception occurred.


Really, the group provider needs to compare the current vs desired SIDs to 
determine which users to add, similar to what we do in the file and 
scheduled_task providers.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #17031] Can't add domain user account as a member of a local group

2013-09-25 Thread tickets

Issue #17031 has been updated by Ethan Brown.


Rob Reynolds wrote:
> Ethan Brown wrote:
> > * Neither of the `LDAP` style bind syntax options may be used, as they 
> > alway need a host, and in local testing `LDAP://./foo` and 
> > `LDAP://localhost/foo` do not work by default on machines that are not 
> > running a DC.  In testing, a PowerShell style query like 
> > `[ADSI]"LDAP://localhost/" | Select *` does not error, but it 
> > also does not yield any results.  When removing the host, 
> > `[ADSI]"LDAP://" | Select *` does error with `exception 
> > occurred while retrieving member "distinguishedName": "The specified domain 
> > either does not exist or could not be contacted"`.  NOTE: Also attempted 
> > were non well-known SIDs as well (users local to a given test environment).
> 
> Did you try `LDAP://machineName/foo` ?

Yes.  The result is the same.



Bug #17031: Can't add domain user account as a member of a local group
https://projects.puppetlabs.com/issues/17031#change-97977

* Author: Josh Cooper
* Status: Accepted
* Priority: High
* Assignee: Josh Cooper
* Category: 
* Target version: 3.x
* Affected Puppet version: 2.7.6
* Keywords: windows user group domain
* Branch: 

This is a common need when managing domain service accounts that need to be a 
member of the local Administrators account. I thought it would be resolved once 
#16581 was fixed, but there's a more fundamental issue with the group provider, 
so I'm filing this as a separate issue.

First, it attempts to add members to the group using an ADSI path of 
`WinNT://WIN-QP47VOHA2P4/BIZARRO\albert,user`, but it needs to be 
`WinNT://WIN-QP47VOHA2P4/BIZARRO/albert,user`


def add_members(*names)
  names.each do |name|
native_group.Add(Puppet::Util::ADSI::User.uri(name))
  end
end


It may be possible to just use the SID form `WinNT://` but I'm not sure if 
that will work in a non-domain environment.

Second, when calculating whether the group's members are insync? it compares 
names:


  members_to_add = desired_members - current_members
  add_members(*members_to_add)


However the ADSI provider returns current members as, e.g. `albert`. But since 
this doesn't match `BIZARRO\albert`, the provider will think the resource is 
out of sync and will attempt to re-add a user that is already a member of the 
group and fail:


err: /Stage[main]//Group[Foobars]/members: change from albertAdministrator to 
BIZARRO\albert Administrator failed: Add
OLE error code:80070562 in Active Directory
  The specified account name is already a member of the group.

HRESULT error code:0x80020009
  Exception occurred.


Really, the group provider needs to compare the current vs desired SIDs to 
determine which users to add, similar to what we do in the file and 
scheduled_task providers.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #21198] (Merged - Pending Release) hiera calling_module / calling_class not set for automatic parameter lookups

2013-09-25 Thread tickets

Issue #21198 has been updated by Patrick Carlisle.

Status changed from In Topic Branch Pending Review to Merged - Pending Release

Merged in 
[487d93e](https://github.com/puppetlabs/puppet/commit/487d93ed166449c7e162aa21f6e632b58b8027db).
 This should be released in 3.4.0.


Bug #21198: hiera calling_module / calling_class not set for automatic 
parameter lookups
https://projects.puppetlabs.com/issues/21198#change-97975

* Author: Robert Frank
* Status: Merged - Pending Release
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 3.4.0
* Affected Puppet version: 3.0.0
* Keywords: 
* Branch: https://github.com/puppetlabs/puppet/pull/1913

The automatic parameter lookup uses a different scope (Puppet::DataBinding) 
than the explicit lookup with the hiera function (Hiera::Scope). The 
calling_module and calling_class variables are generated in Hiera::Scope and 
therefore are not available when automatic parameter lookup is used. This 
breaks hiera configurations that make use of those variables for lookups.
Including the following class in a node definition on a puppet master

class test($myopt = 'default') {
  notify { "auto myopt: ${myopt}": }
  $myvar = hiera('test::myopt', $myopt)
  notify { "hiera myopt: ${myvar}": }
}

with a hiera configuration that uses

- %{calling_module}
- common

and different configuration values for test::myopt in test.yaml and common.yaml 
prints the value defined in test.yaml for the explicit lookup and the value 
defined in common.yaml for the automatic lookup.



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #17031] Can't add domain user account as a member of a local group

2013-09-25 Thread tickets

Issue #17031 has been updated by Rob Reynolds.


The ideas in the end game seem sound (from someone outside of the current 
problem set).


Bug #17031: Can't add domain user account as a member of a local group
https://projects.puppetlabs.com/issues/17031#change-97974

* Author: Josh Cooper
* Status: Accepted
* Priority: High
* Assignee: Josh Cooper
* Category: 
* Target version: 3.x
* Affected Puppet version: 2.7.6
* Keywords: windows user group domain
* Branch: 

This is a common need when managing domain service accounts that need to be a 
member of the local Administrators account. I thought it would be resolved once 
#16581 was fixed, but there's a more fundamental issue with the group provider, 
so I'm filing this as a separate issue.

First, it attempts to add members to the group using an ADSI path of 
`WinNT://WIN-QP47VOHA2P4/BIZARRO\albert,user`, but it needs to be 
`WinNT://WIN-QP47VOHA2P4/BIZARRO/albert,user`


def add_members(*names)
  names.each do |name|
native_group.Add(Puppet::Util::ADSI::User.uri(name))
  end
end


It may be possible to just use the SID form `WinNT://` but I'm not sure if 
that will work in a non-domain environment.

Second, when calculating whether the group's members are insync? it compares 
names:


  members_to_add = desired_members - current_members
  add_members(*members_to_add)


However the ADSI provider returns current members as, e.g. `albert`. But since 
this doesn't match `BIZARRO\albert`, the provider will think the resource is 
out of sync and will attempt to re-add a user that is already a member of the 
group and fail:


err: /Stage[main]//Group[Foobars]/members: change from albertAdministrator to 
BIZARRO\albert Administrator failed: Add
OLE error code:80070562 in Active Directory
  The specified account name is already a member of the group.

HRESULT error code:0x80020009
  Exception occurred.


Really, the group provider needs to compare the current vs desired SIDs to 
determine which users to add, similar to what we do in the file and 
scheduled_task providers.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #17031] Can't add domain user account as a member of a local group

2013-09-25 Thread tickets

Issue #17031 has been updated by Rob Reynolds.


Ethan Brown wrote:


> * Well-known SIDs like SYSTEM (S-1-5-18), Local Service (S-1-5-19), Network 
> Service (S-1-5-20) are not globally unique and would require a host prefix if 
> used in any sort of comparison.

Do you have a reference? This is a pretty scary proposition if true.


Bug #17031: Can't add domain user account as a member of a local group
https://projects.puppetlabs.com/issues/17031#change-97973

* Author: Josh Cooper
* Status: Accepted
* Priority: High
* Assignee: Josh Cooper
* Category: 
* Target version: 3.x
* Affected Puppet version: 2.7.6
* Keywords: windows user group domain
* Branch: 

This is a common need when managing domain service accounts that need to be a 
member of the local Administrators account. I thought it would be resolved once 
#16581 was fixed, but there's a more fundamental issue with the group provider, 
so I'm filing this as a separate issue.

First, it attempts to add members to the group using an ADSI path of 
`WinNT://WIN-QP47VOHA2P4/BIZARRO\albert,user`, but it needs to be 
`WinNT://WIN-QP47VOHA2P4/BIZARRO/albert,user`


def add_members(*names)
  names.each do |name|
native_group.Add(Puppet::Util::ADSI::User.uri(name))
  end
end


It may be possible to just use the SID form `WinNT://` but I'm not sure if 
that will work in a non-domain environment.

Second, when calculating whether the group's members are insync? it compares 
names:


  members_to_add = desired_members - current_members
  add_members(*members_to_add)


However the ADSI provider returns current members as, e.g. `albert`. But since 
this doesn't match `BIZARRO\albert`, the provider will think the resource is 
out of sync and will attempt to re-add a user that is already a member of the 
group and fail:


err: /Stage[main]//Group[Foobars]/members: change from albertAdministrator to 
BIZARRO\albert Administrator failed: Add
OLE error code:80070562 in Active Directory
  The specified account name is already a member of the group.

HRESULT error code:0x80020009
  Exception occurred.


Really, the group provider needs to compare the current vs desired SIDs to 
determine which users to add, similar to what we do in the file and 
scheduled_task providers.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #17031] Can't add domain user account as a member of a local group

2013-09-25 Thread tickets

Issue #17031 has been updated by Rob Reynolds.


Ethan Brown wrote:
> * Neither of the `LDAP` style bind syntax options may be used, as they 
> alway need a host, and in local testing `LDAP://./foo` and 
> `LDAP://localhost/foo` do not work by default on machines that are not 
> running a DC.  In testing, a PowerShell style query like 
> `[ADSI]"LDAP://localhost/" | Select *` does not error, but it 
> also does not yield any results.  When removing the host, 
> `[ADSI]"LDAP://" | Select *` does error with `exception 
> occurred while retrieving member "distinguishedName": "The specified domain 
> either does not exist or could not be contacted"`.  NOTE: Also attempted were 
> non well-known SIDs as well (users local to a given test environment).

Did you try `LDAP://machineName/foo` ?



Bug #17031: Can't add domain user account as a member of a local group
https://projects.puppetlabs.com/issues/17031#change-97972

* Author: Josh Cooper
* Status: Accepted
* Priority: High
* Assignee: Josh Cooper
* Category: 
* Target version: 3.x
* Affected Puppet version: 2.7.6
* Keywords: windows user group domain
* Branch: 

This is a common need when managing domain service accounts that need to be a 
member of the local Administrators account. I thought it would be resolved once 
#16581 was fixed, but there's a more fundamental issue with the group provider, 
so I'm filing this as a separate issue.

First, it attempts to add members to the group using an ADSI path of 
`WinNT://WIN-QP47VOHA2P4/BIZARRO\albert,user`, but it needs to be 
`WinNT://WIN-QP47VOHA2P4/BIZARRO/albert,user`


def add_members(*names)
  names.each do |name|
native_group.Add(Puppet::Util::ADSI::User.uri(name))
  end
end


It may be possible to just use the SID form `WinNT://` but I'm not sure if 
that will work in a non-domain environment.

Second, when calculating whether the group's members are insync? it compares 
names:


  members_to_add = desired_members - current_members
  add_members(*members_to_add)


However the ADSI provider returns current members as, e.g. `albert`. But since 
this doesn't match `BIZARRO\albert`, the provider will think the resource is 
out of sync and will attempt to re-add a user that is already a member of the 
group and fail:


err: /Stage[main]//Group[Foobars]/members: change from albertAdministrator to 
BIZARRO\albert Administrator failed: Add
OLE error code:80070562 in Active Directory
  The specified account name is already a member of the group.

HRESULT error code:0x80020009
  Exception occurred.


Really, the group provider needs to compare the current vs desired SIDs to 
determine which users to add, similar to what we do in the file and 
scheduled_task providers.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #19955] Misleading error when Hiera databindings fail

2013-09-25 Thread tickets

Issue #19955 has been updated by Charlie Sharpsteen.

Keywords changed from error to error customer


Bug #19955: Misleading error when Hiera databindings fail
https://projects.puppetlabs.com/issues/19955#change-97970

* Author: Dolf Schimmel
* Status: Accepted
* Priority: Normal
* Assignee: 
* Category: databinding
* Target version: 3.x
* Affected Puppet version: 
* Keywords: error customer
* Branch: 

Hi,

I just put created a hiera.yaml file with some invalid contents (`echo foobar > 
/etc/puppet/hiera.yaml`). When doing a puppet run, I'm confronted with the 
following error:


Error: Could not retrieve catalog from remote server: Error 400 on SERVER: 
can't convert String into Hash at 
/etc/puppet/environments/production/manifests/cluster/core/nodes.pp:4 on node 
puppet01.dev.example.net


The contents of the nodes.pp file is:


node 'puppet01.dev.node.net' inherits basenode {

  $manage_puppet = false
  include "cluster::core::puppetmaster::pupppet"

  include basenode::general

}


Clearly the config file is not parsed, which is alright in this case. The error 
is quite misleading though, as it suggests some error had occurred in my 
manifest, while it was caused (and fixed afterwards) in hiera.yaml.

Proposed fix would be to change the error into something meaningful. Last week 
I had the same error causing me to debug for several hours, only to do a 
vagrant destroy.


root@puppet01:/etc/puppet# puppet --version
3.1.1
root@puppet01:/etc/puppet# uname -a
Linux puppet01.dev.example.net 3.2.0-23-generic #36-Ubuntu SMP Tue Apr 10 
20:39:51 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #19955] Misleading error when Hiera databindings fail

2013-09-25 Thread tickets

Issue #19955 has been updated by Charlie Sharpsteen.


Another common example: consider the following Hiera data, which passes the 
Syck parser used by ruby 1.8.x but chokes the Psych parser used by 1.9.x 
(variable interpolation needs to be quoted):


# /var/lib/hiera/defaults.yaml
---
hiera_test::message: %{settings::modulepath} is the master modulepath


And associated puppet class:


class hiera_test ($message = 'hello' ){
  notify { $message: }
}


Trying to apply the class throws a very obscure error message:


# puppet apply -e 'include hiera_test'
Error: Could not run: (): found character that cannot start any token 
while scanning for the next token at line 2 column 22


There is no indication that the failure occurred in the Hiera data.


Bug #19955: Misleading error when Hiera databindings fail
https://projects.puppetlabs.com/issues/19955#change-97968

* Author: Dolf Schimmel
* Status: Accepted
* Priority: Normal
* Assignee: 
* Category: databinding
* Target version: 3.x
* Affected Puppet version: 
* Keywords: error
* Branch: 

Hi,

I just put created a hiera.yaml file with some invalid contents (`echo foobar > 
/etc/puppet/hiera.yaml`). When doing a puppet run, I'm confronted with the 
following error:


Error: Could not retrieve catalog from remote server: Error 400 on SERVER: 
can't convert String into Hash at 
/etc/puppet/environments/production/manifests/cluster/core/nodes.pp:4 on node 
puppet01.dev.example.net


The contents of the nodes.pp file is:


node 'puppet01.dev.node.net' inherits basenode {

  $manage_puppet = false
  include "cluster::core::puppetmaster::pupppet"

  include basenode::general

}


Clearly the config file is not parsed, which is alright in this case. The error 
is quite misleading though, as it suggests some error had occurred in my 
manifest, while it was caused (and fixed afterwards) in hiera.yaml.

Proposed fix would be to change the error into something meaningful. Last week 
I had the same error causing me to debug for several hours, only to do a 
vagrant destroy.


root@puppet01:/etc/puppet# puppet --version
3.1.1
root@puppet01:/etc/puppet# uname -a
Linux puppet01.dev.example.net 3.2.0-23-generic #36-Ubuntu SMP Tue Apr 10 
20:39:51 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #17031] Can't add domain user account as a member of a local group

2013-09-25 Thread tickets

Issue #17031 has been updated by Ethan Brown.


* To reiterate the obvious, there is a difference between a local user / SID vs 
a domain user / SID
* There are a number of available options for [binding string 
syntax](http://msdn.microsoft.com/en-us/library/windows/desktop/aa772316\(v=vs.85\).aspx),
 but for practical reasons, the only viable option is to use `WinNT://` -- 
additional details follow.  Note that as mentioned above, `\` is treated as an 
escape for a literal.  Not mentioned in the MSDN docs is an additional `GC://` 
global catalog style binding string to "execute fast queries"
* `WinNT://SID` and `WinNT://servername/SID` are invalid -- to find a user by 
SID, when limited to only `WinNT://` style bind paths, enumeration of the local 
groups / users is required, to perform a match on a given SID -- some VB code 
is available [here](http://www.tek-tips.com/viewthread.cfm?qid=1247882)
* For clarification, the `WinNT://servername/username,user` bind syntax is 
overloaded.  `servername` may either be a `host` or a `domain`
* The syntax that *could* be used for SID lookup uses `LDAP://`, but this is 
not viable.
*  `LDAP://COMPUTER/`, where `XXX` is a hexadecimal representation 
of the raw SID byte array is one option.  It may also take the form of 
`` where this is a string 
generated by the `ConvertSidToStringSid` Win32 API call - see [Binding to an 
Object Using a 
SID](http://msdn.microsoft.com/en-us/library/windows/desktop/ms675562\(v=vs.85\).aspx).
  Also see [LDAP 
ADsPath](http://msdn.microsoft.com/en-us/library/windows/desktop/aa746384\(v=vs.85\).aspx)
 for the "official" MSDN documentation.
* Yet another available bind syntax is `LDAP://servername/` where 
`XXX` is either a string of 32 hex characters without punctuation OR a string 
of hex characters `----` - see [Using 
objectGUID to Bind to an 
Object](http://msdn.microsoft.com/en-us/library/windows/desktop/ms677985\(v=vs.85\).aspx)
 for more information.
* Neither of the `LDAP` style bind syntax options may be used, as they 
alway need a host, and in local testing `LDAP://./foo` and 
`LDAP://localhost/foo` do not work by default on machines that are not running 
a DC.  In testing, a PowerShell style query like 
`[ADSI]"LDAP://localhost/" | Select *` does not error, but it 
also does not yield any results.  When removing the host, 
`[ADSI]"LDAP://" | Select *` does error with `exception occurred 
while retrieving member "distinguishedName": "The specified domain either does 
not exist or could not be contacted"`.  NOTE: Also attempted were non 
well-known SIDs as well (users local to a given test environment).
* Additionally, binding by SID like the above, when it works, will only 
return the `distinguishedName` property (based on forum reports).  To retrieve 
the entire AD object would require an additional refetch with an 
`LDAP://distinguishedName` type query (for instance, to build a 
`DOMAIN\Username` style name).
* Well-known SIDs like SYSTEM (S-1-5-18), Local Service (S-1-5-19), Network 
Service (S-1-5-20) are not globally unique and would require a host prefix if 
used in any sort of comparison.
* WIN32OLE objects returned by the `WinNT` sytanx with 
[connect](http://ruby-doc.org/stdlib-1.9.3/libdoc/win32ole/rdoc/WIN32OLE.html#method-c-connect)
 method expose an `objectSID` property that is an array of bytes in [octet 
string](http://msdn.microsoft.com/en-us/library/ms180873\(v=vs.80\).aspx) 
format.  The [IADsUser 
docs](http://msdn.microsoft.com/en-us/library/windows/desktop/aa746340\(v=vs.85\).aspx)
 do not mention this as it is specifically a [WinNT Custom User 
Property](http://msdn.microsoft.com/en-us/library/windows/desktop/aa746535\(v=vs.85\).aspx).
  This array of bytes cannot be passed directly to the 
[Win32::Security::SID.new](http://rubydoc.info/gems/win32-security/0.2.3/Win32/Security/SID:initialize)
 we are using as only a binary string format is accepted.  Conversion with 
Ruby's Array#pack method must be performed
* So how to translate from a SID to a username when needed?
* The Win32 
[LookupAcocuntSid](http://msdn.microsoft.com/en-us/library/windows/desktop/aa379166\(v=vs.85\).aspx)
 function is automatically called within `Win32::Security::SID::new`, so opt to 
use this where possible.
* There is some sample [Powershell 
code](http://blogs.technet.com/b/heyscriptingguy/archive/2010/10/12/use-powershell-to-translate-a-user-s-sid-to-an-active-directory-account-name.aspx)
 demonstrating the conversion of a SID to a user name.  This relies heavily on 
some .NET Framework classes, particularly `SecurityIdentifier` which 
understands how to convert a byte array into a SID.  [More Powershell examples 
here](http://technet.microsoft.com/en-us/library/ff730940.aspx)
* Such a PowerShell example looks like `(New-Object 
System.Security.Principal.NTAccount("Administrator")).Translate([System.Security.Principal.SecurityIdentifier])
 | Format-List`

Ultimatel

[Puppet - Feature #19111] (Accepted) no_proxy configuration parameter missing

2013-09-25 Thread tickets

Issue #19111 has been updated by Josh Cooper.

Description updated
Status changed from Unreviewed to Accepted


Feature #19111: no_proxy configuration parameter missing
https://projects.puppetlabs.com/issues/19111#change-97955

* Author: Michael Rumpf
* Status: Accepted
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* Affected Puppet version: 
* Keywords: 
* Branch: 

In a corporate environment a proxy must usually be used to access the internet.
When I add the parameters http_proxy_host and http_proxy_port to my 
puppet.conf, I can install modules from puppetforge just fine.
But the proxy seems to be used by the puppetmaster to connect to the 
puppet-dashboard as well. This fails as the server cannot be reached via the 
proxy.


puppet.conf
[main]
http_proxy_host = myproxy.mycompany.com
http_proxy_port = 80
[master]
reporturl=http://localhost:3000/reports/upload
external_nodes = /usr/bin/env PUPPET_DASHBOARD_URL=http://localhost:3000 
/usr/share/puppet-dashboard/bin/external_node


I tried both, localhost and the FQDN of the puppet-dashboard host in 
puppet.conf, but the agent on same node tells in /var/log/syslog:

Feb  7 09:26:08 x puppet-agent[3234]: Starting Puppet client version 3.0.2
Feb  7 09:26:08 x puppet-agent[3234]: Reopening log files
Feb  7 09:26:08 x puppet-agent[3238]: Failed to apply catalog: 403 
"Forbidden"
Feb  7 09:26:08 x puppet-agent[3238]: Could not send report: 403 "Forbidden"

It would be nice if a "no_proxy" parameter could be added so that hosts can be 
specified for which a direct connect should be used.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22557] Regression on arrays and puppet resources using the name attribute

2013-09-25 Thread tickets

Issue #22557 has been updated by Andrew Parker.


On the other hand, there is the problem that this code doesn't seem to take 
into account that `name` can be an array. Is it true that name can really be an 
array? I think that this usage was depending on an accident of the 
implementation, but I could be wrong.


Bug #22557: Regression on arrays and puppet resources using the name attribute
https://projects.puppetlabs.com/issues/22557#change-97953

* Author: William Van Hevelingen
* Status: Investigating
* Priority: Normal
* Assignee: Andrew Parker
* Category: 
* Target version: 
* Affected Puppet version: 3.3.0
* Keywords: 
* Branch: 

Upgraded to Puppet 3.3.0 and started getting these errors.

Reporting broken for arrays on puppet resources using the name attribute.


# puppet apply -e "package { 'nrpe': name => ['nagios-plugins', 
'nagios-nrpe-server'], ensure=>present } "
Notice: Compiled catalog for foo.lan in environment production in 1.72 seconds
Notice: /Stage[main]//Package[nrpe]/ensure: ensure changed 'purged' to 'present'



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22557] Regression on arrays and puppet resources using the name attribute

2013-09-25 Thread tickets

Issue #22557 has been updated by Andrew Parker.


I think I've tracked this down. The problem is happening in the `query` method 
in the dpkg provider. When it executes

154 # list out our specific package
155 begin
156   self.class.dpkgquery_piped(
157 "-W",
158 "--showformat",
159 self.class::DPKG_QUERY_FORMAT_STRING,
160 @resource[:name]
161   ) do |pipe|
162 hash = self.class.parse_multi_line(pipe)
163   end
164 rescue Puppet::ExecutionFailure
165   # dpkg-query exits 1 if the package is not found.
166   return {:ensure => :purged, :status => 'missing', :name => 
@resource[:name], :error => 'ok'}
167 end


Then the `dpkg_query_piped` works correctly, sets `hash`, and it ok. Then the 
control is returned to `execpipe`. `execpipe` gets an exit status that is not 
0, it actually shows up as 36096. Inspection of the `Process::Status` object 
(which is what `$CHILD_STATUS` is) shows that it is exiting with 141. After 
some experimentation this seems to be because it is not reading everything from 
the dpkg command


irb(main):027:0> open("| /usr/bin/dpkg-query -W --showformat '${Status} 
${Package} ${Version} :DESC: ${Description}\n:DESC:\n' nagios-plugins 
nagios-nrpe-server") { |p| p.gets; p.gets
}
=> " Nagios is a host/service/network monitoring and management system.\n"
irb(main):028:0> $CHILD_STATUS
=> #
irb(main):029:0> open("| /usr/bin/dpkg-query -W --showformat '${Status} 
${Package} ${Version} :DESC: ${Description}\n:DESC:\n' nagios-plugins 
nagios-nrpe-server") { |p| while !p.eof; p
.gets; end }
=> nil
irb(main):030:0> $CHILD_STATUS
=> #


What this tells me is that the `parse_multi_line` method needs to make sure it 
drains the rest of the pipe when it is done.



Bug #22557: Regression on arrays and puppet resources using the name attribute
https://projects.puppetlabs.com/issues/22557#change-97952

* Author: William Van Hevelingen
* Status: Investigating
* Priority: Normal
* Assignee: Andrew Parker
* Category: 
* Target version: 
* Affected Puppet version: 3.3.0
* Keywords: 
* Branch: 

Upgraded to Puppet 3.3.0 and started getting these errors.

Reporting broken for arrays on puppet resources using the name attribute.


# puppet apply -e "package { 'nrpe': name => ['nagios-plugins', 
'nagios-nrpe-server'], ensure=>present } "
Notice: Compiled catalog for foo.lan in environment production in 1.72 seconds
Notice: /Stage[main]//Package[nrpe]/ensure: ensure changed 'purged' to 'present'



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22557] Regression on arrays and puppet resources using the name attribute

2013-09-25 Thread tickets

Issue #22557 has been updated by Andrew Parker.


Just did a bisect on this and the behavior change happened in:


e96ac6b6abb9f387e9b8cd097b024aaa4bc656ee is the first bad commit
commit e96ac6b6abb9f387e9b8cd097b024aaa4bc656ee
Author: Josh Partlow 
Date:   Tue Apr 30 19:02:04 2013 -0700

(#19875) Package descriptions obtained by rpm/dpkg providers



Bug #22557: Regression on arrays and puppet resources using the name attribute
https://projects.puppetlabs.com/issues/22557#change-97949

* Author: William Van Hevelingen
* Status: Investigating
* Priority: Normal
* Assignee: Andrew Parker
* Category: 
* Target version: 
* Affected Puppet version: 3.3.0
* Keywords: 
* Branch: 

Upgraded to Puppet 3.3.0 and started getting these errors.

Reporting broken for arrays on puppet resources using the name attribute.


# puppet apply -e "package { 'nrpe': name => ['nagios-plugins', 
'nagios-nrpe-server'], ensure=>present } "
Notice: Compiled catalog for foo.lan in environment production in 1.72 seconds
Notice: /Stage[main]//Package[nrpe]/ensure: ensure changed 'purged' to 'present'



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22557] (Investigating) Regression on arrays and puppet resources using the name attribute

2013-09-25 Thread tickets

Issue #22557 has been updated by Andrew Parker.

Status changed from Accepted to Investigating
Assignee set to Andrew Parker


Bug #22557: Regression on arrays and puppet resources using the name attribute
https://projects.puppetlabs.com/issues/22557#change-97947

* Author: William Van Hevelingen
* Status: Investigating
* Priority: Normal
* Assignee: Andrew Parker
* Category: 
* Target version: 
* Affected Puppet version: 3.3.0
* Keywords: 
* Branch: 

Upgraded to Puppet 3.3.0 and started getting these errors.

Reporting broken for arrays on puppet resources using the name attribute.


# puppet apply -e "package { 'nrpe': name => ['nagios-plugins', 
'nagios-nrpe-server'], ensure=>present } "
Notice: Compiled catalog for foo.lan in environment production in 1.72 seconds
Notice: /Stage[main]//Package[nrpe]/ensure: ensure changed 'purged' to 'present'



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22652] (In Topic Branch Pending Review) ignore doesn't work if pluginsync enabled

2013-09-25 Thread tickets

Issue #22652 has been updated by Andrew Parker.

Status changed from Accepted to In Topic Branch Pending Review
Branch set to https://github.com/puppetlabs/puppet/pull/1938




Bug #22652: ignore doesn't work if pluginsync enabled
https://projects.puppetlabs.com/issues/22652#change-97946

* Author: Daniel Wittenberg
* Status: In Topic Branch Pending Review
* Priority: Normal
* Assignee: Kylo Ginsberg
* Category: 
* Target version: 3.3.1
* Affected Puppet version: 3.3.1-rc1
* Keywords: 
* Branch: https://github.com/puppetlabs/puppet/pull/1938

/var/lib/puppet//.svn directories are still pushed out even if you have a 
global ignore 
File { ignore => '.svn' }

Confirmed by downgrading the server to 3.2.4-1 and it all worked as expected, 
no .svn directories in /var/lib/puppet


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #19153] service puppet ensure stopped kills off cron-run puppet with "Caught TERM; calling stop"

2013-09-25 Thread tickets

Issue #19153 has been updated by Poul H. Sørensen.


A related problem:

If a puppet-client machine is rebooted during a puppet run:
Nothing will remove the lock file  /var/lib/puppet/state/agent_catalog_run.lock
(which, in my opinion, ought to be located on /var/run instead).

And because the lock-file exists, no further puppet-runs will occur.


Bug #19153: service puppet ensure stopped kills off cron-run puppet with 
"Caught TERM; calling stop"
https://projects.puppetlabs.com/issues/19153#change-97944

* Author: Jo Rhett
* Status: Accepted
* Priority: Urgent
* Assignee: 
* Category: agent
* Target version: 3.x
* Affected Puppet version: 
* Keywords: init service
* Branch: 

We have recently switched from puppet agent in daemon mode (for kick) to 
cron-run puppet with mcollective agent. However, I started noticing that puppet 
policies were being inconsistently applied across the hosts. It turns out that 
this policy is the problem:


service { 'puppet':
ensure  => stopped,
enable  => false,
require => File['/etc/cron.d/puppet','/etc/puppet/puppet.conf'],
}


I have checked and confirmed that the puppet init script returns the correct 
response even when puppet is running. If I run "puppet agent --test" in one 
window and while it is running I run this in the other window, it shows clear:


root@sj2-noc01 ~$ service puppet status ; echo $?
puppet is stopped
3


However, if I run puppet in a silent mode with --onetime and --no-daemon then 
the init script returns this value


root@sj2-noc01 ~$ service puppet status ; echo $?
puppet (pid  30406) is running...
0


This causes it to kill itself off, and not finish the run. Due to the 
semi-random nature of ordering, this happens near the end or near the beginning 
of the puppet run on different hosts. (there are few dependancies on the puppet 
module, so its order in the manifest is random from host to host)

This is clearly a major flaw. We need the above policy to ensure that no puppet 
daemons are running, however it interferes with the cron-run instance. However 
it is handled properly when run verbosely with test.

Environment is a mixture of CentOS 5 & 6.



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22563] 3.2.4 invalid byte sequence in US-ASCII for extlookup variables

2013-09-25 Thread tickets

Issue #22563 has been updated by Claudiu Vasadi.


puppet agent 3.3.1-rc1 still has this problem.


Bug #22563: 3.2.4 invalid byte sequence in US-ASCII for extlookup variables
https://projects.puppetlabs.com/issues/22563#change-97943

* Author: Luke Alexander
* Status: Unreviewed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* Affected Puppet version: 3.2.4
* Keywords: 
* Branch: 

I have a bug with a recently upgraded puppet master, when I run the puppet 
client on the master we get this error:

puppet agent -vt --debug > /root/debug.log
Warning: Local environment: "production" doesn't match server specified node 
environment "dr", switching agent to "dr".
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: 
invalid byte sequence in US-ASCII at 
/etc/puppet/modules/vendor/apt/manifests/params.pp:7 on node 
guadalupe.dr.brandwatch.net
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

Line 7 from params.pp is an extlookup variable:

$reposerver = extlookup(“reposerver”)

reposerver from extdata evaluates to a fqdn of our repo server

I can work around this problem by adding the below lines to the top of 
/usr/lib/ruby/vendor_ruby/puppet/parser/functions/extlookup.rb

Encoding.default_external = Encoding::UTF_8
Encoding.default_internal = Encoding::UTF_8

I guess that is not the correct fix, though.

This on Debian Wheezy with:
ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-linux]
puppet 3.2.4
facter 1.6.7

I've attached the debug log.
Regards,
Luke





-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Feature #22662] create a logstash_event logger

2013-09-25 Thread tickets

Issue #22662 has been updated by R. Arruda.

Target version set to 3.3.0
Affected Puppet version set to 3.3.0
Branch set to master

Looks like bug #6523 (somewhat related) is now solved.

I should also add that this code is inspired by 
http://www.strewth.org/words/2011/02/structured-log-output-from-puppet/

-Renato


Feature #22662: create a logstash_event logger
https://projects.puppetlabs.com/issues/22662#change-97942

* Author: R. Arruda
* Status: Unreviewed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 3.3.0
* Affected Puppet version: 3.3.0
* Keywords: log, logstash, json
* Branch: master

Hi,

I would like to be able to log puppet runs in logstash using a structured log 
format (json, eventlog, schema can be found at 
https://logstash.jira.com/browse/LOGSTASH-675 ). I'm hope that this 
implementation is acceptable. Also let me know if it needs additional rspec 
tests.

The patch is attached, but I will be soon sending the patch via a pull request 
as well.

Regards,
Renato


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Bug #22613] puppet agent installer 3.2.4 and 3.3.0 on windows xp (sp2 and sp3) german edition gives “Service 'Puppet Agent' (puppet) failed to start. Verify that you have sufficient privileg

2013-09-25 Thread tickets

Issue #22613 has been updated by Claudiu Vasadi.


puppet agent 3.3.1-rc1 fixed this issue.

Thx guys.


Bug #22613: puppet agent installer 3.2.4 and 3.3.0 on windows xp (sp2 and sp3) 
german edition gives “Service 'Puppet Agent' (puppet) failed to start. Verify 
that you have sufficient privileges to start system services."
https://projects.puppetlabs.com/issues/22613#change-97941

* Author: Claudiu Vasadi
* Status: Duplicate
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* Affected Puppet version: 
* Keywords: 
* Branch: 

I noticed this problem on Windows XP Professional SP2 and SP3 german edition 
only (VM and physical machine). Basically, the installation process goes all 
the way through and then it fails to start the service. Keeping an eye on 
"Services" I noticed the installer trying to restart the service 3 times and 
then giving up. The "Event Viewer" gives not much extra info.

Puppet agent for windows works fine on Windows XP SP2 and SP3 english edition.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.


[Puppet - Feature #22662] create a logstash_event logger

2013-09-25 Thread tickets

Issue #22662 has been updated by R. Arruda.


Pull request now in place. Any and all feedback will be appreciated.

-Renato


Feature #22662: create a logstash_event logger
https://projects.puppetlabs.com/issues/22662#change-97940

* Author: R. Arruda
* Status: Unreviewed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* Affected Puppet version: 
* Keywords: log, logstash, json
* Branch: 

Hi,

I would like to be able to log puppet runs in logstash using a structured log 
format (json, eventlog, schema can be found at 
https://logstash.jira.com/browse/LOGSTASH-675 ). I'm hope that this 
implementation is acceptable. Also let me know if it needs additional rspec 
tests.

The patch is attached, but I will be soon sending the patch via a pull request 
as well.

Regards,
Renato


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.