Jira (FACT-469) facter clobbers LANG env var for other threads

2014-04-27 Thread Cezary Baginski (JIRA)
Title: Message Title










 

 Cezary Baginski updated an issue











 






 Facter /  FACT-469



  facter clobbers LANG env var for other threads 










PR: https://github.com/puppetlabs/facter/pull/669












   

 Add Comment











 










 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-469) facter clobbers LANG env var for other threads

2014-04-27 Thread Cezary Baginski (JIRA)
Title: Message Title










 

 Cezary Baginski created an issue











 






 Facter /  FACT-469



  facter clobbers LANG env var for other threads 










Issue Type:

  Bug




Affects Versions:


 1.7.6, 1.7.5, 2.0.1, 1.7.4




Assignee:

 Eric Sorenson




Created:


 27/Apr/14 11:10 PM




Priority:

  Normal




Reporter:

 Cezary Baginski










How to reproduce: 1. run thread #1 that uses ENV['LANG'] 2. run thread #2 that reads a factor variable
Expected: thread #1 ENV['LANG'] stays the same
Actual: thread #1 ENV['LANG'] is sometimes randomly set to 'C'












   

 Add Comment











 










 

Jira (PUP-2354) allow duplicate certs does not work with agent/master

2014-04-27 Thread Kylo Ginsberg (JIRA)
Title: Message Title










 

 Kylo Ginsberg commented on an issue











 






  Re: allow duplicate certs does not work with agent/master 










@josh can you comment on this one?












   

 Add Comment











 













 Puppet /  PUP-2354



  allow duplicate certs does not work with agent/master 







 On my master, I set:   {code}  [main]    allow_deplicate_certs = true  {code}   on the master, I regenerate a private key, I get the failure:   {noformat}  root@cygnet-2:~# puppet agent -t --ssldir=/tmp/  info: Creating a new SSL key for cygnet-2.cygnet.lab  warning: peer certificate won't be verified in this SSL session  info: Caching certificate for ...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2182) Package resource not working as expected in 3.5.0

2014-04-27 Thread Michael Stahnke (JIRA)
Title: Message Title










 

 Michael Stahnke commented on an issue











 






  Re: Package resource not working as expected in 3.5.0 










My 2 cents is that the package resource should behave like a call to yum. Therefore if I say ensure it's installed, it is. If I say it should be uninstalled, it should be. I don't really see any reason to be more fancy than that. If yum works that way, why shouldn't our abstraction?
I think the syslog example above is odd. Just ensure rsyslog is installed. There should be no need to remove syslog. 












   

 Add Comment











 













 Puppet /  PUP-2182



  Package resource not working as expected in 3.5.0 







 One of my modules has the following code:   {code}  package { 'inetd': ensure => absent; }  {code}   On the next Puppet run, Puppet tries to remove the xinetd package (debug output):  {code}  Debug: Executing '/bin/rpm -q inetd --nosignature --nodigest --qf %{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\n'  Debug: Executing '/bin/rpm -q i...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe fr

Jira (PUP-2182) Package resource not working as expected in 3.5.0

2014-04-27 Thread Kylo Ginsberg (JIRA)
Title: Message Title










 

 Kylo Ginsberg commented on an issue











 






  Re: Package resource not working as expected in 3.5.0 










For background, this was introduced in 

PUP-897
 (which has links to two long-time redmine issues requesting support for virtual packages).
At this point, I'm leaning toward option #3 (and if we did that, I'm also wondering if allow_virtual should default to true in puppet-4?). But I'd still like to get more input. Adrien Thebo any thoughts on this one?












   

 Add Comment











 













 Puppet /  PUP-2182



  Package resource not working as expected in 3.5.0 







 One of my modules has the following code:   {code}  package { 'inetd': ensure => absent; }  {code}   On the next Puppet run, Puppet tries to remove the xinetd package (debug output):  {code}  Debug: Executing '/bin/rpm -q inetd --nosignature --nodigest --qf %{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\n'  Debug: Executing '/bin/rpm -q i...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this messa

Jira (PUP-2182) Package resource not working as expected in 3.5.0

2014-04-27 Thread Nick Le Mouton (JIRA)
Title: Message Title










 

 Nick Le Mouton commented on an issue











 






  Re: Package resource not working as expected in 3.5.0 










Just came across this problem on my servers as well. I had to vote on a solution it would be to rollback to previous behaviour (pre 3.5). I can't seem to find any mention of Michael Stahnke's reasoning to add support for virtual packages, so I'm unsure on why this was done in the first place.












   

 Add Comment











 













 Puppet /  PUP-2182



  Package resource not working as expected in 3.5.0 







 One of my modules has the following code:   {code}  package { 'inetd': ensure => absent; }  {code}   On the next Puppet run, Puppet tries to remove the xinetd package (debug output):  {code}  Debug: Executing '/bin/rpm -q inetd --nosignature --nodigest --qf %{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\n'  Debug: Executing '/bin/rpm -q i...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-b

Jira (PDB-623) Constraint violation

2014-04-27 Thread jon yeargers (JIRA)
Title: Message Title










 

 jon yeargers commented on an issue











 






  Re: Constraint violation 










I use phusion passenger(4.0.41) to run the puppet server. It restarts every weekend (and did so this morning). 
What other details can I provide? If this is isolated to my installation then any guidance on how to fix it would be appreciated.
I included the versions of all puppet and puppet related RPMs on my system in a previous comment. 












   

 Add Comment











 













 PuppetDB /  PDB-623



  Constraint violation 














 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-468) undefined method `ipaddress' for Facter:Module

2014-04-27 Thread Eric Sorenson (JIRA)
Title: Message Title










 

 Eric Sorenson commented on an issue











 






  Re: undefined method `ipaddress' for Facter:Module 










one of the backwards-incompatible API changes in facter 2 is that we no longer support the accessors for facts as methods on Facter directly, as you're doing with "Facter.ipaddress". Instead, use Facter.value['ipaddress'] as described here: http://docs.puppetlabs.com/facter/latest/custom_facts.html#using-other-facts
This is called out in the release notes under "breaking changes": http://docs.puppetlabs.com/facter/latest/release_notes.html#breaking-changes












   

 Add Comment











 













 Facter /  FACT-468



  undefined method `ipaddress' for Facter:Module 







 I have the following code in my puppet setup:   {code:ruby}  def get_mysql_id  mysql_id = nil;  mysql_id = Facter.ipaddress.split('.').inject(0) {|total,value| (total << 8 ) + value.to_i}  end   Facter.add("mysql_server_id") do  setcode do  get_mysql_id  end  end  {code}   This has just started generating this error since facter...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Go

Jira (PUP-2371) Truthiness and nullness

2014-04-27 Thread Henrik Lindberg (JIRA)
Title: Message Title










 

 Henrik Lindberg commented on an issue











 






  Re: Truthiness and nullness 










This is a very thorny and multi faceted issue since the concept of "no value" is both poorly specified, and poorly implemented. In fact, the system uses different ways to handle "no value" in different parts of the system. How the fixes are made has backwards compatibility issues as well.


The 3x function API is designed so that undefined input is encoded as empty string


The 3x evaluator (and currently future evaluator as well) treats empty string and undefined as being equal to undef.


There is no requirement that values returned from functions are transformed back to Puppet (i.e. it may leak nil, :undef) or it may translate them to empty strings


When one function calls another there is no transformation - and Ruby values leak.


In 3x evaluation of argument expressions feed the Ruby result directly to the function




For 4x the consensus seems to be that the special "" == undef should be removed.


In addition to this, the new function API should operate on Ruby types as it is expensive to transform (it already does this, but we have not yet focused on the particular nil vs. :undef issue)


Until we have a new catalog and a new way to handle resources and types it is very difficult to do anything about the existing RAL.














   

 Add Comment











 










  

Jira (PUP-2371) Truthiness and nullness

2014-04-27 Thread Henrik Lindberg (JIRA)
Title: Message Title










 

 Henrik Lindberg updated an issue











 






 Puppet /  PUP-2371



  Truthiness and nullness 










Change By:

 Henrik Lindberg




Component/s:

 DSL












   

 Add Comment











 










 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2371) Truthiness and nullness

2014-04-27 Thread Henrik Lindberg (JIRA)
Title: Message Title










 

 Henrik Lindberg updated an issue











 






 Puppet /  PUP-2371



  Truthiness and nullness 










Change By:

 Henrik Lindberg




Labels:

 future-parser












   

 Add Comment











 










 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDB-623) Constraint violation

2014-04-27 Thread Kenneth Barber (JIRA)
Title: Message Title










 

 Kenneth Barber updated an issue











 






 PuppetDB /  PDB-623



  Constraint violation 










Change By:

 Kenneth Barber




Assignee:

 jon yeargers












   

 Add Comment











 










 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDB-623) Constraint violation

2014-04-27 Thread Kenneth Barber (JIRA)
Title: Message Title










 

 Kenneth Barber commented on an issue











 






  Re: Constraint violation 










This looks like a duplicate of 

PDB-349
, and should have been resolved by Puppet 3.4.3 (see 

PUP-1524
). This is caused by Puppet emitting duplicate events and can be solved with an upgrade to Puppet 3.4.3 or greater.
However, you say you've already upgraded to 3.5.1. Are you certain about this? I certainly haven't heard of any regressions in duplicate report events in Puppet 3.5.1 but anything is possible. To be clear, any Puppet master emitting reports that is still running 3.4.0, 3.4.1 and 3.4.2 will show this problem, this includes puppet masters that were upgrade but had not been properly restarted (for example Apache Passenger setups, often Apache isn't restarted during package install, but I could be wrong).
Please confirm this before we go ahead and try to duplicate on this end.












   

 Add Comment











 













 PuppetDB /  PDB-623



  Constraint violation 














 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegro

Jira (PUP-957) Case and Selector expressions using Regexp type does not set match vars

2014-04-27 Thread Henrik Lindberg (JIRA)
Title: Message Title










 

 Henrik Lindberg commented on an issue











 






  Re: Case and Selector expressions using Regexp type does not set match vars 










The issues here are:


It is questionable if it is helpful that a LHS =~ RegexpType works as if the RHS was a literal Regexp since a RHS String is converted to a Regexp by the =~ operator.


Strictly, a String is not an instance of Regexp - and thus, the =~ operator can not be used to tell if something is a Regexp


It is correct to use a PatternType to match String vs Pattern (Pattern is based on one or more Regexps)


Since a Pattern has 0-many regular expressions, it becomes difficult to handle the $0-$n variables (how does the user know which regexp matched? (They can have different number of captures).


Setting match variables based on type becomes even more complex if the type is an Optional, Variant or Struct type where one nested type is a Pattern type. Should result be captured there as well? What should happen if there are multiple Pattern types being triggered (say for a struct or collection)? (Short answer: this is neither easy to implement nor easy to understand / use).


I think the right thing to do is the following:


Remove the special handling of RegexpType for =~ operator that sets match data


(As a consequence of the above, a String does not match RegexpType, now only regular expressions do)


Specify that matching against a type never sets match variables


If we want to do more, we can implement a function that is similar to the matches operator, but that returns matched data as an Array. This function could be given more smarts wrt to matching against regexp, RegexpType, PatternType, and string (regexp in string form) than the boolean "is instance of" that is otherwise performed for types. Also, since it is a function, it does not have to return a boolean (which is the specified result of the matches =~ and not matches !~ operators).



# Returns Array of match result where index 0 is the entire matched part, and index 1-n are the captured matches
match(string_to_match, pattern_or_type)



This function has several benefits:

 

Jira (PUP-957) Case and Selector expressions using Regexp type does not set match vars

2014-04-27 Thread Henrik Lindberg (JIRA)
Title: Message Title










 

 Henrik Lindberg updated an issue











 






 Puppet /  PUP-957



  Case and Selector expressions using Regexp type does not set match vars 










Change By:

 Henrik Lindberg









 Since =~ operator treats the  Pattern  Regexp  type as if it were a regular _expression_ and sets the match variables, so should the other conditional expressions that invoke pattern matching (case and selector).This is missing in the new evaluator implementation. (Matching is still done, but without the side effect of setting the match variables).












   

 Add Comment











 










 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDB-623) Constraint violation

2014-04-27 Thread jon yeargers (JIRA)
Title: Message Title










 

 jon yeargers commented on an issue











 






  Re: Constraint violation 










NOTE: some agents are still serviced correctly. Evidenced as follows:
2014-04-27 16:08:35,736 INFO [command-proc-68] [puppetdb.command] [e41b62c7-64a7-46af-811d-2533a748d113] [replace facts] tenm a.bme.ogi.edu 2014-04-27 16:08:38,743 INFO [command-proc-67] [puppetdb.command] [22475f94-e008-4e72-90d4-3a7d5028dfd3] [replace catalog] te nma.bme.ogi.edu 2014-04-27 16:08:49,492 INFO [command-proc-66] [puppetdb.command] [7dd1d463-0c19-4347-9d8b-d922690e29c5] [store report] puppe t v3.5.1 - tenma.bme.ogi.edu 2014-04-27 16:08:53,993 INFO [command-proc-65] [puppetdb.command] [5425ae53-cd19-4c42-9313-3a4e69a60345] [store report] puppe t v3.4.0 - plugpc-036.pocl
and so on...












   

 Add Comment











 













 PuppetDB /  PDB-623



  Constraint violation 














 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDB-623) Constraint violation

2014-04-27 Thread jon yeargers (JIRA)
Title: Message Title










 

 jon yeargers commented on an issue











 






  Re: Constraint violation 










After upgrade to these versions:


rpm -qa | grep puppet puppetdb-1.6.3-1.el6.noarch puppet-3.5.1-1.el6.noarch puppet-server-3.5.1-1.el6.noarch vim-puppet-2.7.20-1.el6.rf.noarch puppetlabs-release-6-10.noarch puppetdb-terminus-1.6.3-1.el6.noarch


the puppetdb log file begins reporting this exception:
2014-04-27 16:07:37,009 ERROR [command-proc-65] [puppetdb.command] [18189b8b-5e27-4e96-8a03-42ac88186ff0] [store report] Retry ing after attempt 7, due to: java.sql.SQLIntegrityConstraintViolationException: integrity constraint violation: unique constra int or index violation; CONSTRAINT_RESOURCE_EVENTS_UNIQUE table: RESOURCE_EVENTS java.sql.SQLIntegrityConstraintViolationException: integrity constraint violation: unique constraint or index violation; CONST RAINT_RESOURCE_EVENTS_UNIQUE table: RESOURCE_EVENTS at org.hsqldb.jdbc.Util.sqlException(Unknown Source) at org.hsqldb.jdbc.Util.sqlException(Unknown Source) at org.hsqldb.jdbc.JDBCPreparedStatement.fetchResult(Unknown Source) at org.hsqldb.jdbc.JDBCPreparedStatement.executeUpdate(Unknown Source) at com.jolbox.bonecp.PreparedStatementHandle.executeUpdate(PreparedStatementHandle.java:203) at clojure.java.jdbc.internal$do_prepared_return_keys_STAR_$fn__2133.invoke(internal.clj:337) at clojure.java.jdbc.internal$transaction_STAR_.invoke(internal.clj:223) at clojure.java.jdbc.internal$do_prepared_return_keys_STAR_.invoke(internal.clj:337) at clojure.lang.AFn.applyToHelper(AFn.java:163) at clojure.lang.AFn.applyTo(AFn.java:151) at clojure.core$apply.invoke(core.clj:619) at clojure.java.jdbc$insert_values.doInvoke(jdbc.clj:263) at clojure.lang.RestFn.invoke(RestFn.java:442) at clojure.java.jdbc$insert_records$ins_v__2201.invoke(jdbc.clj:278) at clojure.core$map$fn__4207.invoke(core.clj:2485) at clojure.lang.LazySeq.sval(LazySeq.java:42) at clojure.lang.LazySeq.seq(LazySeq.java:60) at clojure.lang.RT.seq(RT.java:484) at clojure.core$seq.invoke(core.clj:133) at clojure.core$dorun.invoke(core.clj:2780) at clojure.core$doall.invoke(core.clj:2796) at clojure.java.jdbc$insert_records.doInvoke(jdbc.clj:279) at clojure.lang.RestFn.applyTo(RestFn.java:139) at clojure.core$apply.invoke(core.clj:619) at com.puppetlabs.puppetdb.scf.storage$add_report_BANG_STAR$fn_3922$fn_3923.invoke(storage.clj:823) at clojure.java.jdbc.internal$transaction_STAR_.invoke(internal.clj:223) at com.puppetlabs.puppetdb.scf.storage$add_report_BANG_STAR$fn__3922.invoke(storage.clj:812) at com.puppetlabs.puppetdb.scf.storage.proxy$java.lang.Object$Callable$f8c5758f.call(Unknown Source) at com.yammer.metrics.core.Timer.time(Timer.java:91) at com.puppetlabs.puppetdb.scf.storage$add_report_BANG_STAR.invoke(storage.clj:811) at com.puppetlabs.puppetdb.scf.storage$eval4096$add_report_BANG__4097$fn_4098.invoke(storage.clj:929) at com.puppetlabs.puppetdb.scf.storage$eval4096$add_report_BANG___4097.invoke(storage.clj:925) at com.puppetlabs.puppetdb.command$store_report_STAR_$fn__5566.invoke(command.clj:376) at com.puppetlabs.jdbc$with_transacted_connection_fn$fn_2278$fn_2279.invoke(jdbc.clj:229) at clojure.java.jdbc.internal$transaction_STAR_.invoke(internal.clj:204) at com.puppetlabs.jdbc$with_transacted_connection_fn$fn__2278.invoke(jdbc.clj:228) at clojure.java.jdbc.internal$with_connection_STAR_.invoke(internal.clj:186) at com.puppetlabs.jdbc$with_transacted_connection_fn.invoke(jdbc.clj:225) at com.puppetlabs.puppetdb.command$store_report_STAR_.invoke(command.clj:374) at com.puppetlabs.puppetdb.command$eval5578$fn__5581.invoke(command.clj:389) at clojure.lang.

Jira (PUP-957) Case and Selector expressions using Regexp type does not set match vars

2014-04-27 Thread Henrik Lindberg (JIRA)
Title: Message Title










 

 Henrik Lindberg updated an issue











 






 Puppet /  PUP-957



  Case and Selector expressions using Regexp type does not set match vars 










Change By:

 Henrik Lindberg









 Since =~ operator treats the  Regexp  Pattern  type as if it were a regular _expression_ and sets the match variables, so should the other conditional expressions that invoke pattern matching (case and selector).This is missing in the new evaluator implementation. (Matching is still done, but without the side effect of setting the match variables).












   

 Add Comment











 










 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDB-623) Constraint violation

2014-04-27 Thread jon yeargers (JIRA)
Title: Message Title










 

 jon yeargers created an issue











 






 PuppetDB /  PDB-623



  Constraint violation 










Issue Type:

  Bug




Affects Versions:


 1.6.3




Assignee:


 Unassigned




Created:


 27/Apr/14 4:06 PM




Environment:


CentOS 6.4 x64




Priority:

  Normal




Reporter:

 jon yeargers












   

 Add Comment











 










 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 

  

Jira (PUP-2317) Future parser does not error on import statements

2014-04-27 Thread Henrik Lindberg (JIRA)
Title: Message Title










 

 Henrik Lindberg commented on an issue











 






  Re: Future parser does not error on import statements 










So, do you think it is ok to leave it that way? One alternative is to deal with it in the transformation to 3x since we are not too concerned about the performance in that case (it is already slow).












   

 Add Comment











 













 Puppet /  PUP-2317



  Future parser does not error on import statements 







 Puppet 3.5.1 with Future parser enabled does not fail on import statements. When parser is set to current it correctly warns the user that import is deprecated.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-468) undefined method `ipaddress' for Facter:Module

2014-04-27 Thread Nick Le Mouton (JIRA)
Title: Message Title










 

 Nick Le Mouton updated an issue











 






 Facter /  FACT-468



  undefined method `ipaddress' for Facter:Module 










Change By:

 Nick Le Mouton









 I have the following code in my puppet setup: {code:ruby} def get_mysql_idmysql_id = nil;mysql_id = Facter.ipaddress.split('.').inject(0) {|total,value| (total << 8 ) + value.to_i}endFacter.add("mysql_server_id") dosetcode doget_mysql_idendend {code}   This has just started generating this error since facter 2.x (maybe puppet 3.5.1?):Could not retrieve fact='mysql_server_id', resolution='': undefined method `ipaddress' for Facter:Module












   

 Add Comment











 










 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-468) undefined method `ipaddress' for Facter:Module

2014-04-27 Thread Nick Le Mouton (JIRA)
Title: Message Title










 

 Nick Le Mouton created an issue











 






 Facter /  FACT-468



  undefined method `ipaddress' for Facter:Module 










Issue Type:

  Bug




Affects Versions:


 2.0.1




Assignee:

 Eric Sorenson




Created:


 27/Apr/14 3:10 PM




Environment:


RHEL 6.x




Priority:

  Normal




Reporter:

 Nick Le Mouton










I have the following code in my puppet setup:
def get_mysql_id mysql_id = nil; mysql_id = Facter.ipaddress.split('.').inject(0)  {|total,value| (total << 8 ) + value.to_i}
end
Facter.add("mysql_server_id") do setcode do get_mysql_id end end
This has just started generating this error since facter 2.x (maybe puppet 3.5.1?): Could not retrieve fact='mysql_server_id', resolution='': undefined method `ipaddress' for Facter:Module












   

 Add Comment
   

Jira (PUP-2302) New evaluator does not properly handle resource defaults

2014-04-27 Thread Andy Parker (JIRA)
Title: Message Title










 

 Andy Parker commented on an issue











 






  Re: New evaluator does not properly handle resource defaults 










Merged into master in 0283ab












   

 Add Comment











 













 Puppet /  PUP-2302



  New evaluator does not properly handle resource defaults 







 Resource defaults in the new evaluator appear to not be working for defined resource types.   {code:title=Testing manifest}  define testing::thing($msg = 'param default') {    notify { 'name': message => $msg }  }   Testing::Thing {  msg => 'resource default'  }   testing::thing { 'name': }  {code}   If the above code is run with the new evaluato...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2317) Future parser does not error on import statements

2014-04-27 Thread Andy Parker (JIRA)
Title: Message Title










 

 Andy Parker commented on an issue











 






  Re: Future parser does not error on import statements 










Merged into master in ebe3c8.
There is a small issue with the patch, but not one that I'm worried about. Since the error is issued by using a function written using the new Function 4 API, it doesn't create the right warning when --evaluator current is given. It still produces an error, however, so this isn't as bad as silently ignoring. However the error is a little misleading because it says that there is no function named "import".












   

 Add Comment











 













 Puppet /  PUP-2317



  Future parser does not error on import statements 







 Puppet 3.5.1 with Future parser enabled does not fail on import statements. When parser is set to current it correctly warns the user that import is deprecated.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegr

Jira (PUP-2302) New evaluator does not properly handle resource defaults

2014-04-27 Thread Andy Parker (JIRA)
Title: Message Title










 

 Andy Parker assigned an issue to Andy Parker











 






 Puppet /  PUP-2302



  New evaluator does not properly handle resource defaults 










Change By:

 Andy Parker




Assignee:

 Andy Parker












   

 Add Comment











 










 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2317) Future parser does not error on import statements

2014-04-27 Thread Andy Parker (JIRA)
Title: Message Title










 

 Andy Parker assigned an issue to Andy Parker











 






 Puppet /  PUP-2317



  Future parser does not error on import statements 










Change By:

 Andy Parker




Assignee:

 Andy Parker












   

 Add Comment











 










 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2371) Truthiness and nullness

2014-04-27 Thread Daniele Sluijters (JIRA)
Title: Message Title










 

 Daniele Sluijters updated an issue











 






 Puppet /  PUP-2371



  Truthiness and nullness 










Change By:

 Daniele Sluijters




Fix Version/s:

 4.x












   

 Add Comment











 










 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2371) Truthiness and nullness

2014-04-27 Thread Daniele Sluijters (JIRA)
Title: Message Title










 

 Daniele Sluijters created an issue











 






 Puppet /  PUP-2371



  Truthiness and nullness 










Issue Type:

  Improvement




Affects Versions:


 3.5.1




Assignee:


 Unassigned




Created:


 27/Apr/14 7:02 AM




Fix Versions:


 4.x




Priority:

  Normal




Reporter:

 Daniele Sluijters










Puppet's definition of what is truly True, False or Nil is completely insane. Now that Puppet 4 has opened up I think it's a good time to fix this, once and for all.
The problem has recently hit me in Types and Providers where trying to use Boolean parameters and properties is just impossible because the RAL in a lot of places checks for truthiness instead of nullness.
I'm sure there's other examples both in Puppet's internals, Types and Providers and the DSL itself. I believe most of the DSL issues are fixed with future parser though.












   

  

Jira (PUP-2370) factpath conf setting ignored

2014-04-27 Thread JIRA
Title: Message Title










 

 Jürgen Weber created an issue











 






 Puppet /  PUP-2370



  factpath conf setting ignored 










Issue Type:

  Bug




Affects Versions:


 3.5.1




Assignee:


 Unassigned




Created:


 27/Apr/14 3:32 AM




Environment:




dpkg -l | grep puppet ii facter 2.0.1-1puppetlabs1 Ruby module for collecting simple facts about a host operating system ii hiera 1.3.2-1puppetlabs1 A simple pluggable Hierarchical Database. ii puppet 3.5.1-1puppetlabs1 Centralized configuration management - agent startup and compatibility scripts ii puppet-common 3.5.1-1puppetlabs1 Centralized configuration management ii puppetdb 1.6.3-1puppetlabs1 PuppetDB Centralized Storage. ii puppetdb-terminus 1.6.3-1puppetlabs1 Connect Puppet to PuppetDB by setting up a terminus for PuppetDB. ii puppetlabs-release 1.0-7 "Package to install Puppet Labs gpg key and apt repo" ii puppetmaster 3.5.1-1puppetlabs1 Centralized configuration management - master startup and compatibility scripts ii puppetmaster-common 3.5.1-1puppetlabs1 Puppet master common scripts ii ruby-rgen 0.6.5-1puppetlabs1 A framework supporting Model Driven Software Development (MDSD) ii vim-puppet 3.5.1-1puppetlabs1 syntax highlighting for puppet manifests in vim




uname -a Linux vagrant-tools01 3.2.0-60-generic #91-Ubuntu SMP Wed Feb 19 03:54:44 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux






Priority:

  Normal




Reporter:

 Jürgen Weber
  

Jira (PUP-2369) Add extra info to property's return

2014-04-27 Thread Daniele Sluijters (JIRA)
Title: Message Title










 

 Daniele Sluijters created an issue











 






 Puppet /  PUP-2369



  Add extra info to property's return 










Issue Type:

  Bug




Affects Versions:


 3.5.1




Assignee:

 Adrien Thebo




Components:


 Types and Providers




Created:


 27/Apr/14 2:04 AM




Priority:

  Trivial




Reporter:

 Daniele Sluijters










When working with boolean types in providers it happens too often that the values being passed around aren't what we think they are leading the developer down a twisty road of despair while trying to figure out why his methods aren't working.












   

 Add Comment