Jira (PUP-836) FFI Puppet::Util::Windows::User module

2014-05-24 Thread Ethan Brown (JIRA)
Title: Message Title










 

 Ethan Brown commented on an issue


















  Re: FFI Puppet::Util::Windows::User module 










We've already done a fair amount of review for this (and added some integration tests to ensure these APIs are called), but would be good to get an FR on the functionality around `puppet resource user` under Windows to ensure nothing accidentally broke.












   

 Add Comment

























 Puppet /  PUP-836



  FFI Puppet::Util::Windows::User module 







 Use FFI to define and invoke Windows APIs. Always call the wide-version, where applicable, e.g. LogonUserW. Also don't do things like:   {code}  sid = 0.chr * 80  size = [80].pack('L')  member = 0.chr * 4  {code} 















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-840) FFI Puppet::Util::Colors module

2014-05-24 Thread Ethan Brown (JIRA)
Title: Message Title










 

 Ethan Brown commented on an issue


















  Re: FFI Puppet::Util::Colors module 










An FR should verify that Puppet emits colors at the console properly on Windows and that strings still align, etc.












   

 Add Comment

























 Puppet /  PUP-840



  FFI Puppet::Util::Colors module 







 In order to maintain compatibility with ruby 1.9.x, this ticket is about FFI'ing the {{Puppet::Util::Colors}} module, so use FFI instead of:  {code}  WriteConsole = Win32API.new( kernel32, WriteConsoleW, ['l', 'p', 'l', 'p', 'p'], 'l' )  {code}   We should always prefer wide character APIs, and not make assumptions about pointer lengths:   {code}  ...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2658) Provide Latest Windows MSI Package URL for Quick Download

2014-05-24 Thread Louis Mayorga (JIRA)
Title: Message Title










 

 Louis Mayorga created an issue


















 Puppet /  PUP-2658



  Provide Latest Windows MSI Package URL for Quick Download 










Issue Type:

  Improvement




Assignee:


 Unassigned




Created:


 24/May/14 8:19 AM




Priority:

  Normal




Reporter:

 Louis Mayorga










Provide a Quick Download URL pointing to the latest version of puppet for windows.












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because 

Jira (PUP-2635) user purge_ssh_keys not purged

2014-05-24 Thread Felix Frank (JIRA)
Title: Message Title










 

 Felix Frank assigned an issue to Felix Frank


















 Puppet /  PUP-2635



  user purge_ssh_keys not purged 










Change By:

 Felix Frank




Assignee:

 KyloGinsberg FelixFrank












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2635) user purge_ssh_keys not purged

2014-05-24 Thread Felix Frank (JIRA)
Title: Message Title










 

 Felix Frank commented on an issue


















  Re: user purge_ssh_keys not purged 










I fear I cannot reproduce with 3.6.0. Doug Byrne, can you try and perform these steps?


Copy the contents of /home/ubuntu/.ssh/authorized_keys to /tmp/keytest


run the following command



puppet apply -e 'user { foo: purge_ssh_keys = /tmp/keytest, }' --noop





For me, this would work as expected:


Notice: Compiled catalog for geras.localdomain in environment production in 0.20 seconds
Notice: /Stage[main]/Main/Ssh_authorized_key[foreman-122dc11d6-bd1e-43e7-a00d-f8e2d0af54ea]/ensure: current_value present, should be absent (noop)
Notice: /Stage[main]/Main/Ssh_authorized_key[doug]/ensure: current_value present, should be absent (noop)
Notice: foo: Would have triggered 'refresh' from 2 events
Notice: Class[Main]: Would have triggered 'refresh' from 1 events
Notice: Stage[main]: Would have triggered 'refresh' from 1 events
Notice: Finished catalog run in 0.22 seconds















   

 Add Comment

























 Puppet /  PUP-2635



  user purge_ssh_keys not purged 







 I'm using Puppet 3.6.0 on Ubuntu 12.04 and I'm trying to 

Jira (PUP-2097) Could not evaluate: Failed to get security information: Incorrect function

2014-05-24 Thread Louis Mayorga (JIRA)
Title: Message Title










 

 Louis Mayorga commented on an issue


















  Re: Could not evaluate: Failed to get security information: Incorrect function 










About to test this soon. With 3.6.1 that seems to be the latest.












   

 Add Comment

























 Puppet /  PUP-2097



  Could not evaluate: Failed to get security information: Incorrect function 







 It seems that Puppet is not able to get the file permissions using vagrant basic mounted drives.   {code}  Could not evaluate: Failed to get security information: Incorrect function. Could not retrieve file metadata for puppet:///packages/webpicmd/files/Microsoft.Web.PlatformInstaller.dll: Failed to get security information: Incorrect function.  {code}...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2642) selector expression default should be matched last

2014-05-24 Thread Henrik Lindberg (JIRA)
Title: Message Title










 

 Henrik Lindberg commented on an issue


















  Re: selector _expression_ default should be matched last 










For functional review - simply obsereve output of this before and after the change:



notice 3 ? { default = 'the_default', 3 = 'the three' }















   

 Add Comment

























 Puppet /  PUP-2642



  selector _expression_ default should be matched last 







 The future evaluator treats a default in a selector _expression_ just like any other value (historically puppet regular did this too - although I may be wrong). It should instead defer matching against a default until no other entry matched (just like the case _expression_ does).   This will bite all users that have not followed the advice to place the defau...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an 

Jira (PUP-2314) assert_type function should handle lambda

2014-05-24 Thread Henrik Lindberg (JIRA)
Title: Message Title










 

 Henrik Lindberg commented on an issue


















  Re: assert_type function should handle lambda 










For functional review:
The assert_type before the change only accepted a type and a value, returned the value if it was an instance of the type. The new implementation allows a lambda to be given with two parameters, expected, and actual. The lambda is called if the value is not an instance of the type, and the value of the lambda is the value produced by the function.
As an example test:



notice assert_type(String, 1) | $expected, $actual | { warning(A $actual is not a $expected, using default) 'the default }



Which generates a warning, and outputs the default. Observe that changing the argument 1 to 'hello', notices hello and no warning is generated.












   

 Add Comment

























 Puppet /  PUP-2314



  assert_type function should handle lambda 







 The assert_type function was written before lambda support was added to the new function API. If called like this:   {code}  assert_type(Callable[Optional[Object]]) |$x| { }  {code}  It fails because it does not support an optional lambda being passed.   (The error message is also hard to understand - this is a separate issue).   This is easily fixed b...















 This message was 

Jira (PUP-2632) Type type is not an Object

2014-05-24 Thread Henrik Lindberg (JIRA)
Title: Message Title










 

 Henrik Lindberg commented on an issue


















  Re: Type type is not an Object 










For functional review, simply observe the difference of this before / after the change:



notice String =~ Object















   

 Add Comment

























 Puppet /  PUP-2632



  Type type is not an Object 







 It seemed to be a good idea to make the Type type not be an Object, but this creates difficulties when a type is needed for anything as it has to be written as Optional[Variant[Type, Object]], which is a horrible construct to begin with, and it will be shown in error messages for all untyped since it has to be the default for accepting anything.   The ...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email 

Jira (PUP-2659) Puppet stops working with error 'Attempted to pop, but already at root of the context stack.'

2014-05-24 Thread Henrik Lindberg (JIRA)
Title: Message Title










 

 Henrik Lindberg updated an issue


















 Puppet /  PUP-2659



  Puppet stops working with error 'Attempted to pop, but already at root of the context stack.' 










Change By:

 Henrik Lindberg




Assignee:

 WojciechUrbaƄski












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-2659) Puppet stops working with error 'Attempted to pop, but already at root of the context stack.'

2014-05-24 Thread Henrik Lindberg (JIRA)
Title: Message Title










 

 Henrik Lindberg commented on an issue


















  Re: Puppet stops working with error 'Attempted to pop, but already at root of the context stack.' 










Can you please supply information about your environment configuration - what have you configured, and in which section?












   

 Add Comment

























 Puppet /  PUP-2659



  Puppet stops working with error 'Attempted to pop, but already at root of the context stack.' 







 After upgrading puppet to version 3.6.1, the following error occurs:   {noformat}  Attempted to pop, but already at root of the context stack.  {noformat}   And afterwards log is flooded with following message:   {noformat}  no 'environments' in {:root_environment=#Puppet::Node::Environment:0x7fe1930f5a38 @manifest=/, @modulepath=[], @name=:*root*...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For