Jira (PUP-2855) Puppet agent segfault on OSX Mavericks when puppet master is running under passenger
Title: Message Title Christian Caterham commented on an issue Re: Puppet agent segfault on OSX Mavericks when puppet master is running under passenger Since 10.9.3 I get the the segmentation fault below. If the Mac running puppet is upgraded from 10.9.2 to 10.9.3 or 10.9.4 puppet runs without issue. The error below occurs on newly built 10.9.3 and 10.9.4. Facter 1.7.5 Puppet 3.4.3 mac:~ test$ sudo puppet agent --server puppet --waitforcert 60 --test --group 0 Info: Creating a new SSL key for test.inf.susx.ac.uk /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/net/http.rb:918: [BUG] Segmentation fault ruby 2.0.0p451 (2014-02-24 revision 45167) [universal.x86_64-darwin13] Add Comment Puppet / PUP-2855 Puppet agent segfault on OSX Mavericks when puppet master is running under passenger When running under the default WEBrick server puppet master and agents function as expected. When running under passenger agents on OSX Mavericks segfault (sorry, I don't have access to other versions of OSX currently). Agents running under CentOS 6.5 continue to function normally under passenger. Dump file attached. Here is the output: bash-3.2#... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-3037) Pluginsync notices on Windows reports file paths with forward slashes
Title: Message Title Chris Spence updated an issue Puppet / PUP-3037 Pluginsync notices on Windows reports file paths with forward slashes Change By: Chris Spence Pluginsync/loading facts notices on Windows output file paths with forward slashes: ` Notice: /File[C:/ProgramData/PuppetLabs/puppet/var/lib/puppet/provider/rabbitmq_ vhost]/ensure: removedInfo: Loading facts in C:/ProgramData/PuppetLabs/puppet/var/lib/facter/concat_basedir.rb ` This is clearly a lie. When I copy those paths and try to use them, Windows gets angry at me. Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3037) Pluginsync notices on Windows reports file paths with forward slashes
Title: Message Title Chris Spence created an issue Puppet / PUP-3037 Pluginsync notices on Windows reports file paths with forward slashes Issue Type: Bug Affects Versions: 3.6.2 Assignee: Kylo Ginsberg Components: Client Created: 08/Aug/14 4:31 AM Priority: Normal Reporter: Chris Spence Pluginsync/loading facts notices on Windows output file paths with forward slashes: `Notice: /File[C:/ProgramData/PuppetLabs/puppet/var/lib/puppet/provider/rabbitmq_ vhost]/ensure: removed Info: Loading facts in C:/ProgramData/PuppetLabs/puppet/var/lib/facter/concat_basedir.rb` This is clearly a lie. When I copy those paths and try to use them, Windows gets angry at me. Add Comment
Jira (PUP-3037) Pluginsync notices on Windows reports file paths with forward slashes
Title: Message Title Chris Spence updated an issue Puppet / PUP-3037 Pluginsync notices on Windows reports file paths with forward slashes Change By: Chris Spence Pluginsync/loading facts notices on Windows output file paths with forward slashes: {quote} Notice: /File[C:/ProgramData/PuppetLabs/puppet/var/lib/puppet/provider/rabbitmq_ vhost]/ensure: removedInfo: Loading facts in C:/ProgramData/PuppetLabs/puppet/var/lib/facter/concat_basedir.rb {quote} This is clearly a lie. When I copy those paths and try to use them, Windows gets angry at me. Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3018) Puppet doesn't like to evaluate 'require => [ [], [] ],'
Title: Message Title Faye Gibbins updated an issue Puppet / PUP-3018 Puppet doesn't like to evaluate 'require => [ [], [] ],' Change By: Faye Gibbins Sometimes you might want to programmatically decide upon a resources requries, viz:{code}someresource {'mynam': require => $flag ? { true => another_resource Another_resource ['name'], false => []},}{code}This works ok until you have lists on the RHS of the require line.This works ok:{code}someresource {'mynam': require => [$flag_a ? { true => resource_a Resource_a ['name_a'], false => []},],}{code}But this does not:{code}someresource {'mynam': require => [ $flag_a ? { true => resource_a Resource_a ['name_a'], false => []}, $flag_b ? { true => resource_b Resource_b ['name_b'], false => []}, ],}{code}Why? When {{$flag_a}} AND {{$flag_b}} are both false this reduces to:{code}someresource {'mynam': require => [ [], [] ],}{code}And puppet does not like this.To recap: require => [[]], is fine but require => [[],[]], is not.Also: {{require => [ [] , SomeResource['name'] ]}}, is OK too. As is : {{require => [ [] , SomeResource['name'], [] ],}}, this is OK.Confused yet?You might think that the rule is "don't have [],[] in a require". but you'd be wrong this stanza works fine:{code}require => [ [] , SomeResource['name'], [], [] ],{code}The error messages puppet client creates is :{noformat}Error: Failed to apply catalog: Parameter require failed on Exec[xx]: No title provided and [] is not a valid resource reference at /etc/puppet/..:##{noformat} Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscrib
Jira (PUP-3018) Puppet doesn't like to evaluate 'require => [ [], [] ],'
Title: Message Title Faye Gibbins commented on an issue Re: Puppet doesn't like to evaluate 'require => [ [], [] ],' I see what you mean. It looks like some more thought needs to be put into resource.rb as its current operation is too crude. Add Comment Puppet / PUP-3018 Puppet doesn't like to evaluate 'require => [ [], [] ],' Sometimes you might want to programmatically decide upon a resources requries, viz: {code} someresource {'mynam': require => $flag ? { true => Another_resource['name'], false => []}, } {code} This works ok until you have lists on the RHS of the require line. This works ok: {code} someresource {'mynam': require => [$flag_a ? { true ... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1130) PMT cannot install tarballs for modules that don't exist on the Forge
Title: Message Title Heikki Manninen commented on an issue Re: PMT cannot install tarballs for modules that don't exist on the Forge Seems to be a problem with Puppet 3.6.2 also: rpm -q puppet puppet-3.6.2-1.el6.noarch Module install still downloads from Forge if --force is not given: puppet module install /vagrant/puppet/modules/puppetlabs-stdlib-4.3.2.tar.gz Notice: Preparing to install into /etc/puppet/modules ... Notice: Downloading from https://forgeapi.puppetlabs.com ... Notice: Installing – do not interrupt ... /etc/puppet/modules └── puppetlabs-stdlib (v4.3.2) puppet module install --force /vagrant/puppet/modules/puppetlabs-stdlib-4.3.2.tar.gz Notice: Preparing to install into /etc/puppet/modules ... Notice: Installing – do not interrupt ... /etc/puppet/modules └── puppetlabs-stdlib (v4.3.2) Add Comment Puppet / PUP-1130 PMT cannot install tarballs for modules that don't exist on the Forge At present, unless you specify the `--ignore-dependencies` flag, the module tool behaves as follows when told to install a tarball: * Verify that the name ends in `.tar.gz` * Copy the tarball into the staging area * Decompose the filename into author, module short name, and version components * Ask the Forge for the dependency information for th..
Jira (PUP-2946) FileUtils implementation broke compare_stream
Title: Message Title Maksym Melnychok commented on an issue Re: FileUtils implementation broke compare_stream Adrien Thebo Joshua Partlow thanks for sorting this out! Add Comment Puppet / PUP-2946 FileUtils implementation broke compare_stream {{FileUtils.compare_stream}} implementation in ruby 1.9.3 was doing something along the lines of {code:ruby} a = b = nil while something a = as.read size b = bs.read size return false if a != b end {code} {{FileUtils.compare_stream}} in 2.0 instead does this: {code:ruby} a = "" b = "" while some... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3038) Typemanager wastes CPU cycles with global scope defined types
Title: Message Title Maksym Melnychok created an issue Puppet / PUP-3038 Typemanager wastes CPU cycles with global scope defined types Issue Type: Bug Assignee: Kylo Ginsberg Components: Client, Server Created: 08/Aug/14 5:32 AM Priority: Normal Reporter: Maksym Melnychok Defined type defined in a global scope will make MetaType::Manager go through all known code locations (modules, gems, loadpaths, etc) looking for that_type.rb That combined with a fact that code locations are not cached makes puppet slow when working with large repositories. I'm preparing 2 PRs related to this issue. Add Comment
Jira (PUP-3038) Typemanager wastes CPU cycles with global scope defined types
Title: Message Title Henrik Lindberg commented on an issue Re: Typemanager wastes CPU cycles with global scope defined types Have you tried this against Puppet's master branch? Add Comment Puppet / PUP-3038 Typemanager wastes CPU cycles with global scope defined types Defined type defined in a global scope will make MetaType::Manager go through all known code locations (modules, gems, loadpaths, etc) looking for that_type.rb That combined with a fact that code locations are not cached makes puppet slow when working with large repositories. I'm preparing 2 PRs related to this issue. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3038) Typemanager wastes CPU cycles with global scope defined types
Title: Message Title Maksym Melnychok commented on an issue Re: Typemanager wastes CPU cycles with global scope defined types no i haven't, i tested against 3.6.2. were there any related changes done to master? Add Comment Puppet / PUP-3038 Typemanager wastes CPU cycles with global scope defined types Defined type defined in a global scope will make MetaType::Manager go through all known code locations (modules, gems, loadpaths, etc) looking for that_type.rb That combined with a fact that code locations are not cached makes puppet slow when working with large repositories. I'm preparing 2 PRs related to this issue. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3038) Typemanager wastes CPU cycles with global scope defined types
Title: Message Title Maksym Melnychok commented on an issue Re: Typemanager wastes CPU cycles with global scope defined types relevant PRs: https://github.com/puppetlabs/puppet/pull/2951 https://github.com/puppetlabs/puppet/pull/2952 Add Comment Puppet / PUP-3038 Typemanager wastes CPU cycles with global scope defined types Defined type defined in a global scope will make MetaType::Manager go through all known code locations (modules, gems, loadpaths, etc) looking for that_type.rb That combined with a fact that code locations are not cached makes puppet slow when working with large repositories. I'm preparing 2 PRs related to this issue. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, vis
Jira (PDB-806) Transient aws-sdk bug causing a lot of transient acceptance failures
Title: Message Title Kenneth Barber updated an issue PuppetDB / PDB-806 Transient aws-sdk bug causing a lot of transient acceptance failures Change By: Kenneth Barber Sprint: 20140813 to 20140827 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-806) Transient aws-sdk bug causing a lot of transient acceptance failures
Title: Message Title Kenneth Barber created an issue PuppetDB / PDB-806 Transient aws-sdk bug causing a lot of transient acceptance failures Issue Type: Bug Assignee: Unassigned Created: 08/Aug/14 7:01 AM Priority: Normal Reporter: Kenneth Barber Most if not all of our tests now are throwing red indicators due to a failure in the aws-sdk driver for beaker. Here is an example: https://jenkins.puppetlabs.com/job/PuppetDB%20Acceptance%20-%20Pull%20Requests/582/ This is caused by the create_instance command seemingly not working, and the two solutions as discussed with Alice Nodelman are: a) Move the tagging and other operations behind the 'instance running' checks b) Add an additional poll after create_instance that checks if the instance just exists (doesn't have to be running, for tagging to occur) Either way, we believe this is generally caused by the fact that create_instance is not atomic, and that the new instance may not be immediately available from the API, so a poll of some kind to allow the Amazon side to propagate is a good general solution. That is, we believe the instance does get created, its just not ready on the API. This behaviour is alluded to a lot in the Amazon documentation here and there, and even though a client error such as a 4xx is not normally retried, I believe in this case we should. We should look to fix this at some point soon. Lots of red caused by this one.
Jira (PDB-806) Transient aws-sdk bug causing a lot of transient acceptance failures
Title: Message Title Kenneth Barber updated an issue PuppetDB / PDB-806 Transient aws-sdk bug causing a lot of transient acceptance failures Change By: Kenneth Barber Most if not all of our tests now are throwing red indicators due to a failure in the aws-sdk driver for beaker. Here is an example: https://jenkins.puppetlabs.com/job/PuppetDB%20Acceptance%20-%20Pull%20Requests/582/ This is caused by the create_instance command seemingly not working, and the two solutions as discussed with [~alice] are: a) Move the tagging and other operations behind the 'instance running' checks b) Add an additional poll using describe_instance after create_instance that checks if the instance just exists (doesn't have to be running, for tagging to occur) . If it doesn't exist, we keep polling within a timeout until it is, then continue. Either way, we believe this is generally caused by the fact that create_instance is not atomic, and that the new instance may not be immediately available from the API, so a poll of some kind to allow the Amazon side to propagate is a good general solution. That is, we believe the instance _does_ get created, its just not ready on the API. This behaviour is alluded to a lot in the Amazon documentation here and there, and even though a client error such as a 4xx is not normally retried, I believe in this case we should. We should look to fix this at some point soon. Lots of red caused by this one. Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email
Jira (PUP-3034) future parser iteration does not work on OS X Yosemite / ruby 2.0.0p481
Title: Message Title Henrik Lindberg commented on an issue Re: future parser iteration does not work on OS X Yosemite / ruby 2.0.0p481 The example should obviously work. We had similar issues for a while on 3.7 which makes me suspect that the bits running are actually 3.6.2 or some random point on 3.7 (e.g. puppet --version when running from source on master reports 3.6.2). Do you have --evaluator current in settings by any chance? The really odd thing is that the each function does this: {code] pblock = args[1] raise ArgumentError, ("each(): wrong argument type (# {args[1].class}; must be a parameterized block.") unless pblock.respond_to?(:puppet_lambda) And the reported class {{Puppet::Pops::Evaluator::Closure}} has this method: def puppet_lambda() true end Can you run with --trace to see in more detail where the error message is coming from? (I think it is the check in the puppet/parser/functions/each.rb on the line showed above, but that could be wrong). I looked at code for both {{stable}} and the 3.6.2 tag, and they both look the same. A quick check, would be to run this in irb: require 'puppet' require 'puppet/pops' Puppet::Pops::Evaluator::Closure.instance_methods.include?(:puppet_lambda) It is worth trying patching each.rb to this: unless pblock.respond_to?(:puppet_lambda) raise ArgumentError, ("each(): wrong argument type (#{args[1].class} ; must be a parameterized block.") end To see if that makes a difference. Add Comment
Jira (PDB-743) Report retrieval JSON::ParserError due to random database disconnection
Title: Message Title Kenneth Barber commented on an issue Re: Report retrieval JSON::ParserError due to random database disconnection Merged in by Kylo Ginsberg: https://github.com/puppetlabs/pe-puppet/commit/c7a8a9184af4ec1571d4336dc4764dde1d6c7c99 Add Comment PuppetDB / PDB-743 Report retrieval JSON::ParserError due to random database disconnection We've seen this failure a number of times. Digging into the puppetdb log, I can see that PuppetDB drops a connection for an unknown reason. A couple of recent examples: * http://jenkins-enterprise.delivery.puppetlabs.net/view/PE%20Platform/view/Puppet/job/PE%20Puppet%20Acceptance%20Tests/111/label=modgud.delivery.puppetlabs.net,layout=64mcd-64a,platfo... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.
Jira (PDB-806) Transient aws-sdk bug causing a lot of transient acceptance failures
Title: Message Title Kenneth Barber updated an issue PuppetDB / PDB-806 Transient aws-sdk bug causing a lot of transient acceptance failures Change By: Kenneth Barber Sprint: 20140813 to 20140827 to 20140910 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-707) The first request to PuppetDB after DB backend restart fails
Title: Message Title Kenneth Barber updated an issue PuppetDB / PDB-707 The first request to PuppetDB after DB backend restart fails Change By: Kenneth Barber Sprint: 20140813 to 20140827 to 20140910 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-716) HTTP API gets stuck
Title: Message Title Kenneth Barber updated an issue PuppetDB / PDB-716 HTTP API gets stuck Change By: Kenneth Barber Sprint: 20140813 to 20140827 to 20140910 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-807) Structured Facts: Add double glob support for the *> operator
Title: Message Title Kenneth Barber created an issue PuppetDB / PDB-807 Structured Facts: Add double glob support for the *> operator Issue Type: New Feature Assignee: Unassigned Created: 08/Aug/14 8:10 AM Priority: Normal Reporter: Kenneth Barber The current globbing operator for the path field for fact-nodes only supports a single element glob with a '*' but if you want to match multiple entries, you can't use this syntax. This feature adds the double glob '**' which removes the single element constraint, and allows you to descend beyond 1 level of depth in a query. For example the query: ["*>","path",["networking","**"]] Would match all elements under networking. This should just be a change to the replacement code, that replaces the single glob '*' with a bounded regex. If we take the same regexp but remove the negative lookahead for the delimiter, we should find our solution. Add Comment
Jira (PDB-808) Factsets endpoint has an issue with ordering with new schema, much like facts
Title: Message Title Kenneth Barber created an issue PuppetDB / PDB-808 Factsets endpoint has an issue with ordering with new schema, much like facts Issue Type: Bug Assignee: Unassigned Created: 08/Aug/14 8:12 AM Fix Versions: 2.2.0 Priority: Normal Reporter: Kenneth Barber The fact sets endpoint has issues with pagination and possibly with ordering as well. This needs to be investigated and fixed, using similar techniques we've done for /facts. Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha
Jira (PDB-808) Factsets endpoint has an issue with ordering with new schema, much like facts
Title: Message Title Kenneth Barber updated an issue PuppetDB / PDB-808 Factsets endpoint has an issue with ordering with new schema, much like facts Change By: Kenneth Barber Sprint: 20140730 to 20140813 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-809) Switch to using a cache for /facts endpoint
Title: Message Title Kenneth Barber created an issue PuppetDB / PDB-809 Switch to using a cache for /facts endpoint Issue Type: Task Assignee: Unassigned Created: 08/Aug/14 8:16 AM Fix Versions: 2.2.0 Priority: Normal Reporter: Kenneth Barber The queries for the /facts endpoint are very complex due to its multi-row nature. While we've found workarounds for a lot of this, we should investigate the value in converting this to using a cache instead. For performance and storage reduction we should implement the same deduplication and differential techniques, like what we have done for fact_values and fact_paths. There is an argument that the cache could just be treated like another node here, and also stored in the fact_paths & fact_values combination thus avoiding some more complex coding. However, there is a counter argument that making the fact_values table larger with large text blobs is also a bad idea, and that a new table should be said aside to do this. Add Comment
Jira (PDB-809) Switch to using a cache for /facts endpoint
Title: Message Title Kenneth Barber updated an issue PuppetDB / PDB-809 Switch to using a cache for /facts endpoint Change By: Kenneth Barber Sprint: 20140813 to 20140827 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-810) Analyze new structured fact schema and indexing under load
Title: Message Title Kenneth Barber updated an issue PuppetDB / PDB-810 Analyze new structured fact schema and indexing under load Change By: Kenneth Barber Sprint: 20140813 to 20140827 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-810) Analyze new structured fact schema and indexing under load
Title: Message Title Kenneth Barber created an issue PuppetDB / PDB-810 Analyze new structured fact schema and indexing under load Issue Type: Task Assignee: Unassigned Created: 08/Aug/14 8:21 AM Fix Versions: 2.2.0 Priority: Normal Reporter: Kenneth Barber The new structured fact schema introduces a number of changes that may turn out to be sub-optimal for querying. We need to analyze the performance of querying with this new structure, in particular ensuring the index choices are suitable and analyze what schema schema changes should be done now or later if they come up. The output of this task would be a comparison of a series of generic queries comparing old code to new code for performance dips - in particular the /facts endpoint, and any work required to fix that. If the work is simple enough, like a few index changes this can be done as part of this ticket. Also we should be analyzing the performance of the new query capabilities, and ensuring in particular that the proper indexes are applied - in particular the trgm indexes for path, and the btee indexes for the value_* columns.
Jira (PDB-811) Structured Facts: Improve performance of non-equality matches for integers and real numbers for /fact-nodes
Title: Message Title Kenneth Barber created an issue PuppetDB / PDB-811 Structured Facts: Improve performance of non-equality matches for integers and real numbers for /fact-nodes Issue Type: Task Assignee: Unassigned Created: 08/Aug/14 8:24 AM Priority: Normal Reporter: Kenneth Barber The current methodology for doing non-equality matching for reals and integers for /fact-nodes is suboptimal. It uses a coalesce, to force the comparison to a double which is not great. We should instead construct an or, and avoid the coalesce, but I'm not sure what is faster. This ticket tracks the work required to compare the two solutions for performance and correctness ... and then to do the rewrite rule in the query engine to achieve this properly. Add Comment T
Jira (PDB-812) Collapse the produce-body construct from all the HTTP endpoints
Title: Message Title Kenneth Barber created an issue PuppetDB / PDB-812 Collapse the produce-body construct from all the HTTP endpoints Issue Type: Task Assignee: Unassigned Created: 08/Aug/14 8:28 AM Priority: Normal Reporter: Kenneth Barber If you look at all the http endpoint code in http/*.clj, there is a general usage of the produce-body and other functions around it. We should find a pattern and collapse this function into a share one somewhere, and find any other immediate places for cleanup once this is done. For example, the routes code shares a lot of commonality, however does have some uniqueness per endpoint. Perhaps this routing information if reduced enough into shared functions could be moved back into v4.clj instead of living across many files. Add Comment This message was se
Jira (PUP-2994) puppet parser validate shouldn't puke on exported resources
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-2994 puppet parser validate shouldn't puke on exported resources Change By: Henrik Lindberg Labels: future-parser Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-806) Transient aws-sdk bug causing a lot of transient acceptance failures
Title: Message Title Alice Nodelman commented on an issue Re: Transient aws-sdk bug causing a lot of transient acceptance failures My solution is in this PR: https://github.com/puppetlabs/beaker/pull/392 Should be merged today and then available in the next gem. Add Comment PuppetDB / PDB-806 Transient aws-sdk bug causing a lot of transient acceptance failures Most if not all of our tests now are throwing red indicators due to a failure in the aws-sdk driver for beaker. Here is an example: https://jenkins.puppetlabs.com/job/PuppetDB%20Acceptance%20-%20Pull%20Requests/582/ This is caused by the create_instance command seemingly not working, and the two solutions as discussed with [~alice] are: a) Move the tag... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this
Jira (PDB-798) Regexp querying support against path for /facts-node
Title: Message Title Kenneth Barber updated an issue PuppetDB / PDB-798 Regexp querying support against path for /facts-node Change By: Kenneth Barber Sprint: 20140813 20140730 to 20140827 20140813 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-283) native, deep, or deeper merge not working as expected
Title: Message Title Chris Denneen created an issue Hiera / HI-283 native, deep, or deeper merge not working as expected Issue Type: Bug Affects Versions: 1.3.4 Assignee: Adrien Thebo Components: Community Created: 08/Aug/14 9:15 AM Priority: Normal Reporter: Chris Denneen I have uploaded a complete test using vagrant for someone to test. https://github.com/cdenneen/hiera_test Currently hiera output regardless of merge_behavior is showing as "deep" Currently puppet erb with hiera is showing as "native" regardless of merge_behavior setting Add Comment
Jira (HI-283) native, deep, or deeper merge not working as expected
Title: Message Title Adrien Thebo commented on an issue Re: native, deep, or deeper merge not working as expected You're not seeing the data merged in because the node/%{::fqdn} variable isn't being set. If we do a normal priority lookup and the lookup was working, we should see the node specific value but we don't: [vagrant@centos65 ~]$ hiera -c /vagrant/puppet/hiera.yaml mymodule::options {"param1"=>"param1", "param2"=>"param2", "param3"=>"param3", "param4"=>"param4", "nested"=> {"param1"=>"nested_param1", "param2"=>"nested_param2", "param3"=>"nested_param3", "param4"=>"nested_param4"}} This is because the ::fqdn variable isn't set. If we specify that on the command line as part of the scope we get the correct priority lookup: [vagrant@centos65 ~]$ hiera -c /vagrant/puppet/hiera.yaml mymodule::options ::fqdn=centos65.vm.local {"nested"=>{"param4"=>"new_nested_param4"}} And if we do that lookup with the scope and use a hash lookup, we see the deep merge occurring: {"nested"=> {"param1"=>"nested_param1", "param2"=>"nested_param2", "param3"=>"nested_param3", "param4"=>"new_nested_param4"}, "param1"=>"param1", "param2"=>"param2", "param3"=>"param3", "param4"=>"param4"} When running hiera on the commandline, there is no scope set up by default. Since you're using a fully qualified variable name we can't directly dump the output of Facter and use it as the scope, but if you change ::fqdn to fqdn then you can use Facter as the scope input: --- :backends: - yaml :hierarchy: - nodes/%{fqdn} # Note the omitted double colon - common :yaml: :datadir: /vagrant/puppet/hieradata :merge_behavior: deeper [vagrant@centos65 ~]$ facter -y > scope.yaml [vagrant@centos65 ~]$ hiera --hash -c /vagrant/puppet/hiera.yaml --yaml scope.yaml mymodule::options {"nested"=> {"param1"=>"nested_param1", "param2"=>"nested_param2", "param3"=>"nested_param3", "param4"=>"new_nested_param4"}, "param1"=>"param1", "param2"=>"param2", "param3"=>"param3", "param4"=>"param4"}
Jira (HI-283) native, deep, or deeper merge not working as expected
Title: Message Title Adrien Thebo updated an issue Hiera / HI-283 native, deep, or deeper merge not working as expected Change By: Adrien Thebo Assignee: Adrien Thebo Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-283) native, deep, or deeper merge not working as expected
Title: Message Title Adrien Thebo updated an issue Hiera / HI-283 native, deep, or deeper merge not working as expected Change By: Adrien Thebo Component/s: Community Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-744) Pool HTTPS connections
Title: Message Title Josh Cooper assigned an issue to Josh Cooper Puppet / PUP-744 Pool HTTPS connections Change By: Josh Cooper Assignee: Josh Cooper Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-283) native, deep, or deeper merge not working as expected
Title: Message Title Chris Denneen commented on an issue Re: native, deep, or deeper merge not working as expected Ok yeah I forgot to put the ::fqdn=centos65.vm.local on the command which now works: hiera --hash -c /vagrant/puppet/hiera.yaml mymodule::options ::fqdn=centos65.vm.local {"nested"=> {"param1"=>"nested_param1", "param2"=>"nested_param2", "param3"=>"nested_param3", "param4"=>"new_nested_param4"} , "param1"=>"param1", "param2"=>"param2", "param3"=>"param3", "param4"=>"param4"} So the issue isn't with hiera it is with Puppet. Based on this info (and leaving ::fqdn in hiera.yaml) my /tmp/mymodule.conf should have the values shown here above populated but only populates the nested:param4 from the node yaml. Am I doing something wrong to get this to work with Puppet? Add Comment Hiera / HI-283 native, deep, or deeper merge not working as expected I have uploaded a complete test using vagrant for someone to test. https://github.com/cdenneen/hiera_test Currently hiera output regardless of merge_behavior is showing as "deep" Currently puppet erb with hiera is showing as "native" regardless of merge_behavior setting This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PDB-743) Report retrieval JSON::ParserError due to random database disconnection
Title: Message Title Kenneth Barber commented on an issue Re: Report retrieval JSON::ParserError due to random database disconnection I'm marking this resolved for now, looks like some testing hassles that are unrelated are blocking tests for 3.4.x. I guess if it comes back re-open this. Add Comment PuppetDB / PDB-743 Report retrieval JSON::ParserError due to random database disconnection We've seen this failure a number of times. Digging into the puppetdb log, I can see that PuppetDB drops a connection for an unknown reason. A couple of recent examples: * http://jenkins-enterprise.delivery.puppetlabs.net/view/PE%20Platform/view/Puppet/job/PE%20Puppet%20Acceptance%20Tests/111/label=modgud.delivery.puppetlabs.net,layout=64mcd-64a,platfo... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For mor
Jira (PUP-2879) `puppet resource service` not working for `cryptdisks-udev`
Title: Message Title Kylo Ginsberg commented on an issue Re: `puppet resource service` not working for `cryptdisks-udev` Yep I can repro this on trusty by: apt-get install -y cryptsetup puppet resource service And as the snippet suggests the problem is that the underlying command fails: # /sbin/status cryptdisks-udev status: Unknown parameter: DEVNAME Add Comment Puppet / PUP-2879 `puppet resource service` not working for `cryptdisks-udev` Issuing _puppet resource service cryptdisks-udev_ outputs bq. Error: Could not run: Execution of '/sbin/status cryptdisks-udev' returned 1: status: Unknown parameter: DEVNAME Since puppet stops there _puppet resource service_ won't work as well. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-2924) Puppet searches disk for whit classes
Title: Message Title Eric Thompson updated an issue Puppet / PUP-2924 Puppet searches disk for whit classes Change By: Eric Thompson Assignee: Eric Thompson Charlie Sharpsteen Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (HI-283) native, deep, or deeper merge not working as expected
Title: Message Title Adrien Thebo commented on an issue Re: native, deep, or deeper merge not working as expected When you use data binding for variable lookups, Puppet can only use the priority lookup type. If you want to use the hash lookup, you have to directly invoke hiera_hash: diff --git a/puppet/modules/mymodule/manifests/init.pp b/puppet/modules/mymodule/manifests/init.pp index f96be37..76dae0d 100644 --- a/puppet/modules/mymodule/manifests/init.pp +++ b/puppet/modules/mymodule/manifests/init.pp @@ -2,10 +2,9 @@ class mymodule ( $template = undef, - $options = undef, #$options = hiera('$options', undef), - #$options = hiera_hash('$options', undef), ){ + $options = hiera_hash('mymodule::options', undef) file { "mymodule_config": path=> '/tmp/mymodule.conf', [vagrant@centos65 vagrant]$ sudo puppet apply --modulepath puppet/modules --hiera_config puppet/hiera.yaml --fileserverconfig fileserver.conf -e 'include mymodule' --verbose Notice: Compiled catalog for centos65.vm.local in environment production in 0.10 seconds Info: Applying configuration version '1407519056' Info: /Stage[main]/Mymodule/File[mymodule_config]: Filebucketed /tmp/mymodule.conf to puppet with sum 256bb409e0cadfb4b7cfe9278643d3b6 Notice: /Stage[main]/Mymodule/File[mymodule_config]/content: content changed '{md5}256bb409e0cadfb4b7cfe9278643d3b6' to '{md5}b32b087e53c6c86b52f0a1fefef1c442' Notice: Finished catalog run in 0.04 seconds [vagrant@centos65 vagrant]$ cat /tmp/mymodule.conf # This file is managed by Puppet. DO NOT EDIT. These are my options: param1 = param1 param2 = param2 param3 = param3 param4 = param4 nested = param1 = nested_param1 param2 = nested_param2 param3 = nested_param3 param4 = new_nested_param4 Add Comment Hiera / HI-283 native, deep, or deeper merge not working as expected
Jira (HI-283) native, deep, or deeper merge not working as expected
Title: Message Title Chris Denneen commented on an issue Re: native, deep, or deeper merge not working as expected Nevermind... found it: https://docs.puppetlabs.com/hiera/1/puppet.html#limitations If you need to merge arrays or merge hashes from multiple hierarchy levels, you will have to use the hiera_array or hiera_hash functions in the body of your classes. Thanks for the help explaining this... documentation is great but sometimes very hard to find exactly what you are looking for like this. Add Comment Hiera / HI-283 native, deep, or deeper merge not working as expected I have uploaded a complete test using vagrant for someone to test. https://github.com/cdenneen/hiera_test Currently hiera output regardless of merge_behavior is showing as "deep" Currently puppet erb with hiera is showing as "native" regardless of merge_behavior setting This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message
Jira (HI-283) native, deep, or deeper merge not working as expected
Title: Message Title Chris Denneen commented on an issue Re: native, deep, or deeper merge not working as expected Oddly you can use parameterized class hiera_hash just as long as you reset it in the body (so strange): # = Class: mymodule class mymodule ( $template = undef, $my_options = hiera_hash('mymodule::options', undef) ){ $options = $my_options file { "mymodule_config": path=> '/tmp/mymodule.conf', content => template($template), } } Add Comment Hiera / HI-283 native, deep, or deeper merge not working as expected I have uploaded a complete test using vagrant for someone to test. https://github.com/cdenneen/hiera_test Currently hiera output regardless of merge_behavior is showing as "deep" Currently puppet erb with hiera is showing as "native" regardless of merge_behavior setting This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are
Jira (HI-283) native, deep, or deeper merge not working as expected
Title: Message Title Chris Denneen commented on an issue Re: native, deep, or deeper merge not working as expected Thanks I guess I'm not understanding why this wouldn't work with parameterized class so doesn't work: class mymodule ( $template = undef, $options= hiera_hash($options, undef), ){} doesn't work: class mymodule ( $template = undef, $options= hiera_hash('mymodule::options', undef), ){} works: class mymodule ( $template = undef, ){ $options= hiera_hash('mymodule::options', undef) } Add Comment Hiera / HI-283 native, deep, or deeper merge not working as expected I have uploaded a complete test using vagrant for someone to test. https://github.com/cdenneen/hiera_test Currently hiera output regardless of merge_behavior is showing as "deep" Currently puppet erb with hiera is showing as "native" regardless of merge_behavior setting
Jira (PDB-805) PR (1034): (maint) Upgrade trapperkeeper and kitchensink libraries to latest - kbarber
Title: Message Title gepetto-bot commented on an issue Re: PR (1034): (maint) Upgrade trapperkeeper and kitchensink libraries to latest - kbarber pljenkinsro commented: :red_circle: Test failed. Refer to this link for build results: https://jenkins.puppetlabs.com/job/PuppetDB%20Acceptance%20-%20Pull%20Requests/586/ Add Comment PuppetDB / PDB-805 PR (1034): (maint) Upgrade trapperkeeper and kitchensink libraries to latest - kbarber h2. (maint) Upgrade trapperkeeper and kitchensink libraries to latest * Author: Ken Barber* Company: Puppet Labs Inc. * Github ID: [kbarber|https://github.com/kbarber] * [Pull Request 1034 Discussion|https://github.com/puppetlabs/puppetdb/pull/1034] * [Pull Request 1034 File Diff|https://github.com/puppetlabs/puppetdb/pull/1034/files] ... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@
Jira (PUP-3040) Change init/upstart instance-based services from blacklist to whitelist
Title: Message Title Kylo Ginsberg created an issue Puppet / PUP-3040 Change init/upstart instance-based services from blacklist to whitelist Issue Type: Improvement Assignee: Unassigned Created: 08/Aug/14 11:46 AM Priority: Normal Reporter: Kylo Ginsberg Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3040) Change init/upstart instance-based services from blacklist to whitelist
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-3040 Change init/upstart instance-based services from blacklist to whitelist Change By: Kylo Ginsberg Fix Version/s: 4.0.0 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-805) PR (1034): (maint) Upgrade trapperkeeper and kitchensink libraries to latest - kbarber
Title: Message Title gepetto-bot commented on an issue Re: PR (1034): (maint) Upgrade trapperkeeper and kitchensink libraries to latest - kbarber kbarber commented: This patch is dependant on certificate-whitelist support as outlined in TK-46. Add Comment PuppetDB / PDB-805 PR (1034): (maint) Upgrade trapperkeeper and kitchensink libraries to latest - kbarber h2. (maint) Upgrade trapperkeeper and kitchensink libraries to latest * Author: Ken Barber* Company: Puppet Labs Inc. * Github ID: [kbarber|https://github.com/kbarber] * [Pull Request 1034 Discussion|https://github.com/puppetlabs/puppetdb/pull/1034] * [Pull Request 1034 File Diff|https://github.com/puppetlabs/puppetdb/pull/1034/files] ... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/pupp
Jira (PUP-3040) Change init/upstart instance-based services from blacklist to whitelist
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-3040 Change init/upstart instance-based services from blacklist to whitelist Change By: Kylo Ginsberg Story Points: 3 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2879) `puppet resource service` not working for `cryptdisks-udev`
Title: Message Title Kylo Ginsberg commented on an issue Re: `puppet resource service` not working for `cryptdisks-udev` Okay summarizing some meatspace conversations: This isn't specific to `cryptdisks` per se, but is generic to services that use the `instance` variable, as described here: http://upstart.ubuntu.com/cookbook/#instance Currently we're blacklisting such services: https://github.com/puppetlabs/puppet/blob/3.6.2/lib/puppet/provider/service/init.rb#L46-L52 https://github.com/puppetlabs/puppet/blob/3.6.2/lib/puppet/provider/service/upstart.rb#L37-L41 So tactically here we can add cryptdisks to a blacklist (and let's use this ticket for that activity). But the more medium term solution would be to detect services that use `instance` and whitelist those we support. I've created PUP-3040 for that. Add Comment Puppet / PUP-2879 `puppet resource service` not working for `cryptdisks-udev` Issuing _puppet resource service cryptdisks-udev_ outputs bq. Error: Could not run: Execution of '/sbin/status cryptdisks-udev' returned 1: status: Unknown parameter: DEVNAME Since puppet stops there _puppet resource service_ won't work as well. This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-2879) `puppet resource service` not working for `cryptdisks-udev`
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2879 `puppet resource service` not working for `cryptdisks-udev` Change By: Kylo Ginsberg Fix Version/s: 3.7.0 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3040) Change init/upstart instance-based services from blacklist to whitelist
Title: Message Title Kylo Ginsberg commented on an issue Re: Change init/upstart instance-based services from blacklist to whitelist Targeting this for 4.0. Would be nice for 3.7 but that seems unlikely at this point. Add Comment Puppet / PUP-3040 Change init/upstart instance-based services from blacklist to whitelist This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2924) Puppet searches disk for whit classes
Title: Message Title Charlie Sharpsteen commented on an issue Re: Puppet searches disk for whit classes What happened here is that PR 2492 added a call to resource_type directly to Puppet::Resource#initialize. So, my patch moved us one step forward and that PR moved us one step back. To completely fix this problem, we'll need to go all the way and re-factor Resource.new . Add Comment Puppet / PUP-2924 Puppet searches disk for whit classes Our Puppet instance has been pretty slow lately so we traced a puppet agent run to see what it was doing. In the trace we see a bunch of lines like this: stat("/opt/local/lib/ruby/site_ruby/2.0.0/puppet/vendor/semantic/lib/puppet/type/completed_stage.rb", 0xFD7FFFDFE4A0) Err#2 ENOENT stat("/etc/puppet/modules/admin/lib/puppet/type/completed_stage This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet
Jira (PUP-2987) Puppet service hangs when attempting to stop on Windows
Title: Message Title Michael Smith assigned an issue to Ethan Brown Puppet / PUP-2987 Puppet service hangs when attempting to stop on Windows Change By: Michael Smith Assignee: Ethan Brown Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2879) `puppet resource service` not working for `cryptdisks-udev`
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2879 `puppet resource service` not working for `cryptdisks-udev` Change By: Kylo Ginsberg Sprint: 2014-08-20 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2879) `puppet resource service` not working for `cryptdisks-udev`
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2879 `puppet resource service` not working for `cryptdisks-udev` Change By: Kylo Ginsberg Story Points: 1 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2972) Implementation of +=/-= is potentially confusing
Title: Message Title Andy Parker commented on an issue Re: Implementation of +=/-= is potentially confusing The behavior of += in the current parser are documented at https://docs.puppetlabs.com/puppet/3.6/reference/lang_variables.html#appending-assignment The current implementation actually also handles numeric values as well, but it takes some coercion to get it to happen. Numeric + from += $a = (1+0) node default { $a += (2+0) notice($a) } The behavior of += in the future parser differs mainly in that it does not ever produce string concatenation. It is actually just a synonym for $a = $a + $b. I searched through a number of puppet modules and out of the 4097 module releases (multiple versions of various modules) there are only 3 cases of += being used: hastexo-kickstack-0.1.0 thartmann-pam_access-1.0.0 (2 uses in this one) All of these uses are to concatenate arrays of strings. I think this means that it is safe to remove the string concatenation support, which allows += to be a synonym for $a = $a + $b. On the question of whether we should drop these, I don't think we should. They are in light use, and were previously the only way in puppet to concatenate arrays or merge hashes, which is no longer the case. However, they can serve as a useful shortcut that doesn't lead to the confusion that Henrik pointed out about when the variable appears in the current scope and shadows the outer scope. Once += is in the language, then it makes sense to also support -= by analogy. Add Comment Puppet / PUP-2972
Jira (PUP-2526) puppet agent retry failed http requests
Title: Message Title Felix Frank commented on an issue Re: puppet agent retry failed http requests Look, I didn't join this discussion to argue semantics or raise this issue on some pedestal of IT Best Practices. Experience mandates certain requirements in the software I use, and I hold at least that standard to the projects I devote my time to. I will not stand for a change in Puppet that may have a negative impact on the user experience. Snide attacks on my argument aside, is there anything disadvantageous about setting this on an opt-in basis? Add Comment Puppet / PUP-2526 puppet agent retry failed http requests It would be nice if puppet agent had the ability had the ability to retry failed http requests to the puppet master. I have multiple puppet masters sitting behind a load balancer in AWS (ELB). Whenever we update a puppet master, the node is removed from the load balancer while the update occurs. Unfortunately the AWS ELB does not allow quiescent remova... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you a
Jira (PUP-1280) windows agents don't parse runinterval as a duration setting
Title: Message Title Nicholas Fagerlund commented on an issue Re: windows agents don't parse runinterval as a duration setting This is weird to me, because puppet agent --configprint runinterval will actually convert any duration to seconds. So it shouldn't matter what you set the runinterval as in the config file; the daemon.rb script will get seconds anyway. Also, with Puppet 3.6.2 (Puppet Enterprise 3.3), I can't get it to respect a runinterval from puppet.conf even if it IS in seconds, and regardless what config section it's in. I know that puppet agent is using the correct config file, because I was able to set the certname. Add Comment Puppet / PUP-1280 windows agents don't parse runinterval as a duration setting When running as a service, puppet on windows runs `puppet agent --configprint runinterval` and assumes the result is in seconds. It then runs `puppet agent --onetime` every runinterval seconds. In 3.0.0, runinterval was changed to a `duration` setting, so it can be of the form 5m, 2h, etc
Jira (PUP-1280) windows agents don't parse runinterval as a duration setting
Title: Message Title Nicholas Fagerlund commented on an issue Re: windows agents don't parse runinterval as a duration setting I suspect the daemon.rb script is not running Puppet correctly. The vardir/log/windows.log file shows many instances of the Failed to determine runinterval, defaulting to 1800 seconds error, which is what the script logs when ().to_i returns 0. If it were correctly getting my runinterval (set in seconds), it would be getting 120. If it were correctly getting the default runinterval, it should be going to 1800 based on Puppet's own defaults. So clearly the --configprint command is returning something that converts to 0. Add Comment Puppet / PUP-1280 windows agents don't parse runinterval as a duration setting When running as a service, puppet on windows runs `puppet agent --configprint runinterval` and assumes the result is in seconds. It then runs `puppet agent --onetime` every runinterval seconds. In 3.0.0, runinterval was changed to a `duration` setting, so it can be of the form 5m, 2h, etc
Jira (PUP-2972) Implementation of +=/-= is potentially confusing
Title: Message Title Andy Parker commented on an issue Re: Implementation of +=/-= is potentially confusing I've done some more trawling around on Github. The most common use appears to be for concatenating arrays. However, there are several cases where string concatenation is done, which the new semantics of += don't support. Those can however be reworked to use string interpolation to achieve the same goal ($a = "$a$b"). There were also one or two uses that came at me out of left field. It turns out that the current system will allow += with qualified variable named. That has completely strange behavior: += with qualified vars class testing { $a = [1] } include testing $testing::a += [2] notice(inline_template('<%= @testing__a %>')) notice($testing::a) notice($a) produces: Notice: Scope(Class[main]): ["1", "2"] Notice: Scope(Class[main]): 1 Notice: Scope(Class[main]): Notice: Compiled catalog for aparker.corp.puppetlabs.net in environment production in 0.02 seconds Notice: Finished catalog run in 0.07 seconds Add Comment Puppet / PUP-2972 Implementation of +=/-= is potentially confusing It seems to me that += and -= are more confusing than useful, and I would argue that they simply shouldn't exist. Right now (with "--parser future"), these operators implicitly create a new variable
Jira (PUP-1280) windows agents don't parse runinterval as a duration setting
Title: Message Title Nicholas Fagerlund commented on an issue Re: windows agents don't parse runinterval as a duration setting I just experimented a bunch, and the %x{ command } ...syntax appears to simply not work at all on Windows for any purpose whatsoever. At least in this script. I added some debug lines to daemon.rb: # runinterval_source = %x{ "#{puppet}" agent --configprint runinterval } runinterval_source = %x{ echo "hi" } log_err("detected runinterval is #{runinterval_source}") runinterval = runinterval_source.to_i It always logs "detected runinterval is " with no value, no matter what I put in the %x brackets. The execute statement must be returning nil. That's why changing the runinterval has no effect. What would be another way to execute commands and get their output? And why is %x not working like normal, here? Add Comment Puppet / PUP-1280 windows agents don't parse runinterval as a duration setting When running as a service, puppet on windows runs `puppet agent --configprint runinterval` and assumes the result is in seconds. It then runs `puppet agent --onetime` every runinterval seconds. In 3.0.0, runinterval was changed to a `duration` setting, so it can be of the form 5m, 2h, etc
Jira (PUP-489) Handle += / -= with consistent semantics
Title: Message Title Andy Parker commented on an issue Re: Handle += / -= with consistent semantics As a note: without += for strings, the way to concatenate strings is to use string interpolation. String concatenation $a = "hi" node default { $a = "${a}ghly" notice($a) } Add Comment Puppet / PUP-489 Handle += / -= with consistent semantics The current 4x implementation does this: * if referenced and given are numeric, do arithmetic + or - * if referenced and given are collections, do concat/merge * else fail (no string concatenation) Decide: * is this implementation ok * should string concatenation be allowed (+ is not string concat elsewhere) * Remove in favor of explicit $a = $... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received
Jira (PUP-1280) windows agents don't parse runinterval as a duration setting
Title: Message Title Nicholas Fagerlund commented on an issue Re: windows agents don't parse runinterval as a duration setting OH, but: it appears that whatever's in the %x IS actually executing, we're just not getting the results. If I change it to something completely un-runnable, it will complain in the log. Add Comment Puppet / PUP-1280 windows agents don't parse runinterval as a duration setting When running as a service, puppet on windows runs `puppet agent --configprint runinterval` and assumes the result is in seconds. It then runs `puppet agent --onetime` every runinterval seconds. In 3.0.0, runinterval was changed to a `duration` setting, so it can be of the form 5m, 2h, etc
Jira (PUP-1280) windows agents don't parse runinterval as a duration setting
Title: Message Title Nicholas Fagerlund commented on an issue Re: windows agents don't parse runinterval as a duration setting BTW, this is all on win 2008r2. Add Comment Puppet / PUP-1280 windows agents don't parse runinterval as a duration setting When running as a service, puppet on windows runs `puppet agent --configprint runinterval` and assumes the result is in seconds. It then runs `puppet agent --onetime` every runinterval seconds. In 3.0.0, runinterval was changed to a `duration` setting, so it can be of the form 5m, 2h, etc
Jira (PUP-2972) Implementation of +=/-= is potentially confusing
Title: Message Title Henrik Lindberg commented on an issue Re: Implementation of +=/-= is potentially confusing line 6 creates a variable "testing::a" in current scope (should not be allowed because you cannot do $testing::a = [1 2]) line 8 notices the local variable testing::a line 0 notices the correctly scoped variable, since it does a different lookup of the variable name no $a was ever created in this process So the problem is that += is very poorly implemented in that it simply assigns to the variable name. It does not actually alter the referenced variable in the referenced scope. Add Comment Puppet / PUP-2972 Implementation of +=/-= is potentially confusing It seems to me that += and -= are more confusing than useful, and I would argue that they simply shouldn't exist. Right now (with "--parser future"), these operators implicitly create a new variable that may shadow one from an outer scope, appending/removing the RHS to the outer scope variable if it exists. If the variable has already been defined in t...
Jira (PUP-3037) Pluginsync notices on Windows reports file paths with forward slashes
Title: Message Title Kylo Ginsberg commented on an issue Re: Pluginsync notices on Windows reports file paths with forward slashes Hmm that seems like it would be a nice improvement. Not sure if there are entanglements though. Rob Reynolds thoughts? Add Comment Puppet / PUP-3037 Pluginsync notices on Windows reports file paths with forward slashes Pluginsync/loading facts notices on Windows output file paths with forward slashes: {quote} Notice: /File[C:/ProgramData/PuppetLabs/puppet/var/lib/puppet/provider/rabbitmq_ vhost]/ensure: removed Info: Loading facts in C:/ProgramData/PuppetLabs/puppet/var/lib/facter/concat_basedir.rb {quote} This is clearly a lie. When I copy those paths and try t... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/