Jira (PUP-5770) [std-lib] validate_absolute_path does not detect malicious code injection

2016-01-29 Thread tony gaetani (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 tony gaetani created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5770 
 
 
 
  [std-lib] validate_absolute_path does not detect malicious code injection  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Affects Versions:
 

 PUP 3.8.5 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Components:
 

 Modules 
 
 
 

Created:
 

 2016/01/29 5:43 AM 
 
 
 

Environment:
 
 
ubuntu 12.04 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 tony gaetani 
 
 
 
 
 
 
 
 
 
 
It appears that validate_absolute_path is not working properly in some situations. For example: 
{{ $testpath = '/usr/bin/;rm -rf /;' validate_absolute_path($testpath) exec { "mkdir $ {testpath}": returns => 0, user => 'root', ; }}}  The path validated (incorrectly)  Another example:  {{ $testpath = '/*&^ foo\bar#baz /usr/bin/;rm -rf /;' validate_absolute_path($testpath) exec { "mkdir ${testpath} 
": returns => 0, user => 'root', ; }}} 
 
 
 
 
 

Jira (PUP-5770) [std-lib] validate_absolute_path does not detect malicious code injection

2016-01-29 Thread tony gaetani (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 tony gaetani updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5770 
 
 
 
  [std-lib] validate_absolute_path does not detect malicious code injection  
 
 
 
 
 
 
 
 
 

Change By:
 
 tony gaetani 
 
 
 
 
 
 
 
 
 
 It appears that validate_absolute_path is not working properly in some situations. For example: {{   $testpath = '/usr/bin/;rm -rf /;'  validate_absolute_path($testpath)  exec {"mkdir ${testpath}":  returns => 0,  user => 'root',;  } }} The path validated (incorrectly)Another example: {{   $testpath = '/*&^ foo\bar#baz /usr/bin/;rm -rf /;'  validate_absolute_path($testpath)  exec {"mkdir ${testpath}":  returns => 0,  user => 'root',;  } }}  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5648) Add Iterable type and runtime object

2016-01-29 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren assigned an issue to Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5648 
 
 
 
  Add Iterable type and runtime object  
 
 
 
 
 
 
 
 
 

Change By:
 
 Thomas Hallgren 
 
 
 

Assignee:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5769) Windows MSI overriding server with default value of "puppet"

2016-01-29 Thread Ethan Brown (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Ethan Brown updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5769 
 
 
 
  Windows MSI overriding server with default value of "puppet"  
 
 
 
 
 
 
 
 
 

Change By:
 
 Ethan Brown 
 
 
 

Attachment:
 
 Screen Shot 2016-01-29 at 7.57.37 AM.png 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5769) Windows MSI overriding server with default value of "puppet"

2016-01-29 Thread Ethan Brown (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Ethan Brown commented on  PUP-5769 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Windows MSI overriding server with default value of "puppet"  
 
 
 
 
 
 
 
 
 
 
Brandon High please look under the appropriate registry key and we'll go from there. The MSI uses the remembered property pattern, and you should see something like the screenshot I've attached if you look in the right spot under HKLM: 
  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5648) Add Iterable type and runtime object

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5648 
 
 
 
  Add Iterable type and runtime object  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Release Notes Summary:
 
 Two new types where added to the puppet type system; Iterable[T], a type for values that an iterative function can operate on (i.e. a sequence of type T), and Iterator[T] an abstract Iterable that represents a lazily applied iterative function (that produces a sequence of T). In practice an Iterable that is also an Iterator describes a value that can not be assigned directly to attributes of resources; to assign the values an Iterator must first be iterated over to construct a concrete value like an Array). Values of type Array, Hash, String, Integer, Iterator, and the types Type[Enum], Type[Integer]  are Iterable, An introduction to Iterables will be available in predocs, and the specification will be updated in separate tickets linked to this ticket) 
 
 
 

Release Notes:
 
 New Feature 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at 

Jira (PUP-5772) Update lang specification with new types Iterable and Iterator

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5772 
 
 
 
  Update lang specification with new types Iterable and Iterator  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 PUP-5648 introduces Iterable and Iterator types. The specification should be updated with information about these two types. Update DOCUMENT-499 when done. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5772) Update lang specification with new types Iterable and Iterator

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5772 
 
 
 
  Update lang specification with new types Iterable and Iterator  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Task 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2016/01/29 9:09 AM 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 
PUP-5648 introduces Iterable and Iterator types. The specification should be updated with information about these two types. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
  

Jira (PUP-5773) Performance Work in the Puppet 4.x series

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5773 
 
 
 
  Performance Work in the Puppet 4.x series  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Epic 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2016/01/29 9:15 AM 
 
 
 

Fix Versions:
 

 PUP 4.x 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 
This ticket is an umbrella EPIC for all performance related tickets. Tickets are IN this Epic if they are purely performance related, and tickets supports this ticket when they implement some feature that has performance improvements as a side effect. 
This Epic in turn, supports the overall Epic Theme Performance, which runs over releases. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 

Jira (PUP-5775) Theme: Performance - performance across releases

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5775 
 
 
 
  Theme: Performance - performance across releases  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Summary:
 
 The Puppet Performance  Theme : Performance  - performance  work  across releases 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5776) As a Puppet Jira User I want to know how to work with Themes and Epics in the Puppet Project

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5776 
 
 
 
  As a Puppet Jira User I want to know how to work with Themes and Epics in the Puppet Project  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 As a user of Jira focusing on the PUP project, I want to know about existing Epics, and how they should be applied. When we make released I want to know what needs to be done to ensure we have the relevant Epics defined.I expect the PUP folks to update this story with links to the available Themes. And that this description is updated with an overall description of how Themes and Epics work.DESCRIPTION OF THEMES AND EPICS-A Theme represents an activity that stretched over many releases; e.g. "Performance". We use an Epic to describe such themes. They are always named with a prefix of "Theme:". An example is PUP-5775 "Theme: Performance" Epic.For each release series, there is an Epic that contains the tickets that directly implements something in that theme. Other tickets may also support that Epic. As an example PUP-5773 "4.x Performance" is an Epic that supports "Theme: Performance".(This construct is used since Jira does not support the notion of Theme). RELESE SERIES EPICS-Release series epics are named Nx  e.g. "4.x Performance". Such themes are created lazily when there is going to be work on that theme for a release series. RELEASE EPICS-If there is a need to create an Epic that is closed with a specific release, it should be given a concrete version name e.g. "4.4 Performance", and this ticket should support "4.x Performace". which in turn supports "Theme: Performance".The decision to use a release specific epic is based on how many tickets there are in total for the release, and for the release series. If there are too many tickets it becomes hard to find and navigate. Hence the option to use version specific epic. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 

Jira (PUP-5774) Puppet Class Ordering at Roles and Profiles

2016-01-29 Thread Benson Anand Arokiadoss (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Benson Anand Arokiadoss created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5774 
 
 
 
  Puppet Class Ordering at Roles and Profiles   
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Affects Versions:
 

 PUP 3.8.5 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Components:
 

 Language 
 
 
 

Created:
 

 2016/01/29 9:15 AM 
 
 
 

Priority:
 
  Major 
 
 
 

Reporter:
 
 Benson Anand Arokiadoss 
 
 
 
 
 
 
 
 
 
 
I am having an issue with class ordering in puppet, I have classes than need to run in a certain order within a profile, however during puppet agent run it is not running them in the order i specified. 
class profile::l2siebelldap {  class {'prereqs':} 
 class {'installoracleclient32':} 
 class {'installoracleclient64':} 
Class['prereqs'] -> Class['installoracleclient32'] -> Class['installoracleclient64']  } 
It work fine at modules level not at profile and role level. Can some one help with it, is it a bug with puppet or something am i missing  
 
 
 
 
 
 
 
 
 
 

Jira (PUP-5648) Add Iterable type and runtime object

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5648 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Add Iterable type and runtime object  
 
 
 
 
 
 
 
 
 
 
The performance implications of supporting iterables is that chains of iterations can be performed lazily instead of creating intermediate objects at each step in the iteration. 
It is small contribution but reduces the amount of generated garbage and peak memory usage. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5769) Windows MSI overriding server with default value of "puppet"

2016-01-29 Thread Brandon High (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Brandon High commented on  PUP-5769 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Windows MSI overriding server with default value of "puppet"  
 
 
 
 
 
 
 
 
 
 
Ethan Brown Gotcha, I'll poke around in that area. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5776) As a Puppet Jira User I want to know how to work with Themes and Epics in the Puppet Project

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5776 
 
 
 
  As a Puppet Jira User I want to know how to work with Themes and Epics in the Puppet Project  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Story 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2016/01/29 9:40 AM 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 
As a user of Jira focusing on the PUP project, I want to know about existing Epics, and how they should be applied. When we make released I want to know what needs to be done to ensure we have the relevant Epics defined. 
I expect the PUP folks to update this story with links to the available Themes. And that this description is updated with an overall description of how Themes and Epics work. 
DESCRIPTION OF THEMES AND EPICS 
 
A Theme represents an activity that stretched over many releases; e.g. "Performance". We use an Epic to describe such themes. They are always named with a prefix of "Theme:". An example is PUP-5775 "Theme: Performance" Epic. 
For each release series, there is an Epic that contains the tickets that directly implements something in that theme. Other tickets may also support that Epic. As an example PUP-5773 "4.x Performance" is an Epic that supports "Theme: Performance". 
(This construct is used since Jira does not support the notion of Theme). 
 
 
 
 
 
 
 
 
 
 
 
 

  

Jira (PUP-5769) Windows MSI overriding server with default value of "puppet"

2016-01-29 Thread Brandon High (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Brandon High updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5769 
 
 
 
  Windows MSI overriding server with default value of "puppet"  
 
 
 
 
 
 
 
 
 
 
Regedit for 3.8 agent install installed using beaker/pe_acceptance_tests (setup/install.rb) with command C:\cygwin64\home\Administrator>start /w msiexec.exe /i "C:\cygwin64\tmp\2016-01-29_09.29.26.06azif\puppet-enterprise-3.8.3-x64.msi" /qn /L*V C:\Windows\TEMP\install-puppet-2016-01-29_09.35.59.log PUPPET_AGENT_STARTUP_MODE=Manual:  Looks like even though the parameter isn't provided, it still writes puppet to the registry. 
Regedit post 4.3.2 install using beaker/pe_acceptance_tests (setup/agent_upgrade.rb) using puppet_agent module:  
There appears to be no change. 
 
 
 
 
 
 
 
 
 

Change By:
 
 Brandon High 
 
 
 

Attachment:
 
 Screen Shot 2016-01-29 at 9.56.33 AM.png 
 
 
 

Attachment:
 
 Screen Shot 2016-01-29 at 9.38.24 AM.png 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 

Jira (PUP-5648) Add Iterable type and runtime object

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5648 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Add Iterable type and runtime object  
 
 
 
 
 
 
 
 
 
 
Merged to master at: bce6b0a 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5769) Windows MSI overriding server with default value of "puppet"

2016-01-29 Thread Brandon High (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Brandon High commented on  PUP-5769 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Windows MSI overriding server with default value of "puppet"  
 
 
 
 
 
 
 
 
 
 
It also appears that the pe_acceptance_test sets the server post-install, which gets around the default, but that once the in-place upgrade happens, it gets reset. We could just set the server again, but it seems like that is just plastering over this bug? 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5771) Add introduction to Iterable and Iterator to Pre-docs for PUP-5648

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5771 
 
 
 
  Add introduction to Iterable and Iterator to Pre-docs for PUP-5648  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Task 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Components:
 

 Language 
 
 
 

Created:
 

 2016/01/29 9:07 AM 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 
Update DOCUMENT-499 when predocs has been updated to make Docs aware of its existence. Name the document PUP-5648-Iterable (or something like that). 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

   

Jira (PUP-5775) The Puppet Performance Theme - performance work across releases

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5775 
 
 
 
  The Puppet Performance Theme - performance work across releases  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Epic 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2016/01/29 9:27 AM 
 
 
 

Fix Versions:
 

 PUP future 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 
This epic is a forever ongoing Theme. It should never contain any tickets, except such tickets those that possibly related to performance more universally. 
Instead, each major version should have its open release specific Epic supporting this theme. As an example the "4x Performance" (PUP-5773) Epic supports this Theme Epic. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
  

Jira (PUP-5778) dsl-defined functions should accept blocks

2016-01-29 Thread Daniel Dreier (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Daniel Dreier created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5778 
 
 
 
  dsl-defined functions should accept blocks  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Components:
 

 Language 
 
 
 

Created:
 

 2016/01/29 3:26 PM 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Daniel Dreier 
 
 
 
 
 
 
 
 
 
 
I would like to write functions in the puppet language that accept a block of code, so that I can write my own iterators and other functions that accept code, without the context switch of doing it in ruby. 
The specific use case I have is that we often need to run some piece of puppet code once among a group of nodes. To do that, we do a puppetdbquery to find similarly-classified nodes, then sort that list and see if the current node's certname is the first one on the list. If true, run some bit of code. 
I would like to write a function like: 
 
 
 
 
 
 
function runonce() { 
 
 
 
 
  $pdb_leader = join([ 
 
 

Jira (PUP-3630) The compiler does not process metaparameter inheritance for resources declared outside of Class[main]

2016-01-29 Thread Charlie Sharpsteen (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Charlie Sharpsteen updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-3630 
 
 
 
  The compiler does not process metaparameter inheritance for resources declared outside of Class[main]  
 
 
 
 
 
 
 
 
 

Change By:
 
 Charlie Sharpsteen 
 
 
 

Affects Version/s:
 
 PUP 4.3.2 
 
 
 

Affects Version/s:
 
 PUP 3.8.5 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDB-2319) PQL: Pagination support

2016-01-29 Thread Wyatt Alt (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Wyatt Alt assigned an issue to Wyatt Alt 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 PuppetDB /  PDB-2319 
 
 
 
  PQL: Pagination support  
 
 
 
 
 
 
 
 
 

Change By:
 
 Wyatt Alt 
 
 
 

Assignee:
 
 Wyatt Alt 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5736) Remove usage of win32-process gem

2016-01-29 Thread Glenn Sarti (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Glenn Sarti commented on  PUP-5736 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Remove usage of win32-process gem  
 
 
 
 
 
 
 
 
 
 
setpriority does not use any non-wide functions and doesn't appear to have any to input unicode strings as parameters 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5736) Remove usage of win32-process gem

2016-01-29 Thread Glenn Sarti (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Glenn Sarti updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5736 
 
 
 
  Remove usage of win32-process gem  
 
 
 
 
 
 
 
 
 

Change By:
 
 Glenn Sarti 
 
 
 
 
 
 
 
 
 
 For starters, the affected parts appear to be:* [lib/puppet/feature/base.rb|https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/feature/base.rb#L23]* [lib/puppet/util/windows/process.rb|https://github.com/puppetlabs/puppet/blob/1a557254012447a4f0a2e01eeebaf52c75ab6f80/lib/puppet/util/windows/process.rb#L2]* [lib/puppet/util/pidlock.rb|https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/pidlock.rb#L50-L52]* [puppet/ext/windows/service/daemon.rb|https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/ext/windows/service/daemon.rb#L6]* [puppet/install.rb|https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/install.rb#L247]However, note that Win32::Process actually monkey patches the process object - https://github.com/djberg96/win32-process/blob/ffi/lib/win32/process.rbSo we'll also want to look for calls to these functions as well:* -get_affinity-* -getpriority-*  -  setpriority -  -  https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/limits.rb#L8* uid - requires a more in-depth search* -getrlimit-* -setrlimit-* create   https://github.com/puppetlabs/puppet/blob/master/ext/windows/service/daemon.rb#L74   https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/execution.rb#L321   TODO Add Tests * -kill- - https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/pidlock.rb#L55 / https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/execution.rb#L206* -get_exitcode-* -snapshot- 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
  

Jira (PUP-5770) [std-lib] validate_absolute_path does not detect malicious code injection

2016-01-29 Thread tony gaetani (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 tony gaetani commented on  PUP-5770 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: [std-lib] validate_absolute_path does not detect malicious code injection  
 
 
 
 
 
 
 
 
 
 
No, I did not. You are right, both examples are absolute paths.  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5569) acceptance: to ensure Resource Collectors can use resource references in search expressions

2016-01-29 Thread Eric Thompson (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Thompson assigned an issue to Eric Thompson 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5569 
 
 
 
  acceptance: to ensure Resource Collectors can use resource references in search expressions  
 
 
 
 
 
 
 
 
 

Change By:
 
 Eric Thompson 
 
 
 

Assignee:
 
 Eric Thompson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5770) [std-lib] validate_absolute_path does not detect malicious code injection

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5770 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: [std-lib] validate_absolute_path does not detect malicious code injection  
 
 
 
 
 
 
 
 
 
 
Thanks for closing. "Won't do is fine" as "not a bug" as we could sort of try to add the feature you asked for, but it would be strange. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDB-2368) Version the CLI subcommands separately

2016-01-29 Thread Andrew Roetker (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Andrew Roetker created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 PuppetDB /  PDB-2368 
 
 
 
  Version the CLI subcommands separately  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2016/01/29 4:02 PM 
 
 
 

Fix Versions:
 

 PDB CLI 0.1.0 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Andrew Roetker 
 
 
 
 
 
 
 
 
 
 
We should separately version `puppet-db` and `puppet-query` 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
   

Jira (PUP-5774) Puppet Class Ordering at Roles and Profiles

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg assigned an issue to Benson Anand Arokiadoss 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5774 
 
 
 
  Puppet Class Ordering at Roles and Profiles   
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Assignee:
 
 Benson Anand Arokiadoss 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5770) [std-lib] validate_absolute_path does not detect malicious code injection

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5770 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: [std-lib] validate_absolute_path does not detect malicious code injection  
 
 
 
 
 
 
 
 
 
 
No problem. Suggest bringing up that topic on the puppet-dev google group. Maybe it is possible to define a set of rules that a lot of people agree on, and that would provide some level of safety. (Searching for ";", "rm -", etc.). 
Have you looked at the forge - maybe someone has written something like that already? Search the forge, or go ask on IRC or on the google group. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5736) Remove usage of win32-process gem

2016-01-29 Thread Glenn Sarti (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Glenn Sarti commented on  PUP-5736 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Remove usage of win32-process gem  
 
 
 
 
 
 
 
 
 
 
Apart from one integration test there isn't much to do here. I suppose Puppet::Util::Windows::Process could completely shadow Win32::Process and then all Puppet calls go through that to make it easier to segregate Win32/process but I'm not sure it's worth it. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5770) [std-lib] validate_absolute_path does not detect malicious code injection

2016-01-29 Thread tony gaetani (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 tony gaetani commented on  PUP-5770 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: [std-lib] validate_absolute_path does not detect malicious code injection  
 
 
 
 
 
 
 
 
 
 
I don't see the resolution "not a bug" so I guess I will mark it as "won't do" 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5778) dsl-defined functions should accept blocks

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5778 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: dsl-defined functions should accept blocks  
 
 
 
 
 
 
 
 
 
 
In short - we are working on it (adding piece by piece). 
This is a long standing goal. it consists of fixing a couple of things: 
 

scope - scope is a very odd implementation so it is hard to do lambdas in general (this is not required though to make just calling a function written in puppet and giving it a block. It is however strictly forbidden to return such a block, or to bind it so that it survives the return from the function.
 

Puppet function - we have no syntax for defining that a puppet function accepts a block; we are working on that
 

Iterable support - in order to be able to write an iterable function it needs to be able to work in a chain of iterables. We just merged support for the types Iterable and Iterator and that will be in Puppet 4.4.0.
 

yield/call/next etc. block support - we lack functions or operators for this, we are designing these now.
 
 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit 

Jira (PUP-5770) [std-lib] validate_absolute_path does not detect malicious code injection

2016-01-29 Thread tony gaetani (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 tony gaetani commented on  PUP-5770 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: [std-lib] validate_absolute_path does not detect malicious code injection  
 
 
 
 
 
 
 
 
 
 
It would be nice to have a function that somehow checks for unintended or malicious uses of a variable that will eventually be passed to an `exec` call. However, I agree that it has nothing to do with whether or not a path is absolute. I appreciate you taking the time to help me understand  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5770) [std-lib] validate_absolute_path does not detect malicious code injection

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5770 
 
 
 
  [std-lib] validate_absolute_path does not detect malicious code injection  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 It appears that validate_absolute_path is not working properly in some situations. For example: {code:puppet}   $testpath = '/usr/bin/;rm -rf /;'  validate_absolute_path($testpath)  exec {"mkdir ${testpath}":  returns => 0,  user => 'root',;  } {code} The path validated (incorrectly)Another example: {code:puppet}   $testpath = '/*&^ foo\bar#baz /usr/bin/;rm -rf /;'  validate_absolute_path($testpath)  exec {"mkdir ${testpath}":  returns => 0,  user => 'root',;  } {code} 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5774) Puppet Class Ordering at Roles and Profiles

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5774 
 
 
 
  Puppet Class Ordering at Roles and Profiles   
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 I am having an issue with class ordering in puppet, I have classes than need to run in a certain order within a profile, however during puppet agent run it is not running them in the order i specified. {code:puppet} class profile::l2siebelldap {  class{'prereqs':} class{'installoracleclient32':} class{'installoracleclient64':}Class['prereqs'] -> Class['installoracleclient32'] -> Class['installoracleclient64'] } {code:puppet} It work fine at modules level not at profile and role level. Can some one help with it, is it a bug with puppet or something am i missing  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5774) Puppet Class Ordering at Roles and Profiles

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5774 
 
 
 
  Puppet Class Ordering at Roles and Profiles   
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 I am having an issue with class ordering in puppet, I have classes than need to run in a certain order within a profile, however during puppet agent run it is not running them in the order i specified.{code:puppet}class profile::l2siebelldap {  class{'prereqs':} class{'installoracleclient32':} class{'installoracleclient64':}Class['prereqs'] -> Class['installoracleclient32'] -> Class['installoracleclient64'] }{code :puppet }It work fine at modules level not at profile and role level. Can some one help with it, is it a bug with puppet or something am i missing  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5778) dsl-defined functions should accept blocks

2016-01-29 Thread Daniel Dreier (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Daniel Dreier commented on  PUP-5778 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: dsl-defined functions should accept blocks  
 
 
 
 
 
 
 
 
 
 
that sounds awesome. I'm really excited to play with what you come up with. I appreciate the detailed response. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5736) Remove usage of win32-process gem

2016-01-29 Thread Glenn Sarti (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Glenn Sarti commented on  PUP-5736 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Remove usage of win32-process gem  
 
 
 
 
 
 
 
 
 
 
create function already calls CreateProcessWithLogonW and CreateProcessW. However we don't appear to have any tests for unicode based paths. Need to add these. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5736) Remove usage of win32-process gem

2016-01-29 Thread Glenn Sarti (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Glenn Sarti updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5736 
 
 
 
  Remove usage of win32-process gem  
 
 
 
 
 
 
 
 
 

Change By:
 
 Glenn Sarti 
 
 
 
 
 
 
 
 
 
 For starters, the affected parts appear to be:* [lib/puppet/feature/base.rb|https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/feature/base.rb#L23]* [lib/puppet/util/windows/process.rb|https://github.com/puppetlabs/puppet/blob/1a557254012447a4f0a2e01eeebaf52c75ab6f80/lib/puppet/util/windows/process.rb#L2]* [lib/puppet/util/pidlock.rb|https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/pidlock.rb#L50-L52]* [puppet/ext/windows/service/daemon.rb|https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/ext/windows/service/daemon.rb#L6]* [puppet/install.rb|https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/install.rb#L247]However, note that Win32::Process actually monkey patches the process object - https://github.com/djberg96/win32-process/blob/ffi/lib/win32/process.rbSo we'll also want to look for calls to these functions as well:* -get_affinity-* -getpriority-* setpriority - https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/limits.rb#L8* uid - requires a more in-depth search* -getrlimit-* -setrlimit-* create  - requires a more in-depth search     https://github.com/puppetlabs/puppet/blob/master/ext/windows/service/daemon.rb#L74   https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/execution.rb#L321   TODO Add Tests  * -kill- - https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/pidlock.rb#L55 / https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/execution.rb#L206* -get_exitcode-* -snapshot- 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 

Jira (PUP-5141) Add node definition for Fedora 23 (i386, x86_64) to Puppet

2016-01-29 Thread John Duarte (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 John Duarte updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5141 
 
 
 
  Add node definition for Fedora 23 (i386, x86_64) to Puppet  
 
 
 
 
 
 
 
 
 

Change By:
 
 John Duarte 
 
 
 

QA Status:
 
 Reviewed 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5141) Add node definition for Fedora 23 (i386, x86_64) to Puppet

2016-01-29 Thread John Duarte (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 John Duarte updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5141 
 
 
 
  Add node definition for Fedora 23 (i386, x86_64) to Puppet  
 
 
 
 
 
 
 
 
 

Change By:
 
 John Duarte 
 
 
 

Release Notes:
 
 Not Needed 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5736) Remove usage of win32-process gem

2016-01-29 Thread Glenn Sarti (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Glenn Sarti commented on  PUP-5736 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Remove usage of win32-process gem  
 
 
 
 
 
 
 
 
 
 
uid function does call ANSI API calls but Puppet does not appear to ever call uid for Windows. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5736) Remove usage of win32-process gem

2016-01-29 Thread Glenn Sarti (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Glenn Sarti updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5736 
 
 
 
  Remove usage of win32-process gem  
 
 
 
 
 
 
 
 
 

Change By:
 
 Glenn Sarti 
 
 
 
 
 
 
 
 
 
 For starters, the affected parts appear to be:* [lib/puppet/feature/base.rb|https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/feature/base.rb#L23]* [lib/puppet/util/windows/process.rb|https://github.com/puppetlabs/puppet/blob/1a557254012447a4f0a2e01eeebaf52c75ab6f80/lib/puppet/util/windows/process.rb#L2]* [lib/puppet/util/pidlock.rb|https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/pidlock.rb#L50-L52]* [puppet/ext/windows/service/daemon.rb|https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/ext/windows/service/daemon.rb#L6]* [puppet/install.rb|https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/install.rb#L247]However, note that Win32::Process actually monkey patches the process object - https://github.com/djberg96/win32-process/blob/ffi/lib/win32/process.rbSo we'll also want to look for calls to these functions as well:* -get_affinity-* -getpriority-* -setpriority- - https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/limits.rb#L8*  -  uid -  requires a more in - depth search  https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/type/exec.rb#L598 (Not applicable to Windows though. https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/type/exec.rb#L204-L209) * -getrlimit-* -setrlimit-* create   https://github.com/puppetlabs/puppet/blob/master/ext/windows/service/daemon.rb#L74   https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/execution.rb#L321   TODO Add Tests * -kill- - https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/pidlock.rb#L55 / https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/execution.rb#L206* -get_exitcode-* -snapshot- 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
  

Jira (PUP-5774) Puppet Class Ordering at Roles and Profiles

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5774 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Puppet Class Ordering at Roles and Profiles   
 
 
 
 
 
 
 
 
 
 
There is not information to answer you question. You probably need to read up on the concept of "containment" in puppet and the contain function in particular (that concept trips up a lot of people). There is nothing showing what is in those classes so not possible to answer if there is a problem or not in what you are doing. 
Suggest you start by discussing what you are trying to do on IRC #puppet chanel, or on the puppet google group/mailing-list. You will get help there to ensure that you have something configured that does what you want. If you have a small self contained example that shows the problem; and describe what you expected and what happened then please come back and update this ticket. 
For now, there is nothing wrong with the example you posted. You defied the order of 3 classes you added to the catalog. But this says nothing about the resources in them.  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5778) dsl-defined functions should accept blocks

2016-01-29 Thread Eric Zounes (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Zounes commented on  PUP-5778 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: dsl-defined functions should accept blocks  
 
 
 
 
 
 
 
 
 
 
It sounds like what we really want is to have first-class functions sine we already have lambdas. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5778) dsl-defined functions should accept blocks

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5778 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: dsl-defined functions should accept blocks  
 
 
 
 
 
 
 
 
 
 
Your use of runonce, must be written like this: 
 
 
 
 
 
 
runonce() | | { 
 
 
 
 
  cron {'a job': 
 
 
 
 
# blah blah blah 
 
 
 
 
   } 
 
 
 
 
}
 
 
 
 
 
 
 
Puppet requires an empty argument list in order to make a block out of the braced unit that follows the function call. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
   

Jira (PUP-5777) Whits don't copy tags from the containers they replace

2016-01-29 Thread Charlie Sharpsteen (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Charlie Sharpsteen created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5777 
 
 
 
  Whits don't copy tags from the containers they replace  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Affects Versions:
 

 PUP 4.3.2 
 
 
 

Assignee:
 
 Kylo Ginsberg 
 
 
 

Components:
 

 Catalog Application 
 
 
 

Created:
 

 2016/01/29 2:44 PM 
 
 
 

Labels:
 

 support customer 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Charlie Sharpsteen 
 
 
 
 
 
 
 
 
 
 
When the agent converts containers into Whits, tags that were present on the containers are not copied over to the Whits. This causes events generated by contained resources to be excluded by tag filters even though the container had the appropriate tags. 
Reproduction Case 
 

Install Puppet 4.3.2
 

Create the following test manifest which passes a resource event to a refreshonly exec via a class:
  

Jira (PUP-5736) Remove usage of win32-process gem

2016-01-29 Thread Glenn Sarti (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Glenn Sarti commented on  PUP-5736 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Remove usage of win32-process gem  
 
 
 
 
 
 
 
 
 
 
kill function does not call any non wide string functions and doesn't appear to have any way to input unicode strings. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5736) Remove usage of win32-process gem

2016-01-29 Thread Glenn Sarti (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Glenn Sarti updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5736 
 
 
 
  Remove usage of win32-process gem  
 
 
 
 
 
 
 
 
 

Change By:
 
 Glenn Sarti 
 
 
 
 
 
 
 
 
 
 For starters, the affected parts appear to be:* [lib/puppet/feature/base.rb|https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/feature/base.rb#L23]* [lib/puppet/util/windows/process.rb|https://github.com/puppetlabs/puppet/blob/1a557254012447a4f0a2e01eeebaf52c75ab6f80/lib/puppet/util/windows/process.rb#L2]* [lib/puppet/util/pidlock.rb|https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/pidlock.rb#L50-L52]* [puppet/ext/windows/service/daemon.rb|https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/ext/windows/service/daemon.rb#L6]* [puppet/install.rb|https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/install.rb#L247]However, note that Win32::Process actually monkey patches the process object - https://github.com/djberg96/win32-process/blob/ffi/lib/win32/process.rbSo we'll also want to look for calls to these functions as well:* -get_affinity-* -getpriority-* setpriority - https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/limits.rb#L8* uid - requires a more in-depth search* -getrlimit-* -setrlimit-* create - requires a more in-depth search*  -  kill -  -  https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/pidlock.rb#L55 / https://github.com/puppetlabs/puppet/blob/d2199af906fa5ca19ec0c37c82794934ea4fb4b5/lib/puppet/util/execution.rb#L206* -get_exitcode-* -snapshot- 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 

Jira (PUP-5778) dsl-defined functions should accept blocks

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5778 
 
 
 
  dsl-defined functions should accept blocks  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Scrum Team:
 
 Language 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5770) [std-lib] validate_absolute_path does not detect malicious code injection

2016-01-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5770 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: [std-lib] validate_absolute_path does not detect malicious code injection  
 
 
 
 
 
 
 
 
 
 
The function in question only answers if the file path is absolute or not. It does not provide an answer to "is this a really really badly named file". You can actually name files like the ones in your example. The ";" and other funny characters have meanings in a command shell so it makes it very hard to invoke operations on files with ";rm -rf" in the actual name. 
Did you read something that led you to believe that validate_absolute_path would check for "possibly bad stuff" in a string, that I later use in an exec? 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDB-2231) Memory improvement spike

2016-01-29 Thread Rob Browning (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Rob Browning assigned an issue to Rob Browning 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 PuppetDB /  PDB-2231 
 
 
 
  Memory improvement spike  
 
 
 
 
 
 
 
 
 

Change By:
 
 Rob Browning 
 
 
 

Assignee:
 
 Rob Browning 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDB-2289) Use historical-catalogs endpoint in sync

2016-01-29 Thread Susan McNerney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Susan McNerney updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 PuppetDB /  PDB-2289 
 
 
 
  Use historical-catalogs endpoint in sync  
 
 
 
 
 
 
 
 
 

Change By:
 
 Susan McNerney 
 
 
 

Scrum Team:
 
 PuppetDB 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDB-2126) Add the `catalog_uuid` field to catalogs and `reports`

2016-01-29 Thread Susan McNerney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Susan McNerney updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 PuppetDB /  PDB-2126 
 
 
 
  Add the `catalog_uuid` field to catalogs and `reports`  
 
 
 
 
 
 
 
 
 

Change By:
 
 Susan McNerney 
 
 
 

Scrum Team:
 
 PuppetDB 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1337) facter#master fails to compile on AIX: Undefined symbol: pthread_cancel

2016-01-29 Thread John Duarte (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 John Duarte created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Facter /  FACT-1337 
 
 
 
  facter#master fails to compile on AIX: Undefined symbol: pthread_cancel  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2016/01/29 10:53 AM 
 
 
 

Environment:
 
 
AIX 5.3, 6.1, 7.1 
 
 
 

Priority:
 
  Blocker 
 
 
 

Reporter:
 
 John Duarte 
 
 
 
 
 
 
 
 
 
 
When building on AIX, facter fails with ERROR: Undefined symbol: pthread_cancel 
master branch at a6f18181c51dea4818bbaf77c5b70d3ddf93a262 
 
 
 
 
 
 
ld: 0711-317 ERROR: Undefined symbol: pthread_cancel 
 
 
 
 
ld: 0711-345 Use the -bloadmap or -bnoquiet option to obtain more information. 
 
 
 
 
collect2: error: ld returned 8 exit status 
 
   

Jira (PUP-5769) Windows MSI overriding server with default value of "puppet"

2016-01-29 Thread Michael Smith (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Michael Smith commented on  PUP-5769 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Windows MSI overriding server with default value of "puppet"  
 
 
 
 
 
 
 
 
 
 
Agreed, either puppetlabs-puppet_agent needs to ensure the correct puppet.conf, or the MSI needs to avoid overwriting puppet.conf. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.