Jira (PDB-3476) (maint) change varchar columns to text

2017-04-22 Thread gepetto-bot (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 gepetto-bot created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 PuppetDB /  PDB-3476 
 
 
 
  (maint) change varchar columns to text  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2017/04/22 1:33 PM 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 gepetto-bot 
 
 
 
 
 
 
 
 
 
 
Updates the varchar columns to test. I believe this should be fast because varchar and text are binary coercible, but we'll need to verify to be sure. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 

Jira (PDB-3400) change all varchar columns to text

2017-04-22 Thread Wyatt Alt (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Wyatt Alt updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 PuppetDB /  PDB-3400 
 
 
 
  change all varchar columns to text  
 
 
 
 
 
 
 
 
 

Change By:
 
 Wyatt Alt 
 
 
 

Summary:
 
 drop character limit on reports.config_version and resource_events.containing_class change all varchar columns to text 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (HI-569) Hiera filecache class should not store nil when an exception is thrown

2017-04-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  HI-569 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Hiera filecache class should not store nil when an exception is thrown  
 
 
 
 
 
 
 
 
 
 
Ping Thomas Hallgren 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7458) Unclear meaning of default in a array in a case statement

2017-04-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-7458 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Unclear meaning of default in a array in a case statement  
 
 
 
 
 
 
 
 
 
 
Yes, they are equivalent. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-4946) Contain, include functions should be rvalue, return class reference(s)

2017-04-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-4946 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Contain, include functions should be rvalue, return class reference(s)  
 
 
 
 
 
 
 
 
 
 
Eric Sorenson true, this is not a breaking change. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5635) accessing facts via another scope

2017-04-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-5635 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: accessing facts via another scope  
 
 
 
 
 
 
 
 
 
 
Earlier, I think people just went "wtf, meh, shrug" on this problem and worked around it if they encountered it. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7402) handle trailing slashes in references between file resources

2017-04-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg assigned an issue to qa 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7402 
 
 
 
  handle trailing slashes in references between file resources  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Status:
 
 Ready for  Engineering  Test 
 
 
 

Assignee:
 
 qa 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7402) handle trailing slashes in references between file resources

2017-04-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-7402 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: handle trailing slashes in references between file resources  
 
 
 
 
 
 
 
 
 
 
I believe it was brought back into "ready for engineering" as there were test failures in acceptance. Those are now corrected. (I also think it is wrong to bring a ticket back to "ready for engineering" when the merged logic was not reverted - it should have stayed in test. Changing status. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-481) Make variable references strict by default

2017-04-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-481 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Make variable references strict by default  
 
 
 
 
 
 
 
 
 
 
There are warnings already. And I agree with Nick Walker. We do however still have quite a few number of cases where we rely on global variables being set (or not present) - for instance when using the old top level set facts instead of $facts. This means there is a very long fuse to being able to get strict-variables be the default behavior. I do think we should strive for getting there. We thought we would be there by Puppet 5 when it was the shiny thing far into the future. Now I am not sure we will even get there even by Puppet 6. Whether we keep this ticket or create a new one in the future does not really matter - one day I would like it to be strict by default. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7444) Regex match integer silently fails

2017-04-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-7444 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Regex match integer silently fails  
 
 
 
 
 
 
 
 
 
 
For the case of "used to work - no longer works", we do provide the Catalog Preview tool which has an option to perform "migration checking"; it will tell you about differences between data types, case/select _expression_ matching that is different etc. This is also the recommended way to migrate from a 3.x code base to 4.x. We are very much aware that there are a number of difficult / hard to find differences when transitioning and we thought long and hard about all of the changes that went into the 4.x language - the loosey goosey unspecified nature of earlier versions of the language was a real and big problem. 
As a consultant helping people migrate their code, have you tried the Catalog Preview tool? 
For new (and migrated code), you have to be aware of the data type of values - that makes everything easier to reason about and there are far fewer surprises. None of the more involved examples I showed earlier would be necessary when you know what the data type is. 
I don't see us changing the language to make regexp match Numeric values - that would have bad consequences. Also don't see that we want to add warnings about "proposition not chosen" when evaluating a case or selector. At least not in general, and probably not even in general when using --debug as the logs would probably overfill with such information, and thus require some additional setting to turn this on. Would users find and figure out that they could use such an option? It is in general difficult to provide great debugging tools at the same time as providing an efficient/performant runtime. I would love to see a general explain of an evaluation, but such an ability falls more into some kind of debugging tool (see the "puppet-debugger" tool as an example, while it does not have "explain", it is a very useful tool for figuring out how puppet evaluation works). 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You 

Jira (PUP-6694) The Puppet Data type should be limited to JSON types.

2017-04-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-6694 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: The Puppet Data type should be limited to JSON types.  
 
 
 
 
 
 
 
 
 
 
Also see PUP-7382 (reports serializing arbitrary data) as a place where this can be used (i.e. we have one way of validating). 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.