Jira (PUP-9602) puppet 6 apply fails if puppet types have been generated
Title: Message Title Trevor Vaughan commented on PUP-9602 Re: puppet 6 apply fails if puppet types have been generated So, after much poking around with Charlie Sharpsteen on Slack, I've determined a few things. puppet apply is crazy slow for some reason The following code snippet appears to work around the issue but I'll leave it to Henrik Lindberg to tell me if it makes any sort of sense. diff --git a/lib/puppet/pops/loader/base_loader.rb b/lib/puppet/pops/loader/base_loader.rb index d3c80b63e7..9691113c1b 100644 --- a/lib/puppet/pops/loader/base_loader.rb +++ b/lib/puppet/pops/loader/base_loader.rb @@ -70,8 +70,11 @@ class BaseLoader < Loader def set_entry(typed_name, value, origin = nil) # It is never ok to redefine in the very same loader unless redefining a 'not found' entry = @named_values[typed_name] + +user_mode_skip = (entry && !entry.value.nil? && Puppet.run_mode.name == :user) +
Jira (PUP-10256) Add a feature flag for reading symlinked environments
Title: Message Title Molly Waggett updated an issue Puppet / PUP-10256 Add a feature flag for reading symlinked environments Change By: Molly Waggett Fix Version/s: PUP 6.13.0 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.343765.1580165589000.9319.1580518020239%40Atlassian.JIRA.
Jira (PUP-10256) Add a feature flag for reading symlinked environments
Title: Message Title Molly Waggett updated an issue Puppet / PUP-10256 Add a feature flag for reading symlinked environments Change By: Molly Waggett Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.343765.1580165589000.9322.1580518020371%40Atlassian.JIRA.
Jira (PUP-10256) Add a feature flag for reading symlinked environments
Title: Message Title Molly Waggett assigned an issue to Molly Waggett Puppet / PUP-10256 Add a feature flag for reading symlinked environments Change By: Molly Waggett Assignee: Molly Waggett Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.343765.1580165589000.8872.1580505480241%40Atlassian.JIRA.
Jira (PUP-10262) Attempt to redefine entity regression
Title: Message Title Trevor Vaughan commented on PUP-10262 Re: Attempt to redefine entity regression Downgraded to 5.5.18 and no issues. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.344561.1580500988000.8723.1580502420042%40Atlassian.JIRA.
Jira (PUP-10262) Attempt to redefine entity regression
Title: Message Title Trevor Vaughan commented on PUP-10262 Re: Attempt to redefine entity regression Just did a downgrade loop through all versions of Puppet 6 on EL8 and every version has the bug. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.344561.1580500988000.8722.1580502360036%40Atlassian.JIRA.
Jira (PUP-10262) Attempt to redefine entity regression
Title: Message Title
Trevor Vaughan updated an issue
Puppet / PUP-10262
Attempt to redefine entity regression
Change By:
Trevor Vaughan
*Puppet Version: 6.12.0* *Puppet Server Version: N/A* *OS Name/Version: EL8*When using voxpupuli/firewalld code that works in Puppet , I am getting the following error in Puppet 6. NOTE: The same code works on EL7!{code:java} Error: Could not autoload puppet/type/firewalld_service: Attempt to redefine entity 'http://puppet.com/2016.1/runtime/type/firewalld_service'. Set at unknown locationError: Could not autoload puppet/type/firewalld_zone: Could not autoload puppet/type/firewalld_service: Attempt to redefine entity 'http://puppet.com/2016.1/runtime/type/firewalld_service'. Set at unknown locationError: Parameter before failed on Service[firewalld]: Could not autoload puppet/type/firewalld_zone: Could not autoload puppet/type/firewalld_service: Attempt to redefine entity 'http://puppet.com/2016.1/runtime/type/firewalld_service'. Set at unknown location (file: /etc/puppetlabs/code/environments/production/modules/firewalld/manifests/init.pp, line: 79){code}This appears to be related to having run {{puppet generate}} types on the system.Removing the .resource_types directory fixes the puppet run but is not an acceptable solution.*Desired Behavior:*Puppet run should succeed*Actual Behavior:* Posted above.Works on EL7 with identical code.Works on EL8 with Puppet 5 with identical code.There may be one, or two, errors based on the version of Puppet 6 that is installed.CC: [~henrik.lindberg] since this deals with {{generate}} types. *Full Repeater*{code:java}git clone https://github.com/simp/pupmod-simp-pupmodPUPPET_VERSION='~> 6.0' bundle updatePUPPET_VERSION='~>6.0' BEAKER_destroy=onpass rake beaker:suites..wait for failure..cd .vagrant/beaker_vagrant_files/default.ymlvagrant ssh puppet.el8sudo su -cd /tmpgrep pupmod::master *.pp* | head -1puppet apply rm -rf /etc/puppetlabs/code/environments/production/.resource_typespuppet apply puppet generate typespuppet apply {code}
Add Comment
Jira (PUP-10262) Attempt to redefine entity regression
Title: Message Title Trevor Vaughan updated an issue Puppet / PUP-10262 Attempt to redefine entity regression Change By: Trevor Vaughan Priority: Normal Blocker Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.344561.1580500988000.8675.1580501100151%40Atlassian.JIRA.
Jira (PUP-10262) Attempt to redefine entity regression
Title: Message Title Trevor Vaughan created an issue Puppet / PUP-10262 Attempt to redefine entity regression Issue Type: Bug Affects Versions: PUP 6.12.0 Assignee: Unassigned Components: Compiler Created: 2020/01/31 12:03 PM Priority: Normal Reporter: Trevor Vaughan Puppet Version: 6.12.0 Puppet Server Version: N/A OS Name/Version: EL8 When using voxpupuli/firewalld code that works in Puppet , I am getting the following error in Puppet 6. NOTE: The same code works on EL7! Error: Could not autoload puppet/type/firewalld_service: Attempt to redefine entity 'http://puppet.com/2016.1/runtime/type/firewalld_service'. Set at unknown location Error: Could not autoload puppet/type/firewalld_zone: Could not autoload puppet/type/firewalld_service: Attempt to redefine entity 'http://puppet.com/2016.1/runtime/type/firewalld_service'. Set at unknown location Error: Parameter before failed on Service[firewalld]: Could not autoload puppet/type/firewalld_zone: Could not autoload puppet/type/firewalld_service: Attempt
Jira (PUP-10256) Add a feature flag for reading symlinked environments
Title: Message Title Maggie Dreyer commented on PUP-10256 Re: Add a feature flag for reading symlinked environments Yeah I agree we shouldn't call it out. Though I do think the config reference docs are auto-generated. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.343765.1580165589000.8650.1580500380141%40Atlassian.JIRA.
Jira (PUP-10256) Add a feature flag for reading symlinked environments
Title: Message Title Molly Waggett commented on PUP-10256 Re: Add a feature flag for reading symlinked environments ahh okay. but we wouldn't necessarily have to document that, would we? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.343765.1580165589000.8559.1580498820427%40Atlassian.JIRA.
Jira (PUP-10256) Add a feature flag for reading symlinked environments
Title: Message Title Maggie Dreyer commented on PUP-10256 Re: Add a feature flag for reading symlinked environments Unfortunately, I'm not sure we have a choice here: Puppet's settings framework exposes everything to users, as far as I know. And if we want this to be configurable in PE via the puppet-enterprise module, it has to be exposed to that, which means being exposed to all users. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.343765.1580165589000.8539.1580498340107%40Atlassian.JIRA.
Jira (PUP-10256) Add a feature flag for reading symlinked environments
Title: Message Title Molly Waggett commented on PUP-10256 Re: Add a feature flag for reading symlinked environments Is this a setting that should be exposed to users or is this only meant for our development purposes? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.343765.1580165589000.8514.1580497920187%40Atlassian.JIRA.
Jira (PUP-10227) Close the http connection prior to sleeping retry-after seconds
Title: Message Title Melissa Stone assigned an issue to Melissa Stone Puppet / PUP-10227 Close the http connection prior to sleeping retry-after seconds Change By: Melissa Stone Assignee: Melissa Stone Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.341492.1578520569000.8048.1580489160575%40Atlassian.JIRA.
Jira (PUP-10227) Close the http connection prior to sleeping retry-after seconds
Title: Message Title Melissa Stone updated an issue Puppet / PUP-10227 Close the http connection prior to sleeping retry-after seconds Change By: Melissa Stone Sprint: Coremunity Hopper Platform Core KANBAN Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.341492.1578520569000.8042.1580489160311%40Atlassian.JIRA.
Jira (FACT-2339) Fedora disks are not working correctly on Fedora 30
Title: Message Title
Oana Tanasoiu created an issue
Facter / FACT-2339
Fedora disks are not working correctly on Fedora 30
Issue Type:
Bug
Assignee:
Unassigned
Created:
2020/01/31 6:24 AM
Priority:
Normal
Reporter:
Oana Tanasoiu
Current output disks => { dm-0 => { size => 16106127360 } , dm-1 => { size => 2147483648 } , sda => { model => "Virtual disk", size => 21474836480, vendor => "VMware" } , sr0 => { model => "VMware IDE CDR00", size => 1073741312, vendor => "NECVMWar" } } Should be: disks => { sda => { model => "Virtual disk", size => "20.00 GiB", size_bytes => 21474836480, vendor => "VMware" } , sr0 => { model => "VMware IDE CDR00", size => "1.00 GiB", size_bytes => 1073741312, vendor => "NECVMWar" } }
Add Comment
Jira (FACT-2338) Implement options validators for options
Title: Message Title Oana Tanasoiu created an issue Facter / FACT-2338 Implement options validators for options Issue Type: Improvement Assignee: Unassigned Created: 2020/01/31 6:22 AM Priority: Normal Reporter: Oana Tanasoiu Implement validators for every options (YamlValidator, LogLevelValidator etc) or a similar solutions for options validation Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-10261) X-Hub-Signature check
Title: Message Title Patrick Grant updated an issue Puppet / PUP-10261 X-Hub-Signature check Change By: Patrick Grant Zendesk Ticket IDs: 37914 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.344469.1580475995000.7950.1580476320255%40Atlassian.JIRA.
Jira (PUP-10261) X-Hub-Signature check
Title: Message Title Dirk created an issue Puppet / PUP-10261 X-Hub-Signature check Issue Type: New Feature Assignee: Unassigned Components: Networking Created: 2020/01/31 5:06 AM Labels: github Priority: Normal Reporter: Dirk Dear puppet team, we got a request from the AXA security team to check with you if it would be possible to enhance the puppet enterprise code manage with a verification that an received webhook was send by the AXA enterprise Github: "<...>, there are some ways to ensure the hook is coming from github: https://developer.github.com/enterprise/2.17/webhooks/ https://developer.github.com/webhooks/securing/ github is sending some headers X-Github-xxx and a user-agent, so a first check is possible here A header is called X-Hub-Signature, containing a hash (HMAC hex digest) based on a secret. Some tools are able to check this signature to validate <...> Based on the Puppet version you’re using, can you contact the Puppet Support Team and ask them if there’s a way to implement the X-Hub-Signature check when they receive a payload from github ?" If you need any further information please contact me. Best regards and many thanks in advance, Dirk
Jira (FACT-2311) OS is detected incorrectly for redhat-5-x86_64
Title: Message Title Bogdan Irimie assigned an issue to Bogdan Irimie Facter / FACT-2311 OS is detected incorrectly for redhat-5-x86_64 Change By: Bogdan Irimie Assignee: Bogdan Irimie Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.344077.1580301483000.7917.1580472720052%40Atlassian.JIRA.
Jira (PUP-10210) puppet fails with JSON error when a fact value equals Infinity
Title: Message Title Dorin Pleava commented on PUP-10210 Re: puppet fails with JSON error when a fact value equals Infinity Read again the ticket, and I think both this PR and @justinstoller solutions are a workaround for puppet ttl settings, but I also think Justin's solution is more useful as you can choose the desired output of the fact. Still, the main issue is that if a fact returns Float::INFINITY, puppet will fail. This will still happen, and the best solution is what @hlindberg proposed in PUP-478. I'm OK with closing this PR and using Justin's solution. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.340709.1577387077000.7874.1580468760328%40Atlassian.JIRA.
